<html>
<head>
<meta http-equiv="Content-Type" content="text/html; charset=iso-8859-1">
<style type="text/css" style="display:none;"> P {margin-top:0;margin-bottom:0;} </style>
</head>
<body dir="ltr">
<div class="elementToProof" style="font-family: Aptos, Aptos_EmbeddedFont, Aptos_MSFontService, Calibri, Helvetica, sans-serif; font-size: 12pt; color: rgb(0, 0, 0);">
Hi David, </div>
<div class="elementToProof" style="font-family: Aptos, Aptos_EmbeddedFont, Aptos_MSFontService, Calibri, Helvetica, sans-serif; font-size: 12pt; color: rgb(0, 0, 0);">
<br>
</div>
<div class="elementToProof" style="font-family: Aptos, Aptos_EmbeddedFont, Aptos_MSFontService, Calibri, Helvetica, sans-serif; font-size: 12pt; color: rgb(0, 0, 0);">
Thanks for the fixes, will apply and create a new tag for it.</div>
<div id="appendonsend"></div>
<div style="font-family:Aptos,Aptos_EmbeddedFont,Aptos_MSFontService,Calibri,Helvetica,sans-serif; font-size:12pt; color:rgb(0,0,0)">
<br>
</div>
<hr tabindex="-1" style="display:inline-block; width:98%">
<div id="divRplyFwdMsg" dir="ltr"><font face="Calibri, sans-serif" color="#000000" style="font-size:11pt"><b>From:</b> David Marchand <david.marchand@redhat.com><br>
<b>Sent:</b> Thursday, December 12, 2024 9:23 PM<br>
<b>To:</b> stable@dpdk.org <stable@dpdk.org>; Xueming Li <xuemingl@nvidia.com><br>
<b>Subject:</b> [23.11 2/2] power: fix log message when checking lcore ID</font>
<div> </div>
</div>
<div class="BodyFragment"><font size="2"><span style="font-size:11pt">
<div class="PlainText">Caught while inspecting changes backported in 23.11 LTS branch.<br>
The POWER_LOG() macro in the main branch automatically appends a \n<br>
which is not done by RTE_LOG().<br>
<br>
Fixes: 1afa4c7c5ea6 ("power: fix mapped lcore ID")<br>
<br>
Signed-off-by: David Marchand <david.marchand@redhat.com><br>
---<br>
lib/power/power_amd_pstate_cpufreq.c | 2 +-<br>
lib/power/power_common.c | 4 ++--<br>
lib/power/power_pstate_cpufreq.c | 2 +-<br>
3 files changed, 4 insertions(+), 4 deletions(-)<br>
<br>
diff --git a/lib/power/power_amd_pstate_cpufreq.c b/lib/power/power_amd_pstate_cpufreq.c<br>
index 7b8e77003f..ff63e91183 100644<br>
--- a/lib/power/power_amd_pstate_cpufreq.c<br>
+++ b/lib/power/power_amd_pstate_cpufreq.c<br>
@@ -377,7 +377,7 @@ power_amd_pstate_cpufreq_init(unsigned int lcore_id)<br>
}<br>
<br>
if (power_get_lcore_mapped_cpu_id(lcore_id, &pi->lcore_id) < 0) {<br>
- RTE_LOG(ERR, POWER, "Cannot get CPU ID mapped for lcore %u", lcore_id);<br>
+ RTE_LOG(ERR, POWER, "Cannot get CPU ID mapped for lcore %u\n", lcore_id);<br>
return -1;<br>
}<br>
<br>
diff --git a/lib/power/power_common.c b/lib/power/power_common.c<br>
index 8ffb49ef8f..ee0c264c8d 100644<br>
--- a/lib/power/power_common.c<br>
+++ b/lib/power/power_common.c<br>
@@ -211,8 +211,8 @@ int power_get_lcore_mapped_cpu_id(uint32_t lcore_id, uint32_t *cpu_id)<br>
<br>
lcore_cpus = rte_lcore_cpuset(lcore_id);<br>
if (CPU_COUNT(&lcore_cpus) != 1) {<br>
- RTE_LOG(ERR, POWER, "Power library does not support lcore %u mapping to %u CPUs", lcore_id,<br>
- CPU_COUNT(&lcore_cpus));<br>
+ RTE_LOG(ERR, POWER, "Power library does not support lcore %u mapping to %u CPUs\n",<br>
+ lcore_id, CPU_COUNT(&lcore_cpus));<br>
return -1;<br>
}<br>
<br>
diff --git a/lib/power/power_pstate_cpufreq.c b/lib/power/power_pstate_cpufreq.c<br>
index 890875bd93..fa9ef2aa8a 100644<br>
--- a/lib/power/power_pstate_cpufreq.c<br>
+++ b/lib/power/power_pstate_cpufreq.c<br>
@@ -565,7 +565,7 @@ power_pstate_cpufreq_init(unsigned int lcore_id)<br>
}<br>
<br>
if (power_get_lcore_mapped_cpu_id(lcore_id, &pi->lcore_id) < 0) {<br>
- RTE_LOG(ERR, POWER, "Cannot get CPU ID mapped for lcore %u", lcore_id);<br>
+ RTE_LOG(ERR, POWER, "Cannot get CPU ID mapped for lcore %u\n", lcore_id);<br>
return -1;<br>
}<br>
<br>
-- <br>
2.47.0<br>
<br>
</div>
</span></font></div>
</body>
</html>