<html>
<head>
<meta http-equiv="Content-Type" content="text/html; charset=iso-8859-1">
<style type="text/css" style="display:none;"> P {margin-top:0;margin-bottom:0;} </style>
</head>
<body dir="ltr">
<div class="elementToProof" style="font-family: Aptos, Aptos_EmbeddedFont, Aptos_MSFontService, Calibri, Helvetica, sans-serif; font-size: 12pt; color: rgb(0, 0, 0);">
Hi Stephen,</div>
<div class="elementToProof" style="font-family: Aptos, Aptos_EmbeddedFont, Aptos_MSFontService, Calibri, Helvetica, sans-serif; font-size: 12pt; color: rgb(0, 0, 0);">
<br>
</div>
<div class="elementToProof" style="font-family: Aptos, Aptos_EmbeddedFont, Aptos_MSFontService, Calibri, Helvetica, sans-serif; font-size: 12pt; color: rgb(0, 0, 0);">
Found a compilation issue, I made following change to make it work, let me know if you have any questions:</div>
<div class="elementToProof" style="font-family: Aptos, Aptos_EmbeddedFont, Aptos_MSFontService, Calibri, Helvetica, sans-serif; font-size: 12pt; color: rgb(0, 0, 0);">
<br>
</div>
<div class="elementToProof" style="font-family: Aptos, Aptos_EmbeddedFont, Aptos_MSFontService, Calibri, Helvetica, sans-serif; font-size: 12pt; color: rgb(0, 0, 0);">
- if (memcmp(&ptp_hdr->master_clock_id,<br>
+ if (memcmp(&ptp_data->master_clock_id,</div>
<div id="appendonsend" style="color: inherit;"></div>
<div><br>
</div>
<div class="elementToProof" style="font-family: Calibri, Arial, Helvetica, sans-serif; font-size: 12pt; color: rgb(0, 0, 0);">
Regards,</div>
<div class="elementToProof" style="font-family: Calibri, Arial, Helvetica, sans-serif; font-size: 12pt; color: rgb(0, 0, 0);">
Xueming</div>
<div class="elementToProof" style="font-family: Calibri, Arial, Helvetica, sans-serif; font-size: 12pt; color: rgb(0, 0, 0);">
<br>
</div>
<hr style="display: inline-block; width: 98%;">
<div style="font-family: Calibri, Arial, Helvetica, sans-serif; font-size: 12pt; color: rgb(0, 0, 0);">
<b>From:</b> Xueming Li<br>
<b>Sent:</b> Saturday, April 5, 2025 3:38 PM<br>
<b>To:</b> Stephen Hemminger; stable@dpdk.org<br>
<b>Subject:</b> Re: [PATCH 23.11] examples/ptpclient: fix message parsing </div>
<div style="font-family: Calibri, Arial, Helvetica, sans-serif; font-size: 12pt; color: rgb(0, 0, 0);">
<br>
</div>
<div style="direction: ltr; font-family: Aptos, Aptos_EmbeddedFont, Aptos_MSFontService, Calibri, Helvetica, sans-serif; font-size: 12pt; color: rgb(0, 0, 0);">
Thanks, patch queued to 23.11.4 release staging</div>
<div style="direction: ltr; font-family: Aptos, Aptos_EmbeddedFont, Aptos_MSFontService, Calibri, Helvetica, sans-serif; font-size: 12pt; color: rgb(0, 0, 0);">
<br>
</div>
<div style="direction: ltr; font-family: Aptos, Aptos_EmbeddedFont, Aptos_MSFontService, Calibri, Helvetica, sans-serif; font-size: 12pt; color: rgb(0, 0, 0);">
Regards,</div>
<div style="direction: ltr; font-family: Aptos, Aptos_EmbeddedFont, Aptos_MSFontService, Calibri, Helvetica, sans-serif; font-size: 12pt; color: rgb(0, 0, 0);">
Xueming</div>
<div id="x_appendonsend" style="color: inherit;"></div>
<hr style="direction: ltr; display: inline-block; width: 98%;">
<div id="x_divRplyFwdMsg" dir="ltr" style="color: inherit;"><span style="font-family: Calibri, sans-serif; font-size: 11pt; color: rgb(0, 0, 0);"><b>From:</b> Stephen Hemminger <stephen@networkplumber.org><br>
<b>Sent:</b> Thursday, February 20, 2025 1:16 AM<br>
<b>To:</b> stable@dpdk.org <stable@dpdk.org><br>
<b>Cc:</b> Stephen Hemminger <stephen@networkplumber.org><br>
<b>Subject:</b> [PATCH 23.11] examples/ptpclient: fix message parsing</span>
<div> </div>
</div>
<div style="direction: ltr; font-size: 11pt;">[ upstream commit 19630bd0d735badb06143086d4f1c50d726b7bad ]<br>
<br>
Calling memcmp on same structure will always be true.<br>
Replace with same conditional used elsewhere.<br>
<br>
Link: <a href="https://pvs-studio.com/en/blog/posts/cpp/1183/" id="OWA2c1ff075-88df-113c-eca7-ec3945c8ac8e" class="OWAAutoLink" data-auth="NotApplicable">
https://pvs-studio.com/en/blog/posts/cpp/1183/</a><br>
<br>
Fixes: ab129e9065a5 ("examples/ptpclient: add minimal PTP client")<br>
<br>
Signed-off-by: Stephen Hemminger <stephen@networkplumber.org><br>
---<br>
examples/ptpclient/ptpclient.c | 2 +-<br>
1 file changed, 1 insertion(+), 1 deletion(-)<br>
<br>
diff --git a/examples/ptpclient/ptpclient.c b/examples/ptpclient/ptpclient.c<br>
index cdf2da64df..92b54f240e 100644<br>
--- a/examples/ptpclient/ptpclient.c<br>
+++ b/examples/ptpclient/ptpclient.c<br>
@@ -365,7 +365,7 @@ parse_sync(struct ptpv2_data_slave_ordinary *ptp_data, uint16_t rx_tstamp_idx)<br>
ptp_data->ptpset = 1;<br>
}<br>
<br>
- if (memcmp(&ptp_hdr->source_port_id.clock_id,<br>
+ if (memcmp(&ptp_hdr->master_clock_id,<br>
&ptp_hdr->source_port_id.clock_id,<br>
sizeof(struct clock_id)) == 0) {<br>
<br>
--<br>
2.47.2<br>
<br>
</div>
</body>
</html>