<html>
<head>
<meta http-equiv="Content-Type" content="text/html; charset=us-ascii">
<style type="text/css" style="display:none;"> P {margin-top:0;margin-bottom:0;} </style>
</head>
<body dir="ltr">
<div class="elementToProof" style="font-family: Aptos, Aptos_EmbeddedFont, Aptos_MSFontService, Calibri, Helvetica, sans-serif; font-size: 12pt; color: rgb(0, 0, 0);">
Hi Brian,</div>
<div class="elementToProof" style="font-family: Aptos, Aptos_EmbeddedFont, Aptos_MSFontService, Calibri, Helvetica, sans-serif; font-size: 12pt; color: rgb(0, 0, 0);">
<br>
</div>
<div class="elementToProof" style="font-family: Aptos, Aptos_EmbeddedFont, Aptos_MSFontService, Calibri, Helvetica, sans-serif; font-size: 12pt; color: rgb(0, 0, 0);">
Thanks for fixing this, patch include in 23.11.4 rc.</div>
<div class="elementToProof" style="font-family: Aptos, Aptos_EmbeddedFont, Aptos_MSFontService, Calibri, Helvetica, sans-serif; font-size: 12pt; color: rgb(0, 0, 0);">
<br>
</div>
<div class="elementToProof" style="font-family: Aptos, Aptos_EmbeddedFont, Aptos_MSFontService, Calibri, Helvetica, sans-serif; font-size: 12pt; color: rgb(0, 0, 0);">
Best regards,</div>
<div class="elementToProof" style="font-family: Aptos, Aptos_EmbeddedFont, Aptos_MSFontService, Calibri, Helvetica, sans-serif; font-size: 12pt; color: rgb(0, 0, 0);">
Xueming</div>
<div id="appendonsend"></div>
<hr style="display:inline-block;width:98%" tabindex="-1">
<div id="divRplyFwdMsg" dir="ltr"><font face="Calibri, sans-serif" style="font-size:11pt" color="#000000"><b>From:</b> Brian Dooley <brian.dooley@intel.com><br>
<b>Sent:</b> Friday, November 29, 2024 1:36 AM<br>
<b>To:</b> Akhil Goyal <gakhil@marvell.com>; Fan Zhang <fanzhang.oss@gmail.com><br>
<b>Cc:</b> stable@dpdk.org <stable@dpdk.org>; Brian Dooley <brian.dooley@intel.com><br>
<b>Subject:</b> [PATCH 23.11] test/crypto: fix callback setup tests</font>
<div> </div>
</div>
<div class="BodyFragment"><font size="2"><span style="font-size:11pt;">
<div class="PlainText">The test_deq_callback_setup and test_enq_callback_setup tests are<br>
asserting the incorrect case and need to be reversed to reflect correct<br>
callbacks being called.<br>
<br>
Fixes: 4fe42b5bd587 ("test/crypto: fix enqueue/dequeue callback case")<br>
<br>
Signed-off-by: Brian Dooley <brian.dooley@intel.com><br>
---<br>
app/test/test_cryptodev.c | 4 ++--<br>
1 file changed, 2 insertions(+), 2 deletions(-)<br>
<br>
diff --git a/app/test/test_cryptodev.c b/app/test/test_cryptodev.c<br>
index 6cd38aefae..005d3a87f9 100644<br>
--- a/app/test/test_cryptodev.c<br>
+++ b/app/test/test_cryptodev.c<br>
@@ -13727,7 +13727,7 @@ test_enq_callback_setup(void)<br>
"qp %u on cryptodev %u",<br>
qp_id, ts_params->valid_devs[0]);<br>
<br>
- TEST_ASSERT(deq_cb_called == true, "Crypto dequeue callback not called");<br>
+ TEST_ASSERT(enq_cb_called == true, "Crypto enqueue callback not called");<br>
<br>
return TEST_SUCCESS;<br>
}<br>
@@ -13848,7 +13848,7 @@ test_deq_callback_setup(void)<br>
"qp %u on cryptodev %u",<br>
qp_id, ts_params->valid_devs[0]);<br>
<br>
- TEST_ASSERT(enq_cb_called == true, "Crypto enqueue callback not called");<br>
+ TEST_ASSERT(deq_cb_called == true, "Crypto dequeue callback not called");<br>
<br>
return TEST_SUCCESS;<br>
}<br>
-- <br>
2.25.1<br>
<br>
</div>
</span></font></div>
</body>
</html>