<html>
<head>
<meta http-equiv="Content-Type" content="text/html; charset=iso-8859-1">
<style type="text/css" style="display:none;"> P {margin-top:0;margin-bottom:0;} </style>
</head>
<body dir="ltr">
<div style="text-align: left; text-indent: 0px; margin: 0px; font-family: Verdana, Geneva, sans-serif; font-size: 11pt; color: rgb(0, 0, 0);" class="elementToProof">
Hi Kevin!</div>
<div style="text-align: left; text-indent: 0px; margin: 0px; font-family: Verdana, Geneva, sans-serif; font-size: 11pt; color: rgb(0, 0, 0);" class="elementToProof">
<br>
</div>
<div style="text-align: left; text-indent: 0px; margin: 0px; font-family: Verdana, Geneva, sans-serif; font-size: 11pt; color: rgb(0, 0, 0);" class="elementToProof">
Thank you for the notification about backporting. </div>
<div style="text-align: left; text-indent: 0px; margin: 0px; font-family: Verdana, Geneva, sans-serif; font-size: 11pt; color: rgb(0, 0, 0);" class="elementToProof">
Please merge this patch into the stable release. </div>
<div style="text-align: left; text-indent: 0px; margin: 0px; font-family: Verdana, Geneva, sans-serif; font-size: 11pt; color: rgb(0, 0, 0);" class="elementToProof">
<br>
</div>
<div style="text-align: left; text-indent: 0px; margin: 0px; font-family: Verdana, Geneva, sans-serif; font-size: 11pt; color: rgb(0, 0, 0);" class="elementToProof">
If it is possible, it will be nice to add to the stable release this commit too <a style="margin: 0px;" class="OWAAutoLink" id="OWAd4f8c6bd-a7db-7264-3330-4ec8fa5033c5" href="https://git.dpdk.org/dpdk/commit/?id=f7dabff91738e97d81f6844cb6c00b503de3d9ea">
https://git.dpdk.org/dpdk/commit/?id=f7dabff91738e97d81f6844cb6c00b503de3d9ea</a></div>
<div style="text-align: left; text-indent: 0px; margin: 0px; font-family: Verdana, Geneva, sans-serif; font-size: 11pt; color: rgb(0, 0, 0);" class="elementToProof">
<br>
</div>
<div style="text-align: left; text-indent: 0px; margin: 0px; font-family: Verdana, Geneva, sans-serif; font-size: 11pt; color: rgb(0, 0, 0);" class="elementToProof">
Thanks.</div>
<div style="text-align: left; text-indent: 0px; margin: 0px; font-family: Verdana, Geneva, sans-serif; font-size: 11pt; color: rgb(0, 0, 0);" class="elementToProof">
Serhii</div>
<div style="font-family: Verdana, Geneva, sans-serif; font-size: 11pt; color: rgb(0, 0, 0);">
<br>
</div>
<hr style="display: inline-block; width: 98%;">
<div id="divRplyFwdMsg">
<div style="direction: ltr; font-family: Calibri, sans-serif; font-size: 11pt; color: rgb(0, 0, 0);">
<b>From:</b> Kevin Traynor <ktraynor@redhat.com><br>
<b>Sent:</b> 18 July 2025 22:29<br>
<b>To:</b> Danylo Vodopianov <dvo-plv@napatech.com><br>
<b>Cc:</b> dpdk stable <stable@dpdk.org><br>
<b>Subject:</b> patch 'net/ntnic: fix ring queue operation' has been queued to stable release 24.11.3</div>
<div style="direction: ltr;"> </div>
</div>
<div style="font-size: 11pt;">Hi,<br>
<br>
FYI, your patch has been queued to stable release 24.11.3<br>
<br>
Note it hasn't been pushed to <a data-auth="NotApplicable" class="OWAAutoLink" id="OWA89e88bb6-d1a7-35ca-e037-5e59f4730a51" href="https://linkprotect.cudasvc.com/url?a=http%3a%2f%2fdpdk.org%2fbrowse%2fdpdk-stable&c=E,1,0s7L2Nnz1oz870ovFl1dBxRYTbF4gRBnobLRLJC0w0_Z9daayABQIVE41tCC7fZ4pmazXnCn0NtNQMiOCcI8jiLTP_hmlko2qP0og6HJkWmK&typo=1">
https://linkprotect.cudasvc.com/url?a=http%3a%2f%2fdpdk.org%2fbrowse%2fdpdk-stable&c=E,1,0s7L2Nnz1oz870ovFl1dBxRYTbF4gRBnobLRLJC0w0_Z9daayABQIVE41tCC7fZ4pmazXnCn0NtNQMiOCcI8jiLTP_hmlko2qP0og6HJkWmK&typo=1</a> yet.<br>
It will be pushed if I get no objections before 07/23/25. So please<br>
shout if anyone has objections.<br>
<br>
Also note that after the patch there's a diff of the upstream commit vs the<br>
patch applied to the branch. This will indicate if there was any rebasing<br>
needed to apply to the stable branch. If there were code changes for rebasing<br>
(ie: not only metadata diffs), please double check that the rebase was<br>
correctly done.<br>
<br>
Queued patches are on a temporary branch at:<br>
<a data-auth="NotApplicable" class="OWAAutoLink" id="OWAc15f483b-7555-962e-228e-cc5deda3773b" href="https://github.com/kevintraynor/dpdk-stable">https://github.com/kevintraynor/dpdk-stable</a><br>
<br>
This queued commit can be viewed at:<br>
<a data-auth="NotApplicable" class="OWAAutoLink" id="OWAcdaa235d-dbec-5eb6-34c9-4967fa0d2546" href="https://github.com/kevintraynor/dpdk-stable/commit/cd05b2212e2d228d5ed206edf2bd35d6c2c2bdc8">https://github.com/kevintraynor/dpdk-stable/commit/cd05b2212e2d228d5ed206edf2bd35d6c2c2bdc8</a><br>
<br>
Thanks.<br>
<br>
Kevin<br>
<br>
---<br>
>From cd05b2212e2d228d5ed206edf2bd35d6c2c2bdc8 Mon Sep 17 00:00:00 2001<br>
From: Danylo Vodopianov <dvo-plv@napatech.com><br>
Date: Mon, 5 May 2025 09:13:06 +0200<br>
Subject: [PATCH] net/ntnic: fix ring queue operation<br>
<br>
[ upstream commit 13b59c07d6827e3cd7f746997b97fcffb5992435 ]<br>
<br>
User should call rte_ring_dequeue_zc_elem_finish to complete the<br>
dequeue operation. However this complete step if record absent.<br>
<br>
This change rework queue read operation.<br>
<br>
Fixes: 96c8249be53e ("net/ntnic: learn flow queue handling")<br>
<br>
Signed-off-by: Danylo Vodopianov <dvo-plv@napatech.com><br>
---<br>
.../profile_inline/flow_api_profile_inline.c | 12 ++++--------<br>
1 file changed, 4 insertions(+), 8 deletions(-)<br>
<br>
diff --git a/drivers/net/ntnic/nthw/flow_api/profile_inline/flow_api_profile_inline.c b/drivers/net/ntnic/nthw/flow_api/profile_inline/flow_api_profile_inline.c<br>
index ff8eb502f4..5325657551 100644<br>
--- a/drivers/net/ntnic/nthw/flow_api/profile_inline/flow_api_profile_inline.c<br>
+++ b/drivers/net/ntnic/nthw/flow_api/profile_inline/flow_api_profile_inline.c<br>
@@ -404,16 +404,12 @@ static uint32_t flm_lrn_update(struct flow_eth_dev *dev, uint32_t *inf_word_cnt,<br>
{<br>
read_record r = flm_lrn_queue_get_read_buffer(flm_lrn_queue_arr);<br>
+ uint32_t handled_records = 0;<br>
<br>
if (r.num) {<br>
- uint32_t handled_records = 0;<br>
-<br>
- if (hw_mod_flm_lrn_data_set_flush(&dev->ndev->be, HW_FLM_FLOW_LRN_DATA, r.p, r.num,<br>
- &handled_records, inf_word_cnt, sta_word_cnt)) {<br>
+ if (hw_mod_flm_lrn_data_set_flush(&dev->ndev->be, HW_FLM_FLOW_LRN_DATA, r.p,<br>
+ r.num, &handled_records, inf_word_cnt, sta_word_cnt))<br>
NT_LOG(ERR, FILTER, "Flow programming failed");<br>
-<br>
- } else if (handled_records > 0) {<br>
- flm_lrn_queue_release_read_buffer(flm_lrn_queue_arr, handled_records);<br>
- }<br>
}<br>
+ flm_lrn_queue_release_read_buffer(flm_lrn_queue_arr, handled_records);<br>
<br>
return r.num;<br>
--<br>
2.50.0<br>
<br>
---<br>
Diff of the applied patch vs upstream commit (please double-check if non-empty:<br>
---<br>
--- - 2025-07-18 20:29:13.192578837 +0100<br>
+++ 0061-net-ntnic-fix-ring-queue-operation.patch 2025-07-18 20:29:10.959907420 +0100<br>
@@ -1 +1 @@<br>
-From 13b59c07d6827e3cd7f746997b97fcffb5992435 Mon Sep 17 00:00:00 2001<br>
+From cd05b2212e2d228d5ed206edf2bd35d6c2c2bdc8 Mon Sep 17 00:00:00 2001<br>
@@ -5,0 +6,2 @@<br>
+[ upstream commit 13b59c07d6827e3cd7f746997b97fcffb5992435 ]<br>
+<br>
@@ -12 +13,0 @@<br>
-Cc: stable@dpdk.org<br>
@@ -20 +21 @@<br>
-index cb6a66a061..f78c6fbf49 100644<br>
+index ff8eb502f4..5325657551 100644<br>
@@ -23 +24 @@<br>
-@@ -399,16 +399,12 @@ static uint32_t flm_lrn_update(struct flow_eth_dev *dev, uint32_t *inf_word_cnt,<br>
+@@ -404,16 +404,12 @@ static uint32_t flm_lrn_update(struct flow_eth_dev *dev, uint32_t *inf_word_cnt,<br>
<br>
</div>
</body>
</html>