<html>
<head>
<meta http-equiv="Content-Type" content="text/html; charset=iso-8859-1">
<style type="text/css" style="display:none;"> P {margin-top:0;margin-bottom:0;} </style>
</head>
<body dir="ltr">
<div>
<div style="font-family: Calibri; text-align: left; color: rgb(0, 0, 255); margin-left: 5pt; font-size: 10pt;">
[AMD Official Use Only - AMD Internal Distribution Only]</div>
<br>
</div>
<div style="font-family: Verdana, Geneva, sans-serif; font-size: 9pt; color: rgb(0, 0, 0);" class="elementToProof">
Hi Kevin,</div>
<div style="font-family: Verdana, Geneva, sans-serif; font-size: 9pt; color: rgb(0, 0, 0);" class="elementToProof">
<br>
</div>
<div style="font-family: Verdana, Geneva, sans-serif; font-size: 9pt; color: rgb(0, 0, 0);" class="elementToProof">
LGTM! </div>
<div style="font-family: Verdana, Geneva, sans-serif; font-size: 9pt; color: rgb(0, 0, 0);" class="elementToProof">
<br>
</div>
<div style="font-family: Verdana, Geneva, sans-serif; font-size: 9pt; color: rgb(0, 0, 0);" class="elementToProof">
Thanks & Regards,</div>
<div style="font-family: Verdana, Geneva, sans-serif; font-size: 9pt; color: rgb(0, 0, 0);" class="elementToProof">
Sivaprasad<span style="font-family: Calibri, Arial, Helvetica, sans-serif; font-size: 12pt;"><br>
</span></div>
<div style="font-family: Verdana, Geneva, sans-serif; font-size: 9pt; color: rgb(0, 0, 0);" class="elementToProof">
<span style="font-family: Calibri, Arial, Helvetica, sans-serif; font-size: 12pt;"></span></div>
<hr style="display: inline-block; width: 98%;">
<div style="font-family: Calibri, Arial, Helvetica, sans-serif; font-size: 12pt; color: rgb(0, 0, 0);">
<b>From:</b> Kevin Traynor <ktraynor@redhat.com><br>
<b>Sent:</b> Friday, October 31, 2025 8:03 PM<br>
<b>To:</b> Tummala, Sivaprasad <Sivaprasad.Tummala@amd.com><br>
<b>Cc:</b> Anatoly Burakov <anatoly.burakov@intel.com>; dpdk stable <stable@dpdk.org><br>
<b>Subject:</b> patch 'eal/x86: enable timeout in AMD power monitor' has been queued to stable release 24.11.4
</div>
<div style="font-family: Calibri, Arial, Helvetica, sans-serif; font-size: 12pt; color: rgb(0, 0, 0);">
<br>
</div>
<div style="font-size: 11pt;">Caution: This message originated from an External Source. Use proper caution when opening attachments, clicking links, or responding.<br>
<br>
<br>
Hi,<br>
<br>
FYI, your patch has been queued to stable release 24.11.4<br>
<br>
Note it hasn't been pushed to <a data-auth="NotApplicable" class="OWAAutoLink" id="OWAc5899597-5bdf-dbbe-99f2-495596015759" href="http://dpdk.org/browse/dpdk-stable">
http://dpdk.org/browse/dpdk-stable</a> yet.<br>
It will be pushed if I get no objections before 11/05/25. So please<br>
shout if anyone has objections.<br>
<br>
Also note that after the patch there's a diff of the upstream commit vs the<br>
patch applied to the branch. This will indicate if there was any rebasing<br>
needed to apply to the stable branch. If there were code changes for rebasing<br>
(ie: not only metadata diffs), please double check that the rebase was<br>
correctly done.<br>
<br>
Queued patches are on a temporary branch at:<br>
<a data-auth="NotApplicable" class="OWAAutoLink" id="OWA006ecb2f-22a4-b723-7506-de9a9e5b6884" href="https://github.com/kevintraynor/dpdk-stable">https://github.com/kevintraynor/dpdk-stable</a><br>
<br>
This queued commit can be viewed at:<br>
<a data-auth="NotApplicable" class="OWAAutoLink" id="OWA71704e11-4366-91ad-dfdb-b9982fd601df" href="https://github.com/kevintraynor/dpdk-stable/commit/4e309113126d8cf44cf2e50362ae590a176e07ac">https://github.com/kevintraynor/dpdk-stable/commit/4e309113126d8cf44cf2e50362ae590a176e07ac</a><br>
<br>
Thanks.<br>
<br>
Kevin<br>
<br>
---<br>
>From 4e309113126d8cf44cf2e50362ae590a176e07ac Mon Sep 17 00:00:00 2001<br>
From: Sivaprasad Tummala <sivaprasad.tummala@amd.com><br>
Date: Mon, 13 Oct 2025 05:51:57 +0000<br>
Subject: [PATCH] eal/x86: enable timeout in AMD power monitor<br>
<br>
[ upstream commit 1213a8895be3bf883f10b3ba60ee84099b5ff75a ]<br>
<br>
Previously, the AMD power monitor implementation did not enable the<br>
timeout, causing the lcore to remain in a wait state until an external<br>
monitoring event occurred or an interrupt was received.<br>
<br>
This patch enables the timeout-based exit condition, allowing<br>
the lcore to automatically wake up after the specified period.<br>
The maximum supported timeout value is 2^32 - 1.<br>
<br>
Fixes: c7ed1ce04704 ("eal/x86: add power intrinsics for AMD")<br>
<br>
Signed-off-by: Sivaprasad Tummala <sivaprasad.tummala@amd.com><br>
Acked-by: Anatoly Burakov <anatoly.burakov@intel.com><br>
---<br>
lib/eal/x86/rte_power_intrinsics.c | 6 +++---<br>
1 file changed, 3 insertions(+), 3 deletions(-)<br>
<br>
diff --git a/lib/eal/x86/rte_power_intrinsics.c b/lib/eal/x86/rte_power_intrinsics.c<br>
index f7d558153e..b46e8c2aba 100644<br>
--- a/lib/eal/x86/rte_power_intrinsics.c<br>
+++ b/lib/eal/x86/rte_power_intrinsics.c<br>
@@ -88,12 +88,12 @@ static void amd_monitorx(volatile void *addr)<br>
static void amd_mwaitx(const uint64_t timeout)<br>
{<br>
- RTE_SET_USED(timeout);<br>
#if defined(RTE_TOOLCHAIN_MSVC) || defined(__MWAITX__)<br>
- _mm_mwaitx(0, 0, 0);<br>
+ _mm_mwaitx(2, 0, (uint32_t)timeout);<br>
#else<br>
asm volatile(".byte 0x0f, 0x01, 0xfb;"<br>
: /* ignore rflags */<br>
: "a"(0), /* enter C1 */<br>
- "c"(0)); /* no time-out */<br>
+ "b"((uint32_t)timeout),<br>
+ "c"(2)); /* enable time-out */<br>
#endif<br>
}<br>
--<br>
2.51.0<br>
<br>
---<br>
Diff of the applied patch vs upstream commit (please double-check if non-empty:<br>
---<br>
--- - 2025-10-31 13:53:54.355466019 +0000<br>
+++ 0069-eal-x86-enable-timeout-in-AMD-power-monitor.patch 2025-10-31 13:53:52.173523796 +0000<br>
@@ -1 +1 @@<br>
-From 1213a8895be3bf883f10b3ba60ee84099b5ff75a Mon Sep 17 00:00:00 2001<br>
+From 4e309113126d8cf44cf2e50362ae590a176e07ac Mon Sep 17 00:00:00 2001<br>
@@ -5,0 +6,2 @@<br>
+[ upstream commit 1213a8895be3bf883f10b3ba60ee84099b5ff75a ]<br>
+<br>
@@ -15 +16,0 @@<br>
-Cc: stable@dpdk.org<br>
@@ -24 +25 @@<br>
-index 489ad3983f..8a5f222aea 100644<br>
+index f7d558153e..b46e8c2aba 100644<br>
@@ -27 +28 @@<br>
-@@ -90,12 +90,12 @@ static void amd_monitorx(volatile void *addr)<br>
+@@ -88,12 +88,12 @@ static void amd_monitorx(volatile void *addr)<br>
<br>
</div>
</body>
</html>