<html xmlns:o="urn:schemas-microsoft-com:office:office" xmlns:w="urn:schemas-microsoft-com:office:word" xmlns:m="http://schemas.microsoft.com/office/2004/12/omml" xmlns="http://www.w3.org/TR/REC-html40"> <head> <meta http-equiv="Content-Type" content="text/html; charset=us-ascii"> <meta name="Generator" content="Microsoft Word 15 (filtered medium)"> <style></style> </head> <body lang="EN-IN" link="#467886" vlink="#96607D" style="word-wrap:break-word"> <div class="WordSection1"> -----Original Message-----<o:p></o:p> From: Richardson, Bruce <<a href="mailto:bruce.richardson@intel.com">bruce.richardson@intel.com</a>> <o:p></o:p> Sent: 11 December 2025 20:11<o:p></o:p> To: Mandal, Anurag <<a href="mailto:anurag.mandal@intel.com">anurag.mandal@intel.com</a>><o:p></o:p> Cc: <a href="mailto:dev@dpdk.org">dev@dpdk.org</a>; <a href="mailto:stable@dpdk.org"> stable@dpdk.org</a><o:p></o:p> Subject: Re: [PATCH] net/i40e: fix QinQ stripping<o:p></o:p> <o:p> </o:p> On Sat, Dec 06, 2025 at 06:43:11PM +0000, Anurag Mandal wrote:<o:p></o:p> > Outer VLAN strip gets disabled when inner VLAN stripping is <o:p></o:p> > enabled/disabled after enabling outer VLAN stripping.<o:p></o:p> > This happens because the respective register is overridden by the vsi <o:p></o:p> > params update of inner VLAN stripping.<o:p></o:p> > <o:p></o:p> > This patch fixes the issue by re-enabling outer VLAN stripping after <o:p></o:p> > modification of inner VLAN stripping.<o:p></o:p> > <o:p></o:p> > Fixes: c52ff36686a4 ("net/i40e: enable QinQ stripping")<o:p></o:p> > Cc: <a href="mailto:stable@dpdk.org">stable@dpdk.org</a><o:p></o:p> > <o:p></o:p> > Signed-off-by: Anurag Mandal <<a href="mailto:anurag.mandal@intel.com">anurag.mandal@intel.com</a>><o:p></o:p> > ---<o:p></o:p> > drivers/net/intel/i40e/i40e_ethdev.c | 10 ++++++++++<o:p></o:p> > 1 file changed, 10 insertions(+)<o:p></o:p> > <o:p></o:p> > diff --git a/drivers/net/intel/i40e/i40e_ethdev.c <o:p> </o:p> > b/drivers/net/intel/i40e/i40e_ethdev.c<o:p></o:p> > index b8ce79061b..c8153f3351 100644<o:p></o:p> > --- a/drivers/net/intel/i40e/i40e_ethdev.c<o:p></o:p> > +++ b/drivers/net/intel/i40e/i40e_ethdev.c<o:p></o:p> > @@ -4150,6 +4150,16 @@ i40e_vlan_offload_set(struct rte_eth_dev *dev, int mask)<o:p></o:p> > i40e_vsi_config_vlan_stripping(vsi, TRUE);<o:p></o:p> > else<o:p></o:p> > i40e_vsi_config_vlan_stripping(vsi, FALSE);<o:p></o:p> > +<o:p></o:p> > + /* When VLAN strip is enabled/disabled<o:p></o:p> > + * after enabling outer VLAN stripping,<o:p></o:p> > + * outer VLAN stripping gets disabled<o:p></o:p> > + * as the register gets overridden by<o:p></o:p> > + * VLAN's strip vsi param update.<o:p></o:p> > + * Hence, re-enable outer VLAN stripping.<o:p></o:p> > + */<o:p></o:p> > + if (rxmode->offloads & RTE_ETH_RX_OFFLOAD_QINQ_STRIP)<o:p></o:p> > + i40e_vsi_config_outer_vlan_stripping(vsi, TRUE);<o:p></o:p> > }<o:p></o:p> > <o:p></o:p> >Hi,<o:p></o:p> <o:p> </o:p> >to help me test this patch, can you provide a set of instructions as to how to demonstrate the issue with <o:p></o:p> >i40e and how to verify the fix?<o:p></o:p> Hi Bruce,<o:p></o:p> <o:p> </o:p> Thank you for your queries. PFB my response. Traffic: To observe the issue, one needs QinQ traffic with outer VLAN 802.1ad (0x88A8)/802.1Q(0x8100) and inner VLAN 802.1Q(0x8100).<o:p></o:p> <o:p> </o:p> Instructions :Assuming outer VLAN id as 201, inner vlan can be any other. a. set promisc 0 off<o:p></o:p> b. vlan set extend on 0<o:p></o:p> c. vlan set filter on 0<o:p></o:p> d. vlan set outer tpid 0x88a8 0<o:p></o:p> e. vlan set inner tpid 0x8100 0<o:p></o:p> f. vlan set qinq_strip on 0 g. vlan set strip on 0<o:p></o:p> h.rx_vlan add 201 0<o:p></o:p> i. set fwd macswap<o:p></o:p> j. set verbose 8<o:p></o:p> k. start<o:p></o:p> <o:p> </o:p> Objective: To get both outer and inner VLANs stripped from the incoming double tagged traffic. <o:p></o:p> Issue: <o:p></o:p> When outer VLAN strip (qinq_strip) is enabled first[point f) and afterwards, inner vlan strip is enabled[point g], QinQ stripping fails. In verbose o/p we can see incoming packets will still have either type=0x88a8 or 0x8100 VLAN tag present which is the outer VLAN tag.<o:p></o:p> <o:p> </o:p> Verifying Fix: No change in instruction order. Verbose o/p will show type=0x0800 in incoming order indicating both VLAN tags are removed. P.S: If traffic type is 0x8100+0x8100, then points d and e are Not needed as when we set VLAN extend, both outer & inner VLAN TPIDs are set to 802.1Q(0x8100) by default.<o:p></o:p> Also, if inner VLAN strip is enabled first and then outer VLAN strip is set, QinQ stripping happens smoothly and incoming traffic shows type=0x0800.<o:p></o:p> <o:p> </o:p> Thank you.<o:p></o:p> <o:p> </o:p> Regards,<o:p></o:p> Anurag M<o:p></o:p> <o:p> </o:p> -----Original Message-----<o:p></o:p> From: Richardson, Bruce <<a href="mailto:bruce.richardson@intel.com">bruce.richardson@intel.com</a>> <o:p></o:p> Sent: 11 December 2025 20:11<o:p></o:p> To: Mandal, Anurag <<a href="mailto:anurag.mandal@intel.com">anurag.mandal@intel.com</a>><o:p></o:p> Cc: <a href="mailto:dev@dpdk.org">dev@dpdk.org</a>; <a href="mailto:stable@dpdk.org"> stable@dpdk.org</a><o:p></o:p> Subject: Re: [PATCH] net/i40e: fix QinQ stripping<o:p></o:p> <o:p> </o:p> On Sat, Dec 06, 2025 at 06:43:11PM +0000, Anurag Mandal wrote:<o:p></o:p> > Outer VLAN strip gets disabled when inner VLAN stripping is <o:p></o:p> > enabled/disabled after enabling outer VLAN stripping.<o:p></o:p> > This happens because the respective register is overridden by the vsi <o:p></o:p> > params update of inner VLAN stripping.<o:p></o:p> > <o:p></o:p> > This patch fixes the issue by re-enabling outer VLAN stripping after <o:p></o:p> > modification of inner VLAN stripping.<o:p></o:p> > <o:p></o:p> > Fixes: c52ff36686a4 ("net/i40e: enable QinQ stripping")<o:p></o:p> > Cc: <a href="mailto:stable@dpdk.org">stable@dpdk.org</a><o:p></o:p> > <o:p></o:p> > Signed-off-by: Anurag Mandal <<a href="mailto:anurag.mandal@intel.com">anurag.mandal@intel.com</a>><o:p></o:p> > ---<o:p></o:p> > drivers/net/intel/i40e/i40e_ethdev.c | 10 ++++++++++<o:p></o:p> > 1 file changed, 10 insertions(+)<o:p></o:p> > <o:p></o:p> > diff --git a/drivers/net/intel/i40e/i40e_ethdev.c <o:p> </o:p> > b/drivers/net/intel/i40e/i40e_ethdev.c<o:p></o:p> > index b8ce79061b..c8153f3351 100644<o:p></o:p> > --- a/drivers/net/intel/i40e/i40e_ethdev.c<o:p></o:p> > +++ b/drivers/net/intel/i40e/i40e_ethdev.c<o:p></o:p> > @@ -4150,6 +4150,16 @@ i40e_vlan_offload_set(struct rte_eth_dev *dev, int mask)<o:p></o:p> > i40e_vsi_config_vlan_stripping(vsi, TRUE);<o:p></o:p> > else<o:p></o:p> > i40e_vsi_config_vlan_stripping(vsi, FALSE);<o:p></o:p> > +<o:p></o:p> > + /* When VLAN strip is enabled/disabled<o:p></o:p> > + * after enabling outer VLAN stripping,<o:p></o:p> > + * outer VLAN stripping gets disabled<o:p></o:p> > + * as the register gets overridden by<o:p></o:p> > + * VLAN's strip vsi param update.<o:p></o:p> > + * Hence, re-enable outer VLAN stripping.<o:p></o:p> > + */<o:p></o:p> > + if (rxmode->offloads & RTE_ETH_RX_OFFLOAD_QINQ_STRIP)<o:p></o:p> > + i40e_vsi_config_outer_vlan_stripping(vsi, TRUE);<o:p></o:p> > }<o:p></o:p> > <o:p></o:p> Hi,<o:p></o:p> <o:p> </o:p> to help me test this patch, can you provide a set of instructions as to how to demonstrate the issue with i40e and how to verify the fix?<o:p></o:p> <o:p> </o:p> Thanks,<o:p></o:p> /Bruce<o:p></o:p> </div> </body> </html>