<html><head><meta http-equiv="Content-Type" content="text/html; charset=utf-8"><meta name="Generator" content="Microsoft Word 15 (filtered medium)"><style></style></head><body lang="EN-US" link="blue" vlink="purple" style="word-wrap:break-word"><div class="WordSection1">Hi Denis, Accepted the change, should be merged in next cycle. Thanks,Kishore <div><div style="border:none;border-top:solid #e1e1e1 1.0pt;padding:3.0pt 0in 0in 0in">From: Денис Люлин <<a href="mailto:lyulin.2003@mail.ru">lyulin.2003@mail.ru</a>> Sent: Thursday, July 23, 2026 5:36 AM To: Kishore Padmanabha <<a href="mailto:kishore.padmanabha@broadcom.com">kishore.padmanabha@broadcom.com</a>> Cc: Ajit Khaparde <<a href="mailto:ajit.khaparde@broadcom.com">ajit.khaparde@broadcom.com</a>>; Kalesh AP <<a href="mailto:kalesh-anakkur.purayil@broadcom.com">kalesh-anakkur.purayil@broadcom.com</a>>; <a href="mailto:dev@dpdk.org">dev@dpdk.org</a>; <a href="mailto:stable@dpdk.org">stable@dpdk.org</a> Subject: Re: [PATCH] net/bnxt: add cast to wider type before multiplication</div></div> Kindly reminder Sorry, But nobody has reviewed my small cosmetic patch on Patchwork <a href="https://patches.dpdk.org/project/dpdk/patch/20260417052334.2217652-1-lyulin.2003@mail.ru/">https://patches.dpdk.org/project/dpdk/patch/20260417052334.2217652-1-lyulin.2003@mail.ru/</a> Could you please review this? <blockquote style="border:none;border-left:solid #0857a6 1.0pt;padding:0in 0in 0in 8.0pt;margin-left:7.5pt;margin-top:7.5pt;margin-right:7.5pt;margin-bottom:7.5pt"><div id=""><div id="style_17764444091671824853_mr_css_attr"><div id="style_17764444091671824853_BODY_mr_css_attr"> On Fri, Apr 17, 2026 at 1:23 AM Denis Lyulin <<a href="mailto:lyulin.2003@mail.ru">lyulin.2003@mail.ru</a>> wrote:<blockquote style="border:none;border-left:solid #cccccc 1.0pt;padding:0in 0in 0in 6.0pt;margin-left:4.8pt;margin-right:0in">Some static analyzers generate warnings about possible integer overflow on multiplication. The first parameter of `rte_eal_alarm_set()` is `uint64_t`, so this commit adds cast of `uint32_t` values before the multiplication to prevent overflow. The fix is cosmetic. Fixes: 9d0cbaecc91a ("net/bnxt: support periodic FW health monitoring") Cc: <a href="mailto:kalesh-anakkur.purayil@broadcom.com">kalesh-anakkur.purayil@broadcom.com</a> Cc: <a href="mailto:stable@dpdk.org">stable@dpdk.org</a> Signed-off-by: Denis Lyulin <<a href="mailto:lyulin.2003@mail.ru">lyulin.2003@mail.ru</a>></blockquote>Acked-by: Kishore Padmanabha <<a href="mailto:kishore.padmanabha@broadcom.com">kishore.padmanabha@broadcom.com</a>> <blockquote style="border:none;border-left:solid #cccccc 1.0pt;padding:0in 0in 0in 6.0pt;margin-left:4.8pt;margin-right:0in">--- drivers/net/bnxt/bnxt_ethdev.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/net/bnxt/bnxt_ethdev.c b/drivers/net/bnxt/bnxt_ethdev.c index b677f9491d..bdfab3eef2 100644 --- a/drivers/net/bnxt/bnxt_ethdev.c +++ b/drivers/net/bnxt/bnxt_ethdev.c @@ -4861,7 +4861,7 @@ static void bnxt_dev_recover(void *arg) void bnxt_dev_reset_and_resume(void *arg) { struct bnxt *bp = arg; - uint32_t us = US_PER_MS * bp->fw_reset_min_msecs; + uint64_t us = US_PER_MS * (uint64_t)bp->fw_reset_min_msecs; uint16_t val = 0; int rc; @@ -5008,7 +5008,7 @@ static void bnxt_check_fw_health(void *arg) info->last_reset_counter = val; - rte_eal_alarm_set(US_PER_MS * info->driver_polling_freq, + rte_eal_alarm_set(US_PER_MS * (uint64_t)info->driver_polling_freq, bnxt_check_fw_health, (void *)bp); return; @@ -5030,7 +5030,7 @@ static void bnxt_check_fw_health(void *arg) else wait_msec = info->normal_func_wait_period; - rte_eal_alarm_set(US_PER_MS * wait_msec, + rte_eal_alarm_set(US_PER_MS * (uint64_t)wait_msec, bnxt_fw_reset_cb, (void *)bp); } @@ -5048,7 +5048,7 @@ void bnxt_schedule_fw_health_check(struct bnxt *bp) polling_freq = bp->recovery_info->driver_polling_freq; - rte_eal_alarm_set(US_PER_MS * polling_freq, + rte_eal_alarm_set(US_PER_MS * (uint64_t)polling_freq, bnxt_check_fw_health, (void *)bp); bp->flags |= BNXT_FLAG_FW_HEALTH_CHECK_SCHEDULED; -- 2.34.1 </blockquote></div></div></div></blockquote></div></body></html>