<div dir="auto"><div dir="auto">On Tue, Sep 8, 2026, 9:10 PM Stephen Hemminger <<a href="mailto:stephen@networkplumber.org">stephen@networkplumber.org</a>> wrote:</div><div class="gmail_quote gmail_quote_container" dir="auto"><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">On Fri, 31 Jul 2026 16:37:39 +0300<br>
Andrei-Niculae Petre <<a href="mailto:p31andrei@gmail.com" target="_blank" rel="noreferrer">p31andrei@gmail.com</a>> wrote:<br>
<br>
> Update l3fwd example app to fix compilation when building dpdk with<br>
> RTE_LOG_DP_LEVEL=RTE_LOG_DEBUG in config/rte_config.h .<br>
> Move l3fwd_acl.h include above all #ifdef L3FWDACL_DEBUG checks,<br>
> as previously one ifdef would evaluate to false all the time (as<br>
> header include was added too late).<br>
> <br>
> Adapt maintainers line from previous examples/l3fwd-acl (removed in<br>
> 6de0ea50e9b9) to examples/l3fwd/l3fwd_acl* after l3fwd-acl app<br>
> unification into l3fwd. In 6de0ea50e9b9, a line with maintainer<br>
> expertise was removed.<br>
> <br>
> Own testing of the l3fwd example:<br>
> 1. It now compiles with "#define RTE_LOG_DP_LEVEL RTE_LOG_DEBUG" in<br>
> config/rte_config.h. See Bugzilla ID 1318 comments for full error<br>
> seen before this patch.<br>
> 2. I ran the l3fwd app with IPv4/IPv6 ACL rules to see the prints (when<br>
> RTE_LOG_DP_LEVEL RTE_LOG_DEBUG is set) in the application around ACL<br>
> work as expected. See extract below (I added \ to format to 72chars):<br>
> <br>
> // dump_acl4_rule extract:<br>
> Packet Src:192.168.1.100 Dst:192.168.1.101 Src port:2048,Dst port:1846 \<br>
> hit ACL 1 - <a href="http://192.168.1.100/24" rel="noreferrer noreferrer" target="_blank">192.168.1.100/24</a> <a href="http://0.0.0.0/0" rel="noreferrer noreferrer" target="_blank">0.0.0.0/0</a> 0 : 65535 0 : 65535 0x0/0x0 \<br>
> 0xffffffff-0x1ffffffe-0xf0000001<br>
> <br>
> // dump_acl6_rule extract:<br>
> Packet Src2001:db8:1::100<br>
> Dst2001:db8:1::101<br>
> Src port:32768,Dst port:21005 hit ACL 0 - \<br>
> 2001:0db8:0001:0000:0000:0000:0000:0000/64 \<br>
> 0000:0000:0000:0000:0000:0000:0000:0000/0 0 : 65535 0 : 65535 \<br>
> 0x0/0x0 0xffffffff-0x1fffffff-0xf0000000<br>
> <br>
> Bugzilla ID: 1318<br>
> Fixes: 6de0ea50e9b9 ("examples/l3fwd: merge l3fwd-acl example")<br>
> Cc: <a href="mailto:stable@dpdk.org" target="_blank" rel="noreferrer">stable@dpdk.org</a><br>
> Cc: <a href="mailto:sean.morrissey@intel.com" target="_blank" rel="noreferrer">sean.morrissey@intel.com</a><br>
> <br>
> Signed-off-by: Andrei-Niculae Petre <<a href="mailto:p31andrei@gmail.com" target="_blank" rel="noreferrer">p31andrei@gmail.com</a>><br>
> ---<br>
<br>
> diff --git a/MAINTAINERS b/MAINTAINERS<br>
> index e99a65d197..6b6446a998 100644<br>
> --- a/MAINTAINERS<br>
> +++ b/MAINTAINERS<br>
> @@ -1756,6 +1756,8 @@ F: lib/acl/<br>
> F: doc/guides/prog_guide/packet_classif_access_ctrl.rst<br>
> F: app/test-acl/<br>
> F: app/test/test_acl.*<br>
> +F: examples/l3fwd/l3fwd_acl*<br>
> +F: doc/guides/sample_app_ug/l3_forward.rst<br>
<br>
I don't think all of l3_forward should fall under the ACL maintainer bucket.<br></blockquote></div><div dir="auto"><br></div><div dir="auto">Hi Stephen,</div><div dir="auto"><br></div><div dir="auto">I totally agree, but I didn't know of a better way to do this given all the info was merged in a single file post l3fwd unification. Do you or Konstantin have any better ideas how to do this instead to avoid losing information re ACL maintainer?</div><div dir="auto"><br></div><div dir="auto">Thanks for checking the patch also.</div><div dir="auto"><br>Andrei</div><div class="gmail_quote gmail_quote_container" dir="auto"><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
</blockquote></div></div>