<div dir="ltr"><div dir="ltr"><br></div><br><div class="gmail_quote gmail_quote_container"><div dir="ltr" class="gmail_attr">On Tue, Sep 15, 2026 at 6:40 AM Evgeny Sokolov <<a href="mailto:Evgeny.Sokolov@infotecs.ru">Evgeny.Sokolov@infotecs.ru</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">---<br>
drivers/net/bnxt/bnxt_ethdev.c | 29 +++++++++++++++++--------<br>
drivers/net/bnxt/tf_ulp/bnxt_ulp_tfc.c | 2 ++<br>
drivers/net/bnxt/tf_ulp/ulp_mapper_tf.c | 2 +-<br>
3 files changed, 23 insertions(+), 10 deletions(-)<br>
<br>
diff --git a/drivers/net/bnxt/bnxt_ethdev.c b/drivers/net/bnxt/bnxt_ethdev.c<br>
index 8e8ead8f61..c99c375412 100644<br>
--- a/drivers/net/bnxt/bnxt_ethdev.c<br>
+++ b/drivers/net/bnxt/bnxt_ethdev.c<br>
@@ -6395,57 +6395,68 @@ bnxt_parse_dev_args(struct bnxt *bp, struct rte_devargs *devargs)<br>
if (ret)<br>
goto err;<br>
<br>
-err:<br>
/*<br>
* Handler for "mpc" devarg.<br>
* Invoked as for ex: "-a 000:00:0d.0,mpc=1"<br>
*/<br>
- rte_kvargs_process(kvlist, BNXT_DEVARG_MPC,<br>
+ ret = rte_kvargs_process(kvlist, BNXT_DEVARG_MPC,<br>
bnxt_parse_devarg_mpc, bp);<br>
+ if (ret)<br>
+ goto err;<br>
<br>
/*<br>
* Handler for "app-id" devarg.<br>
* Invoked as for ex: "-a 000:00:0d.0,app-id=1"<br>
*/<br>
- rte_kvargs_process(kvlist, BNXT_DEVARG_APP_ID,<br>
+ ret = rte_kvargs_process(kvlist, BNXT_DEVARG_APP_ID,<br>
bnxt_parse_devarg_app_id, bp);<br>
+ if (ret)<br>
+ goto err;<br>
<br>
/*<br>
* Handler for "ieee-1588" devarg.<br>
* Invoked as for ex: "-a 000:00:0d.0,ieee-1588=1"<br>
*/<br>
- rte_kvargs_process(kvlist, BNXT_DEVARG_IEEE_1588,<br>
+ ret = rte_kvargs_process(kvlist, BNXT_DEVARG_IEEE_1588,<br>
bnxt_parse_devarg_ieee_1588, bp);<br>
+ if (ret)<br>
+ goto err;<br>
<br>
/*<br>
* Handler for "cqe-mode" devarg.<br>
* Invoked as for ex: "-a 000:00:0d.0,cqe-mode=1"<br>
*/<br>
- rte_kvargs_process(kvlist, BNXT_DEVARG_CQE_MODE,<br>
+ ret = rte_kvargs_process(kvlist, BNXT_DEVARG_CQE_MODE,<br>
bnxt_parse_devarg_cqe_mode, bp);<br>
+ if (ret)<br>
+ goto err;<br>
<br>
/*<br>
* Handler for "representor" devarg.<br>
* Invoked as for ex: "-a 000:00:0d.0,representor=1"<br>
*/<br>
- rte_kvargs_process(kvlist, BNXT_DEVARG_REPRESENTOR,<br>
+ ret = rte_kvargs_process(kvlist, BNXT_DEVARG_REPRESENTOR,<br>
bnxt_parse_devarg_representor_mode, bp);<br>
+ if (ret)<br>
+ goto err;<br>
<br>
/*<br>
* Handler for "scalar-mode" devarg.<br>
* Invoked as for ex: "-a 000:00:0d.0,scalar-mode=1"<br>
*/<br>
- rte_kvargs_process(kvlist, BNXT_DEVARG_SCALAR_MODE,<br>
+ ret = rte_kvargs_process(kvlist, BNXT_DEVARG_SCALAR_MODE,<br>
bnxt_parse_devarg_scalar_mode, bp);<br>
+ if (ret)<br>
+ goto err;<br>
<br>
/*<br>
* Handler for "app-instance-id" devarg.<br>
* Invoked as for ex: "-a 000:00:0d.0,app-instance-id=1"<br>
* This argument is required for enabling truflow hot upgrade feature.<br>
*/<br>
- rte_kvargs_process(kvlist, BNXT_DEVARD_APP_INST_ID,<br>
+ ret = rte_kvargs_process(kvlist, BNXT_DEVARD_APP_INST_ID,<br>
bnxt_parse_devarg_app_instance_id, bp);<br>
-<br>
+err:<br>
rte_kvargs_free(kvlist);<br>
return ret;<br>
}<br>
diff --git a/drivers/net/bnxt/tf_ulp/bnxt_ulp_tfc.c b/drivers/net/bnxt/tf_ulp/bnxt_ulp_tfc.c<br>
index fa98b2bca9..facce8f125 100644<br>
--- a/drivers/net/bnxt/tf_ulp/bnxt_ulp_tfc.c<br>
+++ b/drivers/net/bnxt/tf_ulp/bnxt_ulp_tfc.c<br>
@@ -309,6 +309,8 @@ ulp_tfc_tbl_scope_deinit(struct bnxt *bp)<br>
return;<br>
<br>
rc = bnxt_ulp_cntxt_tsid_get(bp->ulp_ctx, &tsid);<br>
+ if (rc)<br>
+ return;<br>
<br>
rc = bnxt_ulp_cntxt_fid_get(bp->ulp_ctx, &fid);<br>
if (rc)<br>
diff --git a/drivers/net/bnxt/tf_ulp/ulp_mapper_tf.c b/drivers/net/bnxt/tf_ulp/ulp_mapper_tf.c<br>
index f17fb6e3b2..075071620f 100644<br>
--- a/drivers/net/bnxt/tf_ulp/ulp_mapper_tf.c<br>
+++ b/drivers/net/bnxt/tf_ulp/ulp_mapper_tf.c<br>
@@ -404,7 +404,7 @@ ulp_mapper_tf_em_tbl_process(struct bnxt_ulp_mapper_parms *parms,<br>
BNXT_DRV_DBG(DEBUG,<br>
"Fail to insert EM, shall add to wc\n");<br>
}<br>
- ulp_regfile_write(parms->regfile, tbl->tbl_operand,<br>
+ rc = ulp_regfile_write(parms->regfile, tbl->tbl_operand,<br>
tfp_cpu_to_be_64(val));<br></blockquote><div>The return code needs to be handled, cannot overload this to rc.</div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">
}<br>
if (rc)<br>
-- <br>
2.47.3<br>
<br>
</blockquote></div></div>