[dpdk-test-report] [PatchWork]|ERROR| pw12038-12073 mempool: fix comments and style

[sys_stv at intel.com]

Test-Label: Intel Niantic on Fedora
Test-Status: ERROR

Patchwork ID: 12038-12073
http://www.dpdk.org/dev/patchwork/patch/12073/
Submitter: Olivier Matz <olivier.matz at 6wind.com>
Date: Thu, 14 Apr 2016 12:19:24 +0200
DPDK git baseline: e888dffdcbe1a3bc909d6ece1b8de01fd4d26172

Check patch error:
12040: 
WARNING: quoted string split across lines
#56: FILE: lib/librte_mempool/rte_mempool.c:733:
+            rte_panic("MEMPOOL: object is owned by another "
+                  "mempool
");

WARNING: line over 80 characters
#65: FILE: lib/librte_mempool/rte_mempool.c:742:
+                    "obj=%p, mempool=%p, cookie=%" PRIx64 "
",

ERROR: else should follow close brace '}'
#71: FILE: lib/librte_mempool/rte_mempool.c:748:
+        }
+        else if (free == 1) {

WARNING: line over 80 characters
#75: FILE: lib/librte_mempool/rte_mempool.c:752:
+					"obj=%p, mempool=%p, cookie=%" PRIx64 "
",

ERROR: else should follow close brace '}'
#81: FILE: lib/librte_mempool/rte_mempool.c:758:
+		}
+		else if (free == 2) {

WARNING: line over 80 characters
#86: FILE: lib/librte_mempool/rte_mempool.c:763:
+					"obj=%p, mempool=%p, cookie=%" PRIx64 "
",

WARNING: line over 80 characters
#88: FILE: lib/librte_mempool/rte_mempool.c:765:
+				rte_panic("MEMPOOL: bad header cookie (audit)
");

total: 2 errors, 5 warnings, 163 lines checked

/home/patchWorkOrg/patches/dpdk-dev-03-36-mempool-uninline-function-to-check-cookies.patch has style problems, please review.

If any of these errors are false positives, please report them to the maintainer, see CHECKPATCH in MAINTAINERS.

12048: 
ERROR: do not use assignment in if condition
#283: FILE: lib/librte_mempool/rte_mempool.c:393:
+	if ((n = rte_mempool_obj_mem_iter(vaddr, elt_num, total_elt_sz, 1,

total: 1 errors, 0 warnings, 334 lines checked

/home/patchWorkOrg/patches/dpdk-dev-10-36-mempool-use-the-list-to-iterate-the-mempool-elements.patch has style problems, please review.

If any of these errors are false positives, please report them to the maintainer, see CHECKPATCH in MAINTAINERS.

12069: 
ERROR: space required before the open parenthesis '('
#37: FILE: app/test/test_mempool.c:83:
+	} while(0)

total: 1 errors, 0 warnings, 420 lines checked

/home/patchWorkOrg/patches/dpdk-dev-35-36-app-test-rework-mempool-test.patch has style problems, please review.

If any of these errors are false positives, please report them to the maintainer, see CHECKPATCH in MAINTAINERS.

12039: 
ERROR: do not use assignment in if condition
#81: FILE: lib/librte_mempool/rte_mempool.c:342:
+	if ((n = pg_sz / total_elt_sz) > 0) {

ERROR: do not use assignment in if condition
#104: FILE: lib/librte_mempool/rte_mempool.c:377:
+	if ((n = rte_mempool_obj_iter(vaddr, elt_num, total_elt_sz, 1,

total: 2 errors, 0 warnings, 116 lines checked

/home/patchWorkOrg/patches/dpdk-dev-02-36-mempool-replace-elt_size-by-total_elt_size.patch has style problems, please review.

If any of these errors are false positives, please report them to the maintainer, see CHECKPATCH in MAINTAINERS.



patch file error:
12065: 
patching file lib/librte_mempool/rte_mempool.c Hunk #1 FAILED at 324.
Hunk #2 FAILED at 372.
Hunk #3 FAILED at 696.
3 out of 3 hunks FAILED -- saving rejects to file lib/librte_mempool/rte_mempool.c.rej
patching file lib/librte_mempool/rte_mempool.h Hunk #1 succeeded at 223 (offset -11 lines).

12066: 
patching file lib/librte_mempool/rte_mempool.c Hunk #1 FAILED at 365.
Hunk #2 FAILED at 423.
Hunk #3 FAILED at 458.
Hunk #4 FAILED at 518.
Hunk #5 FAILED at 609.
Hunk #6 FAILED at 650.
Hunk #7 FAILED at 679.
7 out of 7 hunks FAILED -- saving rejects to file lib/librte_mempool/rte_mempool.c.rej
patching file lib/librte_mempool/rte_mempool.h Hunk #1 FAILED at 502.
1 out of 1 hunk FAILED -- saving rejects to file lib/librte_mempool/rte_mempool.h.rej
patching file lib/librte_mempool/rte_mempool_version.map
Hunk #1 FAILED at 16.
1 out of 1 hunk FAILED -- saving rejects to file lib/librte_mempool/rte_mempool_version.map.rej

12067: 
patching file app/test-pmd/Makefile
patching file app/test-pmd/mempool_anon.c Reversed (or previously applied) patch detected!  Assume -R? [n] Apply anyway? [n] Skipping patch.
1 out of 1 hunk ignored -- saving rejects to file app/test-pmd/mempool_anon.c.rej patching file app/test-pmd/mempool_osdep.h Reversed (or previously applied) patch detected!  Assume -R? [n] Apply anyway? [n] Skipping patch.
1 out of 1 hunk ignored -- saving rejects to file app/test-pmd/mempool_osdep.h.rej patching file app/test-pmd/testpmd.c Hunk #2 FAILED at 426.
1 out of 2 hunks FAILED -- saving rejects to file app/test-pmd/testpmd.c.rej

12069: 
patching file app/test/test_mempool.c
Hunk #3 FAILED at 114.
Hunk #4 succeeded at 140 (offset 1 line).
Hunk #5 succeeded at 157 (offset 1 line).
Hunk #6 succeeded at 174 (offset 1 line).
Hunk #7 succeeded at 197 (offset 1 line).
Hunk #8 succeeded at 245 (offset 1 line).
Hunk #9 succeeded at 292 (offset 1 line).
Hunk #10 succeeded at 318 (offset 1 line).
Hunk #11 succeeded at 361 (offset 1 line).
Hunk #12 succeeded at 371 (offset 1 line).
Hunk #13 FAILED at 420.
Hunk #14 succeeded at 459 (offset -3 lines).
Hunk #15 succeeded at 472 (offset -3 lines).
2 out of 15 hunks FAILED -- saving rejects to file app/test/test_mempool.c.rej

12070: 
patching file lib/librte_mempool/rte_mempool.c Hunk #2 FAILED at 586.
1 out of 2 hunks FAILED -- saving rejects to file lib/librte_mempool/rte_mempool.c.rej

12071: 
patching file lib/librte_mempool/rte_mempool.c Hunk #1 FAILED at 719.
Hunk #2 FAILED at 983.
2 out of 2 hunks FAILED -- saving rejects to file lib/librte_mempool/rte_mempool.c.rej
patching file lib/librte_mempool/rte_mempool.h Hunk #1 succeeded at 181 with fuzz 2 (offset -22 lines).

12072: 
patching file app/test/test_mempool.c
Hunk #1 succeeded at 408 (offset 1 line).
patching file lib/librte_eal/common/eal_common_memzone.c
patching file lib/librte_mempool/rte_mempool.c Hunk #1 FAILED at 303.
Hunk #2 FAILED at 692.
Hunk #3 succeeded at 558 with fuzz 2 (offset -187 lines).
Hunk #4 FAILED at 758.
3 out of 4 hunks FAILED -- saving rejects to file lib/librte_mempool/rte_mempool.c.rej
patching file lib/librte_ring/rte_ring.c

12073: 
patching file lib/librte_eal/common/eal_common_log.c
patching file lib/librte_mempool/rte_mempool.c Hunk #1 FAILED at 410.
Hunk #2 FAILED at 439.
Hunk #3 FAILED at 479.
Hunk #4 FAILED at 528.
Hunk #5 FAILED at 567.
5 out of 5 hunks FAILED -- saving rejects to file lib/librte_mempool/rte_mempool.c.rej
patching file lib/librte_mempool/rte_mempool.h Hunk #1 FAILED at 235.
Hunk #2 succeeded at 522 (offset 105 lines).
Hunk #3 succeeded at 1254 with fuzz 1 (offset 30 lines).
1 out of 3 hunks FAILED -- saving rejects to file lib/librte_mempool/rte_mempool.h.rej

12050: 
patching file lib/librte_mempool/rte_mempool.c Hunk #3 succeeded at 528 (offset 4 lines).
Hunk #4 succeeded at 536 (offset 4 lines).
Hunk #5 succeeded at 604 (offset 4 lines).
Hunk #6 succeeded at 685 with fuzz 2 (offset 74 lines).
Hunk #7 FAILED at 665.
1 out of 7 hunks FAILED -- saving rejects to file lib/librte_mempool/rte_mempool.c.rej
patching file lib/librte_mempool/rte_mempool.h Hunk #1 succeeded at 190 (offset 2 lines).

12051: 
patching file lib/librte_mempool/rte_mempool.c Hunk #1 FAILED at 132.
Hunk #2 succeeded at 161 (offset -12 lines).
Hunk #3 succeeded at 197 (offset -12 lines).
Hunk #4 FAILED at 249.
Hunk #5 succeeded at 349 with fuzz 1 (offset -8 lines).
2 out of 5 hunks FAILED -- saving rejects to file lib/librte_mempool/rte_mempool.c.rej
patching file lib/librte_mempool/rte_mempool.h Hunk #1 succeeded at 158 with fuzz 2.
Hunk #2 succeeded at 1256 (offset 130 lines).

12053: 
patching file app/test/test_mempool.c
Hunk #1 FAILED at 123.
1 out of 1 hunk FAILED -- saving rejects to file app/test/test_mempool.c.rej patching file lib/librte_mempool/rte_mempool.c Hunk #1 FAILED at 141.
Hunk #2 FAILED at 246.
Hunk #3 succeeded at 421 with fuzz 1 (offset -44 lines).
Hunk #4 succeeded at 552 (offset -41 lines).
Hunk #5 succeeded at 586 (offset -37 lines).
Hunk #6 FAILED at 670.
Hunk #7 FAILED at 718.
Hunk #8 FAILED at 727.
Hunk #9 FAILED at 773.
Hunk #10 succeeded at 897 (offset -69 lines).
Hunk #11 succeeded at 909 (offset -69 lines).
Hunk #12 succeeded at 919 (offset -69 lines).
6 out of 12 hunks FAILED -- saving rejects to file lib/librte_mempool/rte_mempool.c.rej
patching file lib/librte_mempool/rte_mempool.h Hunk #1 succeeded at 177 (offset -5 lines).
Hunk #2 FAILED at 209.
Hunk #3 FAILED at 222.
Hunk #4 FAILED at 272.
Hunk #5 FAILED at 286.
Hunk #6 FAILED at 1178.
5 out of 6 hunks FAILED -- saving rejects to file lib/librte_mempool/rte_mempool.h.rej

12054: 
patching file lib/librte_mempool/rte_mempool.c Hunk #1 FAILED at 244.
1 out of 1 hunk FAILED -- saving rejects to file lib/librte_mempool/rte_mempool.c.rej
patching file lib/librte_mempool/rte_mempool.h Hunk #1 succeeded at 463 with fuzz 1 (offset 131 lines).
Hunk #2 succeeded at 758 with fuzz 1 (offset 147 lines).
patching file lib/librte_mempool/rte_mempool_version.map
Hunk #1 FAILED at 21.
1 out of 1 hunk FAILED -- saving rejects to file lib/librte_mempool/rte_mempool_version.map.rej

12056: 
patching file lib/librte_mempool/rte_mempool.c Hunk #1 FAILED at 388.
Hunk #2 FAILED at 405.
Hunk #3 FAILED at 415.
Hunk #4 FAILED at 436.
Hunk #5 FAILED at 462.
Hunk #6 FAILED at 480.
Hunk #7 FAILED at 666.
7 out of 7 hunks FAILED -- saving rejects to file lib/librte_mempool/rte_mempool.c.rej
patching file lib/librte_mempool/rte_mempool.h Hunk #1 FAILED at 187.
Hunk #2 FAILED at 198.
2 out of 2 hunks FAILED -- saving rejects to file lib/librte_mempool/rte_mempool.h.rej

12057: 
patching file lib/librte_mempool/rte_mempool.c Hunk #1 FAILED at 252.
1 out of 1 hunk FAILED -- saving rejects to file lib/librte_mempool/rte_mempool.c.rej
patching file lib/librte_mempool/rte_mempool.h Hunk #1 succeeded at 1354 with fuzz 2 (offset 97 lines).

12058: 
patching file drivers/net/mlx4/mlx4.c
Hunk #1 succeeded at 1187 (offset -11 lines).
Hunk #2 succeeded at 1266 (offset -11 lines).
Hunk #3 succeeded at 1294 (offset -11 lines).
Hunk #4 succeeded at 1334 (offset -11 lines).
Hunk #5 succeeded at 1352 (offset -11 lines).
Hunk #6 succeeded at 1373 (offset -11 lines).
patching file drivers/net/mlx5/mlx5_rxtx.c Hunk #1 succeeded at 136 (offset -4 lines).
Hunk #2 succeeded at 215 (offset -4 lines).
Hunk #3 succeeded at 243 (offset -4 lines).
Hunk #4 succeeded at 283 (offset -4 lines).
Hunk #5 succeeded at 301 (offset -4 lines).
Hunk #6 succeeded at 322 (offset -4 lines).
patching file drivers/net/mlx5/mlx5_rxtx.h Hunk #1 FAILED at 341.
1 out of 1 hunk FAILED -- saving rejects to file drivers/net/mlx5/mlx5_rxtx.h.rej patching file lib/librte_kni/rte_kni.c patching file lib/librte_mempool/rte_dom0_mempool.c
patching file lib/librte_mempool/rte_mempool.c Hunk #1 FAILED at 389.
Hunk #2 succeeded at 419 with fuzz 1 (offset -88 lines).
Hunk #3 FAILED at 579.
Hunk #4 FAILED at 640.
Hunk #5 succeeded at 599 with fuzz 2 (offset -67 lines).
Hunk #6 succeeded at 606 (offset -67 lines).
Hunk #7 FAILED at 704.
Hunk #8 succeeded at 663 with fuzz 2 (offset -79 lines).
4 out of 8 hunks FAILED -- saving rejects to file lib/librte_mempool/rte_mempool.c.rej
patching file lib/librte_mempool/rte_mempool.h Hunk #1 succeeded at 126 (offset 2 lines).

12060: 
patching file lib/librte_mempool/rte_mempool.c Hunk #1 succeeded at 297 (offset 75 lines).
Hunk #2 succeeded at 402 with fuzz 1 (offset -88 lines).
Hunk #3 succeeded at 475 (offset -88 lines).
Hunk #4 succeeded at 507 (offset -88 lines).
patching file lib/librte_mempool/rte_mempool.h Hunk #1 FAILED at 1146.
1 out of 1 hunk FAILED -- saving rejects to file lib/librte_mempool/rte_mempool.h.rej

12061: 
patching file lib/librte_mempool/rte_mempool.c Hunk #1 FAILED at 318.
Hunk #2 FAILED at 645.
Hunk #3 FAILED at 668.
Hunk #4 FAILED at 691.
Hunk #5 FAILED at 730.
Hunk #6 FAILED at 746.
Hunk #7 FAILED at 771.
7 out of 7 hunks FAILED -- saving rejects to file lib/librte_mempool/rte_mempool.c.rej

12062: 
patching file lib/librte_mempool/rte_mempool.c Hunk #1 succeeded at 419 with fuzz 1 (offset -197 lines).
Hunk #2 FAILED at 804.
1 out of 2 hunks FAILED -- saving rejects to file lib/librte_mempool/rte_mempool.c.rej

12063: 
patching file lib/librte_mempool/Makefile patching file lib/librte_mempool/rte_dom0_mempool.c
Reversed (or previously applied) patch detected!  Assume -R? [n] Apply anyway? [n] Skipping patch.
1 out of 1 hunk ignored -- saving rejects to file lib/librte_mempool/rte_dom0_mempool.c.rej
patching file lib/librte_mempool/rte_mempool.c Hunk #1 FAILED at 298.
Hunk #2 FAILED at 490.
Hunk #3 FAILED at 571.
Hunk #4 FAILED at 747.
4 out of 4 hunks FAILED -- saving rejects to file lib/librte_mempool/rte_mempool.c.rej
patching file lib/librte_mempool/rte_mempool.h Hunk #1 FAILED at 501.
1 out of 1 hunk FAILED -- saving rejects to file lib/librte_mempool/rte_mempool.h.rej
patching file lib/librte_mempool/rte_mempool_version.map


 DPDK STV team