[dpdk-test-report] [PatchWork]|SUCCESS| pw12189 Rate as a decimal number

sys_stv at intel.com sys_stv at intel.com
Thu Apr 21 18:05:27 CEST 2016


Test-Label: Intel Niantic on Fedora
Test-Status: SUCCESS

Patchwork ID: 12189
http://www.dpdk.org/dev/patchwork/patch/12189/
Submitter: "inaki.murillo" <inaki.murilloa at ehu.eus>
Date: Thu, 21 Apr 2016 17:33:44 +0200
DPDK git baseline: 7d619406f31ddf115714b32778c33f6dc0ead470

Check patch error:
12189: 
ERROR: code indent should use tabs where possible
#49: FILE: app/cmd-functions.c:1869:
+        TOKEN_FLOAT_INITIALIZER(struct cmd_set_result, value, FLOAT);$

WARNING: please, no spaces at the start of a line
#49: FILE: app/cmd-functions.c:1869:
+        TOKEN_FLOAT_INITIALIZER(struct cmd_set_result, value, FLOAT);$

WARNING: line over 80 characters
#67: FILE: app/cmd-functions.c:4704:
+cmdline_parse_float(cmdline_parse_token_hdr_t *tk, const char *srcbuf, void *res, unsigned ressize)

ERROR: space prohibited after that '!' (ctx:WxW)
#75: FILE: app/cmd-functions.c:4712:
+	if (!tk || !srcbuf || ! *srcbuf)
 	                      ^

WARNING: line over 80 characters
#79: FILE: app/cmd-functions.c:4716:
+	while(!cmdline_isendoftoken(srcbuf[token_len]) && token_len < (STR_TOKEN_SIZE-1))

ERROR: that open brace { should be on the previous line
#79: FILE: app/cmd-functions.c:4716:
+	while(!cmdline_isendoftoken(srcbuf[token_len]) && token_len < (STR_TOKEN_SIZE-1))
+	{

ERROR: space required before the open parenthesis '('
#79: FILE: app/cmd-functions.c:4716:
+	while(!cmdline_isendoftoken(srcbuf[token_len]) && token_len < (STR_TOKEN_SIZE-1))

WARNING: braces {} are not necessary for single statement blocks
#85: FILE: app/cmd-functions.c:4722:
+	if (token_len >= STR_TOKEN_SIZE - 1) {
+		return -1;
+	}

WARNING: line over 80 characters
#102: FILE: app/cmd-functions.c:4739:
+cmdline_get_help_float(cmdline_parse_token_hdr_t *tk, char *dstbuf, unsigned int size)

WARNING: line over 80 characters
#110: FILE: app/cmd-functions.c:4747:
+	memcpy(&nd, &((struct cmdline_token_float *)tk)->float_data, sizeof(nd));

WARNING: do not add new typedefs
#145: FILE: app/cmd-functions.h:95:
+typedef struct cmdline_token_float cmdline_parse_token_float_t;

ERROR: code indent should use tabs where possible
#191: FILE: app/pktgen-cmds.c:181:
+^I^I        "# Port: %2d, Burst:%3d, Rate:%3f%%, Flags:%08x, TX Count:%s\n",$

total: 5 errors, 7 warnings, 2817 lines checked

NOTE: whitespace errors detected, you may wish to use scripts/cleanpatch or
      scripts/cleanfile

/home/patchWorkOrg/patches/dpdk-dev-Rate-as-a-decimal-number.patch has style problems, please review.

If any of these errors are false positives, please report
them to the maintainer, see CHECKPATCH in MAINTAINERS.


Compilation:
OS: fedora
Nic: niantic
GCC: gcc_x86-64, 4.8.3
ICC:16.0.2
i686-native-linuxapp-icc: compile pass
x86_64-native-linuxapp-gcc-combined: compile pass
i686-native-linuxapp-gcc: compile pass
x86_64-native-linuxapp-gcc: compile pass
x86_64-native-linuxapp-icc: compile pass
x86_64-native-linuxapp-gcc-debug: compile pass
x86_64-native-linuxapp-gcc-shared: compile pass
x86_64-native-linuxapp-clang: compile pass



DPDK STV team 


More information about the test-report mailing list