[dpdk-test-report] |WARNING| [PATCH 1/8] drivers/common/dpaa2: Run time assembler for Descriptor formation

checkpatch at dpdk.org checkpatch at dpdk.org
Mon Dec 5 08:29:31 CET 2016
Previous message: [dpdk-test-report] |SUCCESS| pw17589 [PATCH, 1/3] mk: fix build of assembly files for ARM64
Next message: [dpdk-test-report] |SUCCESS| [PATCH 3/8] doc: Adding NXP DPAA2_SEC in cryptodev
Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]
Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/17672

_coding style issues_


WARNING:TYPO_SPELLING: 'descritptor' may be misspelled - perhaps 'descriptor'?
#136: 
for descritptor formation.

ERROR:COMPLEX_MACRO: Macros with complex values should be enclosed in parentheses
#281: FILE: drivers/common/dpaa2/flib/compat.h:50:
+#define __always_inline inline __attribute__((always_inline))

WARNING:PREFER_PR_LEVEL: Prefer pr_warn(... to pr_warning(...
#321: FILE: drivers/common/dpaa2/flib/compat.h:90:
+#define pr_warning(fmt, ...)    printf(fmt, ##__VA_ARGS__)

WARNING:PREFER_PR_LEVEL: Prefer pr_warn(... to pr_warning(...
#323: FILE: drivers/common/dpaa2/flib/compat.h:92:
+#define pr_warning(fmt, ...)    no_printf(fmt, ##__VA_ARGS__)

WARNING:UNSPECIFIED_INT: Prefer 'unsigned int' to bare use of 'unsigned'
#607: FILE: drivers/common/dpaa2/flib/rta.h:184:
+static inline unsigned rta_get_sec_era(void)

WARNING:TABSTOP: Statements should start on a tabstop
#609: FILE: drivers/common/dpaa2/flib/rta.h:186:
+	 return rta_sec_era;

WARNING:UNSPECIFIED_INT: Prefer 'unsigned int' to bare use of 'unsigned'
#1235: FILE: drivers/common/dpaa2/flib/rta.h:812:
+#define LABEL(label)      unsigned label = 0

ERROR:COMPLEX_MACRO: Macros with complex values should be enclosed in parentheses
#1243: FILE: drivers/common/dpaa2/flib/rta.h:820:
+#define SET_LABEL(program, label)  label = rta_set_label(program)

WARNING:UNSPECIFIED_INT: Prefer 'unsigned int' to bare use of 'unsigned'
#1390: FILE: drivers/common/dpaa2/flib/rta/fifo_load_store_cmd.h:43:
+static const unsigned fifo_load_table_sz[] = {22, 22, 23, 23, 23, 23, 23, 23};

WARNING:UNSPECIFIED_INT: Prefer 'unsigned int' to bare use of 'unsigned'
#1399: FILE: drivers/common/dpaa2/flib/rta/fifo_load_store_cmd.h:52:
+	unsigned start_pc = program->current_pc;

WARNING:UNSPECIFIED_INT: Prefer 'unsigned int' to bare use of 'unsigned'
#1547: FILE: drivers/common/dpaa2/flib/rta/fifo_load_store_cmd.h:200:
+static const unsigned fifo_store_table_sz[] = {21, 21, 21, 21, 22, 22, 22, 23};

WARNING:UNSPECIFIED_INT: Prefer 'unsigned int' to bare use of 'unsigned'
#1557: FILE: drivers/common/dpaa2/flib/rta/fifo_load_store_cmd.h:210:
+	unsigned start_pc = program->current_pc;

WARNING:UNSPECIFIED_INT: Prefer 'unsigned int' to bare use of 'unsigned'
#1698: FILE: drivers/common/dpaa2/flib/rta/header_cmd.h:37:
+				 enum rta_share_type share, unsigned start_idx,

WARNING:UNSPECIFIED_INT: Prefer 'unsigned int' to bare use of 'unsigned'
#1702: FILE: drivers/common/dpaa2/flib/rta/header_cmd.h:41:
+	unsigned start_pc = program->current_pc;

WARNING:UNSPECIFIED_INT: Prefer 'unsigned int' to bare use of 'unsigned'
#1761: FILE: drivers/common/dpaa2/flib/rta/header_cmd.h:100:
+				 enum rta_share_type share, unsigned start_idx,

WARNING:UNSPECIFIED_INT: Prefer 'unsigned int' to bare use of 'unsigned'
#1767: FILE: drivers/common/dpaa2/flib/rta/header_cmd.h:106:
+	unsigned start_pc = program->current_pc;

WARNING:UNSPECIFIED_INT: Prefer 'unsigned int' to bare use of 'unsigned'
#1938: FILE: drivers/common/dpaa2/flib/rta/jump_cmd.h:58:
+	unsigned start_pc = program->current_pc;

WARNING:UNSPECIFIED_INT: Prefer 'unsigned int' to bare use of 'unsigned'
#2088: FILE: drivers/common/dpaa2/flib/rta/key_cmd.h:30:
+	unsigned start_pc = program->current_pc;

WARNING:BLOCK_COMMENT_STYLE: Block comments use * on subsequent lines
#2197: FILE: drivers/common/dpaa2/flib/rta/key_cmd.h:139:
+		/* Encrypted (black) keys must be padded to 8 bytes (CCM) or
+		   16 bytes (ECB) depending on EKT bit. AES-CCM encrypted keys

WARNING:UNSPECIFIED_INT: Prefer 'unsigned int' to bare use of 'unsigned'
#2390: FILE: drivers/common/dpaa2/flib/rta/load_cmd.h:139:
+static const unsigned load_dst_sz[] = { 31, 34, 34, 40, 40, 40, 40, 40 };

WARNING:UNNECESSARY_BREAK: break is not useful after a goto or return
#2453: FILE: drivers/common/dpaa2/flib/rta/load_cmd.h:202:
+		goto err;
+		break;

WARNING:UNSPECIFIED_INT: Prefer 'unsigned int' to bare use of 'unsigned'
#2466: FILE: drivers/common/dpaa2/flib/rta/load_cmd.h:215:
+	unsigned start_pc = program->current_pc, i;

WARNING:UNSPECIFIED_INT: Prefer 'unsigned int' to bare use of 'unsigned'
#2589: FILE: drivers/common/dpaa2/flib/rta/math_cmd.h:31:
+static const unsigned math_op1_sz[] = {10, 10, 12, 12, 12, 12, 12, 12};

WARNING:UNSPECIFIED_INT: Prefer 'unsigned int' to bare use of 'unsigned'
#2611: FILE: drivers/common/dpaa2/flib/rta/math_cmd.h:53:
+static const unsigned math_op2_sz[] = {8, 9, 13, 13, 13, 13, 13, 13};

WARNING:UNSPECIFIED_INT: Prefer 'unsigned int' to bare use of 'unsigned'
#2631: FILE: drivers/common/dpaa2/flib/rta/math_cmd.h:73:
+static const unsigned math_result_sz[] = {9, 9, 10, 10, 10, 10, 10, 10};

WARNING:UNSPECIFIED_INT: Prefer 'unsigned int' to bare use of 'unsigned'
#2640: FILE: drivers/common/dpaa2/flib/rta/math_cmd.h:82:
+	unsigned start_pc = program->current_pc;

WARNING:UNSPECIFIED_INT: Prefer 'unsigned int' to bare use of 'unsigned'
#2812: FILE: drivers/common/dpaa2/flib/rta/math_cmd.h:254:
+	unsigned start_pc = program->current_pc;

WARNING:UNSPECIFIED_INT: Prefer 'unsigned int' to bare use of 'unsigned'
#2979: FILE: drivers/common/dpaa2/flib/rta/move_cmd.h:49:
+static const unsigned move_src_table_sz[] = {9, 11, 14, 14, 14, 14, 14, 14};

WARNING:UNSPECIFIED_INT: Prefer 'unsigned int' to bare use of 'unsigned'
#3003: FILE: drivers/common/dpaa2/flib/rta/move_cmd.h:73:
+static const unsigned move_dst_table_sz[] = {13, 14, 14, 15, 15, 15, 15, 15};

WARNING:UNSPECIFIED_INT: Prefer 'unsigned int' to bare use of 'unsigned'
#3021: FILE: drivers/common/dpaa2/flib/rta/move_cmd.h:91:
+	unsigned start_pc = program->current_pc;

WARNING:UNSPECIFIED_INT: Prefer 'unsigned int' to bare use of 'unsigned'
#3367: FILE: drivers/common/dpaa2/flib/rta/nfifo_cmd.h:26:
+static const unsigned nfifo_src_sz[] = {4, 5, 5, 5, 5, 5, 5, 7};

WARNING:UNSPECIFIED_INT: Prefer 'unsigned int' to bare use of 'unsigned'
#3420: FILE: drivers/common/dpaa2/flib/rta/nfifo_cmd.h:79:
+static const unsigned nfifo_flags_sz[] = {12, 14, 14, 14, 14, 14, 14, 14};

WARNING:UNSPECIFIED_INT: Prefer 'unsigned int' to bare use of 'unsigned'
#3433: FILE: drivers/common/dpaa2/flib/rta/nfifo_cmd.h:92:
+static const unsigned nfifo_pad_flags_sz[] = {2, 2, 2, 2, 3, 3, 3, 3};

WARNING:UNSPECIFIED_INT: Prefer 'unsigned int' to bare use of 'unsigned'
#3442: FILE: drivers/common/dpaa2/flib/rta/nfifo_cmd.h:101:
+	unsigned start_pc = program->current_pc;

WARNING:UNSPECIFIED_INT: Prefer 'unsigned int' to bare use of 'unsigned'
#3724: FILE: drivers/common/dpaa2/flib/rta/operation_cmd.h:216:
+static const unsigned alg_table_sz[] = {14, 15, 15, 15, 17, 17, 11, 17};

WARNING:UNSPECIFIED_INT: Prefer 'unsigned int' to bare use of 'unsigned'
#3731: FILE: drivers/common/dpaa2/flib/rta/operation_cmd.h:223:
+	unsigned i, found = 0;

WARNING:UNSPECIFIED_INT: Prefer 'unsigned int' to bare use of 'unsigned'
#3732: FILE: drivers/common/dpaa2/flib/rta/operation_cmd.h:224:
+	unsigned start_pc = program->current_pc;

WARNING:UNSPECIFIED_INT: Prefer 'unsigned int' to bare use of 'unsigned'
#3995: FILE: drivers/common/dpaa2/flib/rta/operation_cmd.h:487:
+	unsigned start_pc = program->current_pc;

WARNING:UNSPECIFIED_INT: Prefer 'unsigned int' to bare use of 'unsigned'
#4647: FILE: drivers/common/dpaa2/flib/rta/protocol_cmd.h:584:
+static const unsigned proto_table_sz[] = {21, 29, 29, 29, 29, 35, 37, 39};

WARNING:UNSPECIFIED_INT: Prefer 'unsigned int' to bare use of 'unsigned'
#4653: FILE: drivers/common/dpaa2/flib/rta/protocol_cmd.h:590:
+	unsigned i, found = 0;

WARNING:UNSPECIFIED_INT: Prefer 'unsigned int' to bare use of 'unsigned'
#4655: FILE: drivers/common/dpaa2/flib/rta/protocol_cmd.h:592:
+	unsigned start_pc = program->current_pc;

WARNING:UNSPECIFIED_INT: Prefer 'unsigned int' to bare use of 'unsigned'
#4702: FILE: drivers/common/dpaa2/flib/rta/protocol_cmd.h:639:
+	unsigned start_pc = program->current_pc;

WARNING:UNSPECIFIED_INT: Prefer 'unsigned int' to bare use of 'unsigned'
#4703: FILE: drivers/common/dpaa2/flib/rta/protocol_cmd.h:640:
+	unsigned in_words = 0, out_words = 0;

WARNING:UNSPECIFIED_INT: Prefer 'unsigned int' to bare use of 'unsigned'
#4721: FILE: drivers/common/dpaa2/flib/rta/protocol_cmd.h:658:
+		in_words = (unsigned)((keylen + 3) / 4);

WARNING:BLOCK_COMMENT_STYLE: Block comments use * on subsequent lines
#5030: FILE: drivers/common/dpaa2/flib/rta/sec_run_time_asm.h:281:
+#define COPY		BIT(31) /*command param is pointer (not immediate)
+				  valid only in combination when IMMED */

WARNING:BLOCK_COMMENT_STYLE: Block comments use a trailing */ on a separate line
#5030: FILE: drivers/common/dpaa2/flib/rta/sec_run_time_asm.h:281:
+				  valid only in combination when IMMED */

WARNING:BLOCK_COMMENT_STYLE: Block comments use a trailing */ on a separate line
#5046: FILE: drivers/common/dpaa2/flib/rta/sec_run_time_asm.h:297:
+				 * AES ECB Encryption) */

WARNING:BLOCK_COMMENT_STYLE: Block comments use a trailing */ on a separate line
#5048: FILE: drivers/common/dpaa2/flib/rta/sec_run_time_asm.h:299:
+				 * Job Descriptor Key) */

WARNING:UNSPECIFIED_INT: Prefer 'unsigned int' to bare use of 'unsigned'
#5129: FILE: drivers/common/dpaa2/flib/rta/sec_run_time_asm.h:380:
+	unsigned current_pc;

WARNING:UNSPECIFIED_INT: Prefer 'unsigned int' to bare use of 'unsigned'
#5130: FILE: drivers/common/dpaa2/flib/rta/sec_run_time_asm.h:381:
+	unsigned current_instruction;

WARNING:UNSPECIFIED_INT: Prefer 'unsigned int' to bare use of 'unsigned'
#5131: FILE: drivers/common/dpaa2/flib/rta/sec_run_time_asm.h:382:
+	unsigned first_error_pc;

WARNING:UNSPECIFIED_INT: Prefer 'unsigned int' to bare use of 'unsigned'
#5132: FILE: drivers/common/dpaa2/flib/rta/sec_run_time_asm.h:383:
+	unsigned start_pc;

WARNING:UNSPECIFIED_INT: Prefer 'unsigned int' to bare use of 'unsigned'
#5141: FILE: drivers/common/dpaa2/flib/rta/sec_run_time_asm.h:392:
+					 uint32_t *buffer, unsigned offset)

WARNING:UNSPECIFIED_INT: Prefer 'unsigned int' to bare use of 'unsigned'
#5179: FILE: drivers/common/dpaa2/flib/rta/sec_run_time_asm.h:430:
+static inline unsigned rta_program_set_36bit_addr(struct program *program)

WARNING:UNSPECIFIED_INT: Prefer 'unsigned int' to bare use of 'unsigned'
#5185: FILE: drivers/common/dpaa2/flib/rta/sec_run_time_asm.h:436:
+static inline unsigned rta_program_set_bswap(struct program *program)

WARNING:UNSPECIFIED_INT: Prefer 'unsigned int' to bare use of 'unsigned'
#5238: FILE: drivers/common/dpaa2/flib/rta/sec_run_time_asm.h:489:
+static inline unsigned rta_word(struct program *program, uint32_t val)

WARNING:UNSPECIFIED_INT: Prefer 'unsigned int' to bare use of 'unsigned'
#5240: FILE: drivers/common/dpaa2/flib/rta/sec_run_time_asm.h:491:
+	unsigned start_pc = program->current_pc;

WARNING:UNSPECIFIED_INT: Prefer 'unsigned int' to bare use of 'unsigned'
#5247: FILE: drivers/common/dpaa2/flib/rta/sec_run_time_asm.h:498:
+static inline unsigned rta_dword(struct program *program, uint64_t val)

WARNING:UNSPECIFIED_INT: Prefer 'unsigned int' to bare use of 'unsigned'
#5249: FILE: drivers/common/dpaa2/flib/rta/sec_run_time_asm.h:500:
+	unsigned start_pc = program->current_pc;

WARNING:UNSPECIFIED_INT: Prefer 'unsigned int' to bare use of 'unsigned'
#5272: FILE: drivers/common/dpaa2/flib/rta/sec_run_time_asm.h:523:
+static inline unsigned rta_copy_data(struct program *program, uint8_t *data,

WARNING:UNSPECIFIED_INT: Prefer 'unsigned int' to bare use of 'unsigned'
#5273: FILE: drivers/common/dpaa2/flib/rta/sec_run_time_asm.h:524:
+				     unsigned length)

WARNING:UNSPECIFIED_INT: Prefer 'unsigned int' to bare use of 'unsigned'
#5275: FILE: drivers/common/dpaa2/flib/rta/sec_run_time_asm.h:526:
+	unsigned i;

WARNING:UNSPECIFIED_INT: Prefer 'unsigned int' to bare use of 'unsigned'
#5276: FILE: drivers/common/dpaa2/flib/rta/sec_run_time_asm.h:527:
+	unsigned start_pc = program->current_pc;

WARNING:UNSPECIFIED_INT: Prefer 'unsigned int' to bare use of 'unsigned'
#5315: FILE: drivers/common/dpaa2/flib/rta/sec_run_time_asm.h:566:
+static inline unsigned rta_desc_len(uint32_t *buffer)

WARNING:UNSPECIFIED_INT: Prefer 'unsigned int' to bare use of 'unsigned'
#5323: FILE: drivers/common/dpaa2/flib/rta/sec_run_time_asm.h:574:
+static inline unsigned rta_desc_bytes(uint32_t *buffer)

WARNING:UNSPECIFIED_INT: Prefer 'unsigned int' to bare use of 'unsigned'
#5325: FILE: drivers/common/dpaa2/flib/rta/sec_run_time_asm.h:576:
+	return (unsigned)(rta_desc_len(buffer) * CAAM_CMD_SZ);

WARNING:UNSPECIFIED_INT: Prefer 'unsigned int' to bare use of 'unsigned'
#5358: FILE: drivers/common/dpaa2/flib/rta/sec_run_time_asm.h:609:
+static inline unsigned rta_set_label(struct program *program)

WARNING:UNSPECIFIED_INT: Prefer 'unsigned int' to bare use of 'unsigned'
#5364: FILE: drivers/common/dpaa2/flib/rta/sec_run_time_asm.h:615:
+				 unsigned new_ref)

WARNING:UNSPECIFIED_INT: Prefer 'unsigned int' to bare use of 'unsigned'
#5382: FILE: drivers/common/dpaa2/flib/rta/sec_run_time_asm.h:633:
+				unsigned new_ref)

WARNING:UNSPECIFIED_INT: Prefer 'unsigned int' to bare use of 'unsigned'
#5400: FILE: drivers/common/dpaa2/flib/rta/sec_run_time_asm.h:651:
+				   unsigned new_ref)

WARNING:UNSPECIFIED_INT: Prefer 'unsigned int' to bare use of 'unsigned'
#5418: FILE: drivers/common/dpaa2/flib/rta/sec_run_time_asm.h:669:
+				 unsigned new_ref)

WARNING:UNSPECIFIED_INT: Prefer 'unsigned int' to bare use of 'unsigned'
#5441: FILE: drivers/common/dpaa2/flib/rta/sec_run_time_asm.h:692:
+				  unsigned new_ref)

WARNING:UNSPECIFIED_INT: Prefer 'unsigned int' to bare use of 'unsigned'
#5472: FILE: drivers/common/dpaa2/flib/rta/sec_run_time_asm.h:723:
+				unsigned mask, unsigned new_val)

WARNING:UNSPECIFIED_INT: Prefer 'unsigned int' to bare use of 'unsigned'
#5472: FILE: drivers/common/dpaa2/flib/rta/sec_run_time_asm.h:723:
+				unsigned mask, unsigned new_val)

WARNING:UNSPECIFIED_INT: Prefer 'unsigned int' to bare use of 'unsigned'
#5491: FILE: drivers/common/dpaa2/flib/rta/sec_run_time_asm.h:742:
+				  unsigned num_of_entries, uint32_t *val)

WARNING:UNSPECIFIED_INT: Prefer 'unsigned int' to bare use of 'unsigned'
#5493: FILE: drivers/common/dpaa2/flib/rta/sec_run_time_asm.h:744:
+	unsigned i;

WARNING:UNSPECIFIED_INT: Prefer 'unsigned int' to bare use of 'unsigned'
#5506: FILE: drivers/common/dpaa2/flib/rta/sec_run_time_asm.h:757:
+				   unsigned num_of_entries, uint32_t *opcode)

WARNING:UNSPECIFIED_INT: Prefer 'unsigned int' to bare use of 'unsigned'
#5508: FILE: drivers/common/dpaa2/flib/rta/sec_run_time_asm.h:759:
+	unsigned i;

WARNING:UNSPECIFIED_INT: Prefer 'unsigned int' to bare use of 'unsigned'
#5562: FILE: drivers/common/dpaa2/flib/rta/seq_in_out_ptr_cmd.h:40:
+	unsigned start_pc = program->current_pc;

WARNING:UNSPECIFIED_INT: Prefer 'unsigned int' to bare use of 'unsigned'
#5637: FILE: drivers/common/dpaa2/flib/rta/seq_in_out_ptr_cmd.h:115:
+	unsigned start_pc = program->current_pc;

WARNING:UNSPECIFIED_INT: Prefer 'unsigned int' to bare use of 'unsigned'
#5713: FILE: drivers/common/dpaa2/flib/rta/signature_cmd.h:13:
+	unsigned start_pc = program->current_pc;

WARNING:UNSPECIFIED_INT: Prefer 'unsigned int' to bare use of 'unsigned'
#5803: FILE: drivers/common/dpaa2/flib/rta/store_cmd.h:57:
+static const unsigned store_src_table_sz[] = {29, 31, 33, 33, 33, 33, 35, 35};

WARNING:UNSPECIFIED_INT: Prefer 'unsigned int' to bare use of 'unsigned'
#5811: FILE: drivers/common/dpaa2/flib/rta/store_cmd.h:65:
+	unsigned start_pc = program->current_pc;

total: 2 errors, 81 warnings, 5617 lines checked
Previous message: [dpdk-test-report] |SUCCESS| pw17589 [PATCH, 1/3] mk: fix build of assembly files for ARM64
Next message: [dpdk-test-report] |SUCCESS| [PATCH 3/8] doc: Adding NXP DPAA2_SEC in cryptodev
Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]
More information about the test-report mailing list