[dpdk-test-report] [PatchWork]|ERROR| pw13962-13988 net/thunderx/base: add HW constants

[sys_stv at intel.com]

Test-Label: Intel Niantic on Fedora
Test-Status: ERROR

Patchwork ID: 13962-13988
http://www.dpdk.org/dev/patchwork/patch/13988/
Submitter: Jerin Jacob <jerin.jacob at caviumnetworks.com>
Date: Fri, 17 Jun 2016 18:59:28 +0530
DPDK git baseline: 1e9e0a6270c8ab1c81008927e8577e6a0629965f

Check patch error:
13980: 
WARNING: networking block comments don't use an empty /* line, use /* Comment...
#83: FILE: drivers/net/thunderx/nicvf_rxtx.c:2:
+/*
+ *   BSD LICENSE

ERROR: return is not a function, parentheses are not required
#221: FILE: drivers/net/thunderx/nicvf_rxtx.c:140:
+	return ((sq->head - sq->tail - 1) & sq->qlen_mask);

WARNING: networking block comments don't use an empty /* line, use /* Comment...
#344: FILE: drivers/net/thunderx/nicvf_rxtx.h:2:
+/*
+ *   BSD LICENSE

total: 1 errors, 2 warnings, 377 lines checked

/home/patchWorkOrg/patches/dpdk-dev-v6-19-27-net-thunderx-add-single-and-multi-segment-Tx-functions.patch has style problems, please review.

If any of these errors are false positives, please report them to the maintainer, see CHECKPATCH in MAINTAINERS.

13963: 
WARNING: do not add new typedefs
#42: FILE: drivers/net/thunderx/base/nicvf_hw_defs.h:553:
+typedef union {

WARNING: do not add new typedefs
#87: FILE: drivers/net/thunderx/base/nicvf_hw_defs.h:598:
+typedef union {

WARNING: do not add new typedefs
#112: FILE: drivers/net/thunderx/base/nicvf_hw_defs.h:623:
+typedef union {

WARNING: do not add new typedefs
#129: FILE: drivers/net/thunderx/base/nicvf_hw_defs.h:640:
+typedef union {

WARNING: do not add new typedefs
#146: FILE: drivers/net/thunderx/base/nicvf_hw_defs.h:657:
+typedef union {

WARNING: do not add new typedefs
#163: FILE: drivers/net/thunderx/base/nicvf_hw_defs.h:674:
+typedef union {

WARNING: do not add new typedefs
#180: FILE: drivers/net/thunderx/base/nicvf_hw_defs.h:691:
+typedef union {

ERROR: spaces prohibited around that ':' (ctx:VxW)
#617: FILE: drivers/net/thunderx/base/nicvf_hw_defs.h:1128:
+	uint64_t ena: 1;
	            ^

total: 1 errors, 7 warnings, 672 lines checked

/home/patchWorkOrg/patches/dpdk-dev-v6-02-27-net-thunderx-base-add-HW-register-definitions.patch has style problems, please review.

If any of these errors are false positives, please report them to the maintainer, see CHECKPATCH in MAINTAINERS.

13964: 
WARNING: networking block comments don't use an empty /* line, use /* Comment...
#41: FILE: drivers/net/thunderx/base/nicvf_plat.h:2:
+/*
+ *   BSD LICENSE

ERROR: space prohibited before open square bracket '['
#122: FILE: drivers/net/thunderx/base/nicvf_plat.h:83:
+		    : [val] "r" (val), [addr] "r" (addr));

ERROR: space prohibited before open square bracket '['
#132: FILE: drivers/net/thunderx/base/nicvf_plat.h:93:
+		    : [val] "=r" (val)

ERROR: space prohibited before open square bracket '['
#133: FILE: drivers/net/thunderx/base/nicvf_plat.h:94:
+		    : [addr] "r" (addr));

ERROR: space prohibited before open square bracket '['
#140: FILE: drivers/net/thunderx/base/nicvf_plat.h:101:
+			: [x1]"=r"(reg1), [x0]"=r"(reg2)
ERROR: space prohibited before open square bracket '['
#141: FILE: drivers/net/thunderx/base/nicvf_plat.h:102:
+			: [p1]"r"(addr)			
WARNING: Use of volatile is usually wrong: see Documentation/volatile-considered-harmful.txt
#151: FILE: drivers/net/thunderx/base/nicvf_plat.h:112:
+	*(volatile uint64_t *)addr = val;

WARNING: Use of volatile is usually wrong: see Documentation/volatile-considered-harmful.txt
#157: FILE: drivers/net/thunderx/base/nicvf_plat.h:118:
+	return	*(volatile uint64_t *)addr;

total: 5 errors, 3 warnings, 129 lines checked

/home/patchWorkOrg/patches/dpdk-dev-v6-03-27-net-thunderx-base-implement-DPDK-based-platform-abstraction.patch has style problems, please review.

If any of these errors are false positives, please report them to the maintainer, see CHECKPATCH in MAINTAINERS.

13966: 
WARNING: networking block comments don't use an empty /* line, use /* Comment...
#43: FILE: drivers/net/thunderx/base/nicvf_hw.c:2:
+/*
+ *   BSD LICENSE

ERROR: return is not a function, parentheses are not required
#312: FILE: drivers/net/thunderx/base/nicvf_hw.c:271:
+	return (*(const uint32_t *)a - *(const uint32_t *)b);

WARNING: networking block comments don't use an empty /* line, use /* Comment...
#386: FILE: drivers/net/thunderx/base/nicvf_hw.c:345:
+/*
+ * Handle poll mode driver interested "mbox" and "queue-set error" interrupts.

WARNING: networking block comments don't use an empty /* line, use /* Comment...
#780: FILE: drivers/net/thunderx/base/nicvf_hw.h:2:
+/*
+ *   BSD LICENSE

total: 1 errors, 3 warnings, 914 lines checked

/home/patchWorkOrg/patches/dpdk-dev-v6-05-27-net-thunderx-base-add-hardware-API.patch has style problems, please review.

If any of these errors are false positives, please report them to the maintainer, see CHECKPATCH in MAINTAINERS.


Compilation:
OS: fedora
Nic: niantic
GCC: gcc_x86-64, 4.8.3
ICC:16.0.2
i686-native-linuxapp-icc: compile pass
x86_64-native-linuxapp-gcc-combined: compile pass
i686-native-linuxapp-gcc: compile pass
x86_64-native-linuxapp-gcc: compile pass
x86_64-native-linuxapp-icc: compile pass
x86_64-native-linuxapp-gcc-debug: compile pass
x86_64-native-linuxapp-gcc-shared: compile pass
x86_64-native-linuxapp-clang: compile pass



DPDK STV team