[dpdk-test-report] |WARNING| [PATCH 13/56] net/sfc: import libefx built-in selftest support

checkpatch at dpdk.org checkpatch at dpdk.org
Mon Nov 21 16:02:42 CET 2016


Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/17113

_coding style issues_


CHECK:CAMELCASE: Avoid CamelCase: <__checkReturn>
#90: FILE: drivers/net/sfc/efx/base/ef10_impl.h:350:
+extern	__checkReturn		efx_rc_t

ERROR:ASSIGN_IN_IF: do not use assignment in if condition
#136: FILE: drivers/net/sfc/efx/base/ef10_phy.c:401:
+	if ((rc = efx_mcdi_bist_enable_offline(enp)) != 0)

ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#139: FILE: drivers/net/sfc/efx/base/ef10_phy.c:404:
+	return (0);

ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#144: FILE: drivers/net/sfc/efx/base/ef10_phy.c:409:
+	return (rc);

ERROR:ASSIGN_IN_IF: do not use assignment in if condition
#154: FILE: drivers/net/sfc/efx/base/ef10_phy.c:419:
+	if ((rc = efx_mcdi_bist_start(enp, type)) != 0)

ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#157: FILE: drivers/net/sfc/efx/base/ef10_phy.c:422:
+	return (0);

ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#162: FILE: drivers/net/sfc/efx/base/ef10_phy.c:427:
+	return (rc);

CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around enp->en_nic_cfg
#176: FILE: drivers/net/sfc/efx/base/ef10_phy.c:441:
+	efx_nic_cfg_t *encp = &(enp->en_nic_cfg);

CHECK:SPACING: No space is necessary after a cast
#186: FILE: drivers/net/sfc/efx/base/ef10_phy.c:451:
+	(void) memset(payload, 0, sizeof (payload));

WARNING:SPACING: space prohibited between function name and open parenthesis '('
#186: FILE: drivers/net/sfc/efx/base/ef10_phy.c:451:
+	(void) memset(payload, 0, sizeof (payload));

CHECK:SPACING: No space is necessary after a cast
#206: FILE: drivers/net/sfc/efx/base/ef10_phy.c:471:
+		(void) memset(valuesp, '


More information about the test-report mailing list