[dpdk-test-report] |WARNING| [PATCH 32/56] net/sfc: implement driver operation to init device on attach

checkpatch at dpdk.org checkpatch at dpdk.org
Mon Nov 21 16:09:12 CET 2016


Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/17126

_coding style issues_


WARNING:USE_NEGATIVE_ERRNO: return of an errno should typically be negative (ie: return -ENOMEM)
#157: FILE: drivers/net/sfc/efx/sfc.c:56:
+		return ENOMEM;

WARNING:USE_NEGATIVE_ERRNO: return of an errno should typically be negative (ie: return -EFAULT)
#163: FILE: drivers/net/sfc/efx/sfc.c:62:
+		return EFAULT;

WARNING:USE_NEGATIVE_ERRNO: return of an errno should typically be negative (ie: return -EFAULT)
#207: FILE: drivers/net/sfc/efx/sfc.c:106:
+	return EFAULT;

CHECK:CAMELCASE: Avoid CamelCase: <PRIu8>
#466: FILE: drivers/net/sfc/efx/sfc_debug.h:51:
+		rte_panic("sfc " PCI_PRI_FMT " #%" PRIu8 ": " fmt "
",	\

WARNING:CONSTANT_COMPARISON: Comparisons should place the constant on the right side of the test
#663: FILE: drivers/net/sfc/efx/sfc_mcdi.c:79:
+		RTE_BUILD_BUG_ON(SFC_MCDI_POLL_INTERVAL_MAX_US > UINT_MAX / 2);

total: 0 errors, 4 warnings, 1 checks, 663 lines checked


More information about the test-report mailing list