[dpdk-test-report] |WARNING| [PATCH 18/56] net/sfc: import libefx MAC statistics support

checkpatch at dpdk.org checkpatch at dpdk.org
Mon Nov 21 16:10:59 CET 2016
Previous message: [dpdk-test-report] |SUCCESS| [PATCH 31/56] net/sfc: implement dummy callback to get device information
Next message: [dpdk-test-report] |SUCCESS| [PATCH 35/56] net/sfc: implement device start and stop operations
Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]
Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/17130

_coding style issues_


CHECK:CAMELCASE: Avoid CamelCase: <__checkReturn>
#115: FILE: drivers/net/sfc/efx/base/ef10_impl.h:264:
+extern	__checkReturn			efx_rc_t

CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around enp->en_nic_cfg
#158: FILE: drivers/net/sfc/efx/base/ef10_mac.c:463:
+	efx_nic_cfg_t *encp = &(enp->en_nic_cfg);

CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around enp->en_port
#159: FILE: drivers/net/sfc/efx/base/ef10_mac.c:464:
+	efx_port_t *epp = &(enp->en_port);

ERROR:ASSIGN_IN_IF: do not use assignment in if condition
#162: FILE: drivers/net/sfc/efx/base/ef10_mac.c:467:
+	if ((rc = efx_mac_stats_mask_add_ranges(maskp, mask_size,

ERROR:ASSIGN_IN_IF: do not use assignment in if condition
#171: FILE: drivers/net/sfc/efx/base/ef10_mac.c:476:
+		if ((rc = efx_mac_stats_mask_add_ranges(maskp, mask_size,

ERROR:ASSIGN_IN_IF: do not use assignment in if condition
#176: FILE: drivers/net/sfc/efx/base/ef10_mac.c:481:
+			if ((rc = efx_mac_stats_mask_add_ranges(maskp,

ERROR:ASSIGN_IN_IF: do not use assignment in if condition
#182: FILE: drivers/net/sfc/efx/base/ef10_mac.c:487:
+		if ((rc = efx_mac_stats_mask_add_ranges(maskp, mask_size,

ERROR:ASSIGN_IN_IF: do not use assignment in if condition
#192: FILE: drivers/net/sfc/efx/base/ef10_mac.c:497:
+		if ((rc = efx_mac_stats_mask_add_ranges(maskp, mask_size,

ERROR:ASSIGN_IN_IF: do not use assignment in if condition
#203: FILE: drivers/net/sfc/efx/base/ef10_mac.c:508:
+		if ((rc = efx_mac_stats_mask_add_ranges(maskp, mask_size,

ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#208: FILE: drivers/net/sfc/efx/base/ef10_mac.c:513:
+	return (0);

ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#223: FILE: drivers/net/sfc/efx/base/ef10_mac.c:528:
+	return (rc);

WARNING:SPACING: space prohibited between function name and open parenthesis '('
#227: FILE: drivers/net/sfc/efx/base/ef10_mac.c:532:
+	EFSYS_MEM_READQ((_esmp), (_field) * sizeof (efx_qword_t), _eqp)

CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around stat[EFX_MAC_TX_PKTS]
#251: FILE: drivers/net/sfc/efx/base/ef10_mac.c:556:
+	EFSYS_STAT_SET_QWORD(&(stat[EFX_MAC_TX_PKTS]), &value);

CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around stat[EFX_MAC_TX_PKTS]
#254: FILE: drivers/net/sfc/efx/base/ef10_mac.c:559:
+	EFSYS_STAT_SUBR_QWORD(&(stat[EFX_MAC_TX_PKTS]), &value);

CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around stat[EFX_MAC_TX_PAUSE_PKTS]
#257: FILE: drivers/net/sfc/efx/base/ef10_mac.c:562:
+	EFSYS_STAT_SET_QWORD(&(stat[EFX_MAC_TX_PAUSE_PKTS]), &value);

CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around stat[EFX_MAC_TX_UNICST_PKTS]
#260: FILE: drivers/net/sfc/efx/base/ef10_mac.c:565:
+	EFSYS_STAT_SET_QWORD(&(stat[EFX_MAC_TX_UNICST_PKTS]), &value);

CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around stat[EFX_MAC_TX_MULTICST_PKTS]
#263: FILE: drivers/net/sfc/efx/base/ef10_mac.c:568:
+	EFSYS_STAT_SET_QWORD(&(stat[EFX_MAC_TX_MULTICST_PKTS]), &value);

CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around stat[EFX_MAC_TX_BRDCST_PKTS]
#266: FILE: drivers/net/sfc/efx/base/ef10_mac.c:571:
+	EFSYS_STAT_SET_QWORD(&(stat[EFX_MAC_TX_BRDCST_PKTS]), &value);

CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around stat[EFX_MAC_TX_OCTETS]
#269: FILE: drivers/net/sfc/efx/base/ef10_mac.c:574:
+	EFSYS_STAT_SET_QWORD(&(stat[EFX_MAC_TX_OCTETS]), &value);

CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around stat[EFX_MAC_TX_LE_64_PKTS]
#272: FILE: drivers/net/sfc/efx/base/ef10_mac.c:577:
+	EFSYS_STAT_SET_QWORD(&(stat[EFX_MAC_TX_LE_64_PKTS]), &value);

CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around stat[EFX_MAC_TX_LE_64_PKTS]
#274: FILE: drivers/net/sfc/efx/base/ef10_mac.c:579:
+	EFSYS_STAT_SET_QWORD(&(stat[EFX_MAC_TX_LE_64_PKTS]), &value);

CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around stat[EFX_MAC_TX_65_TO_127_PKTS]
#277: FILE: drivers/net/sfc/efx/base/ef10_mac.c:582:
+	EFSYS_STAT_SET_QWORD(&(stat[EFX_MAC_TX_65_TO_127_PKTS]), &value);

CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around stat[EFX_MAC_TX_128_TO_255_PKTS]
#280: FILE: drivers/net/sfc/efx/base/ef10_mac.c:585:
+	EFSYS_STAT_SET_QWORD(&(stat[EFX_MAC_TX_128_TO_255_PKTS]), &value);

CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around stat[EFX_MAC_TX_256_TO_511_PKTS]
#283: FILE: drivers/net/sfc/efx/base/ef10_mac.c:588:
+	EFSYS_STAT_SET_QWORD(&(stat[EFX_MAC_TX_256_TO_511_PKTS]), &value);

CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around stat[EFX_MAC_TX_512_TO_1023_PKTS]
#286: FILE: drivers/net/sfc/efx/base/ef10_mac.c:591:
+	EFSYS_STAT_SET_QWORD(&(stat[EFX_MAC_TX_512_TO_1023_PKTS]), &value);

CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around stat[EFX_MAC_TX_1024_TO_15XX_PKTS]
#289: FILE: drivers/net/sfc/efx/base/ef10_mac.c:594:
+	EFSYS_STAT_SET_QWORD(&(stat[EFX_MAC_TX_1024_TO_15XX_PKTS]), &value);

CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around stat[EFX_MAC_TX_GE_15XX_PKTS]
#292: FILE: drivers/net/sfc/efx/base/ef10_mac.c:597:
+	EFSYS_STAT_SET_QWORD(&(stat[EFX_MAC_TX_GE_15XX_PKTS]), &value);

CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around stat[EFX_MAC_TX_GE_15XX_PKTS]
#294: FILE: drivers/net/sfc/efx/base/ef10_mac.c:599:
+	EFSYS_STAT_INCR_QWORD(&(stat[EFX_MAC_TX_GE_15XX_PKTS]), &value);

CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around stat[EFX_MAC_TX_ERRORS]
#297: FILE: drivers/net/sfc/efx/base/ef10_mac.c:602:
+	EFSYS_STAT_SET_QWORD(&(stat[EFX_MAC_TX_ERRORS]), &value);

CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around stat[EFX_MAC_TX_SGL_COL_PKTS]
#300: FILE: drivers/net/sfc/efx/base/ef10_mac.c:605:
+	EFSYS_STAT_SET_QWORD(&(stat[EFX_MAC_TX_SGL_COL_PKTS]), &value);

CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around stat[EFX_MAC_TX_MULT_COL_PKTS]
#304: FILE: drivers/net/sfc/efx/base/ef10_mac.c:609:
+	EFSYS_STAT_SET_QWORD(&(stat[EFX_MAC_TX_MULT_COL_PKTS]), &value);

CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around stat[EFX_MAC_TX_EX_COL_PKTS]
#308: FILE: drivers/net/sfc/efx/base/ef10_mac.c:613:
+	EFSYS_STAT_SET_QWORD(&(stat[EFX_MAC_TX_EX_COL_PKTS]), &value);

CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around stat[EFX_MAC_TX_LATE_COL_PKTS]
#311: FILE: drivers/net/sfc/efx/base/ef10_mac.c:616:
+	EFSYS_STAT_SET_QWORD(&(stat[EFX_MAC_TX_LATE_COL_PKTS]), &value);

CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around stat[EFX_MAC_TX_DEF_PKTS]
#314: FILE: drivers/net/sfc/efx/base/ef10_mac.c:619:
+	EFSYS_STAT_SET_QWORD(&(stat[EFX_MAC_TX_DEF_PKTS]), &value);

CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around stat[EFX_MAC_TX_EX_DEF_PKTS]
#318: FILE: drivers/net/sfc/efx/base/ef10_mac.c:623:
+	EFSYS_STAT_SET_QWORD(&(stat[EFX_MAC_TX_EX_DEF_PKTS]), &value);

CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around stat[EFX_MAC_RX_OCTETS]
#322: FILE: drivers/net/sfc/efx/base/ef10_mac.c:627:
+	EFSYS_STAT_SET_QWORD(&(stat[EFX_MAC_RX_OCTETS]), &value);

CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around stat[EFX_MAC_RX_PKTS]
#325: FILE: drivers/net/sfc/efx/base/ef10_mac.c:630:
+	EFSYS_STAT_SET_QWORD(&(stat[EFX_MAC_RX_PKTS]), &value);

CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around stat[EFX_MAC_RX_UNICST_PKTS]
#328: FILE: drivers/net/sfc/efx/base/ef10_mac.c:633:
+	EFSYS_STAT_SET_QWORD(&(stat[EFX_MAC_RX_UNICST_PKTS]), &value);

CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around stat[EFX_MAC_RX_MULTICST_PKTS]
#331: FILE: drivers/net/sfc/efx/base/ef10_mac.c:636:
+	EFSYS_STAT_SET_QWORD(&(stat[EFX_MAC_RX_MULTICST_PKTS]), &value);

CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around stat[EFX_MAC_RX_BRDCST_PKTS]
#334: FILE: drivers/net/sfc/efx/base/ef10_mac.c:639:
+	EFSYS_STAT_SET_QWORD(&(stat[EFX_MAC_RX_BRDCST_PKTS]), &value);

CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around stat[EFX_MAC_RX_PAUSE_PKTS]
#337: FILE: drivers/net/sfc/efx/base/ef10_mac.c:642:
+	EFSYS_STAT_SET_QWORD(&(stat[EFX_MAC_RX_PAUSE_PKTS]), &value);

CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around stat[EFX_MAC_RX_LE_64_PKTS]
#340: FILE: drivers/net/sfc/efx/base/ef10_mac.c:645:
+	EFSYS_STAT_SET_QWORD(&(stat[EFX_MAC_RX_LE_64_PKTS]), &value);

CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around stat[EFX_MAC_RX_LE_64_PKTS]
#342: FILE: drivers/net/sfc/efx/base/ef10_mac.c:647:
+	EFSYS_STAT_INCR_QWORD(&(stat[EFX_MAC_RX_LE_64_PKTS]), &value);

CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around stat[EFX_MAC_RX_65_TO_127_PKTS]
#345: FILE: drivers/net/sfc/efx/base/ef10_mac.c:650:
+	EFSYS_STAT_SET_QWORD(&(stat[EFX_MAC_RX_65_TO_127_PKTS]), &value);

CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around stat[EFX_MAC_RX_128_TO_255_PKTS]
#348: FILE: drivers/net/sfc/efx/base/ef10_mac.c:653:
+	EFSYS_STAT_SET_QWORD(&(stat[EFX_MAC_RX_128_TO_255_PKTS]), &value);

CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around stat[EFX_MAC_RX_256_TO_511_PKTS]
#351: FILE: drivers/net/sfc/efx/base/ef10_mac.c:656:
+	EFSYS_STAT_SET_QWORD(&(stat[EFX_MAC_RX_256_TO_511_PKTS]), &value);

CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around stat[EFX_MAC_RX_512_TO_1023_PKTS]
#354: FILE: drivers/net/sfc/efx/base/ef10_mac.c:659:
+	EFSYS_STAT_SET_QWORD(&(stat[EFX_MAC_RX_512_TO_1023_PKTS]), &value);

CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around stat[EFX_MAC_RX_1024_TO_15XX_PKTS]
#357: FILE: drivers/net/sfc/efx/base/ef10_mac.c:662:
+	EFSYS_STAT_SET_QWORD(&(stat[EFX_MAC_RX_1024_TO_15XX_PKTS]), &value);

CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around stat[EFX_MAC_RX_GE_15XX_PKTS]
#360: FILE: drivers/net/sfc/efx/base/ef10_mac.c:665:
+	EFSYS_STAT_SET_QWORD(&(stat[EFX_MAC_RX_GE_15XX_PKTS]), &value);

CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around stat[EFX_MAC_RX_GE_15XX_PKTS]
#362: FILE: drivers/net/sfc/efx/base/ef10_mac.c:667:
+	EFSYS_STAT_INCR_QWORD(&(stat[EFX_MAC_RX_GE_15XX_PKTS]), &value);

CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around stat[EFX_MAC_RX_FCS_ERRORS]
#365: FILE: drivers/net/sfc/efx/base/ef10_mac.c:670:
+	EFSYS_STAT_SET_QWORD(&(stat[EFX_MAC_RX_FCS_ERRORS]), &value);

CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around stat[EFX_MAC_RX_DROP_EVENTS]
#368: FILE: drivers/net/sfc/efx/base/ef10_mac.c:673:
+	EFSYS_STAT_SET_QWORD(&(stat[EFX_MAC_RX_DROP_EVENTS]), &value);

CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around stat[EFX_MAC_RX_FALSE_CARRIER_ERRORS]
#371: FILE: drivers/net/sfc/efx/base/ef10_mac.c:676:
+	EFSYS_STAT_SET_QWORD(&(stat[EFX_MAC_RX_FALSE_CARRIER_ERRORS]), &value);

CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around stat[EFX_MAC_RX_SYMBOL_ERRORS]
#374: FILE: drivers/net/sfc/efx/base/ef10_mac.c:679:
+	EFSYS_STAT_SET_QWORD(&(stat[EFX_MAC_RX_SYMBOL_ERRORS]), &value);

CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around stat[EFX_MAC_RX_ALIGN_ERRORS]
#377: FILE: drivers/net/sfc/efx/base/ef10_mac.c:682:
+	EFSYS_STAT_SET_QWORD(&(stat[EFX_MAC_RX_ALIGN_ERRORS]), &value);

CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around stat[EFX_MAC_RX_INTERNAL_ERRORS]
#380: FILE: drivers/net/sfc/efx/base/ef10_mac.c:685:
+	EFSYS_STAT_SET_QWORD(&(stat[EFX_MAC_RX_INTERNAL_ERRORS]), &value);

CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around stat[EFX_MAC_RX_JABBER_PKTS]
#383: FILE: drivers/net/sfc/efx/base/ef10_mac.c:688:
+	EFSYS_STAT_SET_QWORD(&(stat[EFX_MAC_RX_JABBER_PKTS]), &value);

CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around stat[EFX_MAC_RX_LANE0_CHAR_ERR]
#386: FILE: drivers/net/sfc/efx/base/ef10_mac.c:691:
+	EFSYS_STAT_SET_DWORD(&(stat[EFX_MAC_RX_LANE0_CHAR_ERR]),

CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around value.eq_dword[0]
#387: FILE: drivers/net/sfc/efx/base/ef10_mac.c:692:
+			    &(value.eq_dword[0]));

CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around stat[EFX_MAC_RX_LANE1_CHAR_ERR]
#388: FILE: drivers/net/sfc/efx/base/ef10_mac.c:693:
+	EFSYS_STAT_SET_DWORD(&(stat[EFX_MAC_RX_LANE1_CHAR_ERR]),

CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around value.eq_dword[1]
#389: FILE: drivers/net/sfc/efx/base/ef10_mac.c:694:
+			    &(value.eq_dword[1]));

CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around stat[EFX_MAC_RX_LANE2_CHAR_ERR]
#392: FILE: drivers/net/sfc/efx/base/ef10_mac.c:697:
+	EFSYS_STAT_SET_DWORD(&(stat[EFX_MAC_RX_LANE2_CHAR_ERR]),

CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around value.eq_dword[0]
#393: FILE: drivers/net/sfc/efx/base/ef10_mac.c:698:
+			    &(value.eq_dword[0]));

CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around stat[EFX_MAC_RX_LANE3_CHAR_ERR]
#394: FILE: drivers/net/sfc/efx/base/ef10_mac.c:699:
+	EFSYS_STAT_SET_DWORD(&(stat[EFX_MAC_RX_LANE3_CHAR_ERR]),

CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around value.eq_dword[1]
#395: FILE: drivers/net/sfc/efx/base/ef10_mac.c:700:
+			    &(value.eq_dword[1]));

CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around stat[EFX_MAC_RX_LANE0_DISP_ERR]
#398: FILE: drivers/net/sfc/efx/base/ef10_mac.c:703:
+	EFSYS_STAT_SET_DWORD(&(stat[EFX_MAC_RX_LANE0_DISP_ERR]),

CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around value.eq_dword[0]
#399: FILE: drivers/net/sfc/efx/base/ef10_mac.c:704:
+			    &(value.eq_dword[0]));

CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around stat[EFX_MAC_RX_LANE1_DISP_ERR]
#400: FILE: drivers/net/sfc/efx/base/ef10_mac.c:705:
+	EFSYS_STAT_SET_DWORD(&(stat[EFX_MAC_RX_LANE1_DISP_ERR]),

CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around value.eq_dword[1]
#401: FILE: drivers/net/sfc/efx/base/ef10_mac.c:706:
+			    &(value.eq_dword[1]));

CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around stat[EFX_MAC_RX_LANE2_DISP_ERR]
#404: FILE: drivers/net/sfc/efx/base/ef10_mac.c:709:
+	EFSYS_STAT_SET_DWORD(&(stat[EFX_MAC_RX_LANE2_DISP_ERR]),

CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around value.eq_dword[0]
#405: FILE: drivers/net/sfc/efx/base/ef10_mac.c:710:
+			    &(value.eq_dword[0]));

CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around stat[EFX_MAC_RX_LANE3_DISP_ERR]
#406: FILE: drivers/net/sfc/efx/base/ef10_mac.c:711:
+	EFSYS_STAT_SET_DWORD(&(stat[EFX_MAC_RX_LANE3_DISP_ERR]),

CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around value.eq_dword[1]
#407: FILE: drivers/net/sfc/efx/base/ef10_mac.c:712:
+			    &(value.eq_dword[1]));

CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around stat[EFX_MAC_RX_MATCH_FAULT]
#410: FILE: drivers/net/sfc/efx/base/ef10_mac.c:715:
+	EFSYS_STAT_SET_QWORD(&(stat[EFX_MAC_RX_MATCH_FAULT]), &value);

CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around stat[EFX_MAC_RX_NODESC_DROP_CNT]
#413: FILE: drivers/net/sfc/efx/base/ef10_mac.c:718:
+	EFSYS_STAT_SET_QWORD(&(stat[EFX_MAC_RX_NODESC_DROP_CNT]), &value);

CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around stat[EFX_MAC_PM_TRUNC_BB_OVERFLOW]
#417: FILE: drivers/net/sfc/efx/base/ef10_mac.c:722:
+	EFSYS_STAT_SET_QWORD(&(stat[EFX_MAC_PM_TRUNC_BB_OVERFLOW]), &value);

CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around stat[EFX_MAC_PM_DISCARD_BB_OVERFLOW]
#420: FILE: drivers/net/sfc/efx/base/ef10_mac.c:725:
+	EFSYS_STAT_SET_QWORD(&(stat[EFX_MAC_PM_DISCARD_BB_OVERFLOW]), &value);

CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around stat[EFX_MAC_PM_TRUNC_VFIFO_FULL]
#423: FILE: drivers/net/sfc/efx/base/ef10_mac.c:728:
+	EFSYS_STAT_SET_QWORD(&(stat[EFX_MAC_PM_TRUNC_VFIFO_FULL]), &value);

CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around stat[EFX_MAC_PM_DISCARD_VFIFO_FULL]
#426: FILE: drivers/net/sfc/efx/base/ef10_mac.c:731:
+	EFSYS_STAT_SET_QWORD(&(stat[EFX_MAC_PM_DISCARD_VFIFO_FULL]), &value);

CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around stat[EFX_MAC_PM_TRUNC_QBB]
#429: FILE: drivers/net/sfc/efx/base/ef10_mac.c:734:
+	EFSYS_STAT_SET_QWORD(&(stat[EFX_MAC_PM_TRUNC_QBB]), &value);

CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around stat[EFX_MAC_PM_DISCARD_QBB]
#432: FILE: drivers/net/sfc/efx/base/ef10_mac.c:737:
+	EFSYS_STAT_SET_QWORD(&(stat[EFX_MAC_PM_DISCARD_QBB]), &value);

CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around stat[EFX_MAC_PM_DISCARD_MAPPING]
#435: FILE: drivers/net/sfc/efx/base/ef10_mac.c:740:
+	EFSYS_STAT_SET_QWORD(&(stat[EFX_MAC_PM_DISCARD_MAPPING]), &value);

CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around stat[EFX_MAC_RXDP_Q_DISABLED_PKTS]
#439: FILE: drivers/net/sfc/efx/base/ef10_mac.c:744:
+	EFSYS_STAT_SET_QWORD(&(stat[EFX_MAC_RXDP_Q_DISABLED_PKTS]), &value);

CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around stat[EFX_MAC_RXDP_DI_DROPPED_PKTS]
#442: FILE: drivers/net/sfc/efx/base/ef10_mac.c:747:
+	EFSYS_STAT_SET_QWORD(&(stat[EFX_MAC_RXDP_DI_DROPPED_PKTS]), &value);

CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around stat[EFX_MAC_RXDP_STREAMING_PKTS]
#445: FILE: drivers/net/sfc/efx/base/ef10_mac.c:750:
+	EFSYS_STAT_SET_QWORD(&(stat[EFX_MAC_RXDP_STREAMING_PKTS]), &value);

CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around stat[EFX_MAC_RXDP_HLB_FETCH]
#448: FILE: drivers/net/sfc/efx/base/ef10_mac.c:753:
+	EFSYS_STAT_SET_QWORD(&(stat[EFX_MAC_RXDP_HLB_FETCH]), &value);

CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around stat[EFX_MAC_RXDP_HLB_WAIT]
#451: FILE: drivers/net/sfc/efx/base/ef10_mac.c:756:
+	EFSYS_STAT_SET_QWORD(&(stat[EFX_MAC_RXDP_HLB_WAIT]), &value);

CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around stat[EFX_MAC_VADAPTER_RX_UNICAST_PACKETS]
#457: FILE: drivers/net/sfc/efx/base/ef10_mac.c:762:
+	EFSYS_STAT_SET_QWORD(&(stat[EFX_MAC_VADAPTER_RX_UNICAST_PACKETS]),

CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around stat[EFX_MAC_VADAPTER_RX_UNICAST_BYTES]
#462: FILE: drivers/net/sfc/efx/base/ef10_mac.c:767:
+	EFSYS_STAT_SET_QWORD(&(stat[EFX_MAC_VADAPTER_RX_UNICAST_BYTES]),

CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around stat[EFX_MAC_VADAPTER_RX_MULTICAST_PACKETS]
#467: FILE: drivers/net/sfc/efx/base/ef10_mac.c:772:
+	EFSYS_STAT_SET_QWORD(&(stat[EFX_MAC_VADAPTER_RX_MULTICAST_PACKETS]),

CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around stat[EFX_MAC_VADAPTER_RX_MULTICAST_BYTES]
#472: FILE: drivers/net/sfc/efx/base/ef10_mac.c:777:
+	EFSYS_STAT_SET_QWORD(&(stat[EFX_MAC_VADAPTER_RX_MULTICAST_BYTES]),

CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around stat[EFX_MAC_VADAPTER_RX_BROADCAST_PACKETS]
#477: FILE: drivers/net/sfc/efx/base/ef10_mac.c:782:
+	EFSYS_STAT_SET_QWORD(&(stat[EFX_MAC_VADAPTER_RX_BROADCAST_PACKETS]),

CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around stat[EFX_MAC_VADAPTER_RX_BROADCAST_BYTES]
#482: FILE: drivers/net/sfc/efx/base/ef10_mac.c:787:
+	EFSYS_STAT_SET_QWORD(&(stat[EFX_MAC_VADAPTER_RX_BROADCAST_BYTES]),

CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around stat[EFX_MAC_VADAPTER_RX_BAD_PACKETS]
#487: FILE: drivers/net/sfc/efx/base/ef10_mac.c:792:
+	EFSYS_STAT_SET_QWORD(&(stat[EFX_MAC_VADAPTER_RX_BAD_PACKETS]),

CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around stat[EFX_MAC_VADAPTER_RX_BAD_BYTES]
#491: FILE: drivers/net/sfc/efx/base/ef10_mac.c:796:
+	EFSYS_STAT_SET_QWORD(&(stat[EFX_MAC_VADAPTER_RX_BAD_BYTES]), &value);

CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around stat[EFX_MAC_VADAPTER_RX_OVERFLOW]
#494: FILE: drivers/net/sfc/efx/base/ef10_mac.c:799:
+	EFSYS_STAT_SET_QWORD(&(stat[EFX_MAC_VADAPTER_RX_OVERFLOW]), &value);

CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around stat[EFX_MAC_VADAPTER_TX_UNICAST_PACKETS]
#499: FILE: drivers/net/sfc/efx/base/ef10_mac.c:804:
+	EFSYS_STAT_SET_QWORD(&(stat[EFX_MAC_VADAPTER_TX_UNICAST_PACKETS]),

CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around stat[EFX_MAC_VADAPTER_TX_UNICAST_BYTES]
#504: FILE: drivers/net/sfc/efx/base/ef10_mac.c:809:
+	EFSYS_STAT_SET_QWORD(&(stat[EFX_MAC_VADAPTER_TX_UNICAST_BYTES]),

CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around stat[EFX_MAC_VADAPTER_TX_MULTICAST_PACKETS]
#509: FILE: drivers/net/sfc/efx/base/ef10_mac.c:814:
+	EFSYS_STAT_SET_QWORD(&(stat[EFX_MAC_VADAPTER_TX_MULTICAST_PACKETS]),

CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around stat[EFX_MAC_VADAPTER_TX_MULTICAST_BYTES]
#514: FILE: drivers/net/sfc/efx/base/ef10_mac.c:819:
+	EFSYS_STAT_SET_QWORD(&(stat[EFX_MAC_VADAPTER_TX_MULTICAST_BYTES]),

CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around stat[EFX_MAC_VADAPTER_TX_BROADCAST_PACKETS]
#519: FILE: drivers/net/sfc/efx/base/ef10_mac.c:824:
+	EFSYS_STAT_SET_QWORD(&(stat[EFX_MAC_VADAPTER_TX_BROADCAST_PACKETS]),

CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around stat[EFX_MAC_VADAPTER_TX_BROADCAST_BYTES]
#524: FILE: drivers/net/sfc/efx/base/ef10_mac.c:829:
+	EFSYS_STAT_SET_QWORD(&(stat[EFX_MAC_VADAPTER_TX_BROADCAST_BYTES]),

CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around stat[EFX_MAC_VADAPTER_TX_BAD_PACKETS]
#528: FILE: drivers/net/sfc/efx/base/ef10_mac.c:833:
+	EFSYS_STAT_SET_QWORD(&(stat[EFX_MAC_VADAPTER_TX_BAD_PACKETS]), &value);

CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around stat[EFX_MAC_VADAPTER_TX_BAD_BYTES]
#531: FILE: drivers/net/sfc/efx/base/ef10_mac.c:836:
+	EFSYS_STAT_SET_QWORD(&(stat[EFX_MAC_VADAPTER_TX_BAD_BYTES]), &value);

CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around stat[EFX_MAC_VADAPTER_TX_OVERFLOW]
#534: FILE: drivers/net/sfc/efx/base/ef10_mac.c:839:
+	EFSYS_STAT_SET_QWORD(&(stat[EFX_MAC_VADAPTER_TX_OVERFLOW]), &value);

WARNING:SPACING: space prohibited between function name and open parenthesis '('
#545: FILE: drivers/net/sfc/efx/base/ef10_mac.c:850:
+	    sizeof (generation_start)))

ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#546: FILE: drivers/net/sfc/efx/base/ef10_mac.c:851:
+		return (EAGAIN);

WARNING:USE_NEGATIVE_ERRNO: return of an errno should typically be negative (ie: return -EAGAIN)
#546: FILE: drivers/net/sfc/efx/base/ef10_mac.c:851:
+		return (EAGAIN);

ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#551: FILE: drivers/net/sfc/efx/base/ef10_mac.c:856:
+	return (0);

ERROR:ASSIGN_IN_IF: do not use assignment in if condition
#567: FILE: drivers/net/sfc/efx/base/ef10_nic.c:1376:
+	if ((rc = efx_mcdi_mac_stats_clear(enp)) != 0)

WARNING:SPACING: space prohibited between function name and open parenthesis '('
#700: FILE: drivers/net/sfc/efx/base/efx.h:537:
+#define	EFX_MAC_STATS_MASK_BITS_PER_PAGE	(8 * sizeof (uint32_t))

CHECK:MACRO_ARG_REUSE: Macro argument reuse '_stat' - possible side-effects?
#719: FILE: drivers/net/sfc/efx/base/efx.h:556:
+#define	EFX_MAC_STAT_SUPPORTED(_mask, _stat)	\
+	((_mask)[(_stat) / EFX_MAC_STATS_MASK_BITS_PER_PAGE] &	\
+	 (1ULL << ((_stat) & (EFX_MAC_STATS_MASK_BITS_PER_PAGE - 1))))

ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#1004: FILE: drivers/net/sfc/efx/base/efx_mac.c:606:
+	return (__efx_mac_stat_name[id]);

WARNING:SPACING: space prohibited between function name and open parenthesis '('
#1015: FILE: drivers/net/sfc/efx/base/efx_mac.c:617:
+	unsigned int mask_npages = mask_size / sizeof (*maskp);

ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#1048: FILE: drivers/net/sfc/efx/base/efx_mac.c:650:
+	return (0);

ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#1053: FILE: drivers/net/sfc/efx/base/efx_mac.c:655:
+	return (rc);

ERROR:ASSIGN_IN_IF: do not use assignment in if condition
#1067: FILE: drivers/net/sfc/efx/base/efx_mac.c:669:
+		if ((rc = efx_mac_stats_mask_add_range(maskp, mask_size,

ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#1072: FILE: drivers/net/sfc/efx/base/efx_mac.c:674:
+	return (0);

ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#1077: FILE: drivers/net/sfc/efx/base/efx_mac.c:679:
+	return (rc);

CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around enp->en_port
#1086: FILE: drivers/net/sfc/efx/base/efx_mac.c:688:
+	efx_port_t *epp = &(enp->en_port);

WARNING:SPACING: space prohibited between function name and open parenthesis '('
#1093: FILE: drivers/net/sfc/efx/base/efx_mac.c:695:
+	EFSYS_ASSERT(mask_size % sizeof (maskp[0]) == 0);

CHECK:SPACING: No space is necessary after a cast
#1095: FILE: drivers/net/sfc/efx/base/efx_mac.c:697:
+	(void) memset(maskp, 0, mask_size);

ERROR:ASSIGN_IN_IF: do not use assignment in if condition
#1097: FILE: drivers/net/sfc/efx/base/efx_mac.c:699:
+	if ((rc = emop->emo_stats_get_mask(enp, maskp, mask_size)) != 0)

ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#1100: FILE: drivers/net/sfc/efx/base/efx_mac.c:702:
+	return (0);

ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#1105: FILE: drivers/net/sfc/efx/base/efx_mac.c:707:
+	return (rc);

CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around enp->en_port
#1113: FILE: drivers/net/sfc/efx/base/efx_mac.c:715:
+	efx_port_t *epp = &(enp->en_port);

ERROR:ASSIGN_IN_IF: do not use assignment in if condition
#1126: FILE: drivers/net/sfc/efx/base/efx_mac.c:728:
+	if ((rc = emop->emo_stats_upload(enp, esmp)) != 0)

ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#1131: FILE: drivers/net/sfc/efx/base/efx_mac.c:733:
+	return (0);

ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#1136: FILE: drivers/net/sfc/efx/base/efx_mac.c:738:
+	return (rc);

CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around enp->en_port
#1146: FILE: drivers/net/sfc/efx/base/efx_mac.c:748:
+	efx_port_t *epp = &(enp->en_port);

ERROR:ASSIGN_IN_IF: do not use assignment in if condition
#1160: FILE: drivers/net/sfc/efx/base/efx_mac.c:762:
+	if ((rc = emop->emo_stats_periodic(enp, esmp, period_ms, events)) != 0)

ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#1163: FILE: drivers/net/sfc/efx/base/efx_mac.c:765:
+	return (0);

ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#1170: FILE: drivers/net/sfc/efx/base/efx_mac.c:772:
+	return (rc);

CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around enp->en_port
#1181: FILE: drivers/net/sfc/efx/base/efx_mac.c:783:
+	efx_port_t *epp = &(enp->en_port);

ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#1193: FILE: drivers/net/sfc/efx/base/efx_mac.c:795:
+	return (rc);

CHECK:SPACING: No space is necessary after a cast
#1235: FILE: drivers/net/sfc/efx/base/efx_mcdi.c:1737:
+	(void) memset(payload, 0, sizeof (payload));

WARNING:SPACING: space prohibited between function name and open parenthesis '('
#1235: FILE: drivers/net/sfc/efx/base/efx_mcdi.c:1737:
+	(void) memset(payload, 0, sizeof (payload));

WARNING:SPACING: space prohibited between function name and open parenthesis '('
#1251: FILE: drivers/net/sfc/efx/base/efx_mcdi.c:1753:
+		int bytes = MC_CMD_MAC_NSTATS * sizeof (uint64_t);

WARNING:SPACING: space prohibited between function name and open parenthesis '('
#1253: FILE: drivers/net/sfc/efx/base/efx_mcdi.c:1755:
+		EFX_STATIC_ASSERT(MC_CMD_MAC_NSTATS * sizeof (uint64_t) <=

ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#1284: FILE: drivers/net/sfc/efx/base/efx_mcdi.c:1786:
+	return (0);

ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#1289: FILE: drivers/net/sfc/efx/base/efx_mcdi.c:1791:
+	return (rc);

ERROR:ASSIGN_IN_IF: do not use assignment in if condition
#1298: FILE: drivers/net/sfc/efx/base/efx_mcdi.c:1800:
+	if ((rc = efx_mcdi_mac_stats(enp, NULL, EFX_STATS_CLEAR)) != 0)

ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#1301: FILE: drivers/net/sfc/efx/base/efx_mcdi.c:1803:
+	return (0);

ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#1306: FILE: drivers/net/sfc/efx/base/efx_mcdi.c:1808:
+	return (rc);

ERROR:ASSIGN_IN_IF: do not use assignment in if condition
#1321: FILE: drivers/net/sfc/efx/base/efx_mcdi.c:1823:
+	if ((rc = efx_mcdi_mac_stats(enp, esmp, EFX_STATS_UPLOAD)) != 0)

ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#1324: FILE: drivers/net/sfc/efx/base/efx_mcdi.c:1826:
+	return (0);

ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#1329: FILE: drivers/net/sfc/efx/base/efx_mcdi.c:1831:
+	return (rc);

ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#1357: FILE: drivers/net/sfc/efx/base/efx_mcdi.c:1859:
+	return (0);

ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#1362: FILE: drivers/net/sfc/efx/base/efx_mcdi.c:1864:
+	return (rc);

ERROR:ASSIGN_IN_IF: do not use assignment in if condition
#1423: FILE: drivers/net/sfc/efx/base/siena_mac.c:214:
+	if ((rc = efx_mac_stats_mask_add_ranges(maskp, mask_size,

ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#1427: FILE: drivers/net/sfc/efx/base/siena_mac.c:218:
+	return (0);

ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#1432: FILE: drivers/net/sfc/efx/base/siena_mac.c:223:
+	return (rc);

WARNING:SPACING: space prohibited between function name and open parenthesis '('
#1436: FILE: drivers/net/sfc/efx/base/siena_mac.c:227:
+	EFSYS_MEM_READQ((_esmp), (_field) * sizeof (efx_qword_t), _eqp)

CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around stat[EFX_MAC_TX_PKTS]
#1459: FILE: drivers/net/sfc/efx/base/siena_mac.c:250:
+	EFSYS_STAT_SET_QWORD(&(stat[EFX_MAC_TX_PKTS]), &value);

CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around stat[EFX_MAC_TX_PKTS]
#1461: FILE: drivers/net/sfc/efx/base/siena_mac.c:252:
+	EFSYS_STAT_SUBR_QWORD(&(stat[EFX_MAC_TX_PKTS]), &value);

CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around stat[EFX_MAC_TX_PAUSE_PKTS]
#1464: FILE: drivers/net/sfc/efx/base/siena_mac.c:255:
+	EFSYS_STAT_SET_QWORD(&(stat[EFX_MAC_TX_PAUSE_PKTS]), &value);

CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around stat[EFX_MAC_TX_UNICST_PKTS]
#1467: FILE: drivers/net/sfc/efx/base/siena_mac.c:258:
+	EFSYS_STAT_SET_QWORD(&(stat[EFX_MAC_TX_UNICST_PKTS]), &value);

CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around stat[EFX_MAC_TX_MULTICST_PKTS]
#1470: FILE: drivers/net/sfc/efx/base/siena_mac.c:261:
+	EFSYS_STAT_SET_QWORD(&(stat[EFX_MAC_TX_MULTICST_PKTS]), &value);

CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around stat[EFX_MAC_TX_BRDCST_PKTS]
#1473: FILE: drivers/net/sfc/efx/base/siena_mac.c:264:
+	EFSYS_STAT_SET_QWORD(&(stat[EFX_MAC_TX_BRDCST_PKTS]), &value);

CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around stat[EFX_MAC_TX_OCTETS]
#1476: FILE: drivers/net/sfc/efx/base/siena_mac.c:267:
+	EFSYS_STAT_SET_QWORD(&(stat[EFX_MAC_TX_OCTETS]), &value);

CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around stat[EFX_MAC_TX_LE_64_PKTS]
#1479: FILE: drivers/net/sfc/efx/base/siena_mac.c:270:
+	EFSYS_STAT_SET_QWORD(&(stat[EFX_MAC_TX_LE_64_PKTS]), &value);

CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around stat[EFX_MAC_TX_LE_64_PKTS]
#1481: FILE: drivers/net/sfc/efx/base/siena_mac.c:272:
+	EFSYS_STAT_INCR_QWORD(&(stat[EFX_MAC_TX_LE_64_PKTS]), &value);

CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around stat[EFX_MAC_TX_65_TO_127_PKTS]
#1484: FILE: drivers/net/sfc/efx/base/siena_mac.c:275:
+	EFSYS_STAT_SET_QWORD(&(stat[EFX_MAC_TX_65_TO_127_PKTS]), &value);

CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around stat[EFX_MAC_TX_128_TO_255_PKTS]
#1487: FILE: drivers/net/sfc/efx/base/siena_mac.c:278:
+	EFSYS_STAT_SET_QWORD(&(stat[EFX_MAC_TX_128_TO_255_PKTS]), &value);

CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around stat[EFX_MAC_TX_256_TO_511_PKTS]
#1490: FILE: drivers/net/sfc/efx/base/siena_mac.c:281:
+	EFSYS_STAT_SET_QWORD(&(stat[EFX_MAC_TX_256_TO_511_PKTS]), &value);

CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around stat[EFX_MAC_TX_512_TO_1023_PKTS]
#1493: FILE: drivers/net/sfc/efx/base/siena_mac.c:284:
+	EFSYS_STAT_SET_QWORD(&(stat[EFX_MAC_TX_512_TO_1023_PKTS]), &value);

CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around stat[EFX_MAC_TX_1024_TO_15XX_PKTS]
#1496: FILE: drivers/net/sfc/efx/base/siena_mac.c:287:
+	EFSYS_STAT_SET_QWORD(&(stat[EFX_MAC_TX_1024_TO_15XX_PKTS]), &value);

CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around stat[EFX_MAC_TX_GE_15XX_PKTS]
#1499: FILE: drivers/net/sfc/efx/base/siena_mac.c:290:
+	EFSYS_STAT_SET_QWORD(&(stat[EFX_MAC_TX_GE_15XX_PKTS]), &value);

CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around stat[EFX_MAC_TX_GE_15XX_PKTS]
#1501: FILE: drivers/net/sfc/efx/base/siena_mac.c:292:
+	EFSYS_STAT_INCR_QWORD(&(stat[EFX_MAC_TX_GE_15XX_PKTS]), &value);

CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around stat[EFX_MAC_TX_ERRORS]
#1504: FILE: drivers/net/sfc/efx/base/siena_mac.c:295:
+	EFSYS_STAT_SET_QWORD(&(stat[EFX_MAC_TX_ERRORS]), &value);

CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around stat[EFX_MAC_TX_SGL_COL_PKTS]
#1507: FILE: drivers/net/sfc/efx/base/siena_mac.c:298:
+	EFSYS_STAT_SET_QWORD(&(stat[EFX_MAC_TX_SGL_COL_PKTS]), &value);

CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around stat[EFX_MAC_TX_MULT_COL_PKTS]
#1511: FILE: drivers/net/sfc/efx/base/siena_mac.c:302:
+	EFSYS_STAT_SET_QWORD(&(stat[EFX_MAC_TX_MULT_COL_PKTS]), &value);

CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around stat[EFX_MAC_TX_EX_COL_PKTS]
#1515: FILE: drivers/net/sfc/efx/base/siena_mac.c:306:
+	EFSYS_STAT_SET_QWORD(&(stat[EFX_MAC_TX_EX_COL_PKTS]), &value);

CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around stat[EFX_MAC_TX_LATE_COL_PKTS]
#1518: FILE: drivers/net/sfc/efx/base/siena_mac.c:309:
+	EFSYS_STAT_SET_QWORD(&(stat[EFX_MAC_TX_LATE_COL_PKTS]), &value);

CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around stat[EFX_MAC_TX_DEF_PKTS]
#1521: FILE: drivers/net/sfc/efx/base/siena_mac.c:312:
+	EFSYS_STAT_SET_QWORD(&(stat[EFX_MAC_TX_DEF_PKTS]), &value);

CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around stat[EFX_MAC_TX_EX_DEF_PKTS]
#1525: FILE: drivers/net/sfc/efx/base/siena_mac.c:316:
+	EFSYS_STAT_SET_QWORD(&(stat[EFX_MAC_TX_EX_DEF_PKTS]), &value);

CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around stat[EFX_MAC_RX_OCTETS]
#1529: FILE: drivers/net/sfc/efx/base/siena_mac.c:320:
+	EFSYS_STAT_SET_QWORD(&(stat[EFX_MAC_RX_OCTETS]), &value);

CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around stat[EFX_MAC_RX_PKTS]
#1532: FILE: drivers/net/sfc/efx/base/siena_mac.c:323:
+	EFSYS_STAT_SET_QWORD(&(stat[EFX_MAC_RX_PKTS]), &value);

CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around stat[EFX_MAC_RX_UNICST_PKTS]
#1535: FILE: drivers/net/sfc/efx/base/siena_mac.c:326:
+	EFSYS_STAT_SET_QWORD(&(stat[EFX_MAC_RX_UNICST_PKTS]), &value);

CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around stat[EFX_MAC_RX_MULTICST_PKTS]
#1538: FILE: drivers/net/sfc/efx/base/siena_mac.c:329:
+	EFSYS_STAT_SET_QWORD(&(stat[EFX_MAC_RX_MULTICST_PKTS]), &value);

CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around stat[EFX_MAC_RX_BRDCST_PKTS]
#1541: FILE: drivers/net/sfc/efx/base/siena_mac.c:332:
+	EFSYS_STAT_SET_QWORD(&(stat[EFX_MAC_RX_BRDCST_PKTS]), &value);

CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around stat[EFX_MAC_RX_PAUSE_PKTS]
#1544: FILE: drivers/net/sfc/efx/base/siena_mac.c:335:
+	EFSYS_STAT_SET_QWORD(&(stat[EFX_MAC_RX_PAUSE_PKTS]), &value);

CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around stat[EFX_MAC_RX_LE_64_PKTS]
#1547: FILE: drivers/net/sfc/efx/base/siena_mac.c:338:
+	EFSYS_STAT_SET_QWORD(&(stat[EFX_MAC_RX_LE_64_PKTS]), &value);

CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around stat[EFX_MAC_RX_LE_64_PKTS]
#1549: FILE: drivers/net/sfc/efx/base/siena_mac.c:340:
+	EFSYS_STAT_INCR_QWORD(&(stat[EFX_MAC_RX_LE_64_PKTS]), &value);

CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around stat[EFX_MAC_RX_65_TO_127_PKTS]
#1552: FILE: drivers/net/sfc/efx/base/siena_mac.c:343:
+	EFSYS_STAT_SET_QWORD(&(stat[EFX_MAC_RX_65_TO_127_PKTS]), &value);

CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around stat[EFX_MAC_RX_128_TO_255_PKTS]
#1555: FILE: drivers/net/sfc/efx/base/siena_mac.c:346:
+	EFSYS_STAT_SET_QWORD(&(stat[EFX_MAC_RX_128_TO_255_PKTS]), &value);

CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around stat[EFX_MAC_RX_256_TO_511_PKTS]
#1558: FILE: drivers/net/sfc/efx/base/siena_mac.c:349:
+	EFSYS_STAT_SET_QWORD(&(stat[EFX_MAC_RX_256_TO_511_PKTS]), &value);

CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around stat[EFX_MAC_RX_512_TO_1023_PKTS]
#1561: FILE: drivers/net/sfc/efx/base/siena_mac.c:352:
+	EFSYS_STAT_SET_QWORD(&(stat[EFX_MAC_RX_512_TO_1023_PKTS]), &value);

CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around stat[EFX_MAC_RX_1024_TO_15XX_PKTS]
#1564: FILE: drivers/net/sfc/efx/base/siena_mac.c:355:
+	EFSYS_STAT_SET_QWORD(&(stat[EFX_MAC_RX_1024_TO_15XX_PKTS]), &value);

CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around stat[EFX_MAC_RX_GE_15XX_PKTS]
#1567: FILE: drivers/net/sfc/efx/base/siena_mac.c:358:
+	EFSYS_STAT_SET_QWORD(&(stat[EFX_MAC_RX_GE_15XX_PKTS]), &value);

CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around stat[EFX_MAC_RX_GE_15XX_PKTS]
#1569: FILE: drivers/net/sfc/efx/base/siena_mac.c:360:
+	EFSYS_STAT_INCR_QWORD(&(stat[EFX_MAC_RX_GE_15XX_PKTS]), &value);

CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around stat[EFX_MAC_RX_FCS_ERRORS]
#1572: FILE: drivers/net/sfc/efx/base/siena_mac.c:363:
+	EFSYS_STAT_SET_QWORD(&(stat[EFX_MAC_RX_FCS_ERRORS]), &value);

CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around stat[EFX_MAC_RX_DROP_EVENTS]
#1575: FILE: drivers/net/sfc/efx/base/siena_mac.c:366:
+	EFSYS_STAT_SET_QWORD(&(stat[EFX_MAC_RX_DROP_EVENTS]), &value);

CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around stat[EFX_MAC_RX_FALSE_CARRIER_ERRORS]
#1578: FILE: drivers/net/sfc/efx/base/siena_mac.c:369:
+	EFSYS_STAT_SET_QWORD(&(stat[EFX_MAC_RX_FALSE_CARRIER_ERRORS]), &value);

CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around stat[EFX_MAC_RX_SYMBOL_ERRORS]
#1581: FILE: drivers/net/sfc/efx/base/siena_mac.c:372:
+	EFSYS_STAT_SET_QWORD(&(stat[EFX_MAC_RX_SYMBOL_ERRORS]), &value);

CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around stat[EFX_MAC_RX_ALIGN_ERRORS]
#1584: FILE: drivers/net/sfc/efx/base/siena_mac.c:375:
+	EFSYS_STAT_SET_QWORD(&(stat[EFX_MAC_RX_ALIGN_ERRORS]), &value);

CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around stat[EFX_MAC_RX_INTERNAL_ERRORS]
#1587: FILE: drivers/net/sfc/efx/base/siena_mac.c:378:
+	EFSYS_STAT_SET_QWORD(&(stat[EFX_MAC_RX_INTERNAL_ERRORS]), &value);

CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around stat[EFX_MAC_RX_JABBER_PKTS]
#1590: FILE: drivers/net/sfc/efx/base/siena_mac.c:381:
+	EFSYS_STAT_SET_QWORD(&(stat[EFX_MAC_RX_JABBER_PKTS]), &value);

CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around stat[EFX_MAC_RX_LANE0_CHAR_ERR]
#1593: FILE: drivers/net/sfc/efx/base/siena_mac.c:384:
+	EFSYS_STAT_SET_DWORD(&(stat[EFX_MAC_RX_LANE0_CHAR_ERR]),

CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around value.eq_dword[0]
#1594: FILE: drivers/net/sfc/efx/base/siena_mac.c:385:
+			    &(value.eq_dword[0]));

CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around stat[EFX_MAC_RX_LANE1_CHAR_ERR]
#1595: FILE: drivers/net/sfc/efx/base/siena_mac.c:386:
+	EFSYS_STAT_SET_DWORD(&(stat[EFX_MAC_RX_LANE1_CHAR_ERR]),

CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around value.eq_dword[1]
#1596: FILE: drivers/net/sfc/efx/base/siena_mac.c:387:
+			    &(value.eq_dword[1]));

CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around stat[EFX_MAC_RX_LANE2_CHAR_ERR]
#1599: FILE: drivers/net/sfc/efx/base/siena_mac.c:390:
+	EFSYS_STAT_SET_DWORD(&(stat[EFX_MAC_RX_LANE2_CHAR_ERR]),

CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around value.eq_dword[0]
#1600: FILE: drivers/net/sfc/efx/base/siena_mac.c:391:
+			    &(value.eq_dword[0]));

CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around stat[EFX_MAC_RX_LANE3_CHAR_ERR]
#1601: FILE: drivers/net/sfc/efx/base/siena_mac.c:392:
+	EFSYS_STAT_SET_DWORD(&(stat[EFX_MAC_RX_LANE3_CHAR_ERR]),

CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around value.eq_dword[1]
#1602: FILE: drivers/net/sfc/efx/base/siena_mac.c:393:
+			    &(value.eq_dword[1]));

CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around stat[EFX_MAC_RX_LANE0_DISP_ERR]
#1605: FILE: drivers/net/sfc/efx/base/siena_mac.c:396:
+	EFSYS_STAT_SET_DWORD(&(stat[EFX_MAC_RX_LANE0_DISP_ERR]),

CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around value.eq_dword[0]
#1606: FILE: drivers/net/sfc/efx/base/siena_mac.c:397:
+			    &(value.eq_dword[0]));

CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around stat[EFX_MAC_RX_LANE1_DISP_ERR]
#1607: FILE: drivers/net/sfc/efx/base/siena_mac.c:398:
+	EFSYS_STAT_SET_DWORD(&(stat[EFX_MAC_RX_LANE1_DISP_ERR]),

CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around value.eq_dword[1]
#1608: FILE: drivers/net/sfc/efx/base/siena_mac.c:399:
+			    &(value.eq_dword[1]));

CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around stat[EFX_MAC_RX_LANE2_DISP_ERR]
#1611: FILE: drivers/net/sfc/efx/base/siena_mac.c:402:
+	EFSYS_STAT_SET_DWORD(&(stat[EFX_MAC_RX_LANE2_DISP_ERR]),

CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around value.eq_dword[0]
#1612: FILE: drivers/net/sfc/efx/base/siena_mac.c:403:
+			    &(value.eq_dword[0]));

CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around stat[EFX_MAC_RX_LANE3_DISP_ERR]
#1613: FILE: drivers/net/sfc/efx/base/siena_mac.c:404:
+	EFSYS_STAT_SET_DWORD(&(stat[EFX_MAC_RX_LANE3_DISP_ERR]),

CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around value.eq_dword[1]
#1614: FILE: drivers/net/sfc/efx/base/siena_mac.c:405:
+			    &(value.eq_dword[1]));

CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around stat[EFX_MAC_RX_MATCH_FAULT]
#1617: FILE: drivers/net/sfc/efx/base/siena_mac.c:408:
+	EFSYS_STAT_SET_QWORD(&(stat[EFX_MAC_RX_MATCH_FAULT]), &value);

CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around stat[EFX_MAC_RX_NODESC_DROP_CNT]
#1620: FILE: drivers/net/sfc/efx/base/siena_mac.c:411:
+	EFSYS_STAT_SET_QWORD(&(stat[EFX_MAC_RX_NODESC_DROP_CNT]), &value);

WARNING:SPACING: space prohibited between function name and open parenthesis '('
#1630: FILE: drivers/net/sfc/efx/base/siena_mac.c:421:
+	    sizeof (generation_start)))

ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#1631: FILE: drivers/net/sfc/efx/base/siena_mac.c:422:
+		return (EAGAIN);

WARNING:USE_NEGATIVE_ERRNO: return of an errno should typically be negative (ie: return -EAGAIN)
#1631: FILE: drivers/net/sfc/efx/base/siena_mac.c:422:
+		return (EAGAIN);

ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#1636: FILE: drivers/net/sfc/efx/base/siena_mac.c:427:
+	return (0);

ERROR:ASSIGN_IN_IF: do not use assignment in if condition
#1654: FILE: drivers/net/sfc/efx/base/siena_nic.c:215:
+	if ((rc = efx_mcdi_mac_stats_clear(enp)) != 0)

total: 43 errors, 12 warnings, 166 checks, 1510 lines checked
Previous message: [dpdk-test-report] |SUCCESS| [PATCH 31/56] net/sfc: implement dummy callback to get device information
Next message: [dpdk-test-report] |SUCCESS| [PATCH 35/56] net/sfc: implement device start and stop operations
Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]
More information about the test-report mailing list