[dpdk-test-report] |WARNING| [PATCH 10/56] net/sfc: import libefx SFN7xxx family support

checkpatch at dpdk.org checkpatch at dpdk.org
Mon Nov 21 16:18:23 CET 2016


Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/17152

_coding style issues_


CHECK:CAMELCASE: Avoid CamelCase: <__checkReturn>
#164: FILE: drivers/net/sfc/efx/base/ef10_ev.c:45:
+static	__checkReturn	boolean_t

CHECK:SPACING: No space is necessary after a cast
#212: FILE: drivers/net/sfc/efx/base/ef10_ev.c:93:
+	(void) memset(payload, 0, sizeof (payload));

WARNING:SPACING: space prohibited between function name and open parenthesis '('
#212: FILE: drivers/net/sfc/efx/base/ef10_ev.c:93:
+	(void) memset(payload, 0, sizeof (payload));

ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#236: FILE: drivers/net/sfc/efx/base/ef10_ev.c:117:
+	return (0);

ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#243: FILE: drivers/net/sfc/efx/base/ef10_ev.c:124:
+	return (rc);

CHECK:SPACING: No space is necessary after a cast
#275: FILE: drivers/net/sfc/efx/base/ef10_ev.c:156:
+	(void) memset(payload, 0, sizeof (payload));

WARNING:SPACING: space prohibited between function name and open parenthesis '('
#275: FILE: drivers/net/sfc/efx/base/ef10_ev.c:156:
+	(void) memset(payload, 0, sizeof (payload));

ERROR:ASSIGN_IN_IF: do not use assignment in if condition
#328: FILE: drivers/net/sfc/efx/base/ef10_ev.c:209:
+		if ((rc = efx_ev_usecs_to_ticks(enp, us, &ticks)) != 0)

ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#367: FILE: drivers/net/sfc/efx/base/ef10_ev.c:248:
+	return (0);

ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#380: FILE: drivers/net/sfc/efx/base/ef10_ev.c:261:
+	return (rc);

CHECK:SPACING: No space is necessary after a cast
#412: FILE: drivers/net/sfc/efx/base/ef10_ev.c:293:
+	(void) memset(payload, 0, sizeof (payload));

WARNING:SPACING: space prohibited between function name and open parenthesis '('
#412: FILE: drivers/net/sfc/efx/base/ef10_ev.c:293:
+	(void) memset(payload, 0, sizeof (payload));

ERROR:ASSIGN_IN_IF: do not use assignment in if condition
#455: FILE: drivers/net/sfc/efx/base/ef10_ev.c:336:
+		if ((rc = efx_ev_usecs_to_ticks(enp, us, &ticks)) != 0)

ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#497: FILE: drivers/net/sfc/efx/base/ef10_ev.c:378:
+	return (0);

ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#510: FILE: drivers/net/sfc/efx/base/ef10_ev.c:391:
+	return (rc);

CHECK:SPACING: No space is necessary after a cast
#523: FILE: drivers/net/sfc/efx/base/ef10_ev.c:404:
+	(void) memset(payload, 0, sizeof (payload));

WARNING:SPACING: space prohibited between function name and open parenthesis '('
#523: FILE: drivers/net/sfc/efx/base/ef10_ev.c:404:
+	(void) memset(payload, 0, sizeof (payload));

ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#539: FILE: drivers/net/sfc/efx/base/ef10_ev.c:420:
+	return (0);

ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#544: FILE: drivers/net/sfc/efx/base/ef10_ev.c:425:
+	return (rc);

ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#554: FILE: drivers/net/sfc/efx/base/ef10_ev.c:435:
+	return (0);

CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around enp->en_nic_cfg
#575: FILE: drivers/net/sfc/efx/base/ef10_ev.c:456:
+	efx_nic_cfg_t *encp = &(enp->en_nic_cfg);

ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#654: FILE: drivers/net/sfc/efx/base/ef10_ev.c:535:
+	return (0);

ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#667: FILE: drivers/net/sfc/efx/base/ef10_ev.c:548:
+	return (rc);

CHECK:SPACING: No space is necessary after a cast
#679: FILE: drivers/net/sfc/efx/base/ef10_ev.c:560:
+	(void) efx_mcdi_fini_evq(eep->ee_enp, eep->ee_index);

ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#720: FILE: drivers/net/sfc/efx/base/ef10_ev.c:601:
+	return (0);

ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#754: FILE: drivers/net/sfc/efx/base/ef10_ev.c:635:
+	return (0);

ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#759: FILE: drivers/net/sfc/efx/base/ef10_ev.c:640:
+	return (rc);

CHECK:SPACING: No space is necessary after a cast
#775: FILE: drivers/net/sfc/efx/base/ef10_ev.c:656:
+	(void) efx_mcdi_driver_event(enp, eep->ee_index, event);

CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around enp->en_nic_cfg
#784: FILE: drivers/net/sfc/efx/base/ef10_ev.c:665:
+	efx_nic_cfg_t *encp = &(enp->en_nic_cfg);

WARNING:BRACES: braces {} are not necessary for any arm of this statement
#805: FILE: drivers/net/sfc/efx/base/ef10_ev.c:686:
+	if (us == 0) {
[...]
+	} else {
[...]

ERROR:ASSIGN_IN_IF: do not use assignment in if condition
#820: FILE: drivers/net/sfc/efx/base/ef10_ev.c:701:
+		if ((rc = efx_ev_usecs_to_ticks(enp, us, &ticks)) != 0)

ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#840: FILE: drivers/net/sfc/efx/base/ef10_ev.c:721:
+	return (0);

ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#849: FILE: drivers/net/sfc/efx/base/ef10_ev.c:730:
+	return (rc);

ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#879: FILE: drivers/net/sfc/efx/base/ef10_ev.c:760:
+		return (B_FALSE);

ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#895: FILE: drivers/net/sfc/efx/base/ef10_ev.c:776:
+		return (B_FALSE);

WARNING:BRACES: braces {} are not necessary for any arm of this statement
#964: FILE: drivers/net/sfc/efx/base/ef10_ev.c:845:
+		if (EFX_QWORD_FIELD(*eqp, ESF_DZ_RX_IPCKSUM_ERR)) {
[...]
+		} else {
[...]

WARNING:BRACES: braces {} are not necessary for any arm of this statement
#1002: FILE: drivers/net/sfc/efx/base/ef10_ev.c:883:
+		if (EFX_QWORD_FIELD(*eqp, ESF_DZ_RX_TCPUDP_CKSUM_ERR)) {
[...]
+		} else {
[...]

ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#1017: FILE: drivers/net/sfc/efx/base/ef10_ev.c:898:
+	return (should_abort);

ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#1036: FILE: drivers/net/sfc/efx/base/ef10_ev.c:917:
+		return (B_FALSE);

ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#1040: FILE: drivers/net/sfc/efx/base/ef10_ev.c:921:
+		return (B_FALSE);

ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#1052: FILE: drivers/net/sfc/efx/base/ef10_ev.c:933:
+	return (should_abort);

ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#1102: FILE: drivers/net/sfc/efx/base/ef10_ev.c:983:
+	return (should_abort);

ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#1124: FILE: drivers/net/sfc/efx/base/ef10_ev.c:1005:
+		return (B_TRUE);

ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#1130: FILE: drivers/net/sfc/efx/base/ef10_ev.c:1011:
+	return (should_abort);

ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#1307: FILE: drivers/net/sfc/efx/base/ef10_ev.c:1188:
+	return (should_abort);

ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#1406: FILE: drivers/net/sfc/efx/base/ef10_filter.c:55:
+		return (B_TRUE);

ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#1408: FILE: drivers/net/sfc/efx/base/ef10_filter.c:57:
+		return (B_FALSE);

ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#1417: FILE: drivers/net/sfc/efx/base/ef10_filter.c:66:
+		return (B_TRUE);

ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#1419: FILE: drivers/net/sfc/efx/base/ef10_filter.c:68:
+		return (B_FALSE);

CHECK:MACRO_ARG_REUSE: Macro argument reuse 'match' - possible side-effects?
#1475: FILE: drivers/net/sfc/efx/base/ef10_filter.c:124:
+#define	MATCH_MASK(match) (EFX_MASK32(match) << EFX_LOW_BIT(match))

WARNING:SPACING: space prohibited between function name and open parenthesis '('
#1498: FILE: drivers/net/sfc/efx/base/ef10_filter.c:147:
+	EFSYS_KMEM_ALLOC(enp->en_esip, sizeof (ef10_filter_table_t), eftp);

ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#1507: FILE: drivers/net/sfc/efx/base/ef10_filter.c:156:
+	return (0);

ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#1512: FILE: drivers/net/sfc/efx/base/ef10_filter.c:161:
+	return (rc);

WARNING:SPACING: space prohibited between function name and open parenthesis '('
#1523: FILE: drivers/net/sfc/efx/base/ef10_filter.c:172:
+		EFSYS_KMEM_FREE(enp->en_esip, sizeof (ef10_filter_table_t),

WARNING:SPACING: space prohibited between function name and open parenthesis '('
#1541: FILE: drivers/net/sfc/efx/base/ef10_filter.c:190:
+	memset(payload, 0, sizeof (payload));

WARNING:SPACING: space prohibited between function name and open parenthesis '('
#1627: FILE: drivers/net/sfc/efx/base/ef10_filter.c:276:
+		EFX_STATIC_ASSERT(sizeof (spec->efs_rem_host) ==

WARNING:SPACING: space prohibited between function name and open parenthesis '('
#1629: FILE: drivers/net/sfc/efx/base/ef10_filter.c:278:
+		EFX_STATIC_ASSERT(sizeof (spec->efs_loc_host) ==

ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#1655: FILE: drivers/net/sfc/efx/base/ef10_filter.c:304:
+	return (0);

ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#1664: FILE: drivers/net/sfc/efx/base/ef10_filter.c:313:
+	return (rc);

CHECK:BRACES: Blank lines aren't necessary before a close brace '}'
#1666: FILE: drivers/net/sfc/efx/base/ef10_filter.c:315:
+
+}

WARNING:SPACING: space prohibited between function name and open parenthesis '('
#1679: FILE: drivers/net/sfc/efx/base/ef10_filter.c:328:
+	memset(payload, 0, sizeof (payload));

ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#1716: FILE: drivers/net/sfc/efx/base/ef10_filter.c:365:
+	return (0);

ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#1726: FILE: drivers/net/sfc/efx/base/ef10_filter.c:375:
+	return (rc);

ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#1736: FILE: drivers/net/sfc/efx/base/ef10_filter.c:385:
+		return (B_FALSE);

ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#1738: FILE: drivers/net/sfc/efx/base/ef10_filter.c:387:
+		return (B_FALSE);

ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#1740: FILE: drivers/net/sfc/efx/base/ef10_filter.c:389:
+		return (B_FALSE);

ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#1742: FILE: drivers/net/sfc/efx/base/ef10_filter.c:391:
+		return (B_FALSE);

ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#1744: FILE: drivers/net/sfc/efx/base/ef10_filter.c:393:
+		return (B_FALSE);

ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#1746: FILE: drivers/net/sfc/efx/base/ef10_filter.c:395:
+		return (B_FALSE);

ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#1748: FILE: drivers/net/sfc/efx/base/ef10_filter.c:397:
+		return (B_FALSE);

ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#1750: FILE: drivers/net/sfc/efx/base/ef10_filter.c:399:
+		return (B_FALSE);

ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#1752: FILE: drivers/net/sfc/efx/base/ef10_filter.c:401:
+		return (B_FALSE);

ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#1754: FILE: drivers/net/sfc/efx/base/ef10_filter.c:403:
+		return (B_FALSE);

ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#1756: FILE: drivers/net/sfc/efx/base/ef10_filter.c:405:
+		return (B_FALSE);

ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#1758: FILE: drivers/net/sfc/efx/base/ef10_filter.c:407:
+	return (B_TRUE);

CHECK:BRACES: Blank lines aren't necessary before a close brace '}'
#1760: FILE: drivers/net/sfc/efx/base/ef10_filter.c:409:
+
+}

ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#1770: FILE: drivers/net/sfc/efx/base/ef10_filter.c:419:
+			return (B_TRUE);

ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#1774: FILE: drivers/net/sfc/efx/base/ef10_filter.c:423:
+			return (B_TRUE);

ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#1776: FILE: drivers/net/sfc/efx/base/ef10_filter.c:425:
+	return (B_FALSE);

WARNING:SPACING: space prohibited between function name and open parenthesis '('
#1783: FILE: drivers/net/sfc/efx/base/ef10_filter.c:432:
+	EFX_STATIC_ASSERT((sizeof (efx_filter_spec_t) % sizeof (uint32_t))

WARNING:SPACING: space prohibited between function name and open parenthesis '('
#1783: FILE: drivers/net/sfc/efx/base/ef10_filter.c:432:
+	EFX_STATIC_ASSERT((sizeof (efx_filter_spec_t) % sizeof (uint32_t))

WARNING:SPACING: space prohibited between function name and open parenthesis '('
#1786: FILE: drivers/net/sfc/efx/base/ef10_filter.c:435:
+			    sizeof (uint32_t)) == 0);

WARNING:SPACING: space prohibited between function name and open parenthesis '('
#1794: FILE: drivers/net/sfc/efx/base/ef10_filter.c:443:
+			(sizeof (efx_filter_spec_t) -

WARNING:SPACING: space prohibited between function name and open parenthesis '('
#1796: FILE: drivers/net/sfc/efx/base/ef10_filter.c:445:
+			sizeof (uint32_t), 0));

ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#1811: FILE: drivers/net/sfc/efx/base/ef10_filter.c:460:
+		return (B_TRUE);

ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#1818: FILE: drivers/net/sfc/efx/base/ef10_filter.c:467:
+			return (B_TRUE);

ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#1821: FILE: drivers/net/sfc/efx/base/ef10_filter.c:470:
+			return (B_TRUE);

ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#1824: FILE: drivers/net/sfc/efx/base/ef10_filter.c:473:
+	return (B_FALSE);

CHECK:BRACES: Blank lines aren't necessary after an open brace '{'
#1842: FILE: drivers/net/sfc/efx/base/ef10_filter.c:491:
+	for (tbl_id = 0; tbl_id < EFX_EF10_FILTER_TBL_ROWS; tbl_id++) {
+

ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#1881: FILE: drivers/net/sfc/efx/base/ef10_filter.c:530:
+	return (0);

ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#1886: FILE: drivers/net/sfc/efx/base/ef10_filter.c:535:
+	return (rc);

WARNING:BRACES: braces {} are not necessary for single statement blocks
#1939: FILE: drivers/net/sfc/efx/base/ef10_filter.c:588:
+				if (ins_index < 0) {
+					ins_index = i;
+				}

CHECK:BRACES: Blank lines aren't necessary before a close brace '}'
#1994: FILE: drivers/net/sfc/efx/base/ef10_filter.c:643:
+
+		}

WARNING:SPACING: space prohibited between function name and open parenthesis '('
#1997: FILE: drivers/net/sfc/efx/base/ef10_filter.c:646:
+		EFSYS_KMEM_ALLOC(enp->en_esip, sizeof (*spec), saved_spec);

ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#2052: FILE: drivers/net/sfc/efx/base/ef10_filter.c:701:
+	return (0);

WARNING:SPACING: space prohibited between function name and open parenthesis '('
#2058: FILE: drivers/net/sfc/efx/base/ef10_filter.c:707:
+		EFSYS_KMEM_FREE(enp->en_esip, sizeof (*spec), saved_spec);

ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#2076: FILE: drivers/net/sfc/efx/base/ef10_filter.c:725:
+	return (rc);

ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#2091: FILE: drivers/net/sfc/efx/base/ef10_filter.c:740:
+	return (0);

ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#2096: FILE: drivers/net/sfc/efx/base/ef10_filter.c:745:
+	return (rc);

ERROR:ASSIGN_IN_IF: do not use assignment in if condition
#2124: FILE: drivers/net/sfc/efx/base/ef10_filter.c:773:
+	if ((spec = ef10_filter_entry_spec(table, filter_idx)) != NULL) {

WARNING:BRACES: braces {} are not necessary for single statement blocks
#2124: FILE: drivers/net/sfc/efx/base/ef10_filter.c:773:
+	if ((spec = ef10_filter_entry_spec(table, filter_idx)) != NULL) {
+		ef10_filter_set_entry_busy(table, filter_idx);
+	}

WARNING:SPACING: space prohibited between function name and open parenthesis '('
#2154: FILE: drivers/net/sfc/efx/base/ef10_filter.c:803:
+	EFSYS_KMEM_FREE(enp->en_esip, sizeof (*spec), spec);

ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#2160: FILE: drivers/net/sfc/efx/base/ef10_filter.c:809:
+	return (0);

ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#2168: FILE: drivers/net/sfc/efx/base/ef10_filter.c:817:
+	return (rc);

ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#2215: FILE: drivers/net/sfc/efx/base/ef10_filter.c:864:
+	return (0);

ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#2226: FILE: drivers/net/sfc/efx/base/ef10_filter.c:875:
+	return (rc);

CHECK:SPACING: No space is necessary after a cast
#2243: FILE: drivers/net/sfc/efx/base/ef10_filter.c:892:
+	(void) memset(payload, 0, sizeof (payload));

WARNING:SPACING: space prohibited between function name and open parenthesis '('
#2243: FILE: drivers/net/sfc/efx/base/ef10_filter.c:892:
+	(void) memset(payload, 0, sizeof (payload));

WARNING:SPACING: space prohibited between function name and open parenthesis '('
#2273: FILE: drivers/net/sfc/efx/base/ef10_filter.c:922:
+	    (*length) * sizeof (uint32_t));

WARNING:SPACING: space prohibited between function name and open parenthesis '('
#2274: FILE: drivers/net/sfc/efx/base/ef10_filter.c:923:
+	EFX_STATIC_ASSERT(sizeof (uint32_t) ==

ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#2299: FILE: drivers/net/sfc/efx/base/ef10_filter.c:948:
+	return (0);

ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#2306: FILE: drivers/net/sfc/efx/base/ef10_filter.c:955:
+	return (rc);

ERROR:ASSIGN_IN_IF: do not use assignment in if condition
#2317: FILE: drivers/net/sfc/efx/base/ef10_filter.c:966:
+	if ((rc = efx_mcdi_get_parser_disp_info(enp, list, length)) != 0)

ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#2320: FILE: drivers/net/sfc/efx/base/ef10_filter.c:969:
+	return (0);

ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#2325: FILE: drivers/net/sfc/efx/base/ef10_filter.c:974:
+	return (rc);

ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#2353: FILE: drivers/net/sfc/efx/base/ef10_filter.c:1002:
+	return (0);

ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#2357: FILE: drivers/net/sfc/efx/base/ef10_filter.c:1006:
+	return (rc);

ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#2383: FILE: drivers/net/sfc/efx/base/ef10_filter.c:1032:
+	return (0);

ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#2387: FILE: drivers/net/sfc/efx/base/ef10_filter.c:1036:
+	return (rc);

CHECK:SPACING: spaces preferred around that '*' (ctx:VxV)
#2395: FILE: drivers/net/sfc/efx/base/ef10_filter.c:1044:
+	__in_ecount(6*count)		uint8_t const *addrs,
 	             ^

CHECK:BRACES: Blank lines aren't necessary before a close brace '}'
#2442: FILE: drivers/net/sfc/efx/base/ef10_filter.c:1091:
+
+	}

ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#2470: FILE: drivers/net/sfc/efx/base/ef10_filter.c:1119:
+	return (0);

CHECK:SPACING: No space is necessary after a cast
#2476: FILE: drivers/net/sfc/efx/base/ef10_filter.c:1125:
+		(void) ef10_filter_delete_internal(enp,

ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#2484: FILE: drivers/net/sfc/efx/base/ef10_filter.c:1133:
+	return (rc);

ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#2514: FILE: drivers/net/sfc/efx/base/ef10_filter.c:1163:
+	return (0);

ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#2519: FILE: drivers/net/sfc/efx/base/ef10_filter.c:1168:
+	return (rc);

WARNING:BRACES: braces {} are not necessary for single statement blocks
#2530: FILE: drivers/net/sfc/efx/base/ef10_filter.c:1179:
+		if (ef10_filter_entry_is_auto_old(table, i)) {
+			(void) ef10_filter_delete_internal(enp, i);
+		}

CHECK:SPACING: No space is necessary after a cast
#2531: FILE: drivers/net/sfc/efx/base/ef10_filter.c:1180:
+			(void) ef10_filter_delete_internal(enp, i);

ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#2563: FILE: drivers/net/sfc/efx/base/ef10_filter.c:1212:
+	return (0);

ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#2568: FILE: drivers/net/sfc/efx/base/ef10_filter.c:1217:
+	return (rc);

CHECK:BRACES: Blank lines aren't necessary before a close brace '}'
#2570: FILE: drivers/net/sfc/efx/base/ef10_filter.c:1219:
+
+}

CHECK:SPACING: spaces preferred around that '*' (ctx:VxV)
#2587: FILE: drivers/net/sfc/efx/base/ef10_filter.c:1236:
+	__in_ecount(6*count)		uint8_t const *addrs,
 	             ^

CHECK:SPACING: No space is necessary after a cast
#2606: FILE: drivers/net/sfc/efx/base/ef10_filter.c:1255:
+			(void) ef10_filter_delete_internal(enp,

CHECK:SPACING: No space is necessary after a cast
#2612: FILE: drivers/net/sfc/efx/base/ef10_filter.c:1261:
+			(void) ef10_filter_delete_internal(enp,

ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#2617: FILE: drivers/net/sfc/efx/base/ef10_filter.c:1266:
+		return (0);

ERROR:ASSIGN_IN_IF: do not use assignment in if condition
#2687: FILE: drivers/net/sfc/efx/base/ef10_filter.c:1336:
+	if ((rc = ef10_filter_get_workarounds(enp)) != 0)

ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#2760: FILE: drivers/net/sfc/efx/base/ef10_filter.c:1409:
+	return (rc);

WARNING:BRACES: braces {} are not necessary for single statement blocks
#2773: FILE: drivers/net/sfc/efx/base/ef10_filter.c:1422:
+		if (ef10_filter_entry_is_auto_old(table, i)) {
+			ef10_filter_set_entry_not_auto_old(table, i);
+		}

ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#2778: FILE: drivers/net/sfc/efx/base/ef10_filter.c:1427:
+	return (rc);

CHECK:SPACING: No space is necessary after a cast
#3280: FILE: drivers/net/sfc/efx/base/ef10_impl.h:454:
+#define	EFX_PIOBUF_HANDLE_INVALID	((efx_piobuf_handle_t) -1)

CHECK:SPACING: spaces preferred around that '*' (ctx:VxV)
#3450: FILE: drivers/net/sfc/efx/base/ef10_impl.h:624:
+	__in_ecount(6*count)		uint8_t const *addrs,
 	             ^

ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#3594: FILE: drivers/net/sfc/efx/base/ef10_intr.c:44:
+	return (0);

CHECK:SPACING: No space is necessary after a cast
#3640: FILE: drivers/net/sfc/efx/base/ef10_intr.c:90:
+	(void) memset(payload, 0, sizeof (payload));

WARNING:SPACING: space prohibited between function name and open parenthesis '('
#3640: FILE: drivers/net/sfc/efx/base/ef10_intr.c:90:
+	(void) memset(payload, 0, sizeof (payload));

ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#3656: FILE: drivers/net/sfc/efx/base/ef10_intr.c:106:
+	return (0);

ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#3664: FILE: drivers/net/sfc/efx/base/ef10_intr.c:114:
+	return (rc);

CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around enp->en_nic_cfg
#3672: FILE: drivers/net/sfc/efx/base/ef10_intr.c:122:
+	efx_nic_cfg_t *encp = &(enp->en_nic_cfg);

ERROR:ASSIGN_IN_IF: do not use assignment in if condition
#3684: FILE: drivers/net/sfc/efx/base/ef10_intr.c:134:
+	if ((rc = efx_mcdi_trigger_interrupt(enp, level)) != 0)

ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#3687: FILE: drivers/net/sfc/efx/base/ef10_intr.c:137:
+	return (0);

ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#3694: FILE: drivers/net/sfc/efx/base/ef10_intr.c:144:
+	return (rc);

CHECK:SPACING: spaces preferred around that '*' (ctx:ExV)
#3729: FILE: drivers/net/sfc/efx/base/ef10_intr.c:179:
+	*fatalp = B_FALSE;
 	^

CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around enp->en_port
#3795: FILE: drivers/net/sfc/efx/base/ef10_mac.c:42:
+	efx_port_t *epp = &(enp->en_port);

ERROR:ASSIGN_IN_IF: do not use assignment in if condition
#3799: FILE: drivers/net/sfc/efx/base/ef10_mac.c:46:
+	if ((rc = ef10_phy_get_link(enp, &els)) != 0)

ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#3807: FILE: drivers/net/sfc/efx/base/ef10_mac.c:54:
+	return (0);

ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#3814: FILE: drivers/net/sfc/efx/base/ef10_mac.c:61:
+	return (rc);

ERROR:ASSIGN_IN_IF: do not use assignment in if condition
#3829: FILE: drivers/net/sfc/efx/base/ef10_mac.c:76:
+	if ((rc = ef10_phy_get_link(enp, &els)) != 0)

ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#3834: FILE: drivers/net/sfc/efx/base/ef10_mac.c:81:
+	return (0);

ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#3839: FILE: drivers/net/sfc/efx/base/ef10_mac.c:86:
+	return (rc);

CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around enp->en_port
#3853: FILE: drivers/net/sfc/efx/base/ef10_mac.c:100:
+	efx_port_t *epp = &(enp->en_port);

CHECK:SPACING: No space is necessary after a cast
#3859: FILE: drivers/net/sfc/efx/base/ef10_mac.c:106:
+	(void) memset(payload, 0, sizeof (payload));

WARNING:SPACING: space prohibited between function name and open parenthesis '('
#3859: FILE: drivers/net/sfc/efx/base/ef10_mac.c:106:
+	(void) memset(payload, 0, sizeof (payload));

ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#3878: FILE: drivers/net/sfc/efx/base/ef10_mac.c:125:
+	return (0);

ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#3883: FILE: drivers/net/sfc/efx/base/ef10_mac.c:130:
+	return (rc);

ERROR:ASSIGN_IN_IF: do not use assignment in if condition
#3892: FILE: drivers/net/sfc/efx/base/ef10_mac.c:139:
+	if ((rc = efx_mcdi_vadapter_set_mac(enp)) != 0) {

ERROR:ASSIGN_IN_IF: do not use assignment in if condition
#3900: FILE: drivers/net/sfc/efx/base/ef10_mac.c:147:
+		if ((rc = ef10_mac_reconfigure(enp)) != 0)

ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#3904: FILE: drivers/net/sfc/efx/base/ef10_mac.c:151:
+	return (0);

ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#3912: FILE: drivers/net/sfc/efx/base/ef10_mac.c:159:
+	return (rc);

CHECK:SPACING: No space is necessary after a cast
#3925: FILE: drivers/net/sfc/efx/base/ef10_mac.c:172:
+	(void) memset(payload, 0, sizeof (payload));

WARNING:SPACING: space prohibited between function name and open parenthesis '('
#3925: FILE: drivers/net/sfc/efx/base/ef10_mac.c:172:
+	(void) memset(payload, 0, sizeof (payload));

ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#3944: FILE: drivers/net/sfc/efx/base/ef10_mac.c:191:
+	return (0);

ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#3949: FILE: drivers/net/sfc/efx/base/ef10_mac.c:196:
+	return (rc);

CHECK:SPACING: No space is necessary after a cast
#3962: FILE: drivers/net/sfc/efx/base/ef10_mac.c:209:
+	(void) memset(payload, 0, sizeof (payload));

WARNING:SPACING: space prohibited between function name and open parenthesis '('
#3962: FILE: drivers/net/sfc/efx/base/ef10_mac.c:209:
+	(void) memset(payload, 0, sizeof (payload));

ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#3989: FILE: drivers/net/sfc/efx/base/ef10_mac.c:236:
+	return (0);

ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#3996: FILE: drivers/net/sfc/efx/base/ef10_mac.c:243:
+	return (rc);

CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around enp->en_port
#4003: FILE: drivers/net/sfc/efx/base/ef10_mac.c:250:
+	efx_port_t *epp = &(enp->en_port);

CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around enp->en_nic_cfg
#4004: FILE: drivers/net/sfc/efx/base/ef10_mac.c:251:
+	efx_nic_cfg_t *encp = &(enp->en_nic_cfg);

ERROR:ASSIGN_IN_IF: do not use assignment in if condition
#4008: FILE: drivers/net/sfc/efx/base/ef10_mac.c:255:
+		if ((rc = efx_mcdi_mtu_set(enp, epp->ep_mac_pdu)) != 0)

ERROR:ASSIGN_IN_IF: do not use assignment in if condition
#4016: FILE: drivers/net/sfc/efx/base/ef10_mac.c:263:
+		if ((rc = ef10_mac_reconfigure(enp)) != 0)

ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#4020: FILE: drivers/net/sfc/efx/base/ef10_mac.c:267:
+	return (0);

ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#4027: FILE: drivers/net/sfc/efx/base/ef10_mac.c:274:
+	return (rc);

ERROR:ASSIGN_IN_IF: do not use assignment in if condition
#4037: FILE: drivers/net/sfc/efx/base/ef10_mac.c:284:
+	if ((rc = efx_mcdi_mtu_get(enp, pdu)) != 0)

ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#4040: FILE: drivers/net/sfc/efx/base/ef10_mac.c:287:
+	return (0);

ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#4045: FILE: drivers/net/sfc/efx/base/ef10_mac.c:292:
+	return (rc);

CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around enp->en_port
#4052: FILE: drivers/net/sfc/efx/base/ef10_mac.c:299:
+	efx_port_t *epp = &(enp->en_port);

CHECK:SPACING: No space is necessary after a cast
#4058: FILE: drivers/net/sfc/efx/base/ef10_mac.c:305:
+	(void) memset(payload, 0, sizeof (payload));

WARNING:SPACING: space prohibited between function name and open parenthesis '('
#4058: FILE: drivers/net/sfc/efx/base/ef10_mac.c:305:
+	(void) memset(payload, 0, sizeof (payload));

ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#4119: FILE: drivers/net/sfc/efx/base/ef10_mac.c:366:
+	return (0);

ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#4124: FILE: drivers/net/sfc/efx/base/ef10_mac.c:371:
+	return (rc);

CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around enp->en_port
#4131: FILE: drivers/net/sfc/efx/base/ef10_mac.c:378:
+	efx_port_t *epp = &(enp->en_port);

ERROR:ASSIGN_IN_IF: do not use assignment in if condition
#4138: FILE: drivers/net/sfc/efx/base/ef10_mac.c:385:
+	if ((rc = emop->emo_reconfigure(enp)) != 0)

ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#4141: FILE: drivers/net/sfc/efx/base/ef10_mac.c:388:
+	return (0);

ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#4146: FILE: drivers/net/sfc/efx/base/ef10_mac.c:393:
+	return (rc);

CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around enp->en_port
#4155: FILE: drivers/net/sfc/efx/base/ef10_mac.c:402:
+	efx_port_t *epp = &(enp->en_port);

ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#4173: FILE: drivers/net/sfc/efx/base/ef10_mac.c:420:
+	return (0);

ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#4180: FILE: drivers/net/sfc/efx/base/ef10_mac.c:427:
+	return (rc);

CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around enp->en_port
#4187: FILE: drivers/net/sfc/efx/base/ef10_mac.c:434:
+	efx_port_t *epp = &(enp->en_port);

CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around enp->en_mcdi.em_emip
#4254: FILE: drivers/net/sfc/efx/base/ef10_mcdi.c:49:
+	efx_mcdi_iface_t *emip = &(enp->en_mcdi.em_emip);

CHECK:SPACING: No space is necessary after a cast
#4289: FILE: drivers/net/sfc/efx/base/ef10_mcdi.c:84:
+	(void) ef10_mcdi_poll_reboot(enp);

ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#4294: FILE: drivers/net/sfc/efx/base/ef10_mcdi.c:89:
+	return (0);

ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#4301: FILE: drivers/net/sfc/efx/base/ef10_mcdi.c:96:
+	return (rc);

CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around enp->en_mcdi.em_emip
#4308: FILE: drivers/net/sfc/efx/base/ef10_mcdi.c:103:
+	efx_mcdi_iface_t *emip = &(enp->en_mcdi.em_emip);

CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around enp->en_nic_cfg
#4331: FILE: drivers/net/sfc/efx/base/ef10_mcdi.c:126:
+	efx_nic_cfg_t *encp = &(enp->en_nic_cfg);

WARNING:SPACING: space prohibited between function name and open parenthesis '('
#4370: FILE: drivers/net/sfc/efx/base/ef10_mcdi.c:165:
+	for (pos = 0; pos < hdr_len; pos += sizeof (efx_dword_t)) {

WARNING:SPACING: space prohibited between function name and open parenthesis '('
#4376: FILE: drivers/net/sfc/efx/base/ef10_mcdi.c:171:
+	for (pos = 0; pos < sdu_len; pos += sizeof (efx_dword_t)) {

ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#4406: FILE: drivers/net/sfc/efx/base/ef10_mcdi.c:201:
+	return (EFX_DWORD_FIELD(hdr, MCDI_HEADER_RESPONSE) ? B_TRUE : B_FALSE);

WARNING:SPACING: space prohibited between function name and open parenthesis '('
#4421: FILE: drivers/net/sfc/efx/base/ef10_mcdi.c:216:
+	for (pos = 0; pos < length; pos += sizeof (efx_dword_t)) {

WARNING:SPACING: space prohibited between function name and open parenthesis '('
#4424: FILE: drivers/net/sfc/efx/base/ef10_mcdi.c:219:
+		    MIN(sizeof (data), length - pos));

CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around enp->en_mcdi.em_emip
#4432: FILE: drivers/net/sfc/efx/base/ef10_mcdi.c:227:
+	efx_mcdi_iface_t *emip = &(enp->en_mcdi.em_emip);

ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#4467: FILE: drivers/net/sfc/efx/base/ef10_mcdi.c:262:
+	return (0);

ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#4472: FILE: drivers/net/sfc/efx/base/ef10_mcdi.c:267:
+	return (rc);

CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around enp->en_nic_cfg
#4481: FILE: drivers/net/sfc/efx/base/ef10_mcdi.c:276:
+	efx_nic_cfg_t *encp = &(enp->en_nic_cfg);

ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#4537: FILE: drivers/net/sfc/efx/base/ef10_mcdi.c:332:
+	return (0);

ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#4542: FILE: drivers/net/sfc/efx/base/ef10_mcdi.c:337:
+	return (rc);

CHECK:SPACING: No space is necessary after a cast
#4604: FILE: drivers/net/sfc/efx/base/ef10_nic.c:51:
+	(void) memset(payload, 0, sizeof (payload));

WARNING:SPACING: space prohibited between function name and open parenthesis '('
#4604: FILE: drivers/net/sfc/efx/base/ef10_nic.c:51:
+	(void) memset(payload, 0, sizeof (payload));

ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#4625: FILE: drivers/net/sfc/efx/base/ef10_nic.c:72:
+	return (0);

ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#4632: FILE: drivers/net/sfc/efx/base/ef10_nic.c:79:
+	return (rc);

CHECK:SPACING: No space is necessary after a cast
#4649: FILE: drivers/net/sfc/efx/base/ef10_nic.c:96:
+	(void) memset(payload, 0, sizeof (payload));

WARNING:SPACING: space prohibited between function name and open parenthesis '('
#4649: FILE: drivers/net/sfc/efx/base/ef10_nic.c:96:
+	(void) memset(payload, 0, sizeof (payload));

ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#4685: FILE: drivers/net/sfc/efx/base/ef10_nic.c:132:
+	return (0);

ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#4694: FILE: drivers/net/sfc/efx/base/ef10_nic.c:141:
+	return (rc);

ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#4735: FILE: drivers/net/sfc/efx/base/ef10_nic.c:182:
+	return (0);

ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#4740: FILE: drivers/net/sfc/efx/base/ef10_nic.c:187:
+	return (rc);

CHECK:SPACING: No space is necessary after a cast
#4755: FILE: drivers/net/sfc/efx/base/ef10_nic.c:202:
+	(void) memset(payload, 0, sizeof (payload));

WARNING:SPACING: space prohibited between function name and open parenthesis '('
#4755: FILE: drivers/net/sfc/efx/base/ef10_nic.c:202:
+	(void) memset(payload, 0, sizeof (payload));

ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#4774: FILE: drivers/net/sfc/efx/base/ef10_nic.c:221:
+	return (0);

ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#4779: FILE: drivers/net/sfc/efx/base/ef10_nic.c:226:
+	return (rc);

CHECK:SPACING: No space is necessary after a cast
#4792: FILE: drivers/net/sfc/efx/base/ef10_nic.c:239:
+	(void) memset(payload, 0, sizeof (payload));

WARNING:SPACING: space prohibited between function name and open parenthesis '('
#4792: FILE: drivers/net/sfc/efx/base/ef10_nic.c:239:
+	(void) memset(payload, 0, sizeof (payload));

ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#4808: FILE: drivers/net/sfc/efx/base/ef10_nic.c:255:
+	return (0);

ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#4813: FILE: drivers/net/sfc/efx/base/ef10_nic.c:260:
+	return (rc);

CHECK:SPACING: No space is necessary after a cast
#4829: FILE: drivers/net/sfc/efx/base/ef10_nic.c:276:
+	(void) memset(payload, 0, sizeof (payload));

WARNING:SPACING: space prohibited between function name and open parenthesis '('
#4829: FILE: drivers/net/sfc/efx/base/ef10_nic.c:276:
+	(void) memset(payload, 0, sizeof (payload));

ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#4862: FILE: drivers/net/sfc/efx/base/ef10_nic.c:309:
+	return (0);

ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#4871: FILE: drivers/net/sfc/efx/base/ef10_nic.c:318:
+	return (rc);

CHECK:SPACING: No space is necessary after a cast
#4887: FILE: drivers/net/sfc/efx/base/ef10_nic.c:334:
+	(void) memset(payload, 0, sizeof (payload));

WARNING:SPACING: space prohibited between function name and open parenthesis '('
#4887: FILE: drivers/net/sfc/efx/base/ef10_nic.c:334:
+	(void) memset(payload, 0, sizeof (payload));

ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#4925: FILE: drivers/net/sfc/efx/base/ef10_nic.c:372:
+	return (0);

ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#4934: FILE: drivers/net/sfc/efx/base/ef10_nic.c:381:
+	return (rc);

CHECK:SPACING: No space is necessary after a cast
#4951: FILE: drivers/net/sfc/efx/base/ef10_nic.c:398:
+	(void) memset(payload, 0, sizeof (payload));

WARNING:SPACING: space prohibited between function name and open parenthesis '('
#4951: FILE: drivers/net/sfc/efx/base/ef10_nic.c:398:
+	(void) memset(payload, 0, sizeof (payload));

ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#4981: FILE: drivers/net/sfc/efx/base/ef10_nic.c:428:
+	return (0);

ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#4992: FILE: drivers/net/sfc/efx/base/ef10_nic.c:439:
+	return (rc);

CHECK:SPACING: No space is necessary after a cast
#5007: FILE: drivers/net/sfc/efx/base/ef10_nic.c:454:
+	(void) memset(payload, 0, sizeof (payload));

WARNING:SPACING: space prohibited between function name and open parenthesis '('
#5007: FILE: drivers/net/sfc/efx/base/ef10_nic.c:454:
+	(void) memset(payload, 0, sizeof (payload));

ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#5033: FILE: drivers/net/sfc/efx/base/ef10_nic.c:480:
+	return (0);

ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#5040: FILE: drivers/net/sfc/efx/base/ef10_nic.c:487:
+	return (rc);

CHECK:SPACING: No space is necessary after a cast
#5055: FILE: drivers/net/sfc/efx/base/ef10_nic.c:502:
+	(void) memset(payload, 0, sizeof (payload));

WARNING:SPACING: space prohibited between function name and open parenthesis '('
#5055: FILE: drivers/net/sfc/efx/base/ef10_nic.c:502:
+	(void) memset(payload, 0, sizeof (payload));

ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#5085: FILE: drivers/net/sfc/efx/base/ef10_nic.c:532:
+	return (0);

ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#5092: FILE: drivers/net/sfc/efx/base/ef10_nic.c:539:
+	return (rc);

CHECK:SPACING: No space is necessary after a cast
#5115: FILE: drivers/net/sfc/efx/base/ef10_nic.c:562:
+	(void) memset(payload, 0, sizeof (payload));

WARNING:SPACING: space prohibited between function name and open parenthesis '('
#5115: FILE: drivers/net/sfc/efx/base/ef10_nic.c:562:
+	(void) memset(payload, 0, sizeof (payload));

ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#5146: FILE: drivers/net/sfc/efx/base/ef10_nic.c:593:
+	return (0);

ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#5155: FILE: drivers/net/sfc/efx/base/ef10_nic.c:602:
+	return (rc);

ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#5183: FILE: drivers/net/sfc/efx/base/ef10_nic.c:630:
+	return (0);

ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#5188: FILE: drivers/net/sfc/efx/base/ef10_nic.c:635:
+	return (rc);

CHECK:SPACING: No space is necessary after a cast
#5207: FILE: drivers/net/sfc/efx/base/ef10_nic.c:654:
+	(void) memset(payload, 0, sizeof (payload));

WARNING:SPACING: space prohibited between function name and open parenthesis '('
#5207: FILE: drivers/net/sfc/efx/base/ef10_nic.c:654:
+	(void) memset(payload, 0, sizeof (payload));

ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#5228: FILE: drivers/net/sfc/efx/base/ef10_nic.c:675:
+	return (0);

ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#5237: FILE: drivers/net/sfc/efx/base/ef10_nic.c:684:
+	return (rc);

CHECK:SPACING: No space is necessary after a cast
#5250: FILE: drivers/net/sfc/efx/base/ef10_nic.c:697:
+	(void) memset(payload, 0, sizeof (payload));

WARNING:SPACING: space prohibited between function name and open parenthesis '('
#5250: FILE: drivers/net/sfc/efx/base/ef10_nic.c:697:
+	(void) memset(payload, 0, sizeof (payload));

ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#5266: FILE: drivers/net/sfc/efx/base/ef10_nic.c:713:
+	return (0);

ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#5271: FILE: drivers/net/sfc/efx/base/ef10_nic.c:718:
+	return (rc);

CHECK:SPACING: No space is necessary after a cast
#5285: FILE: drivers/net/sfc/efx/base/ef10_nic.c:732:
+	(void) memset(payload, 0, sizeof (payload));

WARNING:SPACING: space prohibited between function name and open parenthesis '('
#5285: FILE: drivers/net/sfc/efx/base/ef10_nic.c:732:
+	(void) memset(payload, 0, sizeof (payload));

ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#5302: FILE: drivers/net/sfc/efx/base/ef10_nic.c:749:
+	return (0);

ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#5307: FILE: drivers/net/sfc/efx/base/ef10_nic.c:754:
+	return (rc);

CHECK:SPACING: No space is necessary after a cast
#5320: FILE: drivers/net/sfc/efx/base/ef10_nic.c:767:
+	(void) memset(payload, 0, sizeof (payload));

WARNING:SPACING: space prohibited between function name and open parenthesis '('
#5320: FILE: drivers/net/sfc/efx/base/ef10_nic.c:767:
+	(void) memset(payload, 0, sizeof (payload));

ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#5336: FILE: drivers/net/sfc/efx/base/ef10_nic.c:783:
+	return (0);

ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#5341: FILE: drivers/net/sfc/efx/base/ef10_nic.c:788:
+	return (rc);

WARNING:SPACING: space prohibited between function name and open parenthesis '('
#5433: FILE: drivers/net/sfc/efx/base/ef10_nic.c:880:
+		EFSYS_ASSERT3U(blk_per_buf, <=, (8 * sizeof (*map)));

ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#5451: FILE: drivers/net/sfc/efx/base/ef10_nic.c:898:
+	return (0);

ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#5458: FILE: drivers/net/sfc/efx/base/ef10_nic.c:905:
+	return (rc);

WARNING:SPACING: space prohibited between function name and open parenthesis '('
#5472: FILE: drivers/net/sfc/efx/base/ef10_nic.c:919:
+	    (blknum >= (8 * sizeof (*map)))) {

ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#5484: FILE: drivers/net/sfc/efx/base/ef10_nic.c:931:
+	return (0);

ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#5491: FILE: drivers/net/sfc/efx/base/ef10_nic.c:938:
+	return (rc);

ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#5500: FILE: drivers/net/sfc/efx/base/ef10_nic.c:947:
+	return (efx_mcdi_link_piobuf(enp, vi_index, handle));

ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#5508: FILE: drivers/net/sfc/efx/base/ef10_nic.c:955:
+	return (efx_mcdi_unlink_piobuf(enp, vi_index));

CHECK:SPACING: No space is necessary after a cast
#5521: FILE: drivers/net/sfc/efx/base/ef10_nic.c:968:
+	(void) memset(payload, 0, sizeof (payload));

WARNING:SPACING: space prohibited between function name and open parenthesis '('
#5521: FILE: drivers/net/sfc/efx/base/ef10_nic.c:968:
+	(void) memset(payload, 0, sizeof (payload));

ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#5545: FILE: drivers/net/sfc/efx/base/ef10_nic.c:992:
+	return (0);

ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#5552: FILE: drivers/net/sfc/efx/base/ef10_nic.c:999:
+	return (rc);

CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around enp->en_nic_cfg
#5559: FILE: drivers/net/sfc/efx/base/ef10_nic.c:1006:
+	efx_nic_cfg_t *encp = &(enp->en_nic_cfg);

ERROR:ASSIGN_IN_IF: do not use assignment in if condition
#5565: FILE: drivers/net/sfc/efx/base/ef10_nic.c:1012:
+	if ((rc = efx_mcdi_get_capabilities(enp, &flags, &flags2,

ERROR:ASSIGN_IN_IF: do not use assignment in if condition
#5569: FILE: drivers/net/sfc/efx/base/ef10_nic.c:1016:
+	if ((rc = ef10_mcdi_get_pf_count(enp, &encp->enc_hw_pf_count)) != 0)

ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#5681: FILE: drivers/net/sfc/efx/base/ef10_nic.c:1128:
+	return (0);

ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#5688: FILE: drivers/net/sfc/efx/base/ef10_nic.c:1135:
+	return (rc);

CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around enp->en_nic_cfg
#5713: FILE: drivers/net/sfc/efx/base/ef10_nic.c:1160:
+	efx_nic_cfg_t *encp = &(enp->en_nic_cfg);

ERROR:ASSIGN_IN_IF: do not use assignment in if condition
#5717: FILE: drivers/net/sfc/efx/base/ef10_nic.c:1164:
+	if ((rc = efx_mcdi_privilege_mask(enp, encp->enc_pf, encp->enc_vf,

ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#5734: FILE: drivers/net/sfc/efx/base/ef10_nic.c:1181:
+	return (0);

ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#5739: FILE: drivers/net/sfc/efx/base/ef10_nic.c:1186:
+	return (rc);

ERROR:ASSIGN_IN_IF: do not use assignment in if condition
#5829: FILE: drivers/net/sfc/efx/base/ef10_nic.c:1276:
+	if ((rc = efx_mcdi_get_port_modes(enp, &port_modes, &current)) != 0) {

ERROR:ASSIGN_IN_IF: do not use assignment in if condition
#5834: FILE: drivers/net/sfc/efx/base/ef10_nic.c:1281:
+		if ((rc = efx_mcdi_get_port_modes(enp,

ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#5876: FILE: drivers/net/sfc/efx/base/ef10_nic.c:1323:
+	return (0);

ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#5881: FILE: drivers/net/sfc/efx/base/ef10_nic.c:1328:
+	return (rc);

CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around enp->en_nic_cfg
#5890: FILE: drivers/net/sfc/efx/base/ef10_nic.c:1337:
+	efx_nic_cfg_t *encp = &(enp->en_nic_cfg);

CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around enp->en_drv_cfg
#5891: FILE: drivers/net/sfc/efx/base/ef10_nic.c:1338:
+	efx_drv_cfg_t *edcp = &(enp->en_drv_cfg);

ERROR:ASSIGN_IN_IF: do not use assignment in if condition
#5898: FILE: drivers/net/sfc/efx/base/ef10_nic.c:1345:
+	if ((rc = efx_mcdi_read_assertion(enp)) != 0)

ERROR:ASSIGN_IN_IF: do not use assignment in if condition
#5902: FILE: drivers/net/sfc/efx/base/ef10_nic.c:1349:
+	if ((rc = efx_mcdi_exit_assertion_handler(enp)) != 0)

ERROR:ASSIGN_IN_IF: do not use assignment in if condition
#5906: FILE: drivers/net/sfc/efx/base/ef10_nic.c:1353:
+	if ((rc = efx_mcdi_drv_attach(enp, B_TRUE)) != 0)

ERROR:ASSIGN_IN_IF: do not use assignment in if condition
#5909: FILE: drivers/net/sfc/efx/base/ef10_nic.c:1356:
+	if ((rc = enop->eno_board_cfg(enp)) != 0)

CHECK:MULTIPLE_ASSIGNMENTS: multiple assignments should be avoided
#5920: FILE: drivers/net/sfc/efx/base/ef10_nic.c:1367:
+	edcp->edc_min_vi_count = edcp->edc_max_vi_count =

ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#5929: FILE: drivers/net/sfc/efx/base/ef10_nic.c:1376:
+	return (0);

ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#5940: FILE: drivers/net/sfc/efx/base/ef10_nic.c:1387:
+	return (rc);

CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around enp->en_nic_cfg
#5948: FILE: drivers/net/sfc/efx/base/ef10_nic.c:1395:
+	efx_nic_cfg_t *encp = &(enp->en_nic_cfg);

CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around enp->en_drv_cfg
#5949: FILE: drivers/net/sfc/efx/base/ef10_nic.c:1396:
+	efx_drv_cfg_t *edcp = &(enp->en_drv_cfg);

ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#6009: FILE: drivers/net/sfc/efx/base/ef10_nic.c:1456:
+	return (0);

ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#6014: FILE: drivers/net/sfc/efx/base/ef10_nic.c:1461:
+	return (rc);

ERROR:ASSIGN_IN_IF: do not use assignment in if condition
#6028: FILE: drivers/net/sfc/efx/base/ef10_nic.c:1475:
+	if ((rc = efx_mcdi_read_assertion(enp)) != 0)

ERROR:ASSIGN_IN_IF: do not use assignment in if condition
#6030: FILE: drivers/net/sfc/efx/base/ef10_nic.c:1477:
+	if ((rc = efx_mcdi_exit_assertion_handler(enp)) != 0)

CHECK:SPACING: No space is necessary after a cast
#6033: FILE: drivers/net/sfc/efx/base/ef10_nic.c:1480:
+	(void) memset(payload, 0, sizeof (payload));

WARNING:SPACING: space prohibited between function name and open parenthesis '('
#6033: FILE: drivers/net/sfc/efx/base/ef10_nic.c:1480:
+	(void) memset(payload, 0, sizeof (payload));

ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#6053: FILE: drivers/net/sfc/efx/base/ef10_nic.c:1500:
+	return (0);

ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#6062: FILE: drivers/net/sfc/efx/base/ef10_nic.c:1509:
+	return (rc);

CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around enp->en_drv_cfg
#6069: FILE: drivers/net/sfc/efx/base/ef10_nic.c:1516:
+	efx_drv_cfg_t *edcp = &(enp->en_drv_cfg);

ERROR:ASSIGN_IN_IF: do not use assignment in if condition
#6081: FILE: drivers/net/sfc/efx/base/ef10_nic.c:1528:
+	if ((rc = efx_mcdi_log_ctrl(enp)) != 0)

ERROR:ASSIGN_IN_IF: do not use assignment in if condition
#6105: FILE: drivers/net/sfc/efx/base/ef10_nic.c:1552:
+	if ((rc = efx_mcdi_free_vis(enp)) != 0)

ERROR:ASSIGN_IN_IF: do not use assignment in if condition
#6113: FILE: drivers/net/sfc/efx/base/ef10_nic.c:1560:
+	if ((rc = efx_mcdi_alloc_vis(enp, min_vi_count, max_vi_count,

ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#6207: FILE: drivers/net/sfc/efx/base/ef10_nic.c:1654:
+	return (0);

ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#6225: FILE: drivers/net/sfc/efx/base/ef10_nic.c:1672:
+	return (rc);

ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#6242: FILE: drivers/net/sfc/efx/base/ef10_nic.c:1689:
+	return (0);

ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#6280: FILE: drivers/net/sfc/efx/base/ef10_nic.c:1727:
+	return (0);

ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#6285: FILE: drivers/net/sfc/efx/base/ef10_nic.c:1732:
+	return (rc);

CHECK:SPACING: No space is necessary after a cast
#6295: FILE: drivers/net/sfc/efx/base/ef10_nic.c:1742:
+	(void) efx_mcdi_vadaptor_free(enp, enp->en_vport_id);

CHECK:SPACING: No space is necessary after a cast
#6310: FILE: drivers/net/sfc/efx/base/ef10_nic.c:1757:
+	(void) efx_mcdi_free_vis(enp);

CHECK:SPACING: No space is necessary after a cast
#6318: FILE: drivers/net/sfc/efx/base/ef10_nic.c:1765:
+	(void) efx_mcdi_drv_attach(enp, B_FALSE);

CHECK:BRACES: braces {} should be used on all arms of this statement
#6429: FILE: drivers/net/sfc/efx/base/ef10_phy.c:101:
+	if (fcntl == MC_CMD_FCNTL_OFF)
[...]
+	else if (fcntl == MC_CMD_FCNTL_RESPOND)
[...]
+	else if (fcntl == MC_CMD_FCNTL_GENERATE)
[...]
+	else if (fcntl == MC_CMD_FCNTL_BIDIR)
[...]
+	else {
[...]

CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around enp->en_port
#6450: FILE: drivers/net/sfc/efx/base/ef10_phy.c:122:
+	efx_port_t *epp = &(enp->en_port);

ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#6511: FILE: drivers/net/sfc/efx/base/ef10_phy.c:183:
+		return (0);

ERROR:ASSIGN_IN_IF: do not use assignment in if condition
#6514: FILE: drivers/net/sfc/efx/base/ef10_phy.c:186:
+	if ((rc = ef10_phy_verify(enp)) != 0)

ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#6519: FILE: drivers/net/sfc/efx/base/ef10_phy.c:191:
+	return (0);

ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#6524: FILE: drivers/net/sfc/efx/base/ef10_phy.c:196:
+	return (rc);

CHECK:SPACING: No space is necessary after a cast
#6537: FILE: drivers/net/sfc/efx/base/ef10_phy.c:209:
+	(void) memset(payload, 0, sizeof (payload));

WARNING:SPACING: space prohibited between function name and open parenthesis '('
#6537: FILE: drivers/net/sfc/efx/base/ef10_phy.c:209:
+	(void) memset(payload, 0, sizeof (payload));

ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#6568: FILE: drivers/net/sfc/efx/base/ef10_phy.c:240:
+	return (0);

ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#6575: FILE: drivers/net/sfc/efx/base/ef10_phy.c:247:
+	return (rc);

CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around enp->en_port
#6582: FILE: drivers/net/sfc/efx/base/ef10_phy.c:254:
+	efx_port_t *epp = &(enp->en_port);

ERROR:ASSIGN_IN_IF: do not use assignment in if condition
#6592: FILE: drivers/net/sfc/efx/base/ef10_phy.c:264:
+	if ((rc = efx_mcdi_link_control_supported(enp, &supported)) != 0)

CHECK:SPACING: No space is necessary after a cast
#6597: FILE: drivers/net/sfc/efx/base/ef10_phy.c:269:
+	(void) memset(payload, 0, sizeof (payload));

WARNING:SPACING: space prohibited between function name and open parenthesis '('
#6597: FILE: drivers/net/sfc/efx/base/ef10_phy.c:269:
+	(void) memset(payload, 0, sizeof (payload));

CHECK:SPACING: No space is necessary after a cast
#6634: FILE: drivers/net/sfc/efx/base/ef10_phy.c:306:
+	(void) memset(payload, 0, sizeof (payload));

WARNING:SPACING: space prohibited between function name and open parenthesis '('
#6634: FILE: drivers/net/sfc/efx/base/ef10_phy.c:306:
+	(void) memset(payload, 0, sizeof (payload));

ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#6650: FILE: drivers/net/sfc/efx/base/ef10_phy.c:322:
+	return (0);

ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#6659: FILE: drivers/net/sfc/efx/base/ef10_phy.c:331:
+	return (rc);

CHECK:SPACING: No space is necessary after a cast
#6672: FILE: drivers/net/sfc/efx/base/ef10_phy.c:344:
+	(void) memset(payload, 0, sizeof (payload));

WARNING:SPACING: space prohibited between function name and open parenthesis '('
#6672: FILE: drivers/net/sfc/efx/base/ef10_phy.c:344:
+	(void) memset(payload, 0, sizeof (payload));

ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#6699: FILE: drivers/net/sfc/efx/base/ef10_phy.c:371:
+	return (0);

ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#6708: FILE: drivers/net/sfc/efx/base/ef10_phy.c:380:
+	return (rc);

ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#6718: FILE: drivers/net/sfc/efx/base/ef10_phy.c:390:
+	return (ENOTSUP);

WARNING:USE_NEGATIVE_ERRNO: return of an errno should typically be negative (ie: return -ENOTSUP)
#6718: FILE: drivers/net/sfc/efx/base/ef10_phy.c:390:
+	return (ENOTSUP);

CHECK:SPACING: No space is necessary after a cast
#6795: FILE: drivers/net/sfc/efx/base/ef10_rx.c:68:
+	(void) memset(payload, 0, sizeof (payload));

WARNING:SPACING: space prohibited between function name and open parenthesis '('
#6795: FILE: drivers/net/sfc/efx/base/ef10_rx.c:68:
+	(void) memset(payload, 0, sizeof (payload));

ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#6838: FILE: drivers/net/sfc/efx/base/ef10_rx.c:111:
+	return (0);

ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#6843: FILE: drivers/net/sfc/efx/base/ef10_rx.c:116:
+	return (rc);

CHECK:SPACING: No space is necessary after a cast
#6856: FILE: drivers/net/sfc/efx/base/ef10_rx.c:129:
+	(void) memset(payload, 0, sizeof (payload));

WARNING:SPACING: space prohibited between function name and open parenthesis '('
#6856: FILE: drivers/net/sfc/efx/base/ef10_rx.c:129:
+	(void) memset(payload, 0, sizeof (payload));

ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#6872: FILE: drivers/net/sfc/efx/base/ef10_rx.c:145:
+	return (0);

ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#6877: FILE: drivers/net/sfc/efx/base/ef10_rx.c:150:
+	return (rc);

CHECK:BRACES: Blank lines aren't necessary after an open brace '{'
#6885: FILE: drivers/net/sfc/efx/base/ef10_rx.c:158:
+{
+

ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#6886: FILE: drivers/net/sfc/efx/base/ef10_rx.c:159:
+	return (0);

CHECK:SPACING: spaces preferred around that '*' (ctx:ExV)
#6925: FILE: drivers/net/sfc/efx/base/ef10_rx.c:198:
+	*lengthp = buffer[8] | (buffer[9] << 8);
 	^

ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#6926: FILE: drivers/net/sfc/efx/base/ef10_rx.c:199:
+	return (0);

CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around erp->er_mask
#6947: FILE: drivers/net/sfc/efx/base/ef10_rx.c:220:
+	id = added & (erp->er_mask);

WARNING:SPACING: space prohibited between function name and open parenthesis '('
#6960: FILE: drivers/net/sfc/efx/base/ef10_rx.c:233:
+		offset = id * sizeof (efx_qword_t);

CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around erp->er_mask
#6963: FILE: drivers/net/sfc/efx/base/ef10_rx.c:236:
+		id = (id + 1) & (erp->er_mask);

ERROR:ASSIGN_IN_IF: do not use assignment in if condition
#7005: FILE: drivers/net/sfc/efx/base/ef10_rx.c:278:
+	if ((rc = efx_mcdi_fini_rxq(enp, erp->er_index)) != 0)

ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#7008: FILE: drivers/net/sfc/efx/base/ef10_rx.c:281:
+	return (0);

ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#7013: FILE: drivers/net/sfc/efx/base/ef10_rx.c:286:
+	return (rc);

CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around enp->en_nic_cfg
#7037: FILE: drivers/net/sfc/efx/base/ef10_rx.c:310:
+	efx_nic_cfg_t *encp = &(enp->en_nic_cfg);

ERROR:ASSIGN_IN_IF: do not use assignment in if condition
#7078: FILE: drivers/net/sfc/efx/base/ef10_rx.c:351:
+	if ((rc = efx_mcdi_init_rxq(enp, n, eep->ee_index, label, index,

ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#7087: FILE: drivers/net/sfc/efx/base/ef10_rx.c:360:
+	return (0);

ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#7098: FILE: drivers/net/sfc/efx/base/ef10_rx.c:371:
+	return (rc);

WARNING:SPACING: space prohibited between function name and open parenthesis '('
#7114: FILE: drivers/net/sfc/efx/base/ef10_rx.c:387:
+	EFSYS_KMEM_FREE(enp->en_esip, sizeof (efx_rxq_t), erp);

WARNING:BLOCK_COMMENT_STYLE: Block comments should align the * on each line
#7132: FILE: drivers/net/sfc/efx/base/ef10_tlv_layout.h:2:
+/**************************************************************************\
+*//*! ile

WARNING:BLOCK_COMMENT_STYLE: Block comments use * on subsequent lines
#7140: FILE: drivers/net/sfc/efx/base/ef10_tlv_layout.h:10:
+*//*
+\**************************************************************************/

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#7224: FILE: drivers/net/sfc/efx/base/ef10_tlv_layout.h:94:
+  uint32_t tag;$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#7225: FILE: drivers/net/sfc/efx/base/ef10_tlv_layout.h:95:
+  uint32_t length;$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#7226: FILE: drivers/net/sfc/efx/base/ef10_tlv_layout.h:96:
+  uint16_t type_id;$

WARNING:BLOCK_COMMENT_STYLE: Block comments use a trailing */ on a separate line
#7230: FILE: drivers/net/sfc/efx/base/ef10_tlv_layout.h:100:
+ * selected through an RFID command and copied by FW to the location at offset 0. */

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#7231: FILE: drivers/net/sfc/efx/base/ef10_tlv_layout.h:101:
+  uint16_t preset;$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#7232: FILE: drivers/net/sfc/efx/base/ef10_tlv_layout.h:102:
+  uint32_t generation;$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#7233: FILE: drivers/net/sfc/efx/base/ef10_tlv_layout.h:103:
+  uint32_t total_length;$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#7246: FILE: drivers/net/sfc/efx/base/ef10_tlv_layout.h:116:
+  uint32_t tag;$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#7247: FILE: drivers/net/sfc/efx/base/ef10_tlv_layout.h:117:
+  uint32_t length;$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#7248: FILE: drivers/net/sfc/efx/base/ef10_tlv_layout.h:118:
+  uint32_t generation;$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#7249: FILE: drivers/net/sfc/efx/base/ef10_tlv_layout.h:119:
+  uint32_t checksum;$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#7263: FILE: drivers/net/sfc/efx/base/ef10_tlv_layout.h:133:
+  uint32_t tag;$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#7264: FILE: drivers/net/sfc/efx/base/ef10_tlv_layout.h:134:
+  uint32_t length;$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#7265: FILE: drivers/net/sfc/efx/base/ef10_tlv_layout.h:135:
+  uint16_t type_id;$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#7266: FILE: drivers/net/sfc/efx/base/ef10_tlv_layout.h:136:
+  uint16_t reserved;$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#7282: FILE: drivers/net/sfc/efx/base/ef10_tlv_layout.h:152:
+  uint32_t tag;$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#7283: FILE: drivers/net/sfc/efx/base/ef10_tlv_layout.h:153:
+  uint32_t length;$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#7284: FILE: drivers/net/sfc/efx/base/ef10_tlv_layout.h:154:
+  uint32_t flags;$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#7300: FILE: drivers/net/sfc/efx/base/ef10_tlv_layout.h:170:
+  uint32_t tag;$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#7301: FILE: drivers/net/sfc/efx/base/ef10_tlv_layout.h:171:
+  uint32_t length;$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#7302: FILE: drivers/net/sfc/efx/base/ef10_tlv_layout.h:172:
+  uint8_t  base_address[6];$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#7303: FILE: drivers/net/sfc/efx/base/ef10_tlv_layout.h:173:
+  uint16_t reserved;$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#7304: FILE: drivers/net/sfc/efx/base/ef10_tlv_layout.h:174:
+  uint16_t count;$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#7305: FILE: drivers/net/sfc/efx/base/ef10_tlv_layout.h:175:
+  uint16_t stride;$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#7320: FILE: drivers/net/sfc/efx/base/ef10_tlv_layout.h:190:
+  uint32_t tag;$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#7321: FILE: drivers/net/sfc/efx/base/ef10_tlv_layout.h:191:
+  uint32_t length;$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#7322: FILE: drivers/net/sfc/efx/base/ef10_tlv_layout.h:192:
+  uint8_t  bytes[];$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#7328: FILE: drivers/net/sfc/efx/base/ef10_tlv_layout.h:198:
+  uint32_t tag;$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#7329: FILE: drivers/net/sfc/efx/base/ef10_tlv_layout.h:199:
+  uint32_t length;$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#7330: FILE: drivers/net/sfc/efx/base/ef10_tlv_layout.h:200:
+  uint8_t  bytes[];$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#7345: FILE: drivers/net/sfc/efx/base/ef10_tlv_layout.h:215:
+  uint32_t tag;$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#7346: FILE: drivers/net/sfc/efx/base/ef10_tlv_layout.h:216:
+  uint32_t length;$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#7347: FILE: drivers/net/sfc/efx/base/ef10_tlv_layout.h:217:
+  uint8_t  bytes[];$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#7353: FILE: drivers/net/sfc/efx/base/ef10_tlv_layout.h:223:
+  uint32_t tag;$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#7354: FILE: drivers/net/sfc/efx/base/ef10_tlv_layout.h:224:
+  uint32_t length;$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#7355: FILE: drivers/net/sfc/efx/base/ef10_tlv_layout.h:225:
+  uint8_t  bytes[];$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#7370: FILE: drivers/net/sfc/efx/base/ef10_tlv_layout.h:240:
+  uint32_t tag;$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#7371: FILE: drivers/net/sfc/efx/base/ef10_tlv_layout.h:241:
+  uint32_t length;$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#7372: FILE: drivers/net/sfc/efx/base/ef10_tlv_layout.h:242:
+  struct {$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#7373: FILE: drivers/net/sfc/efx/base/ef10_tlv_layout.h:243:
+    uint16_t addr;$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#7374: FILE: drivers/net/sfc/efx/base/ef10_tlv_layout.h:244:
+    uint16_t byte_enables;$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#7375: FILE: drivers/net/sfc/efx/base/ef10_tlv_layout.h:245:
+    uint32_t value;$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#7376: FILE: drivers/net/sfc/efx/base/ef10_tlv_layout.h:246:
+  } items[];$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#7383: FILE: drivers/net/sfc/efx/base/ef10_tlv_layout.h:253:
+  uint32_t tag;$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#7384: FILE: drivers/net/sfc/efx/base/ef10_tlv_layout.h:254:
+  uint32_t length;$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#7385: FILE: drivers/net/sfc/efx/base/ef10_tlv_layout.h:255:
+  struct {$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#7386: FILE: drivers/net/sfc/efx/base/ef10_tlv_layout.h:256:
+    uint16_t addr;$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#7387: FILE: drivers/net/sfc/efx/base/ef10_tlv_layout.h:257:
+    uint16_t byte_enables;$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#7388: FILE: drivers/net/sfc/efx/base/ef10_tlv_layout.h:258:
+    uint32_t value;$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#7389: FILE: drivers/net/sfc/efx/base/ef10_tlv_layout.h:259:
+  } items[];$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#7407: FILE: drivers/net/sfc/efx/base/ef10_tlv_layout.h:277:
+  uint32_t tag;$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#7408: FILE: drivers/net/sfc/efx/base/ef10_tlv_layout.h:278:
+  uint32_t length;$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#7409: FILE: drivers/net/sfc/efx/base/ef10_tlv_layout.h:279:
+  uint32_t subtype;$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#7410: FILE: drivers/net/sfc/efx/base/ef10_tlv_layout.h:280:
+  uint8_t  description[];$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#7424: FILE: drivers/net/sfc/efx/base/ef10_tlv_layout.h:294:
+  uint32_t tag;$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#7425: FILE: drivers/net/sfc/efx/base/ef10_tlv_layout.h:295:
+  uint32_t length;$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#7426: FILE: drivers/net/sfc/efx/base/ef10_tlv_layout.h:296:
+  uint16_t version_w;$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#7427: FILE: drivers/net/sfc/efx/base/ef10_tlv_layout.h:297:
+  uint16_t version_x;$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#7428: FILE: drivers/net/sfc/efx/base/ef10_tlv_layout.h:298:
+  uint16_t version_y;$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#7429: FILE: drivers/net/sfc/efx/base/ef10_tlv_layout.h:299:
+  uint16_t version_z;$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#7437: FILE: drivers/net/sfc/efx/base/ef10_tlv_layout.h:307:
+  uint32_t tag;$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#7438: FILE: drivers/net/sfc/efx/base/ef10_tlv_layout.h:308:
+  uint32_t length;$

WARNING:LONG_LINE_COMMENT: line over 90 characters
#7439: FILE: drivers/net/sfc/efx/base/ef10_tlv_layout.h:309:
+  int16_t max_pf_number;                        /**< Largest PF RID (lower PFs may be hidden) */

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#7439: FILE: drivers/net/sfc/efx/base/ef10_tlv_layout.h:309:
+  int16_t max_pf_number;                        /**< Largest PF RID (lower PFs may be hidden) */$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#7440: FILE: drivers/net/sfc/efx/base/ef10_tlv_layout.h:310:
+  uint16_t pf_aper;                             /**< BIU aperture for PF BAR2 */$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#7441: FILE: drivers/net/sfc/efx/base/ef10_tlv_layout.h:311:
+  uint16_t vf_aper;                             /**< BIU aperture for VF BAR0 */$

WARNING:LONG_LINE_COMMENT: line over 90 characters
#7442: FILE: drivers/net/sfc/efx/base/ef10_tlv_layout.h:312:
+  uint16_t int_aper;                            /**< BIU aperture for PF BAR4 and VF BAR2 */

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#7442: FILE: drivers/net/sfc/efx/base/ef10_tlv_layout.h:312:
+  uint16_t int_aper;                            /**< BIU aperture for PF BAR4 and VF BAR2 */$

WARNING:BLOCK_COMMENT_STYLE: Block comments use a trailing */ on a separate line
#7450: FILE: drivers/net/sfc/efx/base/ef10_tlv_layout.h:320:
+ * tidy things up later */

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#7455: FILE: drivers/net/sfc/efx/base/ef10_tlv_layout.h:325:
+  uint32_t tag;$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#7456: FILE: drivers/net/sfc/efx/base/ef10_tlv_layout.h:326:
+  uint32_t length;$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#7457: FILE: drivers/net/sfc/efx/base/ef10_tlv_layout.h:327:
+  uint8_t vfs_total;$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#7458: FILE: drivers/net/sfc/efx/base/ef10_tlv_layout.h:328:
+  uint8_t port_allocation;$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#7459: FILE: drivers/net/sfc/efx/base/ef10_tlv_layout.h:329:
+  uint16_t vectors_per_pf;$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#7460: FILE: drivers/net/sfc/efx/base/ef10_tlv_layout.h:330:
+  uint16_t vectors_per_vf;$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#7461: FILE: drivers/net/sfc/efx/base/ef10_tlv_layout.h:331:
+  uint8_t pf_bar0_aperture;$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#7462: FILE: drivers/net/sfc/efx/base/ef10_tlv_layout.h:332:
+  uint8_t pf_bar2_aperture;$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#7463: FILE: drivers/net/sfc/efx/base/ef10_tlv_layout.h:333:
+  uint8_t vf_bar0_aperture;$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#7464: FILE: drivers/net/sfc/efx/base/ef10_tlv_layout.h:334:
+  uint8_t vf_base;$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#7465: FILE: drivers/net/sfc/efx/base/ef10_tlv_layout.h:335:
+  uint16_t supp_pagesz;$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#7466: FILE: drivers/net/sfc/efx/base/ef10_tlv_layout.h:336:
+  uint16_t msix_vec_base;$

WARNING:BLOCK_COMMENT_STYLE: Block comments use a trailing */ on a separate line
#7472: FILE: drivers/net/sfc/efx/base/ef10_tlv_layout.h:342:
+ * settings. This is a temporary measure. */

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#7477: FILE: drivers/net/sfc/efx/base/ef10_tlv_layout.h:347:
+  uint32_t tag;$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#7478: FILE: drivers/net/sfc/efx/base/ef10_tlv_layout.h:348:
+  uint32_t length;$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#7480: FILE: drivers/net/sfc/efx/base/ef10_tlv_layout.h:350:
+  uint64_t tx0_tags;     /* Bitmap */$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#7481: FILE: drivers/net/sfc/efx/base/ef10_tlv_layout.h:351:
+  uint64_t tx1_tags;     /* Bitmap */$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#7482: FILE: drivers/net/sfc/efx/base/ef10_tlv_layout.h:352:
+  uint64_t dl_tags;      /* Bitmap */$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#7483: FILE: drivers/net/sfc/efx/base/ef10_tlv_layout.h:353:
+  uint32_t flags;$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#7490: FILE: drivers/net/sfc/efx/base/ef10_tlv_layout.h:360:
+  uint32_t dut_features;        /* All 1s -> leave alone */$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#7491: FILE: drivers/net/sfc/efx/base/ef10_tlv_layout.h:361:
+  int8_t with_rmon;             /* 0 -> off, 1 -> on, -1 -> leave alone */$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#7493: FILE: drivers/net/sfc/efx/base/ef10_tlv_layout.h:363:
+  int8_t clk_mode;             /* 0 -> off, 1 -> on, -1 -> leave alone */$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#7495: FILE: drivers/net/sfc/efx/base/ef10_tlv_layout.h:365:
+  int8_t rx_dc_size;           /* -1 -> leave alone */$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#7496: FILE: drivers/net/sfc/efx/base/ef10_tlv_layout.h:366:
+  int8_t tx_dc_size;$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#7497: FILE: drivers/net/sfc/efx/base/ef10_tlv_layout.h:367:
+  int16_t num_q_allocs;$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#7508: FILE: drivers/net/sfc/efx/base/ef10_tlv_layout.h:378:
+  uint32_t tag;$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#7509: FILE: drivers/net/sfc/efx/base/ef10_tlv_layout.h:379:
+  uint32_t length;$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#7510: FILE: drivers/net/sfc/efx/base/ef10_tlv_layout.h:380:
+  uint32_t ports_per_core;$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#7511: FILE: drivers/net/sfc/efx/base/ef10_tlv_layout.h:381:
+  uint32_t max_port_speed;$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#7528: FILE: drivers/net/sfc/efx/base/ef10_tlv_layout.h:398:
+  uint32_t tag;$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#7529: FILE: drivers/net/sfc/efx/base/ef10_tlv_layout.h:399:
+  uint32_t length;$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#7530: FILE: drivers/net/sfc/efx/base/ef10_tlv_layout.h:400:
+  uint32_t firmware_variant;$

ERROR:CODE_INDENT: code indent should use tabs where possible
#7543: FILE: drivers/net/sfc/efx/base/ef10_tlv_layout.h:413:
+                                             MC_CMD_FW_PACKED_STREAM_HASH_MODE_1$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#7543: FILE: drivers/net/sfc/efx/base/ef10_tlv_layout.h:413:
+                                             MC_CMD_FW_PACKED_STREAM_HASH_MODE_1$

WARNING:BLOCK_COMMENT_STYLE: Block comments use a trailing */ on a separate line
#7551: FILE: drivers/net/sfc/efx/base/ef10_tlv_layout.h:421:
+ * determined. */

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#7556: FILE: drivers/net/sfc/efx/base/ef10_tlv_layout.h:426:
+  uint32_t tag;$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#7557: FILE: drivers/net/sfc/efx/base/ef10_tlv_layout.h:427:
+  uint32_t length;$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#7558: FILE: drivers/net/sfc/efx/base/ef10_tlv_layout.h:428:
+  uint16_t flags; /* Boards with high 0v9 settings may need active cooling */$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#7560: FILE: drivers/net/sfc/efx/base/ef10_tlv_layout.h:430:
+  uint16_t target_voltage; /* In millivolts */$

WARNING:BLOCK_COMMENT_STYLE: Block comments use a trailing */ on a separate line
#7562: FILE: drivers/net/sfc/efx/base/ef10_tlv_layout.h:432:
+   * contain it) they need setting as well. */

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#7563: FILE: drivers/net/sfc/efx/base/ef10_tlv_layout.h:433:
+  uint16_t warn_low;       /* In millivolts */$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#7564: FILE: drivers/net/sfc/efx/base/ef10_tlv_layout.h:434:
+  uint16_t warn_high;      /* In millivolts */$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#7565: FILE: drivers/net/sfc/efx/base/ef10_tlv_layout.h:435:
+  uint16_t panic_low;      /* In millivolts */$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#7566: FILE: drivers/net/sfc/efx/base/ef10_tlv_layout.h:436:
+  uint16_t panic_high;     /* In millivolts */$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#7576: FILE: drivers/net/sfc/efx/base/ef10_tlv_layout.h:446:
+  uint32_t tag;$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#7577: FILE: drivers/net/sfc/efx/base/ef10_tlv_layout.h:447:
+  uint32_t length;$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#7578: FILE: drivers/net/sfc/efx/base/ef10_tlv_layout.h:448:
+  uint16_t clk_sys;        /* MHz */$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#7579: FILE: drivers/net/sfc/efx/base/ef10_tlv_layout.h:449:
+  uint16_t clk_dpcpu;      /* MHz */$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#7580: FILE: drivers/net/sfc/efx/base/ef10_tlv_layout.h:450:
+  uint16_t clk_icore;      /* MHz */$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#7581: FILE: drivers/net/sfc/efx/base/ef10_tlv_layout.h:451:
+  uint16_t clk_pcs;        /* MHz */$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#7587: FILE: drivers/net/sfc/efx/base/ef10_tlv_layout.h:457:
+  uint32_t tag;$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#7588: FILE: drivers/net/sfc/efx/base/ef10_tlv_layout.h:458:
+  uint32_t length;$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#7589: FILE: drivers/net/sfc/efx/base/ef10_tlv_layout.h:459:
+  uint16_t clk_sys;        /* MHz */$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#7590: FILE: drivers/net/sfc/efx/base/ef10_tlv_layout.h:460:
+  uint16_t clk_mc;         /* MHz */$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#7591: FILE: drivers/net/sfc/efx/base/ef10_tlv_layout.h:461:
+  uint16_t clk_rmon;       /* MHz */$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#7592: FILE: drivers/net/sfc/efx/base/ef10_tlv_layout.h:462:
+  uint16_t clk_vswitch;    /* MHz */$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#7593: FILE: drivers/net/sfc/efx/base/ef10_tlv_layout.h:463:
+  uint16_t clk_dpcpu;      /* MHz */$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#7594: FILE: drivers/net/sfc/efx/base/ef10_tlv_layout.h:464:
+  uint16_t clk_pcs;        /* MHz */$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#7608: FILE: drivers/net/sfc/efx/base/ef10_tlv_layout.h:478:
+  uint32_t tag;$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#7609: FILE: drivers/net/sfc/efx/base/ef10_tlv_layout.h:479:
+  uint32_t length;$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#7610: FILE: drivers/net/sfc/efx/base/ef10_tlv_layout.h:480:
+  uint8_t  base_address[6];$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#7611: FILE: drivers/net/sfc/efx/base/ef10_tlv_layout.h:481:
+  uint16_t reserved1;$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#7612: FILE: drivers/net/sfc/efx/base/ef10_tlv_layout.h:482:
+  uint16_t count;$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#7613: FILE: drivers/net/sfc/efx/base/ef10_tlv_layout.h:483:
+  uint16_t reserved2;$

WARNING:BLOCK_COMMENT_STYLE: Block comments use a trailing */ on a separate line
#7620: FILE: drivers/net/sfc/efx/base/ef10_tlv_layout.h:490:
+ * analogue test bus */

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#7622: FILE: drivers/net/sfc/efx/base/ef10_tlv_layout.h:492:
+  uint32_t tag;$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#7623: FILE: drivers/net/sfc/efx/base/ef10_tlv_layout.h:493:
+  uint32_t length;$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#7624: FILE: drivers/net/sfc/efx/base/ef10_tlv_layout.h:494:
+  uint16_t millivolts;$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#7625: FILE: drivers/net/sfc/efx/base/ef10_tlv_layout.h:495:
+  uint16_t reserved;$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#7631: FILE: drivers/net/sfc/efx/base/ef10_tlv_layout.h:501:
+  uint32_t tag;$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#7632: FILE: drivers/net/sfc/efx/base/ef10_tlv_layout.h:502:
+  uint32_t length;$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#7633: FILE: drivers/net/sfc/efx/base/ef10_tlv_layout.h:503:
+  uint8_t quad_tx_imp2k[4];$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#7634: FILE: drivers/net/sfc/efx/base/ef10_tlv_layout.h:504:
+  uint8_t quad_tx_imp50[4];$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#7635: FILE: drivers/net/sfc/efx/base/ef10_tlv_layout.h:505:
+  uint8_t lane_amp[16];$

WARNING:BLOCK_COMMENT_STYLE: Block comments use a trailing */ on a separate line
#7643: FILE: drivers/net/sfc/efx/base/ef10_tlv_layout.h:513:
+ * the old tag will be left in the firmware indefinitely).  */

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#7648: FILE: drivers/net/sfc/efx/base/ef10_tlv_layout.h:518:
+  uint32_t tag;$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#7649: FILE: drivers/net/sfc/efx/base/ef10_tlv_layout.h:519:
+  uint32_t length;$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#7650: FILE: drivers/net/sfc/efx/base/ef10_tlv_layout.h:520:
+  uint16_t visible_pfs;                         /**< Bitmap of visible PFs */$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#7651: FILE: drivers/net/sfc/efx/base/ef10_tlv_layout.h:521:
+  uint16_t pf_aper;                             /**< BIU aperture for PF BAR2 */$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#7652: FILE: drivers/net/sfc/efx/base/ef10_tlv_layout.h:522:
+  uint16_t vf_aper;                             /**< BIU aperture for VF BAR0 */$

WARNING:LONG_LINE_COMMENT: line over 90 characters
#7653: FILE: drivers/net/sfc/efx/base/ef10_tlv_layout.h:523:
+  uint16_t int_aper;                            /**< BIU aperture for PF BAR4 and VF BAR2 */

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#7653: FILE: drivers/net/sfc/efx/base/ef10_tlv_layout.h:523:
+  uint16_t int_aper;                            /**< BIU aperture for PF BAR4 and VF BAR2 */$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#7669: FILE: drivers/net/sfc/efx/base/ef10_tlv_layout.h:539:
+  uint32_t tag;$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#7670: FILE: drivers/net/sfc/efx/base/ef10_tlv_layout.h:540:
+  uint32_t length;$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#7671: FILE: drivers/net/sfc/efx/base/ef10_tlv_layout.h:541:
+  uint32_t port_mode;$

WARNING:LONG_LINE_COMMENT: line over 90 characters
#7675: FILE: drivers/net/sfc/efx/base/ef10_tlv_layout.h:545:
+#define TLV_PORT_MODE_10G_10G                    (2) /* 2x10G, dual SFP/10G-KR or single QSFP */

WARNING:LONG_LINE_COMMENT: line over 90 characters
#7676: FILE: drivers/net/sfc/efx/base/ef10_tlv_layout.h:546:
+#define TLV_PORT_MODE_40G_40G                    (3) /* 40G + 40G, dual QSFP/40G-KR (Greenport, Medford) */

WARNING:LONG_LINE_COMMENT: line over 90 characters
#7677: FILE: drivers/net/sfc/efx/base/ef10_tlv_layout.h:547:
+#define TLV_PORT_MODE_10G_10G_10G_10G            (4) /* 2x10G + 2x10G, quad SFP/10G-KR or dual QSFP (Greenport) */

WARNING:LONG_LINE_COMMENT: line over 90 characters
#7678: FILE: drivers/net/sfc/efx/base/ef10_tlv_layout.h:548:
+#define TLV_PORT_MODE_10G_10G_10G_10G_Q1         (4) /* 4x10G, single QSFP, cage 0 (Medford) */

WARNING:LONG_LINE_COMMENT: line over 90 characters
#7679: FILE: drivers/net/sfc/efx/base/ef10_tlv_layout.h:549:
+#define TLV_PORT_MODE_10G_10G_10G_10G_Q          (5) /* 4x10G, single QSFP, cage 0 (Medford) OBSOLETE DO NOT USE */

WARNING:LONG_LINE_COMMENT: line over 90 characters
#7680: FILE: drivers/net/sfc/efx/base/ef10_tlv_layout.h:550:
+#define TLV_PORT_MODE_40G_10G_10G                (6) /* 1x40G + 2x10G, dual QSFP (Greenport, Medford) */

WARNING:LONG_LINE_COMMENT: line over 90 characters
#7681: FILE: drivers/net/sfc/efx/base/ef10_tlv_layout.h:551:
+#define TLV_PORT_MODE_10G_10G_40G                (7) /* 2x10G + 1x40G, dual QSFP (Greenport, Medford) */

WARNING:LONG_LINE_COMMENT: line over 90 characters
#7682: FILE: drivers/net/sfc/efx/base/ef10_tlv_layout.h:552:
+#define TLV_PORT_MODE_10G_10G_10G_10G_Q2         (8) /* 4x10G, single QSFP, cage 1 (Medford) */

WARNING:LONG_LINE_COMMENT: line over 90 characters
#7683: FILE: drivers/net/sfc/efx/base/ef10_tlv_layout.h:553:
+#define TLV_PORT_MODE_10G_10G_10G_10G_Q1_Q2      (9) /* 2x10G + 2x10G, dual QSFP (Medford) */

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#7692: FILE: drivers/net/sfc/efx/base/ef10_tlv_layout.h:562:
+  uint32_t tag;$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#7693: FILE: drivers/net/sfc/efx/base/ef10_tlv_layout.h:563:
+  uint32_t length;$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#7694: FILE: drivers/net/sfc/efx/base/ef10_tlv_layout.h:564:
+  uint32_t vswitch_type;$

WARNING:LONG_LINE_COMMENT: line over 90 characters
#7695: FILE: drivers/net/sfc/efx/base/ef10_tlv_layout.h:565:
+#define TLV_VSWITCH_TYPE_DEFAULT        (0xffffffff) /* Firmware default; equivalent to no TLV present for a given port */

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#7709: FILE: drivers/net/sfc/efx/base/ef10_tlv_layout.h:579:
+  uint32_t tag;$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#7710: FILE: drivers/net/sfc/efx/base/ef10_tlv_layout.h:580:
+  uint32_t length;$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#7711: FILE: drivers/net/sfc/efx/base/ef10_tlv_layout.h:581:
+  uint32_t vlan_tag;$

WARNING:LONG_LINE_COMMENT: line over 90 characters
#7712: FILE: drivers/net/sfc/efx/base/ef10_tlv_layout.h:582:
+#define TLV_VPORT_NO_VLAN_TAG                    (0xFFFFFFFF) /* Default in the absence of TLV for a given PF */

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#7720: FILE: drivers/net/sfc/efx/base/ef10_tlv_layout.h:590:
+  uint32_t tag;$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#7721: FILE: drivers/net/sfc/efx/base/ef10_tlv_layout.h:591:
+  uint32_t length;$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#7722: FILE: drivers/net/sfc/efx/base/ef10_tlv_layout.h:592:
+  int16_t  offset_millivolts;$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#7723: FILE: drivers/net/sfc/efx/base/ef10_tlv_layout.h:593:
+  uint16_t reserved;$

WARNING:LONG_LINE_COMMENT: line over 90 characters
#7726: FILE: drivers/net/sfc/efx/base/ef10_tlv_layout.h:596:
+/* A privilege mask given on reset to all non-admin PCIe functions (that is other than first-PF-per-port).

WARNING:LONG_LINE_COMMENT: line over 90 characters
#7727: FILE: drivers/net/sfc/efx/base/ef10_tlv_layout.h:597:
+ * The meaning of particular bits is defined in mcdi_ef10.yml under MC_CMD_PRIVILEGE_MASK, see also bug 44583.

WARNING:LONG_LINE_COMMENT: line over 90 characters
#7728: FILE: drivers/net/sfc/efx/base/ef10_tlv_layout.h:598:
+ * TLV_TAG_PRIVILEGE_MASK_ADD specifies bits that should be added (ORed) to firmware default while

WARNING:LONG_LINE_COMMENT: line over 90 characters
#7729: FILE: drivers/net/sfc/efx/base/ef10_tlv_layout.h:599:
+ * TLV_TAG_PRIVILEGE_MASK_REM specifies bits that should be removed (ANDed) from firmware default:

WARNING:LONG_LINE_COMMENT: line over 90 characters
#7730: FILE: drivers/net/sfc/efx/base/ef10_tlv_layout.h:600:
+ * Initial_privilege_mask = (firmware_default_mask | privilege_mask_add) & ~privilege_mask_rem */

WARNING:BLOCK_COMMENT_STYLE: Block comments use a trailing */ on a separate line
#7730: FILE: drivers/net/sfc/efx/base/ef10_tlv_layout.h:600:
+ * Initial_privilege_mask = (firmware_default_mask | privilege_mask_add) & ~privilege_mask_rem */

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#7735: FILE: drivers/net/sfc/efx/base/ef10_tlv_layout.h:605:
+  uint32_t tag;$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#7736: FILE: drivers/net/sfc/efx/base/ef10_tlv_layout.h:606:
+  uint32_t length;$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#7737: FILE: drivers/net/sfc/efx/base/ef10_tlv_layout.h:607:
+  uint32_t privilege_mask;$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#7743: FILE: drivers/net/sfc/efx/base/ef10_tlv_layout.h:613:
+  uint32_t tag;$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#7744: FILE: drivers/net/sfc/efx/base/ef10_tlv_layout.h:614:
+  uint32_t length;$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#7745: FILE: drivers/net/sfc/efx/base/ef10_tlv_layout.h:615:
+  uint32_t privilege_mask_add;$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#7751: FILE: drivers/net/sfc/efx/base/ef10_tlv_layout.h:621:
+  uint32_t tag;$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#7752: FILE: drivers/net/sfc/efx/base/ef10_tlv_layout.h:622:
+  uint32_t length;$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#7753: FILE: drivers/net/sfc/efx/base/ef10_tlv_layout.h:623:
+  uint32_t privilege_mask_rem;$

WARNING:BLOCK_COMMENT_STYLE: Block comments use a trailing */ on a separate line
#7757: FILE: drivers/net/sfc/efx/base/ef10_tlv_layout.h:627:
+ * This tag takes precedence over TLV_TAG_PRIVILEGE_MASK_REM. */

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#7762: FILE: drivers/net/sfc/efx/base/ef10_tlv_layout.h:632:
+  uint32_t tag;$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#7763: FILE: drivers/net/sfc/efx/base/ef10_tlv_layout.h:633:
+  uint32_t length;$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#7764: FILE: drivers/net/sfc/efx/base/ef10_tlv_layout.h:634:
+  uint32_t privilege_mask_add;$

WARNING:BLOCK_COMMENT_STYLE: Block comments use a trailing */ on a separate line
#7768: FILE: drivers/net/sfc/efx/base/ef10_tlv_layout.h:638:
+ * This tag takes precedence over TLV_TAG_PRIVILEGE_MASK_REM. */

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#7773: FILE: drivers/net/sfc/efx/base/ef10_tlv_layout.h:643:
+  uint32_t tag;$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#7774: FILE: drivers/net/sfc/efx/base/ef10_tlv_layout.h:644:
+  uint32_t length;$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#7775: FILE: drivers/net/sfc/efx/base/ef10_tlv_layout.h:645:
+  uint32_t privilege_mask_add;$

WARNING:BLOCK_COMMENT_STYLE: Block comments use a trailing */ on a separate line
#7779: FILE: drivers/net/sfc/efx/base/ef10_tlv_layout.h:649:
+ * This tag only takes effect if TLV_TAG_VSWITCH_TYPE is missing or set to DEFAULT. */

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#7784: FILE: drivers/net/sfc/efx/base/ef10_tlv_layout.h:654:
+  uint32_t tag;$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#7785: FILE: drivers/net/sfc/efx/base/ef10_tlv_layout.h:655:
+  uint32_t length;$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#7786: FILE: drivers/net/sfc/efx/base/ef10_tlv_layout.h:656:
+  uint32_t pfiov;$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#7814: FILE: drivers/net/sfc/efx/base/ef10_tlv_layout.h:684:
+  uint32_t tag;$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#7815: FILE: drivers/net/sfc/efx/base/ef10_tlv_layout.h:685:
+  uint32_t length;$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#7816: FILE: drivers/net/sfc/efx/base/ef10_tlv_layout.h:686:
+  uint32_t mode;$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#7826: FILE: drivers/net/sfc/efx/base/ef10_tlv_layout.h:696:
+  uint32_t tag;$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#7827: FILE: drivers/net/sfc/efx/base/ef10_tlv_layout.h:697:
+  uint32_t length;$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#7828: FILE: drivers/net/sfc/efx/base/ef10_tlv_layout.h:698:
+  uint32_t rate_mbps;$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#7849: FILE: drivers/net/sfc/efx/base/ef10_tlv_layout.h:719:
+  uint32_t tag;$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#7850: FILE: drivers/net/sfc/efx/base/ef10_tlv_layout.h:720:
+  uint32_t length;$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#7851: FILE: drivers/net/sfc/efx/base/ef10_tlv_layout.h:721:
+  uint32_t mode;$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#7867: FILE: drivers/net/sfc/efx/base/ef10_tlv_layout.h:737:
+  uint32_t tag;$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#7868: FILE: drivers/net/sfc/efx/base/ef10_tlv_layout.h:738:
+  uint32_t length;$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#7869: FILE: drivers/net/sfc/efx/base/ef10_tlv_layout.h:739:
+  uint8_t rx_desc_cache_size;$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#7870: FILE: drivers/net/sfc/efx/base/ef10_tlv_layout.h:740:
+  uint8_t tx_desc_cache_size;$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#7871: FILE: drivers/net/sfc/efx/base/ef10_tlv_layout.h:741:
+  uint16_t vi_count;$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#7885: FILE: drivers/net/sfc/efx/base/ef10_tlv_layout.h:755:
+  uint32_t  tag;$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#7886: FILE: drivers/net/sfc/efx/base/ef10_tlv_layout.h:756:
+  uint32_t  length;$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#7887: FILE: drivers/net/sfc/efx/base/ef10_tlv_layout.h:757:
+  uint32_t  max_events;$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#7889: FILE: drivers/net/sfc/efx/base/ef10_tlv_layout.h:759:
+  uint32_t  timeout_ns;$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#7896: FILE: drivers/net/sfc/efx/base/ef10_tlv_layout.h:766:
+  uint32_t tag;$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#7897: FILE: drivers/net/sfc/efx/base/ef10_tlv_layout.h:767:
+  uint32_t length;$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#7898: FILE: drivers/net/sfc/efx/base/ef10_tlv_layout.h:768:
+  uint16_t gen;   /* Target PCIe generation: 1, 2, 3 */$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#7899: FILE: drivers/net/sfc/efx/base/ef10_tlv_layout.h:769:
+  uint16_t width; /* Number of lanes */$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#7910: FILE: drivers/net/sfc/efx/base/ef10_tlv_layout.h:780:
+  uint32_t  tag;$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#7911: FILE: drivers/net/sfc/efx/base/ef10_tlv_layout.h:781:
+  uint32_t  length;$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#7912: FILE: drivers/net/sfc/efx/base/ef10_tlv_layout.h:782:
+  uint32_t  max_events;$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#7914: FILE: drivers/net/sfc/efx/base/ef10_tlv_layout.h:784:
+  uint32_t  timeout_ns;$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#7915: FILE: drivers/net/sfc/efx/base/ef10_tlv_layout.h:785:
+  uint32_t  qempty_timeout_ns; /* Medford only */$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#7924: FILE: drivers/net/sfc/efx/base/ef10_tlv_layout.h:794:
+  uint32_t  tag;$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#7925: FILE: drivers/net/sfc/efx/base/ef10_tlv_layout.h:795:
+  uint32_t  length;$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#7926: FILE: drivers/net/sfc/efx/base/ef10_tlv_layout.h:796:
+  uint8_t   data[];$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#7945: FILE: drivers/net/sfc/efx/base/ef10_tlv_layout.h:815:
+  uint32_t tag;$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#7946: FILE: drivers/net/sfc/efx/base/ef10_tlv_layout.h:816:
+  uint32_t length;$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#7947: FILE: drivers/net/sfc/efx/base/ef10_tlv_layout.h:817:
+  uint32_t mode;$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#7948: FILE: drivers/net/sfc/efx/base/ef10_tlv_layout.h:818:
+  uint32_t ip;$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#7949: FILE: drivers/net/sfc/efx/base/ef10_tlv_layout.h:819:
+  uint32_t netmask;$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#7950: FILE: drivers/net/sfc/efx/base/ef10_tlv_layout.h:820:
+  uint32_t gateway;$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#7951: FILE: drivers/net/sfc/efx/base/ef10_tlv_layout.h:821:
+  uint32_t port;$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#7952: FILE: drivers/net/sfc/efx/base/ef10_tlv_layout.h:822:
+  uint32_t bind_retry;  /* DEPRECATED */$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#7953: FILE: drivers/net/sfc/efx/base/ef10_tlv_layout.h:823:
+  uint32_t bind_bkout;  /* DEPRECATED */$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#7969: FILE: drivers/net/sfc/efx/base/ef10_tlv_layout.h:839:
+  uint32_t tag;$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#7970: FILE: drivers/net/sfc/efx/base/ef10_tlv_layout.h:840:
+  uint32_t length;$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#7971: FILE: drivers/net/sfc/efx/base/ef10_tlv_layout.h:841:
+  uint32_t num_tsacs;$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#7972: FILE: drivers/net/sfc/efx/base/ef10_tlv_layout.h:842:
+  uint32_t ip[TLV_MAX_TSACS];$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#7973: FILE: drivers/net/sfc/efx/base/ef10_tlv_layout.h:843:
+  uint32_t port[TLV_MAX_TSACS];$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#7989: FILE: drivers/net/sfc/efx/base/ef10_tlv_layout.h:859:
+  uint32_t tag;$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#7990: FILE: drivers/net/sfc/efx/base/ef10_tlv_layout.h:860:
+  uint32_t length;$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#7991: FILE: drivers/net/sfc/efx/base/ef10_tlv_layout.h:861:
+  uint8_t  bytes[];$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#8006: FILE: drivers/net/sfc/efx/base/ef10_tlv_layout.h:876:
+  uint32_t tag;$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#8007: FILE: drivers/net/sfc/efx/base/ef10_tlv_layout.h:877:
+  uint32_t length;$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#8008: FILE: drivers/net/sfc/efx/base/ef10_tlv_layout.h:878:
+  uint8_t  bytes[];$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#8024: FILE: drivers/net/sfc/efx/base/ef10_tlv_layout.h:894:
+  uint32_t tag;$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#8025: FILE: drivers/net/sfc/efx/base/ef10_tlv_layout.h:895:
+  uint32_t length;$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#8026: FILE: drivers/net/sfc/efx/base/ef10_tlv_layout.h:896:
+  uint8_t  bytes[];$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#8037: FILE: drivers/net/sfc/efx/base/ef10_tlv_layout.h:907:
+  uint32_t tag;$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#8038: FILE: drivers/net/sfc/efx/base/ef10_tlv_layout.h:908:
+  uint32_t length;$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#8039: FILE: drivers/net/sfc/efx/base/ef10_tlv_layout.h:909:
+  uint8_t  mode;$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#8049: FILE: drivers/net/sfc/efx/base/ef10_tlv_layout.h:919:
+  uint32_t tag;$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#8050: FILE: drivers/net/sfc/efx/base/ef10_tlv_layout.h:920:
+  uint32_t length;$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#8051: FILE: drivers/net/sfc/efx/base/ef10_tlv_layout.h:921:
+  uint8_t  mode;$

WARNING:LONG_LINE_COMMENT: line over 90 characters
#8052: FILE: drivers/net/sfc/efx/base/ef10_tlv_layout.h:922:
+#define TLV_BIU_VI_WINDOW_MODE_8K    0  /*  8k per VI, CTPIO not mapped, medford/hunt compatible */

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#8063: FILE: drivers/net/sfc/efx/base/ef10_tlv_layout.h:933:
+  uint32_t tag;$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#8064: FILE: drivers/net/sfc/efx/base/ef10_tlv_layout.h:934:
+  uint32_t length;$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#8065: FILE: drivers/net/sfc/efx/base/ef10_tlv_layout.h:935:
+  uint8_t  mode;$

WARNING:LONG_LINE_COMMENT: line over 90 characters
#8068: FILE: drivers/net/sfc/efx/base/ef10_tlv_layout.h:938:
+#define TLV_FASTPD_MODE_FAST_SUPPORTED 2  /* Supported packet types to the FastPD; everything else to the SoftPD  */

CHECK:SPACING: No space is necessary after a cast
#8144: FILE: drivers/net/sfc/efx/base/ef10_tx.c:67:
+	(void) memset(payload, 0, sizeof (payload));

WARNING:SPACING: space prohibited between function name and open parenthesis '('
#8144: FILE: drivers/net/sfc/efx/base/ef10_tx.c:67:
+	(void) memset(payload, 0, sizeof (payload));

ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#8189: FILE: drivers/net/sfc/efx/base/ef10_tx.c:112:
+	return (0);

ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#8196: FILE: drivers/net/sfc/efx/base/ef10_tx.c:119:
+	return (rc);

CHECK:SPACING: No space is necessary after a cast
#8209: FILE: drivers/net/sfc/efx/base/ef10_tx.c:132:
+	(void) memset(payload, 0, sizeof (payload));

WARNING:SPACING: space prohibited between function name and open parenthesis '('
#8209: FILE: drivers/net/sfc/efx/base/ef10_tx.c:132:
+	(void) memset(payload, 0, sizeof (payload));

ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#8225: FILE: drivers/net/sfc/efx/base/ef10_tx.c:148:
+	return (0);

ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#8230: FILE: drivers/net/sfc/efx/base/ef10_tx.c:153:
+	return (rc);

ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#8238: FILE: drivers/net/sfc/efx/base/ef10_tx.c:161:
+	return (0);

ERROR:ASSIGN_IN_IF: do not use assignment in if condition
#8266: FILE: drivers/net/sfc/efx/base/ef10_tx.c:189:
+	if ((rc = efx_mcdi_init_txq(enp, n, eep->ee_index, label, index, flags,

ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#8290: FILE: drivers/net/sfc/efx/base/ef10_tx.c:213:
+	return (0);

ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#8295: FILE: drivers/net/sfc/efx/base/ef10_tx.c:218:
+	return (rc);

ERROR:ASSIGN_IN_IF: do not use assignment in if condition
#8321: FILE: drivers/net/sfc/efx/base/ef10_tx.c:244:
+	if ((rc = ef10_nic_pio_alloc(enp,

ERROR:ASSIGN_IN_IF: do not use assignment in if condition
#8332: FILE: drivers/net/sfc/efx/base/ef10_tx.c:255:
+	if ((rc = ef10_nic_pio_link(enp, etp->et_index, handle)) != 0) {

WARNING:BRACES: braces {} are not necessary for single statement blocks
#8332: FILE: drivers/net/sfc/efx/base/ef10_tx.c:255:
+	if ((rc = ef10_nic_pio_link(enp, etp->et_index, handle)) != 0) {
+		goto fail3;
+	}

ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#8349: FILE: drivers/net/sfc/efx/base/ef10_tx.c:272:
+	return (0);

ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#8360: FILE: drivers/net/sfc/efx/base/ef10_tx.c:283:
+	return (rc);

WARNING:SPACING: space prohibited between function name and open parenthesis '('
#8394: FILE: drivers/net/sfc/efx/base/ef10_tx.c:317:
+	EFSYS_ASSERT(length % sizeof (efx_qword_t) == 0);

WARNING:SPACING: space prohibited between function name and open parenthesis '('
#8415: FILE: drivers/net/sfc/efx/base/ef10_tx.c:338:
+		write_offset += sizeof (efx_qword_t);

ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#8418: FILE: drivers/net/sfc/efx/base/ef10_tx.c:341:
+	return (0);

ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#8425: FILE: drivers/net/sfc/efx/base/ef10_tx.c:348:
+	return (rc);

WARNING:SPACING: space prohibited between function name and open parenthesis '('
#8453: FILE: drivers/net/sfc/efx/base/ef10_tx.c:376:
+	offset = id * sizeof (efx_qword_t);

ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#8471: FILE: drivers/net/sfc/efx/base/ef10_tx.c:394:
+	return (0);

ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#8478: FILE: drivers/net/sfc/efx/base/ef10_tx.c:401:
+	return (rc);

WARNING:SPACING: space prohibited between function name and open parenthesis '('
#8511: FILE: drivers/net/sfc/efx/base/ef10_tx.c:434:
+		offset = id * sizeof (efx_qword_t);

ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#8530: FILE: drivers/net/sfc/efx/base/ef10_tx.c:453:
+	return (0);

ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#8535: FILE: drivers/net/sfc/efx/base/ef10_tx.c:458:
+	return (rc);

WARNING:SPACING: space prohibited between function name and open parenthesis '('
#8558: FILE: drivers/net/sfc/efx/base/ef10_tx.c:481:
+	offset = id * sizeof (efx_qword_t);

WARNING:SPACING: space prohibited between function name and open parenthesis '('
#8596: FILE: drivers/net/sfc/efx/base/ef10_tx.c:519:
+		offset = id * sizeof (efx_desc_t);

ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#8607: FILE: drivers/net/sfc/efx/base/ef10_tx.c:530:
+	return (0);

ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#8612: FILE: drivers/net/sfc/efx/base/ef10_tx.c:535:
+	return (rc);

ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#8725: FILE: drivers/net/sfc/efx/base/ef10_tx.c:648:
+	return (0);

ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#8730: FILE: drivers/net/sfc/efx/base/ef10_tx.c:653:
+	return (rc);

ERROR:ASSIGN_IN_IF: do not use assignment in if condition
#8740: FILE: drivers/net/sfc/efx/base/ef10_tx.c:663:
+	if ((rc = efx_mcdi_fini_txq(enp, etp->et_index)) != 0)

ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#8743: FILE: drivers/net/sfc/efx/base/ef10_tx.c:666:
+	return (0);

ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#8748: FILE: drivers/net/sfc/efx/base/ef10_tx.c:671:
+	return (rc);

CHECK:SPACING: No space is necessary after a cast
#9086: FILE: drivers/net/sfc/efx/base/efx_mcdi.c:1596:
+	(void) memset(payload, 0, sizeof (payload));

WARNING:SPACING: space prohibited between function name and open parenthesis '('
#9086: FILE: drivers/net/sfc/efx/base/efx_mcdi.c:1596:
+	(void) memset(payload, 0, sizeof (payload));

ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#9109: FILE: drivers/net/sfc/efx/base/efx_mcdi.c:1619:
+	return (0);

ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#9116: FILE: drivers/net/sfc/efx/base/efx_mcdi.c:1626:
+	return (rc);

CHECK:SPACING: No space is necessary after a cast
#9131: FILE: drivers/net/sfc/efx/base/efx_mcdi.c:1641:
+	(void) memset(payload, 0, sizeof (payload));

WARNING:SPACING: space prohibited between function name and open parenthesis '('
#9131: FILE: drivers/net/sfc/efx/base/efx_mcdi.c:1641:
+	(void) memset(payload, 0, sizeof (payload));

ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#9156: FILE: drivers/net/sfc/efx/base/efx_mcdi.c:1666:
+	return (0);

ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#9163: FILE: drivers/net/sfc/efx/base/efx_mcdi.c:1673:
+	return (rc);

ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#9186: FILE: drivers/net/sfc/efx/base/efx_nic.c:64:
+			return (0);

ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#9191: FILE: drivers/net/sfc/efx/base/efx_nic.c:69:
+			return (0);

ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#9196: FILE: drivers/net/sfc/efx/base/efx_nic.c:74:
+			return (0);

ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#9917: FILE: drivers/net/sfc/efx/base/efx_sram.c:64:
+		return (0);

ERROR:ASSIGN_IN_IF: do not use assignment in if condition
#10133: FILE: drivers/net/sfc/efx/base/hunt_nic.c:54:
+	if ((rc = efx_mcdi_get_port_modes(enp, &port_modes, NULL)) != 0) {

ERROR:ASSIGN_IN_IF: do not use assignment in if condition
#10144: FILE: drivers/net/sfc/efx/base/hunt_nic.c:65:
+		if ((rc = efx_nic_calculate_pcie_link_bandwidth(8,

ERROR:ASSIGN_IN_IF: do not use assignment in if condition
#10157: FILE: drivers/net/sfc/efx/base/hunt_nic.c:78:
+		if ((rc = ef10_nic_get_port_mode_bandwidth(max_port_mode,

ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#10165: FILE: drivers/net/sfc/efx/base/hunt_nic.c:86:
+	return (0);

ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#10172: FILE: drivers/net/sfc/efx/base/hunt_nic.c:93:
+	return (rc);

CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around enp->en_mcdi.em_emip
#10179: FILE: drivers/net/sfc/efx/base/hunt_nic.c:100:
+	efx_mcdi_iface_t *emip = &(enp->en_mcdi.em_emip);

CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around enp->en_nic_cfg
#10180: FILE: drivers/net/sfc/efx/base/hunt_nic.c:101:
+	efx_nic_cfg_t *encp = &(enp->en_nic_cfg);

CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around enp->en_port
#10184: FILE: drivers/net/sfc/efx/base/hunt_nic.c:105:
+	efx_port_t *epp = &(enp->en_port);

ERROR:ASSIGN_IN_IF: do not use assignment in if condition
#10195: FILE: drivers/net/sfc/efx/base/hunt_nic.c:116:
+	if ((rc = efx_mcdi_get_port_assignment(enp, &port)) != 0)

ERROR:ASSIGN_IN_IF: do not use assignment in if condition
#10204: FILE: drivers/net/sfc/efx/base/hunt_nic.c:125:
+	if ((rc = ef10_external_port_mapping(enp, port,

ERROR:ASSIGN_IN_IF: do not use assignment in if condition
#10214: FILE: drivers/net/sfc/efx/base/hunt_nic.c:135:
+	if ((rc = efx_mcdi_get_function_info(enp, &pf, &vf)) != 0)

ERROR:ASSIGN_IN_IF: do not use assignment in if condition
#10254: FILE: drivers/net/sfc/efx/base/hunt_nic.c:175:
+	if ((rc = efx_mcdi_get_phy_cfg(enp)) != 0)

ERROR:ASSIGN_IN_IF: do not use assignment in if condition
#10258: FILE: drivers/net/sfc/efx/base/hunt_nic.c:179:
+	if ((rc = ef10_phy_get_link(enp, &els)) != 0)

ERROR:ASSIGN_IN_IF: do not use assignment in if condition
#10351: FILE: drivers/net/sfc/efx/base/hunt_nic.c:272:
+	if ((rc = efx_mcdi_get_clock(enp, &sysclk, &dpcpu_clk)) != 0)

ERROR:ASSIGN_IN_IF: do not use assignment in if condition
#10370: FILE: drivers/net/sfc/efx/base/hunt_nic.c:291:
+	if ((rc = ef10_get_datapath_caps(enp)) != 0)

ERROR:ASSIGN_IN_IF: do not use assignment in if condition
#10408: FILE: drivers/net/sfc/efx/base/hunt_nic.c:329:
+	if ((rc = ef10_get_privilege_mask(enp, &mask)) != 0)

ERROR:ASSIGN_IN_IF: do not use assignment in if condition
#10413: FILE: drivers/net/sfc/efx/base/hunt_nic.c:334:
+	if ((rc = efx_mcdi_get_vector_cfg(enp, &base, &nvec, NULL)) != 0) {

ERROR:ASSIGN_IN_IF: do not use assignment in if condition
#10430: FILE: drivers/net/sfc/efx/base/hunt_nic.c:351:
+	if ((rc = hunt_nic_get_required_pcie_bandwidth(enp, &bandwidth)) != 0)

ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#10437: FILE: drivers/net/sfc/efx/base/hunt_nic.c:358:
+	return (0);

ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#10470: FILE: drivers/net/sfc/efx/base/hunt_nic.c:391:
+	return (rc);

total: 277 errors, 342 warnings, 94 checks, 10196 lines checked


More information about the test-report mailing list