[dpdk-test-report] |WARNING| [PATCH v2 04/55] net/sfc: import libefx filters support

[checkpatch at dpdk.org]

Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/17286

_coding style issues_


WARNING:BLOCK_COMMENT_STYLE: Block comments use a trailing */ on a separate line
#129: FILE: drivers/net/sfc/base/efx.h:1074:
+						 * address */

WARNING:BLOCK_COMMENT_STYLE: Block comments use a trailing */ on a separate line
#131: FILE: drivers/net/sfc/base/efx.h:1076:
+						 * address */

WARNING:BLOCK_COMMENT_STYLE: Block comments use a trailing */ on a separate line
#140: FILE: drivers/net/sfc/base/efx.h:1085:
+						 * protocol */

WARNING:BLOCK_COMMENT_STYLE: Block comments use a trailing */ on a separate line
#144: FILE: drivers/net/sfc/base/efx.h:1089:
+						 * broadcast filters. */

WARNING:BLOCK_COMMENT_STYLE: Block comments use a trailing */ on a separate line
#153: FILE: drivers/net/sfc/base/efx.h:1098:
+					 * each NIC type. */

CHECK:CAMELCASE: Avoid CamelCase: <__checkReturn>
#189: FILE: drivers/net/sfc/base/efx.h:1134:
+extern	__checkReturn	efx_rc_t

ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#333: FILE: drivers/net/sfc/base/efx_filter.c:48:
+	return (efop->efo_add(enp, spec, B_FALSE));

ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#347: FILE: drivers/net/sfc/base/efx_filter.c:62:
+	return (efop->efo_delete(enp, spec));

ERROR:ASSIGN_IN_IF: do not use assignment in if condition
#358: FILE: drivers/net/sfc/base/efx_filter.c:73:
+	if ((rc = enp->en_efop->efo_restore(enp)) != 0)

ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#361: FILE: drivers/net/sfc/base/efx_filter.c:76:
+	return (0);

ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#366: FILE: drivers/net/sfc/base/efx_filter.c:81:
+	return (rc);

WARNING:SPACING: space prohibited between function name and open parenthesis '('
#377: FILE: drivers/net/sfc/base/efx_filter.c:92:
+	EFX_STATIC_ASSERT(sizeof (efx_filter_spec_t) == 64);

CHECK:BRACES: Blank lines aren't necessary after an open brace '{'
#384: FILE: drivers/net/sfc/base/efx_filter.c:99:
+	switch (enp->en_family) {
+

ERROR:ASSIGN_IN_IF: do not use assignment in if condition
#391: FILE: drivers/net/sfc/base/efx_filter.c:106:
+	if ((rc = efop->efo_init(enp)) != 0)

ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#396: FILE: drivers/net/sfc/base/efx_filter.c:111:
+	return (0);

ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#405: FILE: drivers/net/sfc/base/efx_filter.c:120:
+	return (rc);

ERROR:ASSIGN_IN_IF: do not use assignment in if condition
#435: FILE: drivers/net/sfc/base/efx_filter.c:150:
+	if ((rc = enp->en_efop->efo_supported_filters(enp, list, length)) != 0)

ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#438: FILE: drivers/net/sfc/base/efx_filter.c:153:
+	return (0);

ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#443: FILE: drivers/net/sfc/base/efx_filter.c:158:
+	return (rc);

CHECK:SPACING: spaces preferred around that '*' (ctx:VxV)
#454: FILE: drivers/net/sfc/base/efx_filter.c:169:
+	__in_ecount(6*count)		uint8_t const *addrs,
 	             ^

ERROR:ASSIGN_IN_IF: do not use assignment in if condition
#464: FILE: drivers/net/sfc/base/efx_filter.c:179:
+		if ((rc = enp->en_efop->efo_reconfigure(enp, mac_addr,

ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#471: FILE: drivers/net/sfc/base/efx_filter.c:186:
+	return (0);

ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#476: FILE: drivers/net/sfc/base/efx_filter.c:191:
+	return (rc);

WARNING:SPACING: space prohibited between function name and open parenthesis '('
#491: FILE: drivers/net/sfc/base/efx_filter.c:206:
+	memset(spec, 0, sizeof (*spec));

WARNING:SPACING: space prohibited between function name and open parenthesis '('
#506: FILE: drivers/net/sfc/base/efx_filter.c:221:
+	memset(spec, 0, sizeof (*spec));

ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#532: FILE: drivers/net/sfc/base/efx_filter.c:247:
+	return (0);

ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#559: FILE: drivers/net/sfc/base/efx_filter.c:274:
+	return (0);

ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#575: FILE: drivers/net/sfc/base/efx_filter.c:290:
+		return (EINVAL);

WARNING:USE_NEGATIVE_ERRNO: return of an errno should typically be negative (ie: return -EINVAL)
#575: FILE: drivers/net/sfc/base/efx_filter.c:290:
+		return (EINVAL);

ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#585: FILE: drivers/net/sfc/base/efx_filter.c:300:
+	return (0);

ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#598: FILE: drivers/net/sfc/base/efx_filter.c:313:
+	return (0);

ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#612: FILE: drivers/net/sfc/base/efx_filter.c:327:
+	return (0);

CHECK:SPACING: spaces preferred around that '*' (ctx:VxV)
#648: FILE: drivers/net/sfc/base/efx_impl.h:186:
+	__in_ecount(6*count)		uint8_t const *addrs,
 	             ^

total: 20 errors, 9 warnings, 4 checks, 564 lines checked