[dpdk-test-report] |WARNING| [PATCH v2 12/55] net/sfc: import libefx diagnostics support
checkpatch at dpdk.org
checkpatch at dpdk.org
Tue Nov 29 17:21:46 CET 2016
Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/17289
_coding style issues_
CHECK:CAMELCASE: Avoid CamelCase: <__checkReturn>
#98: FILE: drivers/net/sfc/base/ef10_impl.h:197:
+extern __checkReturn efx_rc_t
ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#132: FILE: drivers/net/sfc/base/ef10_nic.c:1785:
+ return (0);
ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#137: FILE: drivers/net/sfc/base/ef10_nic.c:1790:
+ return (rc);
ERROR:ASSIGN_IN_IF: do not use assignment in if condition
#311: FILE: drivers/net/sfc/base/efx_nic.c:632:
+ if ((rc = enop->eno_register_test(enp)) != 0)
ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#314: FILE: drivers/net/sfc/base/efx_nic.c:635:
+ return (0);
ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#319: FILE: drivers/net/sfc/base/efx_nic.c:640:
+ return (rc);
WARNING:SPACING: space prohibited between function name and open parenthesis '('
#357: FILE: drivers/net/sfc/base/efx_nic.c:678:
+ if (memcmp(®, &buf, sizeof (reg))) {
WARNING:SPACING: space prohibited between function name and open parenthesis '('
#372: FILE: drivers/net/sfc/base/efx_nic.c:693:
+ if (memcmp(®, &buf, sizeof (reg))) {
ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#386: FILE: drivers/net/sfc/base/efx_nic.c:707:
+ return (0);
ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#396: FILE: drivers/net/sfc/base/efx_nic.c:717:
+ return (rc);
WARNING:SPACING: space prohibited between function name and open parenthesis '('
#435: FILE: drivers/net/sfc/base/efx_nic.c:756:
+ if (memcmp(®, &buf, sizeof (reg))) {
ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#447: FILE: drivers/net/sfc/base/efx_nic.c:768:
+ return (0);
ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#452: FILE: drivers/net/sfc/base/efx_nic.c:773:
+ return (rc);
WARNING:SPACING: space prohibited between function name and open parenthesis '('
#481: FILE: drivers/net/sfc/base/efx_sram.c:214:
+ for (index = 0; index < sizeof (efx_qword_t); index++)
WARNING:SPACING: space prohibited between function name and open parenthesis '('
#534: FILE: drivers/net/sfc/base/efx_sram.c:267:
+ for (index = 0; index < sizeof (efx_qword_t); index++) {
WARNING:SPACING: space prohibited between function name and open parenthesis '('
#556: FILE: drivers/net/sfc/base/efx_sram.c:289:
+ EFX_CLEAR_QWORD_BIT(*eqp, (offset / sizeof (efx_qword_t)) % 64);
WARNING:SPACING: space prohibited between function name and open parenthesis '('
#559: FILE: drivers/net/sfc/base/efx_sram.c:292:
+ EFX_SET_QWORD_BIT(*eqp, (offset / sizeof (efx_qword_t)) % 64);
ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#589: FILE: drivers/net/sfc/base/efx_sram.c:322:
+ return (0);
ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#595: FILE: drivers/net/sfc/base/efx_sram.c:328:
+ return (siena_sram_test(enp, func));
ERROR:ASSIGN_IN_IF: do not use assignment in if condition
#740: FILE: drivers/net/sfc/base/siena_nic.c:455:
+ if ((rc = efx_nic_test_registers(enp, __siena_registers,
ERROR:ASSIGN_IN_IF: do not use assignment in if condition
#744: FILE: drivers/net/sfc/base/siena_nic.c:459:
+ if ((rc = efx_nic_test_tables(enp, __siena_tables,
ERROR:ASSIGN_IN_IF: do not use assignment in if condition
#749: FILE: drivers/net/sfc/base/siena_nic.c:464:
+ if ((rc = efx_nic_test_tables(enp, __siena_tables,
ERROR:ASSIGN_IN_IF: do not use assignment in if condition
#754: FILE: drivers/net/sfc/base/siena_nic.c:469:
+ if ((rc = efx_nic_test_tables(enp, __siena_tables,
ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#758: FILE: drivers/net/sfc/base/siena_nic.c:473:
+ return (0);
ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#769: FILE: drivers/net/sfc/base/siena_nic.c:484:
+ return (rc);
ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#871: FILE: drivers/net/sfc/base/siena_sram.c:162:
+ return (0);
ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#882: FILE: drivers/net/sfc/base/siena_sram.c:173:
+ return (rc);
total: 19 errors, 7 warnings, 1 checks, 744 lines checked
More information about the test-report
mailing list