[dpdk-test-report] |WARNING| [PATCH v2 06/55] net/sfc: import libefx MCDI implementation

checkpatch at dpdk.org checkpatch at dpdk.org
Tue Nov 29 17:22:02 CET 2016
Previous message: [dpdk-test-report] |SUCCESS| [PATCH v2 32/55] net/sfc: add device configure and close stubs
Next message: [dpdk-test-report] |WARNING| [PATCH v2 13/55] net/sfc: import libefx built-in selftest support
Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]
Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/17294

_coding style issues_


WARNING:TYPO_SPELLING: 'managment' may be misspelled - perhaps 'management'?
#70: 
Implement interface to talk to NIC managment CPU. Provide

CHECK:CAMELCASE: Avoid CamelCase: <__checkReturn>
#123: FILE: drivers/net/sfc/base/efx.h:202:
+extern	__checkReturn	efx_rc_t

CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around ev[index]
#213: FILE: drivers/net/sfc/base/efx_ev.c:328:
+				    &(ev[index]), eecp, arg);

CHECK:BRACES: Blank lines aren't necessary after an open brace '{'
#372: FILE: drivers/net/sfc/base/efx_mcdi.c:69:
+	switch (enp->en_family) {
+

ERROR:ASSIGN_IN_IF: do not use assignment in if condition
#389: FILE: drivers/net/sfc/base/efx_mcdi.c:86:
+		if ((rc = emcop->emco_init(enp, emtp)) != 0)

ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#396: FILE: drivers/net/sfc/base/efx_mcdi.c:93:
+	return (0);

ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#409: FILE: drivers/net/sfc/base/efx_mcdi.c:106:
+	return (rc);

CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around enp->en_mcdi.em_emip
#416: FILE: drivers/net/sfc/base/efx_mcdi.c:113:
+	efx_mcdi_iface_t *emip = &(enp->en_mcdi.em_emip);

CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around enp->en_mcdi.em_emip
#436: FILE: drivers/net/sfc/base/efx_mcdi.c:133:
+	efx_mcdi_iface_t *emip = &(enp->en_mcdi.em_emip);

ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#466: FILE: drivers/net/sfc/base/efx_mcdi.c:163:
+	return (rc);

ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#477: FILE: drivers/net/sfc/base/efx_mcdi.c:174:
+	return (available);

CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around enp->en_mcdi.em_emip
#498: FILE: drivers/net/sfc/base/efx_mcdi.c:195:
+	efx_mcdi_iface_t *emip = &(enp->en_mcdi.em_emip);

WARNING:SPACING: space prohibited between function name and open parenthesis '('
#546: FILE: drivers/net/sfc/base/efx_mcdi.c:243:
+		hdr_len = sizeof (hdr);

WARNING:SPACING: space prohibited between function name and open parenthesis '('
#562: FILE: drivers/net/sfc/base/efx_mcdi.c:259:
+		hdr_len = sizeof (hdr[0]);

CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around enp->en_mcdi.em_emip
#584: FILE: drivers/net/sfc/base/efx_mcdi.c:281:
+	efx_mcdi_iface_t *emip = &(enp->en_mcdi.em_emip);

WARNING:SPACING: space prohibited between function name and open parenthesis '('
#595: FILE: drivers/net/sfc/base/efx_mcdi.c:292:
+	efx_mcdi_read_response(enp, &hdr[0], 0, sizeof (hdr[0]));

WARNING:SPACING: space prohibited between function name and open parenthesis '('
#596: FILE: drivers/net/sfc/base/efx_mcdi.c:293:
+	hdr_len = sizeof (hdr[0]);

WARNING:SPACING: space prohibited between function name and open parenthesis '('
#605: FILE: drivers/net/sfc/base/efx_mcdi.c:302:
+		efx_mcdi_read_response(enp, &hdr[1], hdr_len, sizeof (hdr[1]));

WARNING:SPACING: space prohibited between function name and open parenthesis '('
#606: FILE: drivers/net/sfc/base/efx_mcdi.c:303:
+		hdr_len += sizeof (hdr[1]);

WARNING:SPACING: space prohibited between function name and open parenthesis '('
#628: FILE: drivers/net/sfc/base/efx_mcdi.c:325:
+		unsigned int err_len = MIN(data_len, sizeof (err));

WARNING:SPACING: space prohibited between function name and open parenthesis '('
#635: FILE: drivers/net/sfc/base/efx_mcdi.c:332:
+		if (err_len >= (MC_CMD_ERR_CODE_OFST + sizeof (efx_dword_t)))

WARNING:SPACING: space prohibited between function name and open parenthesis '('
#638: FILE: drivers/net/sfc/base/efx_mcdi.c:335:
+		if (err_len >= (MC_CMD_ERR_ARG_OFST + sizeof (efx_dword_t)))

WARNING:SPACING: space prohibited between function name and open parenthesis '('
#677: FILE: drivers/net/sfc/base/efx_mcdi.c:374:
+	hdr_len = sizeof (hdr[0]);

WARNING:SPACING: space prohibited between function name and open parenthesis '('
#684: FILE: drivers/net/sfc/base/efx_mcdi.c:381:
+		efx_mcdi_read_response(enp, &hdr[1], hdr_len, sizeof (hdr[1]));

WARNING:SPACING: space prohibited between function name and open parenthesis '('
#685: FILE: drivers/net/sfc/base/efx_mcdi.c:382:
+		hdr_len += sizeof (hdr[1]);

CHECK:BRACES: Blank lines aren't necessary before a close brace '}'
#695: FILE: drivers/net/sfc/base/efx_mcdi.c:392:
+
+}

CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around enp->en_mcdi.em_emip
#702: FILE: drivers/net/sfc/base/efx_mcdi.c:399:
+	efx_mcdi_iface_t *emip = &(enp->en_mcdi.em_emip);

ERROR:ASSIGN_IN_IF: do not use assignment in if condition
#720: FILE: drivers/net/sfc/base/efx_mcdi.c:417:
+		if ((rc = efx_mcdi_poll_reboot(enp)) != 0) {

ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#735: FILE: drivers/net/sfc/base/efx_mcdi.c:432:
+		return (B_FALSE);

ERROR:ASSIGN_IN_IF: do not use assignment in if condition
#749: FILE: drivers/net/sfc/base/efx_mcdi.c:446:
+	if ((rc = emrp->emr_rc) != 0)

ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#753: FILE: drivers/net/sfc/base/efx_mcdi.c:450:
+	return (B_TRUE);

ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#762: FILE: drivers/net/sfc/base/efx_mcdi.c:459:
+	return (B_TRUE);

CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around enp->en_mcdi.em_emip
#769: FILE: drivers/net/sfc/base/efx_mcdi.c:466:
+	efx_mcdi_iface_t *emip = &(enp->en_mcdi.em_emip);

ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#806: FILE: drivers/net/sfc/base/efx_mcdi.c:503:
+	return (aborted);

CHECK:BRACES: Blank lines aren't necessary after an open brace '{'
#824: FILE: drivers/net/sfc/base/efx_mcdi.c:521:
+{
+

ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#828: FILE: drivers/net/sfc/base/efx_mcdi.c:525:
+		return (EACCES);

WARNING:USE_NEGATIVE_ERRNO: return of an errno should typically be negative (ie: return -EACCES)
#828: FILE: drivers/net/sfc/base/efx_mcdi.c:525:
+		return (EACCES);

ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#830: FILE: drivers/net/sfc/base/efx_mcdi.c:527:
+		return (ENOENT);

WARNING:USE_NEGATIVE_ERRNO: return of an errno should typically be negative (ie: return -ENOENT)
#830: FILE: drivers/net/sfc/base/efx_mcdi.c:527:
+		return (ENOENT);

ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#832: FILE: drivers/net/sfc/base/efx_mcdi.c:529:
+		return (EINTR);

WARNING:USE_NEGATIVE_ERRNO: return of an errno should typically be negative (ie: return -EINTR)
#832: FILE: drivers/net/sfc/base/efx_mcdi.c:529:
+		return (EINTR);

ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#834: FILE: drivers/net/sfc/base/efx_mcdi.c:531:
+		return (EACCES);

WARNING:USE_NEGATIVE_ERRNO: return of an errno should typically be negative (ie: return -EACCES)
#834: FILE: drivers/net/sfc/base/efx_mcdi.c:531:
+		return (EACCES);

ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#836: FILE: drivers/net/sfc/base/efx_mcdi.c:533:
+		return (EBUSY);

WARNING:USE_NEGATIVE_ERRNO: return of an errno should typically be negative (ie: return -EBUSY)
#836: FILE: drivers/net/sfc/base/efx_mcdi.c:533:
+		return (EBUSY);

ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#838: FILE: drivers/net/sfc/base/efx_mcdi.c:535:
+		return (EINVAL);

WARNING:USE_NEGATIVE_ERRNO: return of an errno should typically be negative (ie: return -EINVAL)
#838: FILE: drivers/net/sfc/base/efx_mcdi.c:535:
+		return (EINVAL);

ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#840: FILE: drivers/net/sfc/base/efx_mcdi.c:537:
+		return (EDEADLK);

WARNING:USE_NEGATIVE_ERRNO: return of an errno should typically be negative (ie: return -EDEADLK)
#840: FILE: drivers/net/sfc/base/efx_mcdi.c:537:
+		return (EDEADLK);

ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#842: FILE: drivers/net/sfc/base/efx_mcdi.c:539:
+		return (ENOTSUP);

WARNING:USE_NEGATIVE_ERRNO: return of an errno should typically be negative (ie: return -ENOTSUP)
#842: FILE: drivers/net/sfc/base/efx_mcdi.c:539:
+		return (ENOTSUP);

ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#844: FILE: drivers/net/sfc/base/efx_mcdi.c:541:
+		return (ETIMEDOUT);

WARNING:USE_NEGATIVE_ERRNO: return of an errno should typically be negative (ie: return -ETIMEDOUT)
#844: FILE: drivers/net/sfc/base/efx_mcdi.c:541:
+		return (ETIMEDOUT);

ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#846: FILE: drivers/net/sfc/base/efx_mcdi.c:543:
+		return (ENOTSUP);

WARNING:USE_NEGATIVE_ERRNO: return of an errno should typically be negative (ie: return -ENOTSUP)
#846: FILE: drivers/net/sfc/base/efx_mcdi.c:543:
+		return (ENOTSUP);

ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#848: FILE: drivers/net/sfc/base/efx_mcdi.c:545:
+		return (EALREADY);

WARNING:USE_NEGATIVE_ERRNO: return of an errno should typically be negative (ie: return -EALREADY)
#848: FILE: drivers/net/sfc/base/efx_mcdi.c:545:
+		return (EALREADY);

ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#852: FILE: drivers/net/sfc/base/efx_mcdi.c:549:
+		return (EEXIST);

WARNING:USE_NEGATIVE_ERRNO: return of an errno should typically be negative (ie: return -EEXIST)
#852: FILE: drivers/net/sfc/base/efx_mcdi.c:549:
+		return (EEXIST);

ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#855: FILE: drivers/net/sfc/base/efx_mcdi.c:552:
+		return (EAGAIN);

WARNING:USE_NEGATIVE_ERRNO: return of an errno should typically be negative (ie: return -EAGAIN)
#855: FILE: drivers/net/sfc/base/efx_mcdi.c:552:
+		return (EAGAIN);

ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#859: FILE: drivers/net/sfc/base/efx_mcdi.c:556:
+		return (ENOSPC);

WARNING:USE_NEGATIVE_ERRNO: return of an errno should typically be negative (ie: return -ENOSPC)
#859: FILE: drivers/net/sfc/base/efx_mcdi.c:556:
+		return (ENOSPC);

ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#862: FILE: drivers/net/sfc/base/efx_mcdi.c:559:
+		return (ERANGE);

WARNING:USE_NEGATIVE_ERRNO: return of an errno should typically be negative (ie: return -ERANGE)
#862: FILE: drivers/net/sfc/base/efx_mcdi.c:559:
+		return (ERANGE);

ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#865: FILE: drivers/net/sfc/base/efx_mcdi.c:562:
+		return (ENOMEM);

WARNING:USE_NEGATIVE_ERRNO: return of an errno should typically be negative (ie: return -ENOMEM)
#865: FILE: drivers/net/sfc/base/efx_mcdi.c:562:
+		return (ENOMEM);

ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#867: FILE: drivers/net/sfc/base/efx_mcdi.c:564:
+		return (ENOENT);

WARNING:USE_NEGATIVE_ERRNO: return of an errno should typically be negative (ie: return -ENOENT)
#867: FILE: drivers/net/sfc/base/efx_mcdi.c:564:
+		return (ENOENT);

ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#869: FILE: drivers/net/sfc/base/efx_mcdi.c:566:
+		return (ENOENT);

WARNING:USE_NEGATIVE_ERRNO: return of an errno should typically be negative (ie: return -ENOENT)
#869: FILE: drivers/net/sfc/base/efx_mcdi.c:566:
+		return (ENOENT);

ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#871: FILE: drivers/net/sfc/base/efx_mcdi.c:568:
+		return (ENODEV);

WARNING:USE_NEGATIVE_ERRNO: return of an errno should typically be negative (ie: return -ENODEV)
#871: FILE: drivers/net/sfc/base/efx_mcdi.c:568:
+		return (ENODEV);

ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#873: FILE: drivers/net/sfc/base/efx_mcdi.c:570:
+		return (EINVAL);

WARNING:USE_NEGATIVE_ERRNO: return of an errno should typically be negative (ie: return -EINVAL)
#873: FILE: drivers/net/sfc/base/efx_mcdi.c:570:
+		return (EINVAL);

ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#875: FILE: drivers/net/sfc/base/efx_mcdi.c:572:
+		return (ENODEV);

WARNING:USE_NEGATIVE_ERRNO: return of an errno should typically be negative (ie: return -ENODEV)
#875: FILE: drivers/net/sfc/base/efx_mcdi.c:572:
+		return (ENODEV);

ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#877: FILE: drivers/net/sfc/base/efx_mcdi.c:574:
+		return (EINVAL);

WARNING:USE_NEGATIVE_ERRNO: return of an errno should typically be negative (ie: return -EINVAL)
#877: FILE: drivers/net/sfc/base/efx_mcdi.c:574:
+		return (EINVAL);

ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#879: FILE: drivers/net/sfc/base/efx_mcdi.c:576:
+		return (EINVAL);

WARNING:USE_NEGATIVE_ERRNO: return of an errno should typically be negative (ie: return -EINVAL)
#879: FILE: drivers/net/sfc/base/efx_mcdi.c:576:
+		return (EINVAL);

ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#881: FILE: drivers/net/sfc/base/efx_mcdi.c:578:
+		return (EINVAL);

WARNING:USE_NEGATIVE_ERRNO: return of an errno should typically be negative (ie: return -EINVAL)
#881: FILE: drivers/net/sfc/base/efx_mcdi.c:578:
+		return (EINVAL);

ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#883: FILE: drivers/net/sfc/base/efx_mcdi.c:580:
+		return (EEXIST);

WARNING:USE_NEGATIVE_ERRNO: return of an errno should typically be negative (ie: return -EEXIST)
#883: FILE: drivers/net/sfc/base/efx_mcdi.c:580:
+		return (EEXIST);

ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#886: FILE: drivers/net/sfc/base/efx_mcdi.c:583:
+		return (EAGAIN);

WARNING:USE_NEGATIVE_ERRNO: return of an errno should typically be negative (ie: return -EAGAIN)
#886: FILE: drivers/net/sfc/base/efx_mcdi.c:583:
+		return (EAGAIN);

ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#890: FILE: drivers/net/sfc/base/efx_mcdi.c:587:
+		return (EIO);

WARNING:USE_NEGATIVE_ERRNO: return of an errno should typically be negative (ie: return -EIO)
#890: FILE: drivers/net/sfc/base/efx_mcdi.c:587:
+		return (EIO);

CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around enp->en_mcdi.em_emip
#955: FILE: drivers/net/sfc/base/efx_mcdi.c:652:
+	efx_mcdi_iface_t *emip = &(enp->en_mcdi.em_emip);

WARNING:BRACES: braces {} are not necessary for single statement blocks
#997: FILE: drivers/net/sfc/base/efx_mcdi.c:694:
+	if (errcode == 0) {
+		efx_mcdi_finish_response(enp, emrp);
+	}

CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around enp->en_mcdi.em_emip
#1009: FILE: drivers/net/sfc/base/efx_mcdi.c:706:
+	efx_mcdi_iface_t *emip = &(enp->en_mcdi.em_emip);

CHECK:SPACING: No space is necessary after a cast
#1045: FILE: drivers/net/sfc/base/efx_mcdi.c:742:
+		(void) efx_mcdi_poll_reboot(enp);

CHECK:SPACING: No space is necessary after a cast
#1077: FILE: drivers/net/sfc/base/efx_mcdi.c:774:
+	(void) memset(payload, 0, sizeof (payload));

WARNING:SPACING: space prohibited between function name and open parenthesis '('
#1077: FILE: drivers/net/sfc/base/efx_mcdi.c:774:
+	(void) memset(payload, 0, sizeof (payload));

CHECK:MULTIPLE_ASSIGNMENTS: multiple assignments should be avoided
#1093: FILE: drivers/net/sfc/base/efx_mcdi.c:790:
+		version[0] = version[1] = version[2] = version[3] = 0;

CHECK:SPACING: No space is necessary after a cast
#1118: FILE: drivers/net/sfc/base/efx_mcdi.c:815:
+	(void) memset(payload, 0, sizeof (payload));

WARNING:SPACING: space prohibited between function name and open parenthesis '('
#1118: FILE: drivers/net/sfc/base/efx_mcdi.c:815:
+	(void) memset(payload, 0, sizeof (payload));

CHECK:MULTIPLE_ASSIGNMENTS: multiple assignments should be avoided
#1130: FILE: drivers/net/sfc/base/efx_mcdi.c:827:
+		version[0] = version[1] = version[2] = version[3] = 0;

WARNING:SPACING: space prohibited between function name and open parenthesis '('
#1153: FILE: drivers/net/sfc/base/efx_mcdi.c:850:
+		memcpy(versionp, version, sizeof (version));

ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#1159: FILE: drivers/net/sfc/base/efx_mcdi.c:856:
+	return (0);

ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#1170: FILE: drivers/net/sfc/base/efx_mcdi.c:867:
+	return (rc);

CHECK:SPACING: No space is necessary after a cast
#1191: FILE: drivers/net/sfc/base/efx_mcdi.c:888:
+	(void) memset(payload, 0, sizeof (payload));

WARNING:SPACING: space prohibited between function name and open parenthesis '('
#1191: FILE: drivers/net/sfc/base/efx_mcdi.c:888:
+	(void) memset(payload, 0, sizeof (payload));

ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#1215: FILE: drivers/net/sfc/base/efx_mcdi.c:912:
+	return (0);

ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#1220: FILE: drivers/net/sfc/base/efx_mcdi.c:917:
+	return (rc);

ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#1227: FILE: drivers/net/sfc/base/efx_mcdi.c:924:
+	return (efx_mcdi_do_reboot(enp, B_FALSE));

ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#1234: FILE: drivers/net/sfc/base/efx_mcdi.c:931:
+	return (efx_mcdi_do_reboot(enp, B_TRUE));

CHECK:SPACING: No space is necessary after a cast
#1264: FILE: drivers/net/sfc/base/efx_mcdi.c:961:
+		(void) memset(payload, 0, sizeof (payload));

WARNING:SPACING: space prohibited between function name and open parenthesis '('
#1264: FILE: drivers/net/sfc/base/efx_mcdi.c:961:
+		(void) memset(payload, 0, sizeof (payload));

ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#1293: FILE: drivers/net/sfc/base/efx_mcdi.c:990:
+		return (0);

WARNING:SPACING: space prohibited between function name and open parenthesis '('
#1318: FILE: drivers/net/sfc/base/efx_mcdi.c:1015:
+		ofst += sizeof (efx_dword_t);

ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#1323: FILE: drivers/net/sfc/base/efx_mcdi.c:1020:
+	return (0);

ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#1330: FILE: drivers/net/sfc/base/efx_mcdi.c:1027:
+	return (rc);

CHECK:SPACING: No space is necessary after a cast
#1348: FILE: drivers/net/sfc/base/efx_mcdi.c:1045:
+	(void) memset(payload, 0, sizeof (payload));

WARNING:SPACING: space prohibited between function name and open parenthesis '('
#1348: FILE: drivers/net/sfc/base/efx_mcdi.c:1045:
+	(void) memset(payload, 0, sizeof (payload));

ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#1376: FILE: drivers/net/sfc/base/efx_mcdi.c:1073:
+	return (0);

ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#1383: FILE: drivers/net/sfc/base/efx_mcdi.c:1080:
+	return (rc);

CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around enp->en_mcdi.em_emip
#1393: FILE: drivers/net/sfc/base/efx_mcdi.c:1090:
+	efx_mcdi_iface_t *emip = &(enp->en_mcdi.em_emip);

CHECK:SPACING: No space is necessary after a cast
#1399: FILE: drivers/net/sfc/base/efx_mcdi.c:1096:
+	(void) memset(payload, 0, sizeof (payload));

WARNING:SPACING: space prohibited between function name and open parenthesis '('
#1399: FILE: drivers/net/sfc/base/efx_mcdi.c:1096:
+	(void) memset(payload, 0, sizeof (payload));

ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#1453: FILE: drivers/net/sfc/base/efx_mcdi.c:1150:
+	return (0);

ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#1464: FILE: drivers/net/sfc/base/efx_mcdi.c:1161:
+	return (rc);

CHECK:SPACING: No space is necessary after a cast
#1479: FILE: drivers/net/sfc/base/efx_mcdi.c:1176:
+	(void) memset(payload, 0, sizeof (payload));

WARNING:SPACING: space prohibited between function name and open parenthesis '('
#1479: FILE: drivers/net/sfc/base/efx_mcdi.c:1176:
+	(void) memset(payload, 0, sizeof (payload));

ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#1505: FILE: drivers/net/sfc/base/efx_mcdi.c:1202:
+	return (0);

ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#1512: FILE: drivers/net/sfc/base/efx_mcdi.c:1209:
+	return (rc);

CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around enp->en_port
#1519: FILE: drivers/net/sfc/base/efx_mcdi.c:1216:
+	efx_port_t *epp = &(enp->en_port);

CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around enp->en_nic_cfg
#1520: FILE: drivers/net/sfc/base/efx_mcdi.c:1217:
+	efx_nic_cfg_t *encp = &(enp->en_nic_cfg);

CHECK:SPACING: No space is necessary after a cast
#1526: FILE: drivers/net/sfc/base/efx_mcdi.c:1223:
+	(void) memset(payload, 0, sizeof (payload));

WARNING:SPACING: space prohibited between function name and open parenthesis '('
#1526: FILE: drivers/net/sfc/base/efx_mcdi.c:1223:
+	(void) memset(payload, 0, sizeof (payload));

CHECK:SPACING: No space is necessary after a cast
#1547: FILE: drivers/net/sfc/base/efx_mcdi.c:1244:
+	(void) strncpy(encp->enc_phy_name,

WARNING:SPACING: space prohibited between function name and open parenthesis '('
#1549: FILE: drivers/net/sfc/base/efx_mcdi.c:1246:
+		MIN(sizeof (encp->enc_phy_name) - 1,

CHECK:SPACING: No space is necessary after a cast
#1552: FILE: drivers/net/sfc/base/efx_mcdi.c:1249:
+	(void) memset(encp->enc_phy_revision, 0,

WARNING:SPACING: space prohibited between function name and open parenthesis '('
#1553: FILE: drivers/net/sfc/base/efx_mcdi.c:1250:
+	    sizeof (encp->enc_phy_revision));

WARNING:SPACING: space prohibited between function name and open parenthesis '('
#1556: FILE: drivers/net/sfc/base/efx_mcdi.c:1253:
+		MIN(sizeof (encp->enc_phy_revision) - 1,

CHECK:SPACING: No space is necessary after a cast
#1568: FILE: drivers/net/sfc/base/efx_mcdi.c:1265:
+		(efx_phy_media_type_t) MCDI_OUT_DWORD(req, GET_PHY_CFG_OUT_MEDIA_TYPE);

ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#1581: FILE: drivers/net/sfc/base/efx_mcdi.c:1278:
+	return (0);

ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#1588: FILE: drivers/net/sfc/base/efx_mcdi.c:1285:
+	return (rc);

ERROR:ASSIGN_IN_IF: do not use assignment in if condition
#1600: FILE: drivers/net/sfc/base/efx_mcdi.c:1297:
+		if ((rc = emcop->emco_feature_supported(enp,

ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#1608: FILE: drivers/net/sfc/base/efx_mcdi.c:1305:
+	return (0);

ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#1613: FILE: drivers/net/sfc/base/efx_mcdi.c:1310:
+	return (rc);

ERROR:ASSIGN_IN_IF: do not use assignment in if condition
#1625: FILE: drivers/net/sfc/base/efx_mcdi.c:1322:
+		if ((rc = emcop->emco_feature_supported(enp,

ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#1633: FILE: drivers/net/sfc/base/efx_mcdi.c:1330:
+	return (0);

ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#1638: FILE: drivers/net/sfc/base/efx_mcdi.c:1335:
+	return (rc);

ERROR:ASSIGN_IN_IF: do not use assignment in if condition
#1650: FILE: drivers/net/sfc/base/efx_mcdi.c:1347:
+		if ((rc = emcop->emco_feature_supported(enp,

ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#1658: FILE: drivers/net/sfc/base/efx_mcdi.c:1355:
+	return (0);

ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#1663: FILE: drivers/net/sfc/base/efx_mcdi.c:1360:
+	return (rc);

ERROR:ASSIGN_IN_IF: do not use assignment in if condition
#1675: FILE: drivers/net/sfc/base/efx_mcdi.c:1372:
+		if ((rc = emcop->emco_feature_supported(enp,

ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#1683: FILE: drivers/net/sfc/base/efx_mcdi.c:1380:
+	return (0);

ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#1688: FILE: drivers/net/sfc/base/efx_mcdi.c:1385:
+	return (rc);

CHECK:SPACING: No space is necessary after a cast
#1702: FILE: drivers/net/sfc/base/efx_mcdi.c:1399:
+	(void) memset(payload, 0, sizeof (payload));

WARNING:SPACING: space prohibited between function name and open parenthesis '('
#1702: FILE: drivers/net/sfc/base/efx_mcdi.c:1399:
+	(void) memset(payload, 0, sizeof (payload));

ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#1720: FILE: drivers/net/sfc/base/efx_mcdi.c:1417:
+	return (0);

ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#1725: FILE: drivers/net/sfc/base/efx_mcdi.c:1422:
+	return (rc);

CHECK:SPACING: No space is necessary after a cast
#1741: FILE: drivers/net/sfc/base/efx_mcdi.c:1438:
+	(void) memset(payload, 0, sizeof (payload));

WARNING:SPACING: space prohibited between function name and open parenthesis '('
#1741: FILE: drivers/net/sfc/base/efx_mcdi.c:1438:
+	(void) memset(payload, 0, sizeof (payload));

ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#1765: FILE: drivers/net/sfc/base/efx_mcdi.c:1462:
+	return (0);

ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#1770: FILE: drivers/net/sfc/base/efx_mcdi.c:1467:
+	return (rc);

CHECK:SPACING: No space is necessary after a cast
#1784: FILE: drivers/net/sfc/base/efx_mcdi.c:1481:
+	(void) memset(payload, 0, sizeof (payload));

WARNING:SPACING: space prohibited between function name and open parenthesis '('
#1784: FILE: drivers/net/sfc/base/efx_mcdi.c:1481:
+	(void) memset(payload, 0, sizeof (payload));

WARNING:BRACES: braces {} are not necessary for single statement blocks
#1803: FILE: drivers/net/sfc/base/efx_mcdi.c:1500:
+	if (enabledp != NULL) {
+		*enabledp = MCDI_OUT_DWORD(req, GET_WORKAROUNDS_OUT_ENABLED);
+	}

ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#1807: FILE: drivers/net/sfc/base/efx_mcdi.c:1504:
+	return (0);

ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#1812: FILE: drivers/net/sfc/base/efx_mcdi.c:1509:
+	return (rc);

CHECK:SPACING: No space is necessary after a cast
#1837: FILE: drivers/net/sfc/base/efx_mcdi.c:1534:
+	(void) memset(payload, 0, sizeof (payload));

WARNING:SPACING: space prohibited between function name and open parenthesis '('
#1837: FILE: drivers/net/sfc/base/efx_mcdi.c:1534:
+	(void) memset(payload, 0, sizeof (payload));

ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#1870: FILE: drivers/net/sfc/base/efx_mcdi.c:1567:
+	return (0);

ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#1879: FILE: drivers/net/sfc/base/efx_mcdi.c:1576:
+	return (rc);

CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around enp->en_port
#1911: FILE: drivers/net/sfc/base/efx_mcdi.c:1608:
+	efx_port_t *epp = &(enp->en_port);

ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#2016: FILE: drivers/net/sfc/base/efx_mcdi.c:1713:
+	return (0);

ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#2025: FILE: drivers/net/sfc/base/efx_mcdi.c:1722:
+	return (rc);

CHECK:MACRO_ARG_PRECEDENCE: Macro argument '_type' may be better as '(_type)' to avoid precedence issues
#2236: FILE: drivers/net/sfc/base/efx_mcdi.h:202:
+#define	MCDI_IN(_emr, _type, _ofst)					\
+	((_type *)((_emr).emr_in_buf + (_ofst)))

CHECK:MACRO_ARG_PRECEDENCE: Macro argument '_type' may be better as '(_type)' to avoid precedence issues
#2361: FILE: drivers/net/sfc/base/efx_mcdi.h:327:
+#define	MCDI_OUT(_emr, _type, _ofst)					\
+	((_type *)((_emr).emr_out_buf + (_ofst)))

CHECK:MACRO_ARG_PRECEDENCE: Macro argument '_eqp' may be better as '(_eqp)' to avoid precedence issues
#2383: FILE: drivers/net/sfc/base/efx_mcdi.h:349:
+#define	MCDI_EV_FIELD(_eqp, _field)					\
+	EFX_QWORD_FIELD(*_eqp, MCDI_EVENT_ ## _field)

CHECK:MACRO_ARG_PRECEDENCE: Macro argument '_edp' may be better as '(_edp)' to avoid precedence issues
#2386: FILE: drivers/net/sfc/base/efx_mcdi.h:352:
+#define	MCDI_CMD_DWORD_FIELD(_edp, _field)				\
+	EFX_DWORD_FIELD(*_edp, MC_CMD_ ## _field)

total: 77 errors, 59 warnings, 39 checks, 2289 lines checked
Previous message: [dpdk-test-report] |SUCCESS| [PATCH v2 32/55] net/sfc: add device configure and close stubs
Next message: [dpdk-test-report] |WARNING| [PATCH v2 13/55] net/sfc: import libefx built-in selftest support
Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]
More information about the test-report mailing list