[dpdk-test-report] |WARNING| [PATCH v2 26/55] net/sfc: import libefx NVRAM support

checkpatch at dpdk.org checkpatch at dpdk.org
Tue Nov 29 17:34:00 CET 2016
Previous message: [dpdk-test-report] |WARNING| [PATCH v2 10/55] net/sfc: import libefx SFN7xxx family support
Next message: [dpdk-test-report] |SUCCESS| [PATCH v2 42/55] net/sfc: implement device operation to retrieve link info
Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]
Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/17315

_coding style issues_


CHECK:CAMELCASE: Avoid CamelCase: <__checkReturn>
#103: FILE: drivers/net/sfc/base/ef10_impl.h:344:
+extern	__checkReturn		efx_rc_t

ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#416: FILE: drivers/net/sfc/base/ef10_nvram.c:85:
+	return (tag);

ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#426: FILE: drivers/net/sfc/base/ef10_nvram.c:95:
+		return (0);

ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#431: FILE: drivers/net/sfc/base/ef10_nvram.c:100:
+	return ((size_t)length);

ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#439: FILE: drivers/net/sfc/base/ef10_nvram.c:108:
+		return (NULL);

ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#449: FILE: drivers/net/sfc/base/ef10_nvram.c:118:
+		return (NULL);

WARNING:SPACING: space prohibited between function name and open parenthesis '('
#459: FILE: drivers/net/sfc/base/ef10_nvram.c:128:
+	(1 + 1 + (((length) + sizeof (uint32_t) - 1) / sizeof (uint32_t)))

WARNING:SPACING: space prohibited between function name and open parenthesis '('
#459: FILE: drivers/net/sfc/base/ef10_nvram.c:128:
+	(1 + 1 + (((length) + sizeof (uint32_t) - 1) / sizeof (uint32_t)))

ERROR:ASSIGN_IN_IF: do not use assignment in if condition
#479: FILE: drivers/net/sfc/base/ef10_nvram.c:148:
+	if ((rc = tlv_validate_state(cursor)) != 0)

ERROR:ASSIGN_IN_IF: do not use assignment in if condition
#492: FILE: drivers/net/sfc/base/ef10_nvram.c:161:
+	if ((rc = tlv_validate_state(cursor)) != 0)

ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#495: FILE: drivers/net/sfc/base/ef10_nvram.c:164:
+	return (0);

ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#504: FILE: drivers/net/sfc/base/ef10_nvram.c:173:
+	return (rc);

ERROR:ASSIGN_IN_IF: do not use assignment in if condition
#515: FILE: drivers/net/sfc/base/ef10_nvram.c:184:
+	if ((rc = tlv_validate_state(cursor)) != 0)

ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#518: FILE: drivers/net/sfc/base/ef10_nvram.c:187:
+	return (0);

ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#523: FILE: drivers/net/sfc/base/ef10_nvram.c:192:
+	return (rc);

ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#540: FILE: drivers/net/sfc/base/ef10_nvram.c:209:
+	return (rc);

ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#575: FILE: drivers/net/sfc/base/ef10_nvram.c:244:
+	return (0);

ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#586: FILE: drivers/net/sfc/base/ef10_nvram.c:255:
+	return (rc);

ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#602: FILE: drivers/net/sfc/base/ef10_nvram.c:271:
+	return (tlv_validate_state(cursor));

WARNING:SPACING: space prohibited between function name and open parenthesis '('
#613: FILE: drivers/net/sfc/base/ef10_nvram.c:282:
+	limit = (uint32_t *)(block + size - sizeof (uint32_t));

WARNING:SPACING: space prohibited between function name and open parenthesis '('
#628: FILE: drivers/net/sfc/base/ef10_nvram.c:297:
+	limit = (uint32_t *)(block + size - sizeof (uint32_t));

ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#630: FILE: drivers/net/sfc/base/ef10_nvram.c:299:
+	return (tlv_init_cursor(cursor, (uint32_t *)block, limit, current));

ERROR:ASSIGN_IN_IF: do not use assignment in if condition
#642: FILE: drivers/net/sfc/base/ef10_nvram.c:311:
+		if ((rc = tlv_find(cursor, TLV_TAG_END)) != 0)

ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#649: FILE: drivers/net/sfc/base/ef10_nvram.c:318:
+	return (0);

ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#654: FILE: drivers/net/sfc/base/ef10_nvram.c:323:
+	return (rc);

ERROR:ASSIGN_IN_IF: do not use assignment in if condition
#663: FILE: drivers/net/sfc/base/ef10_nvram.c:332:
+	if ((rc = tlv_validate_state(cursor)) != 0)

ERROR:ASSIGN_IN_IF: do not use assignment in if condition
#666: FILE: drivers/net/sfc/base/ef10_nvram.c:335:
+	if ((rc = tlv_require_end(cursor)) != 0)

WARNING:SPACING: space prohibited between function name and open parenthesis '('
#670: FILE: drivers/net/sfc/base/ef10_nvram.c:339:
+	return (cursor->end + 1 - cursor->block) * sizeof (uint32_t);

ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#677: FILE: drivers/net/sfc/base/ef10_nvram.c:346:
+	return (0);

ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#703: FILE: drivers/net/sfc/base/ef10_nvram.c:372:
+	return (last_segment_end);

WARNING:SPACING: space prohibited between function name and open parenthesis '('
#723: FILE: drivers/net/sfc/base/ef10_nvram.c:392:
+		ptr[(len - 1) / sizeof (uint32_t)] = 0;

WARNING:SPACING: space prohibited between function name and open parenthesis '('
#725: FILE: drivers/net/sfc/base/ef10_nvram.c:394:
+		ptr += P2ROUNDUP(len, sizeof (uint32_t)) / sizeof (*ptr);

WARNING:SPACING: space prohibited between function name and open parenthesis '('
#725: FILE: drivers/net/sfc/base/ef10_nvram.c:394:
+		ptr += P2ROUNDUP(len, sizeof (uint32_t)) / sizeof (*ptr);

ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#728: FILE: drivers/net/sfc/base/ef10_nvram.c:397:
+	return (ptr);

ERROR:ASSIGN_IN_IF: do not use assignment in if condition
#743: FILE: drivers/net/sfc/base/ef10_nvram.c:412:
+	if ((rc = tlv_validate_state(cursor)) != 0)

ERROR:ASSIGN_IN_IF: do not use assignment in if condition
#746: FILE: drivers/net/sfc/base/ef10_nvram.c:415:
+	if ((rc = tlv_require_end(cursor)) != 0)

WARNING:SPACING: space prohibited between function name and open parenthesis '('
#764: FILE: drivers/net/sfc/base/ef10_nvram.c:433:
+	    (last_segment_end + 1 - cursor->current) * sizeof (uint32_t));

ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#772: FILE: drivers/net/sfc/base/ef10_nvram.c:441:
+	return (0);

ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#783: FILE: drivers/net/sfc/base/ef10_nvram.c:452:
+	return (rc);

ERROR:ASSIGN_IN_IF: do not use assignment in if condition
#794: FILE: drivers/net/sfc/base/ef10_nvram.c:463:
+	if ((rc = tlv_validate_state(cursor)) != 0)

ERROR:ASSIGN_IN_IF: do not use assignment in if condition
#804: FILE: drivers/net/sfc/base/ef10_nvram.c:473:
+	if ((rc = tlv_require_end(cursor)) != 0)

WARNING:SPACING: space prohibited between function name and open parenthesis '('
#811: FILE: drivers/net/sfc/base/ef10_nvram.c:480:
+	    (last_segment_end + 1 - cursor->current) * sizeof (uint32_t));

WARNING:SPACING: space prohibited between function name and open parenthesis '('
#813: FILE: drivers/net/sfc/base/ef10_nvram.c:482:
+	memset(last_segment_end + 1 - delta, 0, delta * sizeof (uint32_t));

ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#817: FILE: drivers/net/sfc/base/ef10_nvram.c:486:
+	return (0);

ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#826: FILE: drivers/net/sfc/base/ef10_nvram.c:495:
+	return (rc);

ERROR:ASSIGN_IN_IF: do not use assignment in if condition
#844: FILE: drivers/net/sfc/base/ef10_nvram.c:513:
+	if ((rc = tlv_validate_state(cursor)) != 0)

ERROR:ASSIGN_IN_IF: do not use assignment in if condition
#859: FILE: drivers/net/sfc/base/ef10_nvram.c:528:
+	if ((rc = tlv_require_end(cursor)) != 0)

WARNING:SPACING: space prohibited between function name and open parenthesis '('
#876: FILE: drivers/net/sfc/base/ef10_nvram.c:545:
+		    (last_segment_end + 1 - pos) * sizeof (uint32_t));

WARNING:SPACING: space prohibited between function name and open parenthesis '('
#888: FILE: drivers/net/sfc/base/ef10_nvram.c:557:
+		    (last_segment_end + 1 - pos) * sizeof (uint32_t));

WARNING:SPACING: space prohibited between function name and open parenthesis '('
#892: FILE: drivers/net/sfc/base/ef10_nvram.c:561:
+		    delta * sizeof (uint32_t));

ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#901: FILE: drivers/net/sfc/base/ef10_nvram.c:570:
+	return (0);

ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#914: FILE: drivers/net/sfc/base/ef10_nvram.c:583:
+	return (rc);

ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#937: FILE: drivers/net/sfc/base/ef10_nvram.c:606:
+	return (csum);

WARNING:SPACING: space prohibited between function name and open parenthesis '('
#956: FILE: drivers/net/sfc/base/ef10_nvram.c:625:
+	memcpy(&partition.tlv_cursor, cursor, sizeof (*cursor));

WARNING:SPACING: space prohibited between function name and open parenthesis '('
#974: FILE: drivers/net/sfc/base/ef10_nvram.c:643:
+	    new_len - sizeof (*trailer) - sizeof (uint32_t));

WARNING:SPACING: space prohibited between function name and open parenthesis '('
#974: FILE: drivers/net/sfc/base/ef10_nvram.c:643:
+	    new_len - sizeof (*trailer) - sizeof (uint32_t));

ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#980: FILE: drivers/net/sfc/base/ef10_nvram.c:649:
+	return (0);

ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#987: FILE: drivers/net/sfc/base/ef10_nvram.c:656:
+	return (rc);

WARNING:SPACING: space prohibited between function name and open parenthesis '('
#1006: FILE: drivers/net/sfc/base/ef10_nvram.c:675:
+	EFX_STATIC_ASSERT(sizeof (*header) <= EF10_NVRAM_CHUNK);

ERROR:ASSIGN_IN_IF: do not use assignment in if condition
#1014: FILE: drivers/net/sfc/base/ef10_nvram.c:683:
+	if ((rc = tlv_init_cursor_from_size(&cursor, (uint8_t *)partn_data,

ERROR:ASSIGN_IN_IF: do not use assignment in if condition
#1033: FILE: drivers/net/sfc/base/ef10_nvram.c:702:
+	if ((rc = tlv_find(&cursor, TLV_TAG_PARTITION_TRAILER)) != 0) {

ERROR:ASSIGN_IN_IF: do not use assignment in if condition
#1039: FILE: drivers/net/sfc/base/ef10_nvram.c:708:
+	if ((rc = tlv_advance(&cursor)) != 0) {

WARNING:SPACING: space prohibited between function name and open parenthesis '('
#1056: FILE: drivers/net/sfc/base/ef10_nvram.c:725:
+	for (pos = 0; (size_t)pos < total_length; pos += sizeof (uint32_t)) {

WARNING:BRACES: braces {} are not necessary for single statement blocks
#1056: FILE: drivers/net/sfc/base/ef10_nvram.c:725:
+	for (pos = 0; (size_t)pos < total_length; pos += sizeof (uint32_t)) {
+		cksum += *((uint32_t *)(partn_data + pos));
+	}

ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#1064: FILE: drivers/net/sfc/base/ef10_nvram.c:733:
+	return (0);

ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#1085: FILE: drivers/net/sfc/base/ef10_nvram.c:754:
+	return (rc);

WARNING:SPACING: space prohibited between function name and open parenthesis '('
#1103: FILE: drivers/net/sfc/base/ef10_nvram.c:772:
+	unsigned int min_buf_size = sizeof (struct tlv_partition_header) +

WARNING:SPACING: space prohibited between function name and open parenthesis '('
#1104: FILE: drivers/net/sfc/base/ef10_nvram.c:773:
+	    sizeof (struct tlv_partition_trailer);

ERROR:ASSIGN_IN_IF: do not use assignment in if condition
#1113: FILE: drivers/net/sfc/base/ef10_nvram.c:782:
+	if ((rc = tlv_init_cursor(&cursor, buf,

WARNING:SPACING: space prohibited between function name and open parenthesis '('
#1120: FILE: drivers/net/sfc/base/ef10_nvram.c:789:
+	header.length = __CPU_TO_LE_32(sizeof (header) - 8);

ERROR:ASSIGN_IN_IF: do not use assignment in if condition
#1125: FILE: drivers/net/sfc/base/ef10_nvram.c:794:
+	if ((rc = tlv_insert(

WARNING:SPACING: space prohibited between function name and open parenthesis '('
#1127: FILE: drivers/net/sfc/base/ef10_nvram.c:796:
+	    (uint8_t *)&header.type_id, sizeof (header) - 8)) != 0)

ERROR:ASSIGN_IN_IF: do not use assignment in if condition
#1129: FILE: drivers/net/sfc/base/ef10_nvram.c:798:
+	if ((rc = tlv_advance(&cursor)) != 0)

WARNING:SPACING: space prohibited between function name and open parenthesis '('
#1133: FILE: drivers/net/sfc/base/ef10_nvram.c:802:
+	trailer.length = __CPU_TO_LE_32(sizeof (trailer) - 8);

ERROR:ASSIGN_IN_IF: do not use assignment in if condition
#1136: FILE: drivers/net/sfc/base/ef10_nvram.c:805:
+	if ((rc = tlv_insert(&cursor, TLV_TAG_PARTITION_TRAILER,

WARNING:SPACING: space prohibited between function name and open parenthesis '('
#1137: FILE: drivers/net/sfc/base/ef10_nvram.c:806:
+	    (uint8_t *)&trailer.generation, sizeof (trailer) - 8)) != 0)

ERROR:ASSIGN_IN_IF: do not use assignment in if condition
#1140: FILE: drivers/net/sfc/base/ef10_nvram.c:809:
+	if ((rc = tlv_update_partition_len_and_cks(&cursor)) != 0)

ERROR:ASSIGN_IN_IF: do not use assignment in if condition
#1144: FILE: drivers/net/sfc/base/ef10_nvram.c:813:
+	if ((rc = ef10_nvram_buffer_validate(enp, partn_type,

ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#1148: FILE: drivers/net/sfc/base/ef10_nvram.c:817:
+	return (0);

ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#1165: FILE: drivers/net/sfc/base/ef10_nvram.c:834:
+	return (rc);

ERROR:ASSIGN_IN_IF: do not use assignment in if condition
#1188: FILE: drivers/net/sfc/base/ef10_nvram.c:857:
+	if ((rc = tlv_init_cursor_from_size(&cursor, (uint8_t *)bufferp,

ERROR:ASSIGN_IN_IF: do not use assignment in if condition
#1198: FILE: drivers/net/sfc/base/ef10_nvram.c:867:
+	if ((rc = tlv_advance(&cursor)) != 0) {

ERROR:ASSIGN_IN_IF: do not use assignment in if condition
#1204: FILE: drivers/net/sfc/base/ef10_nvram.c:873:
+	if ((rc = tlv_require_end(&cursor)) != 0)

ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#1207: FILE: drivers/net/sfc/base/ef10_nvram.c:876:
+	return (0);

ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#1218: FILE: drivers/net/sfc/base/ef10_nvram.c:887:
+	return (rc);

ERROR:ASSIGN_IN_IF: do not use assignment in if condition
#1236: FILE: drivers/net/sfc/base/ef10_nvram.c:905:
+	if ((rc = tlv_init_cursor_from_size(&cursor, (uint8_t *)bufferp,

WARNING:SPACING: space prohibited between function name and open parenthesis '('
#1266: FILE: drivers/net/sfc/base/ef10_nvram.c:935:
+	*endp = (segment_used - cursor.block) * sizeof (uint32_t);

ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#1268: FILE: drivers/net/sfc/base/ef10_nvram.c:937:
+	return (0);

ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#1275: FILE: drivers/net/sfc/base/ef10_nvram.c:944:
+	return (rc);

ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#1294: FILE: drivers/net/sfc/base/ef10_nvram.c:963:
+		return (B_FALSE);

WARNING:BRACES: braces {} are not necessary for single statement blocks
#1301: FILE: drivers/net/sfc/base/ef10_nvram.c:970:
+			if (tlv_advance(&cursor) != 0) {
+				break;
+			}

ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#1309: FILE: drivers/net/sfc/base/ef10_nvram.c:978:
+		return (B_TRUE);

ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#1312: FILE: drivers/net/sfc/base/ef10_nvram.c:981:
+	return (B_FALSE);

ERROR:ASSIGN_IN_IF: do not use assignment in if condition
#1336: FILE: drivers/net/sfc/base/ef10_nvram.c:1005:
+	if ((rc = tlv_init_cursor_at_offset(&cursor, (uint8_t *)bufferp,

ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#1350: FILE: drivers/net/sfc/base/ef10_nvram.c:1019:
+	return (0);

ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#1359: FILE: drivers/net/sfc/base/ef10_nvram.c:1028:
+	return (rc);

ERROR:ASSIGN_IN_IF: do not use assignment in if condition
#1375: FILE: drivers/net/sfc/base/ef10_nvram.c:1044:
+	if ((rc = tlv_init_cursor_at_offset(&cursor, (uint8_t *)bufferp,

WARNING:BRACES: braces {} are not necessary for single statement blocks
#1382: FILE: drivers/net/sfc/base/ef10_nvram.c:1051:
+	if (rc != 0) {
+		goto fail2;
+	}

ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#1389: FILE: drivers/net/sfc/base/ef10_nvram.c:1058:
+	return (0);

ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#1396: FILE: drivers/net/sfc/base/ef10_nvram.c:1065:
+	return (rc);

ERROR:ASSIGN_IN_IF: do not use assignment in if condition
#1413: FILE: drivers/net/sfc/base/ef10_nvram.c:1082:
+	if ((rc = tlv_init_cursor_at_offset(&cursor, (uint8_t *)bufferp,

ERROR:ASSIGN_IN_IF: do not use assignment in if condition
#1418: FILE: drivers/net/sfc/base/ef10_nvram.c:1087:
+	if ((rc = tlv_delete(&cursor)) != 0)

ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#1421: FILE: drivers/net/sfc/base/ef10_nvram.c:1090:
+	return (0);

ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#1428: FILE: drivers/net/sfc/base/ef10_nvram.c:1097:
+	return (rc);

ERROR:ASSIGN_IN_IF: do not use assignment in if condition
#1440: FILE: drivers/net/sfc/base/ef10_nvram.c:1109:
+	if ((rc = tlv_init_cursor_from_size(&cursor, (uint8_t *)bufferp,

ERROR:ASSIGN_IN_IF: do not use assignment in if condition
#1446: FILE: drivers/net/sfc/base/ef10_nvram.c:1115:
+	if ((rc = tlv_require_end(&cursor)) != 0)

ERROR:ASSIGN_IN_IF: do not use assignment in if condition
#1449: FILE: drivers/net/sfc/base/ef10_nvram.c:1118:
+	if ((rc = tlv_update_partition_len_and_cks(&cursor)) != 0)

ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#1452: FILE: drivers/net/sfc/base/ef10_nvram.c:1121:
+	return (0);

ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#1461: FILE: drivers/net/sfc/base/ef10_nvram.c:1130:
+	return (rc);

WARNING:SPACING: space prohibited between function name and open parenthesis '('
#1488: FILE: drivers/net/sfc/base/ef10_nvram.c:1157:
+	EFX_STATIC_ASSERT(sizeof (*header) <= EF10_NVRAM_CHUNK);

ERROR:ASSIGN_IN_IF: do not use assignment in if condition
#1496: FILE: drivers/net/sfc/base/ef10_nvram.c:1165:
+	if ((rc = ef10_nvram_partn_read_mode(enp, partn, seg_offset, seg_data,

ERROR:ASSIGN_IN_IF: do not use assignment in if condition
#1503: FILE: drivers/net/sfc/base/ef10_nvram.c:1172:
+	if ((rc = tlv_init_cursor_from_size(&cursor, (uint8_t *)seg_data,

ERROR:ASSIGN_IN_IF: do not use assignment in if condition
#1523: FILE: drivers/net/sfc/base/ef10_nvram.c:1192:
+		if ((rc = ef10_nvram_partn_read_mode(enp, partn,

ERROR:ASSIGN_IN_IF: do not use assignment in if condition
#1532: FILE: drivers/net/sfc/base/ef10_nvram.c:1201:
+	if ((rc = tlv_find(&cursor, TLV_TAG_PARTITION_TRAILER)) != 0) {

ERROR:ASSIGN_IN_IF: do not use assignment in if condition
#1538: FILE: drivers/net/sfc/base/ef10_nvram.c:1207:
+	if ((rc = tlv_advance(&cursor)) != 0) {

WARNING:SPACING: space prohibited between function name and open parenthesis '('
#1561: FILE: drivers/net/sfc/base/ef10_nvram.c:1230:
+	for (pos = 0; (size_t)pos < total_length; pos += sizeof (uint32_t)) {

WARNING:BRACES: braces {} are not necessary for single statement blocks
#1561: FILE: drivers/net/sfc/base/ef10_nvram.c:1230:
+	for (pos = 0; (size_t)pos < total_length; pos += sizeof (uint32_t)) {
+		cksum += *((uint32_t *)(seg_data + pos));
+	}

ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#1569: FILE: drivers/net/sfc/base/ef10_nvram.c:1238:
+	return (0);

ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#1594: FILE: drivers/net/sfc/base/ef10_nvram.c:1263:
+	return (rc);

ERROR:ASSIGN_IN_IF: do not use assignment in if condition
#1622: FILE: drivers/net/sfc/base/ef10_nvram.c:1291:
+	if ((rc = tlv_init_cursor_from_size(&cursor, (uint8_t *)seg_data,

ERROR:ASSIGN_IN_IF: do not use assignment in if condition
#1627: FILE: drivers/net/sfc/base/ef10_nvram.c:1296:
+	if ((rc = tlv_find(&cursor, tag)) != 0) {

CHECK:BRACES: braces {} should be used on all arms of this statement
#1634: FILE: drivers/net/sfc/base/ef10_nvram.c:1303:
+	if (length == 0)
[...]
+	else {
[...]

ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#1649: FILE: drivers/net/sfc/base/ef10_nvram.c:1318:
+	return (0);

ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#1660: FILE: drivers/net/sfc/base/ef10_nvram.c:1329:
+	return (rc);

ERROR:ASSIGN_IN_IF: do not use assignment in if condition
#1680: FILE: drivers/net/sfc/base/ef10_nvram.c:1349:
+	if ((rc = ef10_nvram_partn_size(enp, partn, &partn_size)) != 0)

ERROR:ASSIGN_IN_IF: do not use assignment in if condition
#1713: FILE: drivers/net/sfc/base/ef10_nvram.c:1382:
+	if ((rc = ef10_nvram_buf_read_tlv(enp, seg_data, partn_size,

ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#1722: FILE: drivers/net/sfc/base/ef10_nvram.c:1391:
+	return (0);

ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#1737: FILE: drivers/net/sfc/base/ef10_nvram.c:1406:
+	return (rc);

ERROR:ASSIGN_IN_IF: do not use assignment in if condition
#1756: FILE: drivers/net/sfc/base/ef10_nvram.c:1425:
+	if ((rc = tlv_init_cursor_from_size(&cursor, (uint8_t *)seg_data,

ERROR:ASSIGN_IN_IF: do not use assignment in if condition
#1775: FILE: drivers/net/sfc/base/ef10_nvram.c:1444:
+	if ((rc = tlv_find(&cursor, TLV_TAG_PARTITION_TRAILER)) != 0) {

ERROR:ASSIGN_IN_IF: do not use assignment in if condition
#1780: FILE: drivers/net/sfc/base/ef10_nvram.c:1449:
+	if ((rc = tlv_advance(&cursor)) != 0) {

WARNING:SPACING: space prohibited between function name and open parenthesis '('
#1792: FILE: drivers/net/sfc/base/ef10_nvram.c:1461:
+	for (pos = 0; (size_t)pos < *seg_sizep; pos += sizeof (uint32_t)) {

WARNING:BRACES: braces {} are not necessary for single statement blocks
#1792: FILE: drivers/net/sfc/base/ef10_nvram.c:1461:
+	for (pos = 0; (size_t)pos < *seg_sizep; pos += sizeof (uint32_t)) {
+		cksum += *((uint32_t *)(seg_data + pos));
+	}

ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#1838: FILE: drivers/net/sfc/base/ef10_nvram.c:1507:
+	return (0);

ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#1865: FILE: drivers/net/sfc/base/ef10_nvram.c:1534:
+	return (rc);

ERROR:ASSIGN_IN_IF: do not use assignment in if condition
#1890: FILE: drivers/net/sfc/base/ef10_nvram.c:1559:
+	if ((rc = tlv_init_cursor_from_size(&cursor, (uint8_t *)seg_data,

ERROR:ASSIGN_IN_IF: do not use assignment in if condition
#1902: FILE: drivers/net/sfc/base/ef10_nvram.c:1571:
+	if ((rc = tlv_find(&cursor, tag)) == 0) {

ERROR:ASSIGN_IN_IF: do not use assignment in if condition
#1904: FILE: drivers/net/sfc/base/ef10_nvram.c:1573:
+		if ((rc = tlv_modify(&cursor, tag,

ERROR:ASSIGN_IN_IF: do not use assignment in if condition
#1914: FILE: drivers/net/sfc/base/ef10_nvram.c:1583:
+		if ((rc = tlv_insert(&cursor, tag,

ERROR:ASSIGN_IN_IF: do not use assignment in if condition
#1922: FILE: drivers/net/sfc/base/ef10_nvram.c:1591:
+	if ((rc = tlv_find(&cursor, TLV_TAG_PARTITION_TRAILER)) != 0) {

WARNING:SPACING: space prohibited between function name and open parenthesis '('
#1943: FILE: drivers/net/sfc/base/ef10_nvram.c:1612:
+	for (pos = 0; (size_t)pos < *total_lengthp; pos += sizeof (uint32_t)) {

WARNING:BRACES: braces {} are not necessary for single statement blocks
#1943: FILE: drivers/net/sfc/base/ef10_nvram.c:1612:
+	for (pos = 0; (size_t)pos < *total_lengthp; pos += sizeof (uint32_t)) {
+		cksum += *((uint32_t *)(seg_data + pos));
+	}

ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#1948: FILE: drivers/net/sfc/base/ef10_nvram.c:1617:
+	return (0);

ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#1965: FILE: drivers/net/sfc/base/ef10_nvram.c:1634:
+	return (rc);

ERROR:ASSIGN_IN_IF: do not use assignment in if condition
#2029: FILE: drivers/net/sfc/base/ef10_nvram.c:1698:
+		if ((rc = ef10_nvram_buf_write_tlv(*seg_datap,

ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#2048: FILE: drivers/net/sfc/base/ef10_nvram.c:1717:
+	return (0);

ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#2057: FILE: drivers/net/sfc/base/ef10_nvram.c:1726:
+	return (rc);

ERROR:ASSIGN_IN_IF: do not use assignment in if condition
#2102: FILE: drivers/net/sfc/base/ef10_nvram.c:1771:
+	if ((rc = ef10_nvram_partn_size(enp, partn, &partn_size)) != 0)

ERROR:ASSIGN_IN_IF: do not use assignment in if condition
#2116: FILE: drivers/net/sfc/base/ef10_nvram.c:1785:
+	if ((rc = ef10_nvram_partn_lock(enp, partn)) != 0)

ERROR:ASSIGN_IN_IF: do not use assignment in if condition
#2150: FILE: drivers/net/sfc/base/ef10_nvram.c:1819:
+	if ((rc = ef10_nvram_partn_erase(enp, partn, 0, partn_size)) != 0)

ERROR:ASSIGN_IN_IF: do not use assignment in if condition
#2154: FILE: drivers/net/sfc/base/ef10_nvram.c:1823:
+	if ((rc = ef10_nvram_partn_write(enp, partn, 0, partn_data,

ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#2163: FILE: drivers/net/sfc/base/ef10_nvram.c:1832:
+	return (0);

ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#2184: FILE: drivers/net/sfc/base/ef10_nvram.c:1853:
+	return (rc);

ERROR:ASSIGN_IN_IF: do not use assignment in if condition
#2199: FILE: drivers/net/sfc/base/ef10_nvram.c:1868:
+	if ((rc = efx_mcdi_nvram_info(enp, partn, sizep,

ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#2203: FILE: drivers/net/sfc/base/ef10_nvram.c:1872:
+	return (0);

ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#2208: FILE: drivers/net/sfc/base/ef10_nvram.c:1877:
+	return (rc);

ERROR:ASSIGN_IN_IF: do not use assignment in if condition
#2218: FILE: drivers/net/sfc/base/ef10_nvram.c:1887:
+	if ((rc = efx_mcdi_nvram_update_start(enp, partn)) != 0)

ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#2221: FILE: drivers/net/sfc/base/ef10_nvram.c:1890:
+	return (0);

ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#2226: FILE: drivers/net/sfc/base/ef10_nvram.c:1895:
+	return (rc);

ERROR:ASSIGN_IN_IF: do not use assignment in if condition
#2244: FILE: drivers/net/sfc/base/ef10_nvram.c:1913:
+		if ((rc = efx_mcdi_nvram_read(enp, partn, offset,

ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#2254: FILE: drivers/net/sfc/base/ef10_nvram.c:1923:
+	return (0);

ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#2259: FILE: drivers/net/sfc/base/ef10_nvram.c:1928:
+	return (rc);

ERROR:ASSIGN_IN_IF: do not use assignment in if condition
#2288: FILE: drivers/net/sfc/base/ef10_nvram.c:1957:
+	if ((rc = efx_mcdi_nvram_info(enp, partn, NULL, NULL,

ERROR:ASSIGN_IN_IF: do not use assignment in if condition
#2293: FILE: drivers/net/sfc/base/ef10_nvram.c:1962:
+		if ((rc = efx_mcdi_nvram_erase(enp, partn, offset, size)) != 0)

ERROR:ASSIGN_IN_IF: do not use assignment in if condition
#2301: FILE: drivers/net/sfc/base/ef10_nvram.c:1970:
+			if ((rc = efx_mcdi_nvram_erase(enp, partn, offset,

ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#2309: FILE: drivers/net/sfc/base/ef10_nvram.c:1978:
+	return (0);

ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#2320: FILE: drivers/net/sfc/base/ef10_nvram.c:1989:
+	return (rc);

ERROR:ASSIGN_IN_IF: do not use assignment in if condition
#2335: FILE: drivers/net/sfc/base/ef10_nvram.c:2004:
+	if ((rc = efx_mcdi_nvram_info(enp, partn, NULL, NULL,

ERROR:ASSIGN_IN_IF: do not use assignment in if condition
#2355: FILE: drivers/net/sfc/base/ef10_nvram.c:2024:
+		if ((rc = efx_mcdi_nvram_write(enp, partn, offset,

ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#2365: FILE: drivers/net/sfc/base/ef10_nvram.c:2034:
+	return (0);

ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#2374: FILE: drivers/net/sfc/base/ef10_nvram.c:2043:
+	return (rc);

ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#2393: FILE: drivers/net/sfc/base/ef10_nvram.c:2062:
+	return (0);

ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#2398: FILE: drivers/net/sfc/base/ef10_nvram.c:2067:
+	return (rc);

WARNING:SPACING: space prohibited between function name and open parenthesis '('
#2417: FILE: drivers/net/sfc/base/ef10_nvram.c:2086:
+	size = sizeof (partn_version) - (2 * sizeof (uint32_t));

WARNING:SPACING: space prohibited between function name and open parenthesis '('
#2417: FILE: drivers/net/sfc/base/ef10_nvram.c:2086:
+	size = sizeof (partn_version) - (2 * sizeof (uint32_t));

ERROR:ASSIGN_IN_IF: do not use assignment in if condition
#2420: FILE: drivers/net/sfc/base/ef10_nvram.c:2089:
+	if ((rc = ef10_nvram_partn_write_segment_tlv(enp,

ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#2426: FILE: drivers/net/sfc/base/ef10_nvram.c:2095:
+	return (0);

ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#2431: FILE: drivers/net/sfc/base/ef10_nvram.c:2100:
+	return (rc);

ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#2538: FILE: drivers/net/sfc/base/ef10_nvram.c:2207:
+		return (EINVAL);

WARNING:USE_NEGATIVE_ERRNO: return of an errno should typically be negative (ie: return -EINVAL)
#2538: FILE: drivers/net/sfc/base/ef10_nvram.c:2207:
+		return (EINVAL);

ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#2540: FILE: drivers/net/sfc/base/ef10_nvram.c:2209:
+	return (0);

CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around enp->en_mcdi.em_emip
#2549: FILE: drivers/net/sfc/base/ef10_nvram.c:2218:
+	efx_mcdi_iface_t *emip = &(enp->en_mcdi.em_emip);

ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#2564: FILE: drivers/net/sfc/base/ef10_nvram.c:2233:
+				return (0);

ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#2569: FILE: drivers/net/sfc/base/ef10_nvram.c:2238:
+	return (ENOTSUP);

WARNING:USE_NEGATIVE_ERRNO: return of an errno should typically be negative (ie: return -ENOTSUP)
#2569: FILE: drivers/net/sfc/base/ef10_nvram.c:2238:
+	return (ENOTSUP);

CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around enp->en_mcdi.em_emip
#2580: FILE: drivers/net/sfc/base/ef10_nvram.c:2249:
+	efx_mcdi_iface_t *emip = &(enp->en_mcdi.em_emip);

ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#2594: FILE: drivers/net/sfc/base/ef10_nvram.c:2263:
+				return (0);

ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#2599: FILE: drivers/net/sfc/base/ef10_nvram.c:2268:
+	return (ENOTSUP);

WARNING:USE_NEGATIVE_ERRNO: return of an errno should typically be negative (ie: return -ENOTSUP)
#2599: FILE: drivers/net/sfc/base/ef10_nvram.c:2268:
+	return (ENOTSUP);

WARNING:SPACING: space prohibited between function name and open parenthesis '('
#2614: FILE: drivers/net/sfc/base/ef10_nvram.c:2283:
+	size = MC_CMD_NVRAM_PARTITIONS_OUT_TYPE_ID_MAXNUM * sizeof (uint32_t);

ERROR:ASSIGN_IN_IF: do not use assignment in if condition
#2621: FILE: drivers/net/sfc/base/ef10_nvram.c:2290:
+	if ((rc = efx_mcdi_nvram_partitions(enp, (caddr_t)partns, size,

ERROR:ASSIGN_IN_IF: do not use assignment in if condition
#2628: FILE: drivers/net/sfc/base/ef10_nvram.c:2297:
+		if ((rc = ef10_nvram_partn_to_type(enp, partns[i], &type)) != 0)

ERROR:ASSIGN_IN_IF: do not use assignment in if condition
#2631: FILE: drivers/net/sfc/base/ef10_nvram.c:2300:
+		if ((rc = efx_mcdi_nvram_test(enp, partns[i])) != 0)

ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#2636: FILE: drivers/net/sfc/base/ef10_nvram.c:2305:
+	return (0);

ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#2645: FILE: drivers/net/sfc/base/ef10_nvram.c:2314:
+	return (rc);

ERROR:ASSIGN_IN_IF: do not use assignment in if condition
#2662: FILE: drivers/net/sfc/base/ef10_nvram.c:2331:
+	if ((rc = efx_mcdi_nvram_metadata(enp, partn, subtypep,

ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#2666: FILE: drivers/net/sfc/base/ef10_nvram.c:2335:
+	return (0);

ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#2671: FILE: drivers/net/sfc/base/ef10_nvram.c:2340:
+	return (rc);

ERROR:ASSIGN_IN_IF: do not use assignment in if condition
#2682: FILE: drivers/net/sfc/base/ef10_nvram.c:2351:
+	if ((rc = ef10_nvram_partn_lock(enp, partn)) != 0)

ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#2688: FILE: drivers/net/sfc/base/ef10_nvram.c:2357:
+	return (0);

ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#2693: FILE: drivers/net/sfc/base/ef10_nvram.c:2362:
+	return (rc);

ERROR:ASSIGN_IN_IF: do not use assignment in if condition
#2703: FILE: drivers/net/sfc/base/ef10_nvram.c:2372:
+	if ((rc = ef10_nvram_partn_unlock(enp, partn, NULL)) != 0)

ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#2706: FILE: drivers/net/sfc/base/ef10_nvram.c:2375:
+	return (0);

ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#2711: FILE: drivers/net/sfc/base/ef10_nvram.c:2380:
+	return (rc);

ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#3093: FILE: drivers/net/sfc/base/efx_nvram.c:115:
+	return (0);

ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#3098: FILE: drivers/net/sfc/base/efx_nvram.c:120:
+	return (rc);

ERROR:ASSIGN_IN_IF: do not use assignment in if condition
#3113: FILE: drivers/net/sfc/base/efx_nvram.c:135:
+	if ((rc = envop->envo_test(enp)) != 0)

ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#3116: FILE: drivers/net/sfc/base/efx_nvram.c:138:
+	return (0);

ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#3121: FILE: drivers/net/sfc/base/efx_nvram.c:143:
+	return (rc);

ERROR:ASSIGN_IN_IF: do not use assignment in if condition
#3141: FILE: drivers/net/sfc/base/efx_nvram.c:163:
+	if ((rc = envop->envo_type_to_partn(enp, type, &partn)) != 0)

ERROR:ASSIGN_IN_IF: do not use assignment in if condition
#3144: FILE: drivers/net/sfc/base/efx_nvram.c:166:
+	if ((rc = envop->envo_partn_size(enp, partn, sizep)) != 0)

ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#3147: FILE: drivers/net/sfc/base/efx_nvram.c:169:
+	return (0);

ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#3155: FILE: drivers/net/sfc/base/efx_nvram.c:177:
+	return (rc);

ERROR:ASSIGN_IN_IF: do not use assignment in if condition
#3175: FILE: drivers/net/sfc/base/efx_nvram.c:197:
+	if ((rc = envop->envo_type_to_partn(enp, type, &partn)) != 0)

ERROR:ASSIGN_IN_IF: do not use assignment in if condition
#3178: FILE: drivers/net/sfc/base/efx_nvram.c:200:
+	if ((rc = envop->envo_partn_get_version(enp, partn,

ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#3182: FILE: drivers/net/sfc/base/efx_nvram.c:204:
+	return (0);

ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#3189: FILE: drivers/net/sfc/base/efx_nvram.c:211:
+	return (rc);

ERROR:ASSIGN_IN_IF: do not use assignment in if condition
#3210: FILE: drivers/net/sfc/base/efx_nvram.c:232:
+	if ((rc = envop->envo_type_to_partn(enp, type, &partn)) != 0)

ERROR:ASSIGN_IN_IF: do not use assignment in if condition
#3213: FILE: drivers/net/sfc/base/efx_nvram.c:235:
+	if ((rc = envop->envo_partn_rw_start(enp, partn, chunk_sizep)) != 0)

ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#3218: FILE: drivers/net/sfc/base/efx_nvram.c:240:
+	return (0);

ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#3225: FILE: drivers/net/sfc/base/efx_nvram.c:247:
+	return (rc);

ERROR:ASSIGN_IN_IF: do not use assignment in if condition
#3248: FILE: drivers/net/sfc/base/efx_nvram.c:270:
+	if ((rc = envop->envo_type_to_partn(enp, type, &partn)) != 0)

ERROR:ASSIGN_IN_IF: do not use assignment in if condition
#3251: FILE: drivers/net/sfc/base/efx_nvram.c:273:
+	if ((rc = envop->envo_partn_read(enp, partn, offset, data, size)) != 0)

ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#3254: FILE: drivers/net/sfc/base/efx_nvram.c:276:
+	return (0);

ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#3261: FILE: drivers/net/sfc/base/efx_nvram.c:283:
+	return (rc);

ERROR:ASSIGN_IN_IF: do not use assignment in if condition
#3283: FILE: drivers/net/sfc/base/efx_nvram.c:305:
+	if ((rc = envop->envo_type_to_partn(enp, type, &partn)) != 0)

ERROR:ASSIGN_IN_IF: do not use assignment in if condition
#3286: FILE: drivers/net/sfc/base/efx_nvram.c:308:
+	if ((rc = envop->envo_partn_size(enp, partn, &size)) != 0)

ERROR:ASSIGN_IN_IF: do not use assignment in if condition
#3289: FILE: drivers/net/sfc/base/efx_nvram.c:311:
+	if ((rc = envop->envo_partn_erase(enp, partn, offset, size)) != 0)

ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#3292: FILE: drivers/net/sfc/base/efx_nvram.c:314:
+	return (0);

ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#3301: FILE: drivers/net/sfc/base/efx_nvram.c:323:
+	return (rc);

ERROR:ASSIGN_IN_IF: do not use assignment in if condition
#3324: FILE: drivers/net/sfc/base/efx_nvram.c:346:
+	if ((rc = envop->envo_type_to_partn(enp, type, &partn)) != 0)

ERROR:ASSIGN_IN_IF: do not use assignment in if condition
#3327: FILE: drivers/net/sfc/base/efx_nvram.c:349:
+	if ((rc = envop->envo_partn_write(enp, partn, offset, data, size)) != 0)

ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#3330: FILE: drivers/net/sfc/base/efx_nvram.c:352:
+	return (0);

ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#3337: FILE: drivers/net/sfc/base/efx_nvram.c:359:
+	return (rc);

ERROR:ASSIGN_IN_IF: do not use assignment in if condition
#3357: FILE: drivers/net/sfc/base/efx_nvram.c:379:
+	if ((rc = envop->envo_type_to_partn(enp, type, &partn)) != 0)

ERROR:ASSIGN_IN_IF: do not use assignment in if condition
#3360: FILE: drivers/net/sfc/base/efx_nvram.c:382:
+	if ((rc = envop->envo_partn_rw_finish(enp, partn)) != 0)

ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#3365: FILE: drivers/net/sfc/base/efx_nvram.c:387:
+	return (0);

ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#3374: FILE: drivers/net/sfc/base/efx_nvram.c:396:
+	return (rc);

ERROR:ASSIGN_IN_IF: do not use assignment in if condition
#3400: FILE: drivers/net/sfc/base/efx_nvram.c:422:
+	if ((rc = envop->envo_type_to_partn(enp, type, &partn)) != 0)

ERROR:ASSIGN_IN_IF: do not use assignment in if condition
#3403: FILE: drivers/net/sfc/base/efx_nvram.c:425:
+	if ((rc = envop->envo_partn_set_version(enp, partn, version)) != 0)

ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#3406: FILE: drivers/net/sfc/base/efx_nvram.c:428:
+	return (0);

ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#3413: FILE: drivers/net/sfc/base/efx_nvram.c:435:
+	return (rc);

ERROR:ASSIGN_IN_IF: do not use assignment in if condition
#3435: FILE: drivers/net/sfc/base/efx_nvram.c:457:
+	if ((rc = envop->envo_type_to_partn(enp, type, &partn)) != 0)

ERROR:ASSIGN_IN_IF: do not use assignment in if condition
#3438: FILE: drivers/net/sfc/base/efx_nvram.c:460:
+	if (envop->envo_type_to_partn != NULL &&

ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#3443: FILE: drivers/net/sfc/base/efx_nvram.c:465:
+	return (0);

ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#3450: FILE: drivers/net/sfc/base/efx_nvram.c:472:
+	return (rc);

CHECK:SPACING: No space is necessary after a cast
#3489: FILE: drivers/net/sfc/base/efx_nvram.c:511:
+	(void) memset(payload, 0, sizeof (payload));

WARNING:SPACING: space prohibited between function name and open parenthesis '('
#3489: FILE: drivers/net/sfc/base/efx_nvram.c:511:
+	(void) memset(payload, 0, sizeof (payload));

WARNING:SPACING: space prohibited between function name and open parenthesis '('
#3514: FILE: drivers/net/sfc/base/efx_nvram.c:536:
+	if (size < npartn * sizeof (uint32_t)) {

WARNING:SPACING: space prohibited between function name and open parenthesis '('
#3523: FILE: drivers/net/sfc/base/efx_nvram.c:545:
+	    (npartn * sizeof (uint32_t)));

ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#3525: FILE: drivers/net/sfc/base/efx_nvram.c:547:
+	return (0);

ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#3534: FILE: drivers/net/sfc/base/efx_nvram.c:556:
+	return (rc);

CHECK:SPACING: No space is necessary after a cast
#3551: FILE: drivers/net/sfc/base/efx_nvram.c:573:
+	(void) memset(payload, 0, sizeof (payload));

WARNING:SPACING: space prohibited between function name and open parenthesis '('
#3551: FILE: drivers/net/sfc/base/efx_nvram.c:573:
+	(void) memset(payload, 0, sizeof (payload));

CHECK:MULTIPLE_ASSIGNMENTS: multiple assignments should be avoided
#3586: FILE: drivers/net/sfc/base/efx_nvram.c:608:
+		version[0] = version[1] = version[2] = version[3] = 0;

WARNING:TYPO_SPELLING: 'descrition' may be misspelled - perhaps 'description'?
#3591: FILE: drivers/net/sfc/base/efx_nvram.c:613:
+		/* Return optional descrition string */

ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#3616: FILE: drivers/net/sfc/base/efx_nvram.c:638:
+	return (0);

ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#3625: FILE: drivers/net/sfc/base/efx_nvram.c:647:
+	return (rc);

CHECK:SPACING: No space is necessary after a cast
#3642: FILE: drivers/net/sfc/base/efx_nvram.c:664:
+	(void) memset(payload, 0, sizeof (payload));

WARNING:SPACING: space prohibited between function name and open parenthesis '('
#3642: FILE: drivers/net/sfc/base/efx_nvram.c:664:
+	(void) memset(payload, 0, sizeof (payload));

ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#3679: FILE: drivers/net/sfc/base/efx_nvram.c:701:
+	return (0);

ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#3686: FILE: drivers/net/sfc/base/efx_nvram.c:708:
+	return (rc);

CHECK:SPACING: No space is necessary after a cast
#3703: FILE: drivers/net/sfc/base/efx_nvram.c:725:
+	(void) memset(payload, 0, sizeof (payload));

WARNING:SPACING: space prohibited between function name and open parenthesis '('
#3703: FILE: drivers/net/sfc/base/efx_nvram.c:725:
+	(void) memset(payload, 0, sizeof (payload));

ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#3722: FILE: drivers/net/sfc/base/efx_nvram.c:744:
+	return (0);

ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#3727: FILE: drivers/net/sfc/base/efx_nvram.c:749:
+	return (rc);

CHECK:SPACING: No space is necessary after a cast
#3749: FILE: drivers/net/sfc/base/efx_nvram.c:771:
+	(void) memset(payload, 0, sizeof (payload));

WARNING:SPACING: space prohibited between function name and open parenthesis '('
#3749: FILE: drivers/net/sfc/base/efx_nvram.c:771:
+	(void) memset(payload, 0, sizeof (payload));

ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#3777: FILE: drivers/net/sfc/base/efx_nvram.c:799:
+	return (0);

ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#3784: FILE: drivers/net/sfc/base/efx_nvram.c:806:
+	return (rc);

CHECK:SPACING: No space is necessary after a cast
#3799: FILE: drivers/net/sfc/base/efx_nvram.c:821:
+	(void) memset(payload, 0, sizeof (payload));

WARNING:SPACING: space prohibited between function name and open parenthesis '('
#3799: FILE: drivers/net/sfc/base/efx_nvram.c:821:
+	(void) memset(payload, 0, sizeof (payload));

ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#3817: FILE: drivers/net/sfc/base/efx_nvram.c:839:
+	return (0);

ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#3822: FILE: drivers/net/sfc/base/efx_nvram.c:844:
+	return (rc);

CHECK:SPACING: No space is necessary after a cast
#3855: FILE: drivers/net/sfc/base/efx_nvram.c:877:
+	(void) memset(payload, 0, sizeof (payload));

WARNING:SPACING: space prohibited between function name and open parenthesis '('
#3855: FILE: drivers/net/sfc/base/efx_nvram.c:877:
+	(void) memset(payload, 0, sizeof (payload));

ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#3876: FILE: drivers/net/sfc/base/efx_nvram.c:898:
+	return (0);

ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#3883: FILE: drivers/net/sfc/base/efx_nvram.c:905:
+	return (rc);

CHECK:SPACING: No space is necessary after a cast
#3905: FILE: drivers/net/sfc/base/efx_nvram.c:927:
+	(void) memset(payload, 0, sizeof (payload));

WARNING:SPACING: space prohibited between function name and open parenthesis '('
#3905: FILE: drivers/net/sfc/base/efx_nvram.c:927:
+	(void) memset(payload, 0, sizeof (payload));

ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#3948: FILE: drivers/net/sfc/base/efx_nvram.c:970:
+	return (0);

ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#3961: FILE: drivers/net/sfc/base/efx_nvram.c:983:
+	return (rc);

CHECK:SPACING: No space is necessary after a cast
#3977: FILE: drivers/net/sfc/base/efx_nvram.c:999:
+	(void) memset(payload, 0, sizeof (payload));

WARNING:SPACING: space prohibited between function name and open parenthesis '('
#3977: FILE: drivers/net/sfc/base/efx_nvram.c:999:
+	(void) memset(payload, 0, sizeof (payload));

CHECK:BRACES: Blank lines aren't necessary after an open brace '{'
#4000: FILE: drivers/net/sfc/base/efx_nvram.c:1022:
+	if (result == MC_CMD_NVRAM_TEST_FAIL) {
+

ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#4007: FILE: drivers/net/sfc/base/efx_nvram.c:1029:
+	return (0);

ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#4016: FILE: drivers/net/sfc/base/efx_nvram.c:1038:
+	return (rc);

CHECK:SPACING: No space is necessary after a cast
#4153: FILE: drivers/net/sfc/base/siena_nic.c:49:
+	(void) memset(payload, 0, sizeof (payload));

WARNING:SPACING: space prohibited between function name and open parenthesis '('
#4153: FILE: drivers/net/sfc/base/siena_nic.c:49:
+	(void) memset(payload, 0, sizeof (payload));

ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#4174: FILE: drivers/net/sfc/base/siena_nic.c:70:
+	return (0);

ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#4181: FILE: drivers/net/sfc/base/siena_nic.c:77:
+	return (rc);

ERROR:ASSIGN_IN_IF: do not use assignment in if condition
#4194: FILE: drivers/net/sfc/base/siena_nic.c:259:
+	if ((rc = siena_nic_get_partn_mask(enp, &mask)) != 0)

ERROR:ASSIGN_IN_IF: do not use assignment in if condition
#4269: FILE: drivers/net/sfc/base/siena_nvram.c:51:
+	if ((rc = efx_mcdi_nvram_info(enp, partn, sizep,

ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#4274: FILE: drivers/net/sfc/base/siena_nvram.c:56:
+	return (0);

ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#4281: FILE: drivers/net/sfc/base/siena_nvram.c:63:
+	return (rc);

ERROR:ASSIGN_IN_IF: do not use assignment in if condition
#4291: FILE: drivers/net/sfc/base/siena_nvram.c:73:
+	if ((rc = efx_mcdi_nvram_update_start(enp, partn)) != 0) {

WARNING:BRACES: braces {} are not necessary for single statement blocks
#4291: FILE: drivers/net/sfc/base/siena_nvram.c:73:
+	if ((rc = efx_mcdi_nvram_update_start(enp, partn)) != 0) {
+		goto fail1;
+	}

ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#4295: FILE: drivers/net/sfc/base/siena_nvram.c:77:
+	return (0);

ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#4300: FILE: drivers/net/sfc/base/siena_nvram.c:82:
+	return (rc);

ERROR:ASSIGN_IN_IF: do not use assignment in if condition
#4317: FILE: drivers/net/sfc/base/siena_nvram.c:99:
+		if ((rc = efx_mcdi_nvram_read(enp, partn, offset, data, chunk,

ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#4327: FILE: drivers/net/sfc/base/siena_nvram.c:109:
+	return (0);

ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#4332: FILE: drivers/net/sfc/base/siena_nvram.c:114:
+	return (rc);

ERROR:ASSIGN_IN_IF: do not use assignment in if condition
#4344: FILE: drivers/net/sfc/base/siena_nvram.c:126:
+	if ((rc = efx_mcdi_nvram_erase(enp, partn, offset, size)) != 0) {

WARNING:BRACES: braces {} are not necessary for single statement blocks
#4344: FILE: drivers/net/sfc/base/siena_nvram.c:126:
+	if ((rc = efx_mcdi_nvram_erase(enp, partn, offset, size)) != 0) {
+		goto fail1;
+	}

ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#4348: FILE: drivers/net/sfc/base/siena_nvram.c:130:
+	return (0);

ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#4353: FILE: drivers/net/sfc/base/siena_nvram.c:135:
+	return (rc);

ERROR:ASSIGN_IN_IF: do not use assignment in if condition
#4370: FILE: drivers/net/sfc/base/siena_nvram.c:152:
+		if ((rc = efx_mcdi_nvram_write(enp, partn, offset,

ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#4380: FILE: drivers/net/sfc/base/siena_nvram.c:162:
+	return (0);

ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#4385: FILE: drivers/net/sfc/base/siena_nvram.c:167:
+	return (rc);

ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#4408: FILE: drivers/net/sfc/base/siena_nvram.c:190:
+	return (0);

ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#4413: FILE: drivers/net/sfc/base/siena_nvram.c:195:
+	return (rc);

CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around enp->en_mcdi.em_emip
#4457: FILE: drivers/net/sfc/base/siena_nvram.c:239:
+	efx_mcdi_iface_t *emip = &(enp->en_mcdi.em_emip);

ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#4468: FILE: drivers/net/sfc/base/siena_nvram.c:250:
+			return (0);

ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#4472: FILE: drivers/net/sfc/base/siena_nvram.c:254:
+	return (ENOTSUP);

WARNING:USE_NEGATIVE_ERRNO: return of an errno should typically be negative (ie: return -ENOTSUP)
#4472: FILE: drivers/net/sfc/base/siena_nvram.c:254:
+	return (ENOTSUP);

CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around enp->en_mcdi.em_emip
#4482: FILE: drivers/net/sfc/base/siena_nvram.c:264:
+	efx_mcdi_iface_t *emip = &(enp->en_mcdi.em_emip);

ERROR:ASSIGN_IN_IF: do not use assignment in if condition
#4498: FILE: drivers/net/sfc/base/siena_nvram.c:280:
+		if ((rc = efx_mcdi_nvram_test(enp, entry->partn)) != 0) {

WARNING:BRACES: braces {} are not necessary for single statement blocks
#4498: FILE: drivers/net/sfc/base/siena_nvram.c:280:
+		if ((rc = efx_mcdi_nvram_test(enp, entry->partn)) != 0) {
+			goto fail1;
+		}

ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#4503: FILE: drivers/net/sfc/base/siena_nvram.c:285:
+	return (0);

ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#4508: FILE: drivers/net/sfc/base/siena_nvram.c:290:
+	return (rc);

WARNING:SPACING: space prohibited between function name and open parenthesis '('
#4515: FILE: drivers/net/sfc/base/siena_nvram.c:297:
+	(sizeof (siena_mc_dynamic_config_hdr_t) + ((_nitems) *		\

WARNING:SPACING: space prohibited between function name and open parenthesis '('
#4516: FILE: drivers/net/sfc/base/siena_nvram.c:298:
+	sizeof (((siena_mc_dynamic_config_hdr_t *)NULL)->fw_version[0])))

ERROR:ASSIGN_IN_IF: do not use assignment in if condition
#4544: FILE: drivers/net/sfc/base/siena_nvram.c:326:
+	if ((rc = siena_nvram_partn_size(enp, partn, &size)) != 0)

ERROR:ASSIGN_IN_IF: do not use assignment in if condition
#4553: FILE: drivers/net/sfc/base/siena_nvram.c:335:
+	if ((rc = siena_nvram_partn_read(enp, partn, 0,

ERROR:ASSIGN_IN_IF: do not use assignment in if condition
#4587: FILE: drivers/net/sfc/base/siena_nvram.c:369:
+		if ((rc = siena_nvram_partn_read(enp, partn, SIENA_NVRAM_CHUNK,

WARNING:SPACING: space prohibited between function name and open parenthesis '('
#4618: FILE: drivers/net/sfc/base/siena_nvram.c:400:
+	EFX_POPULATE_WORD_1(dcfg->length, EFX_WORD_0, sizeof (*dcfg));

WARNING:SPACING: space prohibited between function name and open parenthesis '('
#4622: FILE: drivers/net/sfc/base/siena_nvram.c:404:
+			    EFX_DWORD_0, sizeof (*dcfg));

ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#4630: FILE: drivers/net/sfc/base/siena_nvram.c:412:
+	return (0);

ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#4644: FILE: drivers/net/sfc/base/siena_nvram.c:426:
+	return (rc);

CHECK:SPACING: No space is necessary after a cast
#4659: FILE: drivers/net/sfc/base/siena_nvram.c:441:
+	(void) memset(payload, 0, sizeof (payload));

WARNING:SPACING: space prohibited between function name and open parenthesis '('
#4659: FILE: drivers/net/sfc/base/siena_nvram.c:441:
+	(void) memset(payload, 0, sizeof (payload));

WARNING:SPACING: space prohibited between function name and open parenthesis '('
#4680: FILE: drivers/net/sfc/base/siena_nvram.c:462:
+	    (partn + 1) * sizeof (efx_word_t)) {

ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#4689: FILE: drivers/net/sfc/base/siena_nvram.c:471:
+	return (0);

ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#4698: FILE: drivers/net/sfc/base/siena_nvram.c:480:
+	return (rc);

ERROR:ASSIGN_IN_IF: do not use assignment in if condition
#4719: FILE: drivers/net/sfc/base/siena_nvram.c:501:
+	if ((rc = siena_nvram_get_subtype(enp, partn, subtypep)) != 0)

CHECK:MULTIPLE_ASSIGNMENTS: multiple assignments should be avoided
#4727: FILE: drivers/net/sfc/base/siena_nvram.c:509:
+	version[0] = version[1] = version[2] = version[3] = 0;

WARNING:TYPO_SPELLING: 'Ingore' may be misspelled - perhaps 'Ignore'?
#4742: FILE: drivers/net/sfc/base/siena_nvram.c:524:
+		 * Ingore missing partitions on port 2, assuming they're due

ERROR:ASSIGN_IN_IF: do not use assignment in if condition
#4750: FILE: drivers/net/sfc/base/siena_nvram.c:532:
+		if ((rc = siena_nvram_get_dynamic_cfg(enp, dcfg_partn,

WARNING:SPACING: space prohibited between function name and open parenthesis '('
#4764: FILE: drivers/net/sfc/base/siena_nvram.c:546:
+		if (memcmp(version, temp, sizeof (temp)) < 0)

WARNING:SPACING: space prohibited between function name and open parenthesis '('
#4765: FILE: drivers/net/sfc/base/siena_nvram.c:547:
+			memcpy(version, temp, sizeof (temp));

ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#4771: FILE: drivers/net/sfc/base/siena_nvram.c:553:
+	return (0);

ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#4780: FILE: drivers/net/sfc/base/siena_nvram.c:562:
+	return (rc);

ERROR:ASSIGN_IN_IF: do not use assignment in if condition
#4791: FILE: drivers/net/sfc/base/siena_nvram.c:573:
+	if ((rc = siena_nvram_partn_lock(enp, partn)) != 0)

ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#4797: FILE: drivers/net/sfc/base/siena_nvram.c:579:
+	return (0);

ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#4802: FILE: drivers/net/sfc/base/siena_nvram.c:584:
+	return (rc);

ERROR:ASSIGN_IN_IF: do not use assignment in if condition
#4812: FILE: drivers/net/sfc/base/siena_nvram.c:594:
+	if ((rc = siena_nvram_partn_unlock(enp, partn)) != 0)

ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#4815: FILE: drivers/net/sfc/base/siena_nvram.c:597:
+	return (0);

ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#4820: FILE: drivers/net/sfc/base/siena_nvram.c:602:
+	return (rc);

CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around enp->en_mcdi.em_emip
#4829: FILE: drivers/net/sfc/base/siena_nvram.c:611:
+	efx_mcdi_iface_t *emip = &(enp->en_mcdi.em_emip);

ERROR:ASSIGN_IN_IF: do not use assignment in if condition
#4849: FILE: drivers/net/sfc/base/siena_nvram.c:631:
+	if ((rc = siena_nvram_partn_size(enp, dcfg_partn, &dcfg_size)) != 0)

ERROR:ASSIGN_IN_IF: do not use assignment in if condition
#4852: FILE: drivers/net/sfc/base/siena_nvram.c:634:
+	if ((rc = siena_nvram_partn_lock(enp, dcfg_partn)) != 0)

ERROR:ASSIGN_IN_IF: do not use assignment in if condition
#4855: FILE: drivers/net/sfc/base/siena_nvram.c:637:
+	if ((rc = siena_nvram_get_dynamic_cfg(enp, dcfg_partn,

CHECK:SPACING: No space is necessary after a cast
#4875: FILE: drivers/net/sfc/base/siena_nvram.c:657:
+		(void) memmove((caddr_t)dcfg + required_hdr_length,

CHECK:SPACING: No space is necessary after a cast
#4883: FILE: drivers/net/sfc/base/siena_nvram.c:665:
+		(void) memset((caddr_t)dcfg + hdr_length, 0,

ERROR:ASSIGN_IN_IF: do not use assignment in if condition
#4891: FILE: drivers/net/sfc/base/siena_nvram.c:673:
+	if ((rc = siena_nvram_get_subtype(enp, partn, &subtype)) != 0)

ERROR:ASSIGN_IN_IF: do not use assignment in if condition
#4916: FILE: drivers/net/sfc/base/siena_nvram.c:698:
+	if ((rc = siena_nvram_partn_erase(enp, dcfg_partn, 0, dcfg_size)) != 0)

ERROR:ASSIGN_IN_IF: do not use assignment in if condition
#4920: FILE: drivers/net/sfc/base/siena_nvram.c:702:
+	if ((rc = siena_nvram_partn_write(enp, dcfg_partn, 0,

ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#4928: FILE: drivers/net/sfc/base/siena_nvram.c:710:
+	return (0);

ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#4947: FILE: drivers/net/sfc/base/siena_nvram.c:729:
+	return (rc);

total: 268 errors, 68 warnings, 23 checks, 4808 lines checked
Previous message: [dpdk-test-report] |WARNING| [PATCH v2 10/55] net/sfc: import libefx SFN7xxx family support
Next message: [dpdk-test-report] |SUCCESS| [PATCH v2 42/55] net/sfc: implement device operation to retrieve link info
Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]
More information about the test-report mailing list