[dpdk-test-report] |WARNING| pw27387 [PATCH v1 21/21] net/mlx5: support RSS hash configuration in generic flow action

checkpatch at dpdk.org checkpatch at dpdk.org
Wed Aug 2 16:17:26 CEST 2017


Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/27387

_coding style issues_


WARNING:USE_NEGATIVE_ERRNO: return of an errno should typically be negative (ie: return -ENOMEM)
#262: FILE: drivers/net/mlx5/mlx5_flow.c:1108:
+		return ENOMEM;

WARNING:USE_NEGATIVE_ERRNO: return of an errno should typically be negative (ie: return -ENOMEM)
#329: FILE: drivers/net/mlx5/mlx5_flow.c:1175:
+			return ENOMEM;

ERROR:POINTER_LOCATION: "(foo*)" should be "(foo *)"
#399: FILE: drivers/net/mlx5/mlx5_flow.c:1247:
+		      (void*)rte_flow, i, (void*)rte_flow->hrxqs[i],

ERROR:POINTER_LOCATION: "(foo*)" should be "(foo *)"
#399: FILE: drivers/net/mlx5/mlx5_flow.c:1247:
+		      (void*)rte_flow, i, (void*)rte_flow->hrxqs[i],

ERROR:POINTER_LOCATION: "(foo*)" should be "(foo *)"
#400: FILE: drivers/net/mlx5/mlx5_flow.c:1248:
+		      (void*)rte_flow->ibv_flows[i]);

ERROR:POINTER_LOCATION: "(foo*)" should be "(foo *)"
#497: FILE: drivers/net/mlx5/mlx5_flow.c:1416:
+			      (void*)flow, i, (void*)flow->hrxqs[i],

ERROR:POINTER_LOCATION: "(foo*)" should be "(foo *)"
#497: FILE: drivers/net/mlx5/mlx5_flow.c:1416:
+			      (void*)flow, i, (void*)flow->hrxqs[i],

ERROR:POINTER_LOCATION: "(foo*)" should be "(foo *)"
#498: FILE: drivers/net/mlx5/mlx5_flow.c:1417:
+			      (void*)flow->ibv_flows[i]);

WARNING:BRACES: braces {} are not necessary for single statement blocks
#565: FILE: drivers/net/mlx5/mlx5_flow.c:1564:
+				for (n = 0; n < queues_n; ++n) {
+					(*priv->rxqs)[queues[n]]->mark = 1;
+				}

total: 6 errors, 3 warnings, 0 checks, 599 lines checked


More information about the test-report mailing list