[dpdk-test-report] |WARNING| pw27759 [PATCH RFC v1] net/mlx4: support count flow action

checkpatch at dpdk.org checkpatch at dpdk.org
Fri Aug 25 12:26:39 CEST 2017


Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/27759

_coding style issues_


WARNING:SPACE_BEFORE_TAB: please, no space before tabs
#36: FILE: drivers/net/mlx4/mlx4_flow.c:116:
+#ifdef ^IHAVE_VERBS_IBV_EXP_FLOW_SPEC_ACTION_COUNT$

ERROR:SPACING: exactly one space required after that #ifdef
#36: FILE: drivers/net/mlx4/mlx4_flow.c:116:
+#ifdef 	HAVE_VERBS_IBV_EXP_FLOW_SPEC_ACTION_COUNT

ERROR:SPACING: space required before the open parenthesis '('
#54: FILE: drivers/net/mlx4/mlx4_flow.c:750:
+		} else if(actions->type == RTE_FLOW_ACTION_TYPE_COUNT) {

ERROR:SPACING: space required before the open parenthesis '('
#114: FILE: drivers/net/mlx4/mlx4_flow.c:1364:
+	if(res_value < 0) {

CHECK:BRACES: Blank lines aren't necessary before a close brace '}'
#118: FILE: drivers/net/mlx4/mlx4_flow.c:1368:
+
+	}

ERROR:SWITCH_CASE_INDENT_LEVEL: switch and case should be at the same indent
#140: FILE: drivers/net/mlx4/mlx4_flow.c:1390:
+	switch (type) {
+		case RTE_FLOW_ACTION_TYPE_COUNT:

ERROR:SPACING: space required before the open parenthesis '('
#143: FILE: drivers/net/mlx4/mlx4_flow.c:1393:
+			if(!flow->counter) {

ERROR:POINTER_LOCATION: "(foo*)" should be "(foo *)"
#151: FILE: drivers/net/mlx4/mlx4_flow.c:1401:
+							(struct rte_flow_query_count*)res,

total: 6 errors, 1 warnings, 1 checks, 153 lines checked


More information about the test-report mailing list