[dpdk-test-report] |WARNING| pw27989 [PATCH RFC 4/5] ixgbe: enable inline ipsec

checkpatch at dpdk.org checkpatch at dpdk.org
Fri Aug 25 17:02:17 CEST 2017


Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/27989

_coding style issues_


CHECK:MACRO_ARG_REUSE: Macro argument reuse '__reg' - possible side-effects?
#160: FILE: drivers/net/ixgbe/ixgbe_ipsec.c:47:
+#define IXGBE_WAIT_RW(__reg, __rw)			\
+{							\
+	IXGBE_WRITE_REG(hw, (__reg), reg);		\
+	while ((IXGBE_READ_REG(hw, (__reg))) & (__rw))	\
+	;						\
+}

CHECK:MACRO_ARG_REUSE: Macro argument reuse 'a' - possible side-effects?
#171: FILE: drivers/net/ixgbe/ixgbe_ipsec.c:58:
+#define CMP_IP(a, b)	\
+		((a).ipv6[0] == (b).ipv6[0] && (a).ipv6[1] == (b).ipv6[1] && \
+		(a).ipv6[2] == (b).ipv6[2] && (a).ipv6[3] == (b).ipv6[3])

CHECK:MACRO_ARG_REUSE: Macro argument reuse 'b' - possible side-effects?
#171: FILE: drivers/net/ixgbe/ixgbe_ipsec.c:58:
+#define CMP_IP(a, b)	\
+		((a).ipv6[0] == (b).ipv6[0] && (a).ipv6[1] == (b).ipv6[1] && \
+		(a).ipv6[2] == (b).ipv6[2] && (a).ipv6[3] == (b).ipv6[3])

CHECK:CAMELCASE: Avoid CamelCase: <IPv6>
#410: FILE: drivers/net/ixgbe/ixgbe_ipsec.c:297:
+		if (sess->dst_ip.type == IPv6)

CHECK:CAMELCASE: Avoid CamelCase: <IPv4>
#417: FILE: drivers/net/ixgbe/ixgbe_ipsec.c:304:
+		if (priv->rx_ip_table[ip_index].ip.type == IPv4) {

total: 0 errors, 0 warnings, 5 checks, 943 lines checked


More information about the test-report mailing list