[dpdk-test-report] |WARNING| pw32441 [PATCH RFC 16/23] eal/malloc: enable dynamic memory allocation/free on

checkpatch at dpdk.org checkpatch at dpdk.org
Tue Dec 19 12:11:44 CET 2017


Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/32441

_coding style issues_


ERROR:OPEN_BRACE: open brace '{' following function definitions go on the next line
#149: FILE: lib/librte_eal/common/malloc_elem.c:427:
+void
+malloc_elem_hide_region(struct malloc_elem *elem, void *start, size_t len) {

WARNING:UNSPECIFIED_INT: Prefer 'unsigned int' to bare use of 'unsigned'
#289: FILE: lib/librte_eal/common/malloc_heap.c:158:
+		unsigned flags, size_t align, size_t bound)

ERROR:OPEN_BRACE: open brace '{' following function definitions go on the next line
#310: FILE: lib/librte_eal/common/malloc_heap.c:176:
+static void *
+try_expand_heap(struct malloc_heap *heap, struct rte_memseg_list *msl,
+		const char *type, size_t size, int socket, unsigned flags,
+		size_t align, size_t bound) {

WARNING:UNSPECIFIED_INT: Prefer 'unsigned int' to bare use of 'unsigned'
#312: FILE: lib/librte_eal/common/malloc_heap.c:178:
+		const char *type, size_t size, int socket, unsigned flags,

WARNING:BRACES: braces {} are not necessary for single statement blocks
#363: FILE: lib/librte_eal/common/malloc_heap.c:229:
+	for (i = 0; i < n_pages; i++) {
+		eal_memalloc_free_page(ms[i]);
+	}

ERROR:OPEN_BRACE: open brace '{' following function definitions go on the next line
#371: FILE: lib/librte_eal/common/malloc_heap.c:237:
+static int
+compare_pagesz(const void *a, const void *b) {

ERROR:OPEN_BRACE: open brace '{' following function definitions go on the next line
#384: FILE: lib/librte_eal/common/malloc_heap.c:250:
+static void *
+heap_alloc_on_socket(const char *type, size_t size, int socket,
+		unsigned flags, size_t align, size_t bound) {

WARNING:UNSPECIFIED_INT: Prefer 'unsigned int' to bare use of 'unsigned'
#386: FILE: lib/librte_eal/common/malloc_heap.c:252:
+		unsigned flags, size_t align, size_t bound) {

WARNING:UNSPECIFIED_INT: Prefer 'unsigned int' to bare use of 'unsigned'
#393: FILE: lib/librte_eal/common/malloc_heap.c:259:
+	unsigned size_flags = flags & ~RTE_MEMZONE_SIZE_HINT_ONLY;

ERROR:OPEN_BRACE: open brace '{' following function definitions go on the next line
#484: FILE: lib/librte_eal/common/malloc_heap.c:350:
+void *
+malloc_heap_alloc(const char *type, size_t size, int socket_arg, unsigned flags,
+		size_t align, size_t bound) {

WARNING:UNSPECIFIED_INT: Prefer 'unsigned int' to bare use of 'unsigned'
#485: FILE: lib/librte_eal/common/malloc_heap.c:351:
+malloc_heap_alloc(const char *type, size_t size, int socket_arg, unsigned flags,

ERROR:POINTER_LOCATION: "(foo*)" should be "(foo *)"
#572: FILE: lib/librte_eal/common/malloc_heap.c:435:
+	malloc_elem_hide_region(elem, (void*) aligned_start, aligned_len);

WARNING:UNSPECIFIED_INT: Prefer 'unsigned int' to bare use of 'unsigned'
#604: FILE: lib/librte_eal/common/malloc_heap.h:56:
+malloc_heap_alloc(const char *type, size_t size, int socket, unsigned flags,

total: 6 errors, 7 warnings, 559 lines checked


More information about the test-report mailing list