[dpdk-test-report] |WARNING| pw32653 [PATCH v4 1/5] bbdev: introducing wireless base band device (BBDEV) abstraction

checkpatch at dpdk.org checkpatch at dpdk.org
Sat Dec 23 01:52:36 CET 2017


Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/32653

_coding style issues_


WARNING:MAINTAINERS_STYLE: MAINTAINERS entries use one tab after TYPE:
#59: FILE: MAINTAINERS:276:
+M: Amr Mokhtar <amr.mokhtar at intel.com>

WARNING:MAINTAINERS_STYLE: MAINTAINERS entries use one tab after TYPE:
#60: FILE: MAINTAINERS:277:
+F: lib/librte_bbdev/

WARNING:MAINTAINERS_STYLE: MAINTAINERS entries use one tab after TYPE:
#61: FILE: MAINTAINERS:278:
+F: doc/guides/prog_guide/bbdev.rst

WARNING:MACRO_WITH_FLOW_CONTROL: Macros with flow control statements should be avoided
#825: FILE: lib/librte_bbdev/rte_bbdev.c:31:
+#define VALID_DEV_OR_RET_ERR(dev, dev_id) do { \
+	if (dev == NULL) { \
+		rte_bbdev_log(ERR, "device %u is invalid", dev_id); \
+		return -ENODEV; \
+	} \
+} while (0)

WARNING:MACRO_WITH_FLOW_CONTROL: Macros with flow control statements should be avoided
#833: FILE: lib/librte_bbdev/rte_bbdev.c:39:
+#define VALID_DEV_OPS_OR_RET_ERR(dev, dev_id) do { \
+	if (dev->dev_ops == NULL) { \
+		rte_bbdev_log(ERR, "NULL dev_ops structure in device %u", \
+				dev_id); \
+		return -ENODEV; \
+	} \
+} while (0)

WARNING:MACRO_WITH_FLOW_CONTROL: Macros with flow control statements should be avoided
#842: FILE: lib/librte_bbdev/rte_bbdev.c:48:
+#define VALID_FUNC_OR_RET_ERR(func, dev_id) do { \
+	if (func == NULL) { \
+		rte_bbdev_log(ERR, "device %u does not support %s", \
+				dev_id, #func); \
+		return -ENOTSUP; \
+	} \
+} while (0)

WARNING:MACRO_WITH_FLOW_CONTROL: Macros with flow control statements should be avoided
#851: FILE: lib/librte_bbdev/rte_bbdev.c:57:
+#define VALID_QUEUE_OR_RET_ERR(queue_id, dev) do { \
+	if (queue_id >= dev->data->num_queues) { \
+		rte_bbdev_log(ERR, "Invalid queue_id %u for device %u", \
+				queue_id, dev->data->dev_id); \
+		return -ERANGE; \
+	} \
+} while (0)

total: 0 errors, 7 warnings, 3397 lines checked


More information about the test-report mailing list