[dpdk-test-report] |WARNING| pw20541 [PATCH] lpm: extend IPv6 next hop field

checkpatch at dpdk.org checkpatch at dpdk.org
Sun Feb 19 18:15:47 CET 2017


Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/20541

_coding style issues_


ERROR:SPACING: space required after that ',' (ctx:VxV)
#408: FILE: app/test/test_lpm6.c:1777:
+	uint8_t ip[] = {0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0};
 	                 ^

ERROR:SPACING: space required after that ',' (ctx:VxV)
#408: FILE: app/test/test_lpm6.c:1777:
+	uint8_t ip[] = {0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0};
 	                   ^

ERROR:SPACING: space required after that ',' (ctx:VxV)
#408: FILE: app/test/test_lpm6.c:1777:
+	uint8_t ip[] = {0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0};
 	                     ^

ERROR:SPACING: space required after that ',' (ctx:VxV)
#408: FILE: app/test/test_lpm6.c:1777:
+	uint8_t ip[] = {0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0};
 	                       ^

ERROR:SPACING: space required after that ',' (ctx:VxV)
#408: FILE: app/test/test_lpm6.c:1777:
+	uint8_t ip[] = {0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0};
 	                         ^

ERROR:SPACING: space required after that ',' (ctx:VxV)
#408: FILE: app/test/test_lpm6.c:1777:
+	uint8_t ip[] = {0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0};
 	                           ^

ERROR:SPACING: space required after that ',' (ctx:VxV)
#408: FILE: app/test/test_lpm6.c:1777:
+	uint8_t ip[] = {0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0};
 	                             ^

ERROR:SPACING: space required after that ',' (ctx:VxV)
#408: FILE: app/test/test_lpm6.c:1777:
+	uint8_t ip[] = {0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0};
 	                               ^

ERROR:SPACING: space required after that ',' (ctx:VxV)
#408: FILE: app/test/test_lpm6.c:1777:
+	uint8_t ip[] = {0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0};
 	                                 ^

ERROR:SPACING: space required after that ',' (ctx:VxV)
#408: FILE: app/test/test_lpm6.c:1777:
+	uint8_t ip[] = {0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0};
 	                                   ^

ERROR:SPACING: space required after that ',' (ctx:VxV)
#408: FILE: app/test/test_lpm6.c:1777:
+	uint8_t ip[] = {0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0};
 	                                     ^

ERROR:SPACING: space required after that ',' (ctx:VxV)
#408: FILE: app/test/test_lpm6.c:1777:
+	uint8_t ip[] = {0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0};
 	                                       ^

ERROR:SPACING: space required after that ',' (ctx:VxV)
#408: FILE: app/test/test_lpm6.c:1777:
+	uint8_t ip[] = {0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0};
 	                                         ^

ERROR:SPACING: space required after that ',' (ctx:VxV)
#408: FILE: app/test/test_lpm6.c:1777:
+	uint8_t ip[] = {0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0};
 	                                           ^

ERROR:SPACING: space required after that ',' (ctx:VxV)
#408: FILE: app/test/test_lpm6.c:1777:
+	uint8_t ip[] = {0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0};
 	                                             ^

WARNING:BRACES: braces {} are not necessary for single statement blocks
#792: FILE: lib/librte_lpm/rte_lpm6.c:618:
+	if (next_hop == NULL) {
+		return -EINVAL;
+	}

WARNING:UNSPECIFIED_INT: Prefer 'unsigned int' to bare use of 'unsigned'
#851: FILE: lib/librte_lpm/rte_lpm6.c:710:
+		int32_t * next_hops, unsigned n)

ERROR:POINTER_LOCATION: "foo * bar" should be "foo *bar"
#851: FILE: lib/librte_lpm/rte_lpm6.c:710:
+		int32_t * next_hops, unsigned n)

WARNING:UNSPECIFIED_INT: Prefer 'unsigned int' to bare use of 'unsigned'
#853: FILE: lib/librte_lpm/rte_lpm6.c:712:
+	unsigned i;

WARNING:BRACES: braces {} are not necessary for single statement blocks
#861: FILE: lib/librte_lpm/rte_lpm6.c:720:
+	if ((lpm == NULL) || (ips == NULL) || (next_hops == NULL)) {
+		return -EINVAL;
+	}

WARNING:LONG_LINE_COMMENT: line over 90 characters
#874: FILE: lib/librte_lpm/rte_lpm6.c:733:
+			/* Continue inspecting following levels until success or failure */

WARNING:UNSPECIFIED_INT: Prefer 'unsigned int' to bare use of 'unsigned'
#891: FILE: lib/librte_lpm/rte_lpm6.c:750:
+				int32_t * next_hops, unsigned n),

ERROR:POINTER_LOCATION: "foo * bar" should be "foo *bar"
#891: FILE: lib/librte_lpm/rte_lpm6.c:750:
+				int32_t * next_hops, unsigned n),

WARNING:BRACES: braces {} are not necessary for single statement blocks
#909: FILE: lib/librte_lpm/rte_lpm6.c:788:
+	if (next_hop == NULL) {
+		return -EINVAL;
+	}

WARNING:UNSPECIFIED_INT: Prefer 'unsigned int' to bare use of 'unsigned'
#997: FILE: lib/librte_lpm/rte_lpm6.h:240:
+		int32_t * next_hops, unsigned n);

ERROR:POINTER_LOCATION: "foo * bar" should be "foo *bar"
#997: FILE: lib/librte_lpm/rte_lpm6.h:240:
+		int32_t * next_hops, unsigned n);

WARNING:UNSPECIFIED_INT: Prefer 'unsigned int' to bare use of 'unsigned'
#1005: FILE: lib/librte_lpm/rte_lpm6.h:248:
+		int32_t * next_hops, unsigned n);

ERROR:POINTER_LOCATION: "foo * bar" should be "foo *bar"
#1005: FILE: lib/librte_lpm/rte_lpm6.h:248:
+		int32_t * next_hops, unsigned n);

total: 19 errors, 9 warnings, 817 lines checked


More information about the test-report mailing list