[dpdk-test-report] |WARNING| pw20665 [PATCH] net/virtio-user: fix multi-process issue

checkpatch at dpdk.org checkpatch at dpdk.org
Wed Feb 22 12:21:33 CET 2017


Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/20665

_coding style issues_


ERROR:GIT_COMMIT_ID: Please use git commit description style 'commit <12+ chars of sha1> ("<title line>")' - ie: 'commit 0123456789ab ("commit description")'
#47: 
The issue was flood by commit 7f95f78a8aea6161b824288bdeb1265798adca29

ERROR:CODE_INDENT: code indent should use tabs where possible
#87: FILE: drivers/net/virtio/virtio_user_ethdev.c:421:
+        if (rte_eal_process_type() == RTE_PROC_PRIMARY) {$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#87: FILE: drivers/net/virtio/virtio_user_ethdev.c:421:
+        if (rte_eal_process_type() == RTE_PROC_PRIMARY) {$

ERROR:CODE_INDENT: code indent should use tabs where possible
#88: FILE: drivers/net/virtio/virtio_user_ethdev.c:422:
+                eth_dev = virtio_user_eth_dev_alloc(name);$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#88: FILE: drivers/net/virtio/virtio_user_ethdev.c:422:
+                eth_dev = virtio_user_eth_dev_alloc(name);$

ERROR:CODE_INDENT: code indent should use tabs where possible
#89: FILE: drivers/net/virtio/virtio_user_ethdev.c:423:
+                if (!eth_dev) {$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#89: FILE: drivers/net/virtio/virtio_user_ethdev.c:423:
+                if (!eth_dev) {$

ERROR:CODE_INDENT: code indent should use tabs where possible
#90: FILE: drivers/net/virtio/virtio_user_ethdev.c:424:
+                        PMD_INIT_LOG(ERR, "virtio_user fails to alloc device");$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#90: FILE: drivers/net/virtio/virtio_user_ethdev.c:424:
+                        PMD_INIT_LOG(ERR, "virtio_user fails to alloc device");$

ERROR:CODE_INDENT: code indent should use tabs where possible
#91: FILE: drivers/net/virtio/virtio_user_ethdev.c:425:
+                        goto end;$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#91: FILE: drivers/net/virtio/virtio_user_ethdev.c:425:
+                        goto end;$

ERROR:CODE_INDENT: code indent should use tabs where possible
#92: FILE: drivers/net/virtio/virtio_user_ethdev.c:426:
+                }$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#92: FILE: drivers/net/virtio/virtio_user_ethdev.c:426:
+                }$

ERROR:CODE_INDENT: code indent should use tabs where possible
#93: FILE: drivers/net/virtio/virtio_user_ethdev.c:427:
+                hw = eth_dev->data->dev_private;$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#93: FILE: drivers/net/virtio/virtio_user_ethdev.c:427:
+                hw = eth_dev->data->dev_private;$

ERROR:CODE_INDENT: code indent should use tabs where possible
#94: FILE: drivers/net/virtio/virtio_user_ethdev.c:428:
+                if (virtio_user_dev_init(hw->virtio_user_dev, path, queues, cq,$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#94: FILE: drivers/net/virtio/virtio_user_ethdev.c:428:
+                if (virtio_user_dev_init(hw->virtio_user_dev, path, queues, cq,$

WARNING:LONG_LINE: line over 90 characters
#95: FILE: drivers/net/virtio/virtio_user_ethdev.c:429:
+                                                                 queue_size, mac_addr) < 0) {

ERROR:CODE_INDENT: code indent should use tabs where possible
#95: FILE: drivers/net/virtio/virtio_user_ethdev.c:429:
+                                                                 queue_size, mac_addr) < 0) {$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#95: FILE: drivers/net/virtio/virtio_user_ethdev.c:429:
+                                                                 queue_size, mac_addr) < 0) {$

ERROR:CODE_INDENT: code indent should use tabs where possible
#96: FILE: drivers/net/virtio/virtio_user_ethdev.c:430:
+                        PMD_INIT_LOG(ERR, "virtio_user_dev_init fails");$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#96: FILE: drivers/net/virtio/virtio_user_ethdev.c:430:
+                        PMD_INIT_LOG(ERR, "virtio_user_dev_init fails");$

ERROR:CODE_INDENT: code indent should use tabs where possible
#97: FILE: drivers/net/virtio/virtio_user_ethdev.c:431:
+                        virtio_user_eth_dev_free(eth_dev);$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#97: FILE: drivers/net/virtio/virtio_user_ethdev.c:431:
+                        virtio_user_eth_dev_free(eth_dev);$

ERROR:CODE_INDENT: code indent should use tabs where possible
#98: FILE: drivers/net/virtio/virtio_user_ethdev.c:432:
+                        goto end;$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#98: FILE: drivers/net/virtio/virtio_user_ethdev.c:432:
+                        goto end;$

ERROR:CODE_INDENT: code indent should use tabs where possible
#99: FILE: drivers/net/virtio/virtio_user_ethdev.c:433:
+                }$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#99: FILE: drivers/net/virtio/virtio_user_ethdev.c:433:
+                }$

ERROR:CODE_INDENT: code indent should use tabs where possible
#100: FILE: drivers/net/virtio/virtio_user_ethdev.c:434:
+        } else {$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#100: FILE: drivers/net/virtio/virtio_user_ethdev.c:434:
+        } else {$

ERROR:CODE_INDENT: code indent should use tabs where possible
#101: FILE: drivers/net/virtio/virtio_user_ethdev.c:435:
+                eth_dev = rte_eth_dev_attach_secondary(name);$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#101: FILE: drivers/net/virtio/virtio_user_ethdev.c:435:
+                eth_dev = rte_eth_dev_attach_secondary(name);$

ERROR:CODE_INDENT: code indent should use tabs where possible
#102: FILE: drivers/net/virtio/virtio_user_ethdev.c:436:
+                if (!eth_dev) {$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#102: FILE: drivers/net/virtio/virtio_user_ethdev.c:436:
+                if (!eth_dev) {$

ERROR:CODE_INDENT: code indent should use tabs where possible
#103: FILE: drivers/net/virtio/virtio_user_ethdev.c:437:
+                        goto end;$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#103: FILE: drivers/net/virtio/virtio_user_ethdev.c:437:
+                        goto end;$

ERROR:CODE_INDENT: code indent should use tabs where possible
#104: FILE: drivers/net/virtio/virtio_user_ethdev.c:438:
+                }$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#104: FILE: drivers/net/virtio/virtio_user_ethdev.c:438:
+                }$

ERROR:CODE_INDENT: code indent should use tabs where possible
#105: FILE: drivers/net/virtio/virtio_user_ethdev.c:439:
+        }$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#105: FILE: drivers/net/virtio/virtio_user_ethdev.c:439:
+        }$

ERROR:TRAILING_WHITESPACE: trailing whitespace
#141: FILE: lib/librte_ether/rte_ethdev.h:1765:
+ * Attach to the ethdev already initialized by the primary $

ERROR:TRAILING_WHITESPACE: trailing whitespace
#142: FILE: lib/librte_ether/rte_ethdev.h:1766:
+ * process. $

ERROR:TRAILING_WHITESPACE: trailing whitespace
#163: FILE: lib/librte_ether/rte_ether_version.map:155:
+^Irte_eth_dev_attach_secondary;^I$

total: 23 errors, 20 warnings, 79 lines checked


More information about the test-report mailing list