[dpdk-test-report] |WARNING| pw26522 [PATCH v3 5/5] net/mlx5: add vectorized Rx/Tx burst for SSE4.1

checkpatch at dpdk.org checkpatch at dpdk.org
Wed Jul 5 20:14:19 CEST 2017


Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/26522

_coding style issues_


WARNING:USE_NEGATIVE_ERRNO: return of an errno should typically be negative (ie: return -ENOMEM)
#157: FILE: drivers/net/mlx5/mlx5_rxq.c:663:
+			return ENOMEM;

WARNING:FUNCTION_ARGUMENTS: function definition argument 'struct priv *' should also have an identifier name
#782: FILE: drivers/net/mlx5/mlx5_rxtx.h:350:
+int priv_check_raw_vec_tx_support(struct priv *);

WARNING:FUNCTION_ARGUMENTS: function definition argument 'struct priv *' should also have an identifier name
#783: FILE: drivers/net/mlx5/mlx5_rxtx.h:351:
+int priv_check_vec_tx_support(struct priv *);

WARNING:FUNCTION_ARGUMENTS: function definition argument 'struct rxq *' should also have an identifier name
#784: FILE: drivers/net/mlx5/mlx5_rxtx.h:352:
+int rxq_check_vec_support(struct rxq *);

WARNING:FUNCTION_ARGUMENTS: function definition argument 'struct priv *' should also have an identifier name
#785: FILE: drivers/net/mlx5/mlx5_rxtx.h:353:
+int priv_check_vec_rx_support(struct priv *);

WARNING:FUNCTION_ARGUMENTS: function definition argument 'struct priv *' should also have an identifier name
#786: FILE: drivers/net/mlx5/mlx5_rxtx.h:354:
+void priv_prep_vec_rx_function(struct priv *);

WARNING:FUNCTION_ARGUMENTS: function definition argument 'void *' should also have an identifier name
#787: FILE: drivers/net/mlx5/mlx5_rxtx.h:355:
+uint16_t mlx5_tx_burst_raw_vec(void *, struct rte_mbuf **, uint16_t);

WARNING:FUNCTION_ARGUMENTS: function definition argument 'struct rte_mbuf **' should also have an identifier name
#787: FILE: drivers/net/mlx5/mlx5_rxtx.h:355:
+uint16_t mlx5_tx_burst_raw_vec(void *, struct rte_mbuf **, uint16_t);

WARNING:FUNCTION_ARGUMENTS: function definition argument 'uint16_t' should also have an identifier name
#787: FILE: drivers/net/mlx5/mlx5_rxtx.h:355:
+uint16_t mlx5_tx_burst_raw_vec(void *, struct rte_mbuf **, uint16_t);

WARNING:FUNCTION_ARGUMENTS: function definition argument 'void *' should also have an identifier name
#788: FILE: drivers/net/mlx5/mlx5_rxtx.h:356:
+uint16_t mlx5_tx_burst_vec(void *, struct rte_mbuf **, uint16_t);

WARNING:FUNCTION_ARGUMENTS: function definition argument 'struct rte_mbuf **' should also have an identifier name
#788: FILE: drivers/net/mlx5/mlx5_rxtx.h:356:
+uint16_t mlx5_tx_burst_vec(void *, struct rte_mbuf **, uint16_t);

WARNING:FUNCTION_ARGUMENTS: function definition argument 'uint16_t' should also have an identifier name
#788: FILE: drivers/net/mlx5/mlx5_rxtx.h:356:
+uint16_t mlx5_tx_burst_vec(void *, struct rte_mbuf **, uint16_t);

WARNING:FUNCTION_ARGUMENTS: function definition argument 'void *' should also have an identifier name
#789: FILE: drivers/net/mlx5/mlx5_rxtx.h:357:
+uint16_t mlx5_rx_burst_vec(void *, struct rte_mbuf **, uint16_t);

WARNING:FUNCTION_ARGUMENTS: function definition argument 'struct rte_mbuf **' should also have an identifier name
#789: FILE: drivers/net/mlx5/mlx5_rxtx.h:357:
+uint16_t mlx5_rx_burst_vec(void *, struct rte_mbuf **, uint16_t);

WARNING:FUNCTION_ARGUMENTS: function definition argument 'uint16_t' should also have an identifier name
#789: FILE: drivers/net/mlx5/mlx5_rxtx.h:357:
+uint16_t mlx5_rx_burst_vec(void *, struct rte_mbuf **, uint16_t);

CHECK:SPACING: spaces preferred around that '*' (ctx:WxV)
#1138: FILE: drivers/net/mlx5/mlx5_rxtx_vec_sse.c:73:
+txq_wr_dseg_v(struct txq *txq, __m128i *dseg,
                                        ^

total: 0 errors, 15 warnings, 1 checks, 2354 lines checked


More information about the test-report mailing list