[dpdk-test-report] |WARNING| pw25234 [PATCH v5 2/2] ethdev: add traffic management API

checkpatch at dpdk.org checkpatch at dpdk.org
Fri Jun 9 18:52:51 CEST 2017


Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/25234

_coding style issues_


WARNING:ENOSYS: ENOSYS means 'invalid syscall nr' and nothing else
#333: FILE: lib/librte_ether/rte_tm.c:61:
+			ENOSYS,

WARNING:ENOSYS: ENOSYS means 'invalid syscall nr' and nothing else
#336: FILE: lib/librte_ether/rte_tm.c:64:
+			rte_strerror(ENOSYS));

WARNING:MACRO_WITH_FLOW_CONTROL: Macros with flow control statements should be avoided
#343: FILE: lib/librte_ether/rte_tm.c:71:
+#define RTE_TM_FUNC(port_id, func)				\
+({							\
+	const struct rte_tm_ops *ops =			\
+		rte_tm_ops_get(port_id, error);		\
+	if (ops == NULL)					\
+		return -rte_errno;			\
+							\
+	if (ops->func == NULL)				\
+		return -rte_tm_error_set(error,		\
+			ENOSYS,				\
+			RTE_TM_ERROR_TYPE_UNSPECIFIED,	\
+			NULL,				\
+			rte_strerror(ENOSYS));		\
+							\
+	ops->func;					\
+})

WARNING:ENOSYS: ENOSYS means 'invalid syscall nr' and nothing else
#352: FILE: lib/librte_ether/rte_tm.c:80:
+			ENOSYS,				\

WARNING:ENOSYS: ENOSYS means 'invalid syscall nr' and nothing else
#355: FILE: lib/librte_ether/rte_tm.c:83:
+			rte_strerror(ENOSYS));		\

WARNING:BLOCK_COMMENT_STYLE: Block comments should align the * on each line
#2409: FILE: lib/librte_ether/rte_tm.h:1693:
+ *   0 on success, non-zero error code otherwise.
+  *

WARNING:BLOCK_COMMENT_STYLE: Block comments should align the * on each line
#2410: FILE: lib/librte_ether/rte_tm.h:1694:
+  *
+ * @see struct rte_tm_capabilities

WARNING:BLOCK_COMMENT_STYLE: Block comments should align the * on each line
#2411: FILE: lib/librte_ether/rte_tm.h:1695:
+ * @see struct rte_tm_capabilities
+*/

total: 0 errors, 8 warnings, 2769 lines checked


More information about the test-report mailing list