[dpdk-test-report] |WARNING| pw25243 [PATCH v4] net/e1000: parse n-tuple filter
checkpatch at dpdk.org
checkpatch at dpdk.org
Mon Jun 12 08:41:18 CEST 2017
Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/25243
_coding style issues_
WARNING:MACRO_WITH_FLOW_CONTROL: Macros with flow control statements should be avoided
#47: FILE: drivers/net/e1000/e1000_ethdev.h:146:
+#define MAC_TYPE_FILTER_SUP(type) do {\
+ if ((type) != e1000_82580 && (type) != e1000_i350 &&\
+ (type) != e1000_82576 && (type) != e1000_i210 &&\
+ (type) != e1000_i211)\
+ return -ENOTSUP;\
+} while (0)
CHECK:MACRO_ARG_REUSE: Macro argument reuse 'item' - possible side-effects?
#172: FILE: drivers/net/e1000/igb_flow.c:62:
+#define NEXT_ITEM_OF_PATTERN(item, pattern, index) \
+ do { \
+ item = (pattern) + (index); \
+ while (item->type == RTE_FLOW_ITEM_TYPE_VOID) { \
+ (index)++; \
+ item = (pattern) + (index); \
+ } \
+ } while (0)
CHECK:MACRO_ARG_REUSE: Macro argument reuse 'pattern' - possible side-effects?
#172: FILE: drivers/net/e1000/igb_flow.c:62:
+#define NEXT_ITEM_OF_PATTERN(item, pattern, index) \
+ do { \
+ item = (pattern) + (index); \
+ while (item->type == RTE_FLOW_ITEM_TYPE_VOID) { \
+ (index)++; \
+ item = (pattern) + (index); \
+ } \
+ } while (0)
CHECK:MACRO_ARG_REUSE: Macro argument reuse 'index' - possible side-effects?
#172: FILE: drivers/net/e1000/igb_flow.c:62:
+#define NEXT_ITEM_OF_PATTERN(item, pattern, index) \
+ do { \
+ item = (pattern) + (index); \
+ while (item->type == RTE_FLOW_ITEM_TYPE_VOID) { \
+ (index)++; \
+ item = (pattern) + (index); \
+ } \
+ } while (0)
CHECK:MACRO_ARG_REUSE: Macro argument reuse 'act' - possible side-effects?
#181: FILE: drivers/net/e1000/igb_flow.c:71:
+#define NEXT_ITEM_OF_ACTION(act, actions, index) \
+ do { \
+ act = (actions) + (index); \
+ while (act->type == RTE_FLOW_ACTION_TYPE_VOID) {\
+ (index)++; \
+ act = (actions) + (index); \
+ } \
+ } while (0)
CHECK:MACRO_ARG_REUSE: Macro argument reuse 'actions' - possible side-effects?
#181: FILE: drivers/net/e1000/igb_flow.c:71:
+#define NEXT_ITEM_OF_ACTION(act, actions, index) \
+ do { \
+ act = (actions) + (index); \
+ while (act->type == RTE_FLOW_ACTION_TYPE_VOID) {\
+ (index)++; \
+ act = (actions) + (index); \
+ } \
+ } while (0)
CHECK:MACRO_ARG_REUSE: Macro argument reuse 'index' - possible side-effects?
#181: FILE: drivers/net/e1000/igb_flow.c:71:
+#define NEXT_ITEM_OF_ACTION(act, actions, index) \
+ do { \
+ act = (actions) + (index); \
+ while (act->type == RTE_FLOW_ACTION_TYPE_VOID) {\
+ (index)++; \
+ act = (actions) + (index); \
+ } \
+ } while (0)
WARNING:SUSPECT_CODE_INDENT: suspect code indent for conditional statements (8, 24)
#321: FILE: drivers/net/e1000/igb_flow.c:211:
+ if (ipv4_mask->hdr.version_ihl ||
[...]
+ rte_flow_error_set(error,
total: 0 errors, 2 warnings, 6 checks, 574 lines checked
More information about the test-report
mailing list