[dpdk-test-report] |WARNING| pw25350 [PATCH v2 1/6] net/vmxnet3: retain counters on restart

[checkpatch at dpdk.org]

Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/25350

_coding style issues_


CHECK:CAMELCASE: Avoid CamelCase: <UPT1_TxStats>
#70: FILE: drivers/net/vmxnet3/vmxnet3_ethdev.c:832:
+			struct UPT1_TxStats *res)

CHECK:MACRO_ARG_REUSE: Macro argument reuse 'h' - possible side-effects?
#72: FILE: drivers/net/vmxnet3/vmxnet3_ethdev.c:834:
+#define VMXNET3_UPDATE_TX_STAT(h, i, f, r)		\
+		((r)->f = (h)->tqd_start[(i)].stats.f +	\
+			(h)->saved_tx_stats[(i)].f)

CHECK:MACRO_ARG_REUSE: Macro argument reuse 'i' - possible side-effects?
#72: FILE: drivers/net/vmxnet3/vmxnet3_ethdev.c:834:
+#define VMXNET3_UPDATE_TX_STAT(h, i, f, r)		\
+		((r)->f = (h)->tqd_start[(i)].stats.f +	\
+			(h)->saved_tx_stats[(i)].f)

CHECK:MACRO_ARG_REUSE: Macro argument reuse 'f' - possible side-effects?
#72: FILE: drivers/net/vmxnet3/vmxnet3_ethdev.c:834:
+#define VMXNET3_UPDATE_TX_STAT(h, i, f, r)		\
+		((r)->f = (h)->tqd_start[(i)].stats.f +	\
+			(h)->saved_tx_stats[(i)].f)

CHECK:MACRO_ARG_PRECEDENCE: Macro argument 'f' may be better as '(f)' to avoid precedence issues
#72: FILE: drivers/net/vmxnet3/vmxnet3_ethdev.c:834:
+#define VMXNET3_UPDATE_TX_STAT(h, i, f, r)		\
+		((r)->f = (h)->tqd_start[(i)].stats.f +	\
+			(h)->saved_tx_stats[(i)].f)

CHECK:CAMELCASE: Avoid CamelCase: <ucastPktsTxOK>
#76: FILE: drivers/net/vmxnet3/vmxnet3_ethdev.c:838:
+	VMXNET3_UPDATE_TX_STAT(hw, q, ucastPktsTxOK, res);

CHECK:CAMELCASE: Avoid CamelCase: <mcastPktsTxOK>
#77: FILE: drivers/net/vmxnet3/vmxnet3_ethdev.c:839:
+	VMXNET3_UPDATE_TX_STAT(hw, q, mcastPktsTxOK, res);

CHECK:CAMELCASE: Avoid CamelCase: <bcastPktsTxOK>
#78: FILE: drivers/net/vmxnet3/vmxnet3_ethdev.c:840:
+	VMXNET3_UPDATE_TX_STAT(hw, q, bcastPktsTxOK, res);

CHECK:CAMELCASE: Avoid CamelCase: <ucastBytesTxOK>
#79: FILE: drivers/net/vmxnet3/vmxnet3_ethdev.c:841:
+	VMXNET3_UPDATE_TX_STAT(hw, q, ucastBytesTxOK, res);

CHECK:CAMELCASE: Avoid CamelCase: <mcastBytesTxOK>
#80: FILE: drivers/net/vmxnet3/vmxnet3_ethdev.c:842:
+	VMXNET3_UPDATE_TX_STAT(hw, q, mcastBytesTxOK, res);

CHECK:CAMELCASE: Avoid CamelCase: <bcastBytesTxOK>
#81: FILE: drivers/net/vmxnet3/vmxnet3_ethdev.c:843:
+	VMXNET3_UPDATE_TX_STAT(hw, q, bcastBytesTxOK, res);

CHECK:CAMELCASE: Avoid CamelCase: <pktsTxError>
#82: FILE: drivers/net/vmxnet3/vmxnet3_ethdev.c:844:
+	VMXNET3_UPDATE_TX_STAT(hw, q, pktsTxError, res);

CHECK:CAMELCASE: Avoid CamelCase: <pktsTxDiscard>
#83: FILE: drivers/net/vmxnet3/vmxnet3_ethdev.c:845:
+	VMXNET3_UPDATE_TX_STAT(hw, q, pktsTxDiscard, res);

CHECK:CAMELCASE: Avoid CamelCase: <UPT1_RxStats>
#90: FILE: drivers/net/vmxnet3/vmxnet3_ethdev.c:852:
+			struct UPT1_RxStats *res)

CHECK:MACRO_ARG_REUSE: Macro argument reuse 'h' - possible side-effects?
#92: FILE: drivers/net/vmxnet3/vmxnet3_ethdev.c:854:
+#define VMXNET3_UPDATE_RX_STAT(h, i, f, r)		\
+		((r)->f = (h)->rqd_start[(i)].stats.f +	\
+			(h)->saved_rx_stats[(i)].f)

CHECK:MACRO_ARG_REUSE: Macro argument reuse 'i' - possible side-effects?
#92: FILE: drivers/net/vmxnet3/vmxnet3_ethdev.c:854:
+#define VMXNET3_UPDATE_RX_STAT(h, i, f, r)		\
+		((r)->f = (h)->rqd_start[(i)].stats.f +	\
+			(h)->saved_rx_stats[(i)].f)

CHECK:MACRO_ARG_REUSE: Macro argument reuse 'f' - possible side-effects?
#92: FILE: drivers/net/vmxnet3/vmxnet3_ethdev.c:854:
+#define VMXNET3_UPDATE_RX_STAT(h, i, f, r)		\
+		((r)->f = (h)->rqd_start[(i)].stats.f +	\
+			(h)->saved_rx_stats[(i)].f)

CHECK:MACRO_ARG_PRECEDENCE: Macro argument 'f' may be better as '(f)' to avoid precedence issues
#92: FILE: drivers/net/vmxnet3/vmxnet3_ethdev.c:854:
+#define VMXNET3_UPDATE_RX_STAT(h, i, f, r)		\
+		((r)->f = (h)->rqd_start[(i)].stats.f +	\
+			(h)->saved_rx_stats[(i)].f)

CHECK:CAMELCASE: Avoid CamelCase: <ucastPktsRxOK>
#96: FILE: drivers/net/vmxnet3/vmxnet3_ethdev.c:858:
+	VMXNET3_UPDATE_RX_STAT(hw, q, ucastPktsRxOK, res);

CHECK:CAMELCASE: Avoid CamelCase: <mcastPktsRxOK>
#97: FILE: drivers/net/vmxnet3/vmxnet3_ethdev.c:859:
+	VMXNET3_UPDATE_RX_STAT(hw, q, mcastPktsRxOK, res);

CHECK:CAMELCASE: Avoid CamelCase: <bcastPktsRxOK>
#98: FILE: drivers/net/vmxnet3/vmxnet3_ethdev.c:860:
+	VMXNET3_UPDATE_RX_STAT(hw, q, bcastPktsRxOK, res);

CHECK:CAMELCASE: Avoid CamelCase: <ucastBytesRxOK>
#99: FILE: drivers/net/vmxnet3/vmxnet3_ethdev.c:861:
+	VMXNET3_UPDATE_RX_STAT(hw, q, ucastBytesRxOK, res);

CHECK:CAMELCASE: Avoid CamelCase: <mcastBytesRxOK>
#100: FILE: drivers/net/vmxnet3/vmxnet3_ethdev.c:862:
+	VMXNET3_UPDATE_RX_STAT(hw, q, mcastBytesRxOK, res);

CHECK:CAMELCASE: Avoid CamelCase: <bcastBytesRxOK>
#101: FILE: drivers/net/vmxnet3/vmxnet3_ethdev.c:863:
+	VMXNET3_UPDATE_RX_STAT(hw, q, bcastBytesRxOK, res);

CHECK:CAMELCASE: Avoid CamelCase: <pktsRxError>
#102: FILE: drivers/net/vmxnet3/vmxnet3_ethdev.c:864:
+	VMXNET3_UPDATE_RX_STAT(hw, q, pktsRxError, res);

CHECK:CAMELCASE: Avoid CamelCase: <pktsRxOutOfBuf>
#103: FILE: drivers/net/vmxnet3/vmxnet3_ethdev.c:865:
+	VMXNET3_UPDATE_RX_STAT(hw, q, pktsRxOutOfBuf, res);

CHECK:CAMELCASE: Avoid CamelCase: <txStats>
#128: FILE: drivers/net/vmxnet3/vmxnet3_ethdev.c:890:
+	struct UPT1_TxStats txStats;

CHECK:CAMELCASE: Avoid CamelCase: <rxStats>
#129: FILE: drivers/net/vmxnet3/vmxnet3_ethdev.c:891:
+	struct UPT1_RxStats rxStats;

total: 0 errors, 0 warnings, 28 checks, 157 lines checked