[dpdk-test-report] |WARNING| pw25402 [PATCH 36/38] net/dpaa: add support for checksum offload

checkpatch at dpdk.org checkpatch at dpdk.org
Fri Jun 16 07:42:03 CEST 2017


Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/25402

_coding style issues_


CHECK:CAMELCASE: Avoid CamelCase: <ETHER_TYPE_IPv4>
#84: FILE: drivers/net/dpaa/dpaa_rxtx.c:223:
+		if (eth_hdr->ether_type == htons(ETHER_TYPE_IPv4))

WARNING:DEEP_INDENTATION: Too many leading tabs - consider code refactoring
#143: FILE: drivers/net/dpaa/dpaa_rxtx.c:443:
+						if (mbuf->data_off < DEFAULT_TX_ICEOF +

WARNING:LONG_LINE: line over 90 characters
#144: FILE: drivers/net/dpaa/dpaa_rxtx.c:444:
+							sizeof(struct dpaa_eth_parse_results_t)) {

WARNING:DEEP_INDENTATION: Too many leading tabs - consider code refactoring
#150: FILE: drivers/net/dpaa/dpaa_rxtx.c:450:
+						} else

CHECK:BRACES: Unbalanced braces around else statement
#150: FILE: drivers/net/dpaa/dpaa_rxtx.c:450:
+						} else

WARNING:LONG_LINE: line over 90 characters
#151: FILE: drivers/net/dpaa/dpaa_rxtx.c:451:
+							dpaa_checksum_offload(mbuf, &fd_arr[loop],

CHECK:MACRO_ARG_PRECEDENCE: Macro argument '_buf' may be better as '(_buf)' to avoid precedence issues
#188: FILE: drivers/net/dpaa/dpaa_rxtx.h:244:
+#define GET_TX_PRS(_buf) \
+	(struct dpaa_eth_parse_results_t *)((uint8_t *)_buf + DEFAULT_TX_ICEOF)

total: 0 errors, 4 warnings, 3 checks, 149 lines checked


More information about the test-report mailing list