[dpdk-test-report] |WARNING| pw25597 [PATCH 20/22] cryptodev: add AEAD parameters in crypto operation

checkpatch at dpdk.org checkpatch at dpdk.org
Wed Jun 21 17:49:07 CEST 2017

Previous message: [dpdk-test-report] |SUCCESS| pw25596 [PATCH 19/22] cryptodev: add AEAD specific data
Next message: [dpdk-test-report] |SUCCESS| pw25598 [PATCH 22/22] cryptodev: remove AAD from authentication structure
Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]

Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/25597

_coding style issues_


WARNING:TYPO_SPELLING: 'an union' may be misspelled - perhaps 'a union'?
#16: 
This structure is within an union with the cipher

WARNING:LONG_LINE_COMMENT: line over 90 characters
#264: FILE: lib/librte_cryptodev/rte_crypto_sym.h:607:
+					 /**< Starting point for cipher processing, specified

WARNING:LONG_LINE_COMMENT: line over 90 characters
#265: FILE: lib/librte_cryptodev/rte_crypto_sym.h:608:
+					  * as number of bytes from start of data in the source

WARNING:LONG_LINE_COMMENT: line over 90 characters
#266: FILE: lib/librte_cryptodev/rte_crypto_sym.h:609:
+					  * buffer. The result of the cipher operation will be

WARNING:LONG_LINE_COMMENT: line over 90 characters
#267: FILE: lib/librte_cryptodev/rte_crypto_sym.h:610:
+					  * written back into the output buffer starting at

WARNING:LONG_LINE_COMMENT: line over 90 characters
#277: FILE: lib/librte_cryptodev/rte_crypto_sym.h:620:
+					 /**< The message length, in bytes, of the source buffer

WARNING:LONG_LINE_COMMENT: line over 90 characters
#279: FILE: lib/librte_cryptodev/rte_crypto_sym.h:622:
+					  * computed. This must be a multiple of the block size

WARNING:LONG_LINE_COMMENT: line over 90 characters
#280: FILE: lib/librte_cryptodev/rte_crypto_sym.h:623:
+					  * if a block cipher is being used. This is also the

WARNING:LONG_LINE_COMMENT: line over 90 characters
#284: FILE: lib/librte_cryptodev/rte_crypto_sym.h:627:
+					  * In the case of CCM @ref RTE_CRYPTO_AUTH_AES_CCM,

WARNING:LONG_LINE_COMMENT: line over 90 characters
#285: FILE: lib/librte_cryptodev/rte_crypto_sym.h:628:
+					  * this value should not include the length of the

WARNING:LONG_LINE_COMMENT: line over 90 characters
#286: FILE: lib/librte_cryptodev/rte_crypto_sym.h:629:
+					  * padding or the length of the MAC; the driver will

WARNING:LONG_LINE_COMMENT: line over 90 characters
#287: FILE: lib/librte_cryptodev/rte_crypto_sym.h:630:
+					  * compute the actual number of bytes over which the

WARNING:LONG_LINE_COMMENT: line over 90 characters
#288: FILE: lib/librte_cryptodev/rte_crypto_sym.h:631:
+					  * encryption will occur, which will include these

WARNING:LONG_LINE_COMMENT: line over 90 characters
#303: FILE: lib/librte_cryptodev/rte_crypto_sym.h:646:
+					 /**< Starting point for hash processing, specified as

WARNING:LONG_LINE_COMMENT: line over 90 characters
#308: FILE: lib/librte_cryptodev/rte_crypto_sym.h:651:
+					  * For CCM and GCM modes of operation, this field is

WARNING:LONG_LINE_COMMENT: line over 90 characters
#323: FILE: lib/librte_cryptodev/rte_crypto_sym.h:666:
+					  * For CCM and GCM modes of operation, this field is

WARNING:LONG_LINE_COMMENT: line over 90 characters
#324: FILE: lib/librte_cryptodev/rte_crypto_sym.h:667:
+					  * ignored. The field @ref aad field should be set

WARNING:LONG_LINE_COMMENT: line over 90 characters
#337: FILE: lib/librte_cryptodev/rte_crypto_sym.h:680:
+					/**< This points to the location where the digest result

WARNING:LONG_LINE_COMMENT: line over 90 characters
#338: FILE: lib/librte_cryptodev/rte_crypto_sym.h:681:
+					 * should be inserted (in the case of digest generation)

WARNING:LONG_LINE_COMMENT: line over 90 characters
#339: FILE: lib/librte_cryptodev/rte_crypto_sym.h:682:
+					 * or where the purported digest exists (in the case of

WARNING:LONG_LINE_COMMENT: line over 90 characters
#342: FILE: lib/librte_cryptodev/rte_crypto_sym.h:685:
+					 * At session creation time, the client specified the

WARNING:LONG_LINE_COMMENT: line over 90 characters
#343: FILE: lib/librte_cryptodev/rte_crypto_sym.h:686:
+					 * digest result length with the digest_length member

WARNING:LONG_LINE_COMMENT: line over 90 characters
#344: FILE: lib/librte_cryptodev/rte_crypto_sym.h:687:
+					 * of the @ref rte_crypto_auth_xform structure. For

WARNING:LONG_LINE_COMMENT: line over 90 characters
#345: FILE: lib/librte_cryptodev/rte_crypto_sym.h:688:
+					 * physical crypto devices the caller must allocate at

WARNING:LONG_LINE_COMMENT: line over 90 characters
#346: FILE: lib/librte_cryptodev/rte_crypto_sym.h:689:
+					 * least digest_length of physically contiguous memory

WARNING:LONG_LINE_COMMENT: line over 90 characters
#362: FILE: lib/librte_cryptodev/rte_crypto_sym.h:705:
+					/**< Pointer to Additional Authenticated Data (AAD)

WARNING:LONG_LINE_COMMENT: line over 90 characters
#363: FILE: lib/librte_cryptodev/rte_crypto_sym.h:706:
+					 * needed for authenticated cipher mechanisms (CCM and

WARNING:LONG_LINE_COMMENT: line over 90 characters
#366: FILE: lib/librte_cryptodev/rte_crypto_sym.h:709:
+					 * The length of the data pointed to by this field is

WARNING:LONG_LINE_COMMENT: line over 90 characters
#368: FILE: lib/librte_cryptodev/rte_crypto_sym.h:711:
+					 * rte_crypto_auth_xform structure as part of the @ref

WARNING:LONG_LINE_COMMENT: line over 90 characters
#370: FILE: lib/librte_cryptodev/rte_crypto_sym.h:713:
+					 * This length must not exceed 65535 (2^16-1) bytes.

WARNING:LONG_LINE_COMMENT: line over 90 characters
#372: FILE: lib/librte_cryptodev/rte_crypto_sym.h:715:
+					 * Specifically for CCM (@ref RTE_CRYPTO_AUTH_AES_CCM),

WARNING:LONG_LINE_COMMENT: line over 90 characters
#375: FILE: lib/librte_cryptodev/rte_crypto_sym.h:718:
+					 * - the nonce should be written starting at an offset

WARNING:LONG_LINE_COMMENT: line over 90 characters
#376: FILE: lib/librte_cryptodev/rte_crypto_sym.h:719:
+					 * of one byte into the array, leaving room for the

WARNING:LONG_LINE_COMMENT: line over 90 characters
#377: FILE: lib/librte_cryptodev/rte_crypto_sym.h:720:
+					 * implementation to write in the flags to the first

WARNING:LONG_LINE_COMMENT: line over 90 characters
#380: FILE: lib/librte_cryptodev/rte_crypto_sym.h:723:
+					 * - the additional  authentication data itself should

WARNING:LONG_LINE_COMMENT: line over 90 characters
#381: FILE: lib/librte_cryptodev/rte_crypto_sym.h:724:
+					 * be written starting at an offset of 18 bytes into

WARNING:LONG_LINE_COMMENT: line over 90 characters
#382: FILE: lib/librte_cryptodev/rte_crypto_sym.h:725:
+					 * the array, leaving room for the length encoding in

WARNING:LONG_LINE_COMMENT: line over 90 characters
#385: FILE: lib/librte_cryptodev/rte_crypto_sym.h:728:
+					 * - the array should be big enough to hold the above

WARNING:LONG_LINE_COMMENT: line over 90 characters
#386: FILE: lib/librte_cryptodev/rte_crypto_sym.h:729:
+					 *  fields, plus any padding to round this up to the

WARNING:LONG_LINE_COMMENT: line over 90 characters
#390: FILE: lib/librte_cryptodev/rte_crypto_sym.h:733:
+					 * Finally, for GCM (@ref RTE_CRYPTO_AUTH_AES_GCM), the

WARNING:LONG_LINE_COMMENT: line over 90 characters
#394: FILE: lib/librte_cryptodev/rte_crypto_sym.h:737:
+					 * - the array must be big enough to hold the AAD, plus

WARNING:LONG_LINE_COMMENT: line over 90 characters
#395: FILE: lib/librte_cryptodev/rte_crypto_sym.h:738:
+					 * any space to round this up to the nearest multiple

total: 0 errors, 42 warnings, 369 lines checked

Previous message: [dpdk-test-report] |SUCCESS| pw25596 [PATCH 19/22] cryptodev: add AEAD specific data
Next message: [dpdk-test-report] |SUCCESS| pw25598 [PATCH 22/22] cryptodev: remove AAD from authentication structure
Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]

More information about the test-report mailing list