[dpdk-test-report] |WARNING| pw25733 [PATCH v2 1/2] net/softnic: add softnic PMD for traffic management

[checkpatch at dpdk.org]

Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/25733

_coding style issues_


WARNING:STATIC_CONST_CHAR_ARRAY: static const char * array should probably be static const char * const
#215: FILE: drivers/net/softnic/rte_eth_softnic.c:52:
+static const char *pmd_valid_args[] = {

CHECK:MACRO_ARG_REUSE: Macro argument reuse 'func' - possible side-effects?
#1684: FILE: drivers/net/softnic/rte_eth_softnic_default.c:876:
+#define CHECK_AND_SET_NULL(o, u, func)	({			\
+	if (!(u)->func)				\
+		(o)->func = NULL;				\
+})

CHECK:MACRO_ARG_PRECEDENCE: Macro argument 'func' may be better as '(func)' to avoid precedence issues
#1684: FILE: drivers/net/softnic/rte_eth_softnic_default.c:876:
+#define CHECK_AND_SET_NULL(o, u, func)	({			\
+	if (!(u)->func)				\
+		(o)->func = NULL;				\
+})

CHECK:MACRO_ARG_REUSE: Macro argument reuse 'u' - possible side-effects?
#1689: FILE: drivers/net/softnic/rte_eth_softnic_default.c:881:
+#define CHECK_AND_SET_NONNULL(o, u, func)	({		\
+	if ((u)->func)				\
+		(o)->func = (u)->func;			\
+})

CHECK:MACRO_ARG_REUSE: Macro argument reuse 'func' - possible side-effects?
#1689: FILE: drivers/net/softnic/rte_eth_softnic_default.c:881:
+#define CHECK_AND_SET_NONNULL(o, u, func)	({		\
+	if ((u)->func)				\
+		(o)->func = (u)->func;			\
+})

CHECK:MACRO_ARG_PRECEDENCE: Macro argument 'func' may be better as '(func)' to avoid precedence issues
#1689: FILE: drivers/net/softnic/rte_eth_softnic_default.c:881:
+#define CHECK_AND_SET_NONNULL(o, u, func)	({		\
+	if ((u)->func)				\
+		(o)->func = (u)->func;			\
+})

total: 0 errors, 1 warnings, 1926 lines checked