[dpdk-test-report] |WARNING| pw21404 [PATCH v3 2/2] ethdev: add hierarchical scheduler API

checkpatch at dpdk.org checkpatch at dpdk.org
Sat Mar 4 02:11:05 CET 2017


Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/21404

_coding style issues_


WARNING:COMMIT_LOG_LONG_LINE: Possible unwrapped commit description (prefer a maximum 75 chars per line)
#54: 
- Traffic shaping: single/dual rate, private (per node) and shared (by multiple

WARNING:ENOSYS: ENOSYS means 'invalid syscall nr' and nothing else
#308: FILE: lib/librte_ether/rte_tm.c:61:
+			ENOSYS,

WARNING:ENOSYS: ENOSYS means 'invalid syscall nr' and nothing else
#311: FILE: lib/librte_ether/rte_tm.c:64:
+			rte_strerror(ENOSYS));

WARNING:MACRO_WITH_FLOW_CONTROL: Macros with flow control statements should be avoided
#318: FILE: lib/librte_ether/rte_tm.c:71:
+#define RTE_TM_FUNC(port_id, func)				\
+({								\
+	const struct rte_tm_ops *ops =			\
+		rte_tm_ops_get(port_id, error);		\
+	if (ops == NULL)						\
+		return -rte_errno;				\
+								\
+	if (ops->func == NULL)					\
+		return -rte_tm_error_set(error,		\
+			ENOSYS,					\
+			RTE_TM_ERROR_TYPE_UNSPECIFIED,	\
+			NULL,					\
+			rte_strerror(ENOSYS));			\
+								\
+	ops->func;						\
+})

WARNING:ENOSYS: ENOSYS means 'invalid syscall nr' and nothing else
#327: FILE: lib/librte_ether/rte_tm.c:80:
+			ENOSYS,					\

WARNING:ENOSYS: ENOSYS means 'invalid syscall nr' and nothing else
#330: FILE: lib/librte_ether/rte_tm.c:83:
+			rte_strerror(ENOSYS));			\

total: 0 errors, 6 warnings, 2334 lines checked


More information about the test-report mailing list