[dpdk-test-report] |WARNING| pw21818 [PATCH] vhost: fix virtio_net cache sharing of broadcast_rarp

checkpatch at dpdk.org checkpatch at dpdk.org
Sun Mar 19 11:02:25 CET 2017


Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/21818

_coding style issues_


WARNING:COMMIT_LOG_LONG_LINE: Possible unwrapped commit description (prefer a maximum 75 chars per line)
#25: 
>> In OVS the issue can cause a uni-directional performance drop of up to 15%.

WARNING:TYPO_SPELLING: 'recieved' may be misspelled - perhaps 'received'?
#42: 
> packet once SEND_RARP request is recieved. Otherwise, we may send more

ERROR:DIFF_IN_COMMIT_MSG: Avoid using diff content in the commit message - patch(1) might not work
#76: 
--- a/lib/librte_vhost/virtio_net.c

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#83: FILE: lib/librte_vhost/virtio_net.c:1060:
+       if (unlikely(rte_atomic16_read(&dev->broadcast_rarp) &&$

WARNING:SUSPECT_CODE_INDENT: suspect code indent for conditional statements (7, 15)
#83: FILE: lib/librte_vhost/virtio_net.c:1060:
+       if (unlikely(rte_atomic16_read(&dev->broadcast_rarp) &&
[...]
                rarp_mbuf = rte_pktmbuf_alloc(mbuf_pool);

ERROR:CODE_INDENT: code indent should use tabs where possible
#84: FILE: lib/librte_vhost/virtio_net.c:1061:
+                       rte_atomic16_cmpset((volatile uint16_t *)$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#84: FILE: lib/librte_vhost/virtio_net.c:1061:
+                       rte_atomic16_cmpset((volatile uint16_t *)$

ERROR:MISSING_SIGN_OFF: Missing Signed-off-by: line(s)

total: 3 errors, 5 warnings, 9 lines checked


More information about the test-report mailing list