[dpdk-test-report] |WARNING| pw24169 [PATCH RFC 2/5] pci: allow shared device instances.

checkpatch at dpdk.org checkpatch at dpdk.org
Tue May 9 17:01:21 CEST 2017


Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/24169

_coding style issues_


WARNING:COMMIT_LOG_LONG_LINE: Possible unwrapped commit description (prefer a maximum 75 chars per line)
#14: 
Updated PCI initialization code to allow devices to be shared across multiple PMDs.

WARNING:BRACES: braces {} are not necessary for single statement blocks
#39: FILE: lib/librte_eal/common/eal_common_pci.c:257:
+	if (!dr->id_table->shared || ret) {
+	        return ret;
+	  }

ERROR:CODE_INDENT: code indent should use tabs where possible
#40: FILE: lib/librte_eal/common/eal_common_pci.c:258:
+^I        return ret;$

WARNING:TABSTOP: Statements should start on a tabstop
#41: FILE: lib/librte_eal/common/eal_common_pci.c:259:
+	  }

WARNING:SUSPECT_CODE_INDENT: suspect code indent for conditional statements (16, 18)
#60: FILE: lib/librte_eal/common/eal_common_pci.c:328:
+		if (dr->id_table->shared)
+		  res = 0;

WARNING:TABSTOP: Statements should start on a tabstop
#63: FILE: lib/librte_eal/common/eal_common_pci.c:331:
+		  return 0;

ERROR:COMPLEX_MACRO: Macros with complex values should be enclosed in parentheses
#87: FILE: lib/librte_eal/common/include/rte_pci.h:191:
+#define _RTE_PCI_DEVICE_SH(vend, dev, sh)  \
 	RTE_CLASS_ANY_ID,         \
 	(vend),                   \
 	(dev),                    \
 	PCI_ANY_ID,               \
+	PCI_ANY_ID,               \
+	(sh)

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#109: FILE: lib/librte_eal/common/include/rte_pci.h:210:
+    _RTE_PCI_DEVICE_SH((vend), (dev), 0)$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#111: FILE: lib/librte_eal/common/include/rte_pci.h:212:
+    _RTE_PCI_DEVICE_SH((vend), (dev), 1)$

total: 2 errors, 7 warnings, 82 lines checked


More information about the test-report mailing list