[dpdk-test-report] |WARNING| pw24236 [PATCH v2] drivers/net/i40e/i40e_fdir.c: Improved i40e FDIR programming times

checkpatch at dpdk.org checkpatch at dpdk.org
Thu May 11 12:22:30 CEST 2017


Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/24236

_coding style issues_


WARNING:LEADING_SPACE: please, no spaces at the start of a line
#48: FILE: drivers/net/i40e/i40e_fdir.c:1299:
+       for (i = 0; i < (I40E_FDIR_WAIT_COUNT * I40E_FDIR_WAIT_INTERVAL_US); i++) {$

WARNING:SUSPECT_CODE_INDENT: suspect code indent for conditional statements (7, 15)
#48: FILE: drivers/net/i40e/i40e_fdir.c:1299:
+       for (i = 0; i < (I40E_FDIR_WAIT_COUNT * I40E_FDIR_WAIT_INTERVAL_US); i++) {
                if ((txdp->cmd_type_offset_bsz &

ERROR:CODE_INDENT: code indent should use tabs where possible
#52: FILE: drivers/net/i40e/i40e_fdir.c:1301:
+                       rte_cpu_to_le_64(I40E_TXD_QW1_DTYPE_MASK)) ==$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#52: FILE: drivers/net/i40e/i40e_fdir.c:1301:
+                       rte_cpu_to_le_64(I40E_TXD_QW1_DTYPE_MASK)) ==$

ERROR:CODE_INDENT: code indent should use tabs where possible
#53: FILE: drivers/net/i40e/i40e_fdir.c:1302:
+                       rte_cpu_to_le_64(I40E_TX_DESC_DTYPE_DESC_DONE))$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#53: FILE: drivers/net/i40e/i40e_fdir.c:1302:
+                       rte_cpu_to_le_64(I40E_TX_DESC_DTYPE_DESC_DONE))$

ERROR:CODE_INDENT: code indent should use tabs where possible
#55: FILE: drivers/net/i40e/i40e_fdir.c:1304:
+               rte_delay_us(1);$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#55: FILE: drivers/net/i40e/i40e_fdir.c:1304:
+               rte_delay_us(1);$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#58: FILE: drivers/net/i40e/i40e_fdir.c:1306:
+       if (i >= (I40E_FDIR_WAIT_COUNT * I40E_FDIR_WAIT_INTERVAL_US)) {$

WARNING:SUSPECT_CODE_INDENT: suspect code indent for conditional statements (7, 15)
#58: FILE: drivers/net/i40e/i40e_fdir.c:1306:
+       if (i >= (I40E_FDIR_WAIT_COUNT * I40E_FDIR_WAIT_INTERVAL_US)) {
                PMD_DRV_LOG(ERR, "Failed to program FDIR filter:"

ERROR:CODE_INDENT: code indent should use tabs where possible
#61: FILE: drivers/net/i40e/i40e_fdir.c:1308:
+                       " time out to get DD on tx queue.");$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#61: FILE: drivers/net/i40e/i40e_fdir.c:1308:
+                       " time out to get DD on tx queue.");$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#66: FILE: drivers/net/i40e/i40e_fdir.c:1312:
+       for (i = 0; i < (I40E_FDIR_WAIT_COUNT * I40E_FDIR_WAIT_INTERVAL_US); i++) {$

WARNING:SUSPECT_CODE_INDENT: suspect code indent for conditional statements (7, 15)
#66: FILE: drivers/net/i40e/i40e_fdir.c:1312:
+       for (i = 0; i < (I40E_FDIR_WAIT_COUNT * I40E_FDIR_WAIT_INTERVAL_US); i++) {
+               if (i40e_check_fdir_programming_status(rxq) >= 0) {

ERROR:CODE_INDENT: code indent should use tabs where possible
#67: FILE: drivers/net/i40e/i40e_fdir.c:1313:
+               if (i40e_check_fdir_programming_status(rxq) >= 0) {$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#67: FILE: drivers/net/i40e/i40e_fdir.c:1313:
+               if (i40e_check_fdir_programming_status(rxq) >= 0) {$

WARNING:SUSPECT_CODE_INDENT: suspect code indent for conditional statements (15, 23)
#67: FILE: drivers/net/i40e/i40e_fdir.c:1313:
+               if (i40e_check_fdir_programming_status(rxq) >= 0) {
+                       break;

WARNING:BRACES: braces {} are not necessary for single statement blocks
#67: FILE: drivers/net/i40e/i40e_fdir.c:1313:
+               if (i40e_check_fdir_programming_status(rxq) >= 0) {
+                       break;
+               }

ERROR:CODE_INDENT: code indent should use tabs where possible
#68: FILE: drivers/net/i40e/i40e_fdir.c:1314:
+                       break;$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#68: FILE: drivers/net/i40e/i40e_fdir.c:1314:
+                       break;$

ERROR:CODE_INDENT: code indent should use tabs where possible
#69: FILE: drivers/net/i40e/i40e_fdir.c:1315:
+               }$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#69: FILE: drivers/net/i40e/i40e_fdir.c:1315:
+               }$

ERROR:CODE_INDENT: code indent should use tabs where possible
#70: FILE: drivers/net/i40e/i40e_fdir.c:1316:
+               rte_delay_us(1);$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#70: FILE: drivers/net/i40e/i40e_fdir.c:1316:
+               rte_delay_us(1);$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#71: FILE: drivers/net/i40e/i40e_fdir.c:1317:
+       }$

ERROR:CODE_INDENT: code indent should use tabs where possible
#75: FILE: drivers/net/i40e/i40e_fdir.c:1320:
+                               " programming status reported.");$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#75: FILE: drivers/net/i40e/i40e_fdir.c:1320:
+                               " programming status reported.");$

total: 9 errors, 18 warnings, 0 checks, 36 lines checked


More information about the test-report mailing list