[dpdk-test-report] |WARNING| pw24863 [PATCH v4 04/12] net/failsafe: add fail-safe PMD

checkpatch at dpdk.org checkpatch at dpdk.org
Mon May 29 15:43:59 CEST 2017


Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/24863

_coding style issues_


CHECK:CAMELCASE: Avoid CamelCase: <PRIu8>
#1721: FILE: drivers/net/failsafe/failsafe_ops.c:614:
+			      PRIu8 " with error %d", i, ret);

CHECK:MACRO_ARG_REUSE: Macro argument reuse 'i' - possible side-effects?
#1931: FILE: drivers/net/failsafe/failsafe_private.h:155:
+#define FOREACH_SUBDEV_ST(s, i, dev, state)				\
+	for (i = fs_find_next((dev), 0, state);				\
+	     i < PRIV(dev)->subs_tail && (s = &PRIV(dev)->subs[i]);	\
+	     i = fs_find_next((dev), i + 1, state))

CHECK:MACRO_ARG_REUSE: Macro argument reuse 'dev' - possible side-effects?
#1931: FILE: drivers/net/failsafe/failsafe_private.h:155:
+#define FOREACH_SUBDEV_ST(s, i, dev, state)				\
+	for (i = fs_find_next((dev), 0, state);				\
+	     i < PRIV(dev)->subs_tail && (s = &PRIV(dev)->subs[i]);	\
+	     i = fs_find_next((dev), i + 1, state))

CHECK:MACRO_ARG_REUSE: Macro argument reuse 'state' - possible side-effects?
#1931: FILE: drivers/net/failsafe/failsafe_private.h:155:
+#define FOREACH_SUBDEV_ST(s, i, dev, state)				\
+	for (i = fs_find_next((dev), 0, state);				\
+	     i < PRIV(dev)->subs_tail && (s = &PRIV(dev)->subs[i]);	\
+	     i = fs_find_next((dev), i + 1, state))

CHECK:MACRO_ARG_REUSE: Macro argument reuse 'dev' - possible side-effects?
#1950: FILE: drivers/net/failsafe/failsafe_private.h:174:
+#define TX_SUBDEV(dev)							  \
+	(PRIV(dev)->subs_tx >= PRIV(dev)->subs_tail		   ? NULL \
+	 : (PRIV(dev)->subs[PRIV(dev)->subs_tx].state < DEV_PROBED ? NULL \
+	 : &PRIV(dev)->subs[PRIV(dev)->subs_tx]))

CHECK:MACRO_ARG_PRECEDENCE: Macro argument 'ops' may be better as '(ops)' to avoid precedence issues
#1959: FILE: drivers/net/failsafe/failsafe_private.h:183:
+#define SUBOPS(s, ops) \
+	(ETH(s)->dev_ops->ops)

total: 0 errors, 0 warnings, 1993 lines checked


More information about the test-report mailing list