[dpdk-test-report] |WARNING| pw31168 [PATCH v2] igb_uio: add config option to control reset

checkpatch at dpdk.org checkpatch at dpdk.org
Fri Nov 3 23:04:21 CET 2017


Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/31168

_coding style issues_


WARNING:COMMIT_LOG_LONG_LINE: Possible unwrapped commit description (prefer a maximum 75 chars per line)
#28: 
>> To: Ferruh Yigit <ferruh.yigit at intel.com>; Thomas Monjalon <thomas at monjalon.net>

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#194: FILE: lib/librte_eal/linuxapp/igb_uio/compat.h:139:
+       { PCI_DEVICE(BROADCOM_PCI_VENDOR_ID, 0x168a) }, /* 57800 */$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#195: FILE: lib/librte_eal/linuxapp/igb_uio/compat.h:140:
+       { PCI_DEVICE(BROADCOM_PCI_VENDOR_ID, 0x164f) }, /* 57711 */$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#196: FILE: lib/librte_eal/linuxapp/igb_uio/compat.h:141:
+       { PCI_DEVICE(BROADCOM_PCI_VENDOR_ID, 0x168e) }, /* 57810 */$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#197: FILE: lib/librte_eal/linuxapp/igb_uio/compat.h:142:
+       { PCI_DEVICE(BROADCOM_PCI_VENDOR_ID, 0x163d) }, /* 57811 */$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#198: FILE: lib/librte_eal/linuxapp/igb_uio/compat.h:143:
+       { PCI_DEVICE(BROADCOM_PCI_VENDOR_ID, 0x168d) }, /* 57840_OBS */$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#199: FILE: lib/librte_eal/linuxapp/igb_uio/compat.h:144:
+       { PCI_DEVICE(BROADCOM_PCI_VENDOR_ID, 0x16a1) }, /* 57840_4_10 */$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#200: FILE: lib/librte_eal/linuxapp/igb_uio/compat.h:145:
+       { PCI_DEVICE(BROADCOM_PCI_VENDOR_ID, 0x16a2) }, /* 57840_2_20 */$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#201: FILE: lib/librte_eal/linuxapp/igb_uio/compat.h:146:
+       { PCI_DEVICE(BROADCOM_PCI_VENDOR_ID, 0x16ae) }, /* 57810_MF */$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#202: FILE: lib/librte_eal/linuxapp/igb_uio/compat.h:147:
+       { PCI_DEVICE(BROADCOM_PCI_VENDOR_ID, 0x163e) }, /* 57811_MF */$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#203: FILE: lib/librte_eal/linuxapp/igb_uio/compat.h:148:
+       { PCI_DEVICE(BROADCOM_PCI_VENDOR_ID, 0x16a4) }, /* 57840_MF */$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#204: FILE: lib/librte_eal/linuxapp/igb_uio/compat.h:149:
+       { PCI_DEVICE(BROADCOM_PCI_VENDOR_ID, 0x16a9) }, /* 57800_VF */$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#205: FILE: lib/librte_eal/linuxapp/igb_uio/compat.h:150:
+       { PCI_DEVICE(BROADCOM_PCI_VENDOR_ID, 0x16af) }, /* 57810_VF */$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#206: FILE: lib/librte_eal/linuxapp/igb_uio/compat.h:151:
+       { PCI_DEVICE(BROADCOM_PCI_VENDOR_ID, 0x163f) }, /* 57811_VF */$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#207: FILE: lib/librte_eal/linuxapp/igb_uio/compat.h:152:
+       { PCI_DEVICE(BROADCOM_PCI_VENDOR_ID, 0x16ad) }, /* 57840_VF */$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#208: FILE: lib/librte_eal/linuxapp/igb_uio/compat.h:153:
+       { 0 },$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#221: FILE: lib/librte_eal/linuxapp/igb_uio/igb_uio.c:353:
+       if (pci_match_id(no_reset_pci_tbl, pdev))$

WARNING:SUSPECT_CODE_INDENT: suspect code indent for conditional statements (7, 15)
#221: FILE: lib/librte_eal/linuxapp/igb_uio/igb_uio.c:353:
+       if (pci_match_id(no_reset_pci_tbl, pdev))
+               return 1;

ERROR:CODE_INDENT: code indent should use tabs where possible
#222: FILE: lib/librte_eal/linuxapp/igb_uio/igb_uio.c:354:
+               return 1;$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#222: FILE: lib/librte_eal/linuxapp/igb_uio/igb_uio.c:354:
+               return 1;$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#224: FILE: lib/librte_eal/linuxapp/igb_uio/igb_uio.c:356:
+       return 0;$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#235: FILE: lib/librte_eal/linuxapp/igb_uio/igb_uio.c:371:
+       if (!is_device_excluded_from_reset(dev))$

WARNING:SUSPECT_CODE_INDENT: suspect code indent for conditional statements (7, 15)
#235: FILE: lib/librte_eal/linuxapp/igb_uio/igb_uio.c:371:
+       if (!is_device_excluded_from_reset(dev))
+               pci_reset_function(dev);

ERROR:CODE_INDENT: code indent should use tabs where possible
#236: FILE: lib/librte_eal/linuxapp/igb_uio/igb_uio.c:372:
+               pci_reset_function(dev);$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#236: FILE: lib/librte_eal/linuxapp/igb_uio/igb_uio.c:372:
+               pci_reset_function(dev);$

ERROR:MISSING_SIGN_OFF: Missing Signed-off-by: line(s)

total: 3 errors, 23 warnings, 44 lines checked


More information about the test-report mailing list