[dpdk-test-report] |WARNING| pw31233 [PATCH v2] ring: guarantee ordering of cons/prod loading when doing

[checkpatch at dpdk.org]

Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/31233

_coding style issues_


WARNING:COMMIT_LOG_LONG_LINE: Possible unwrapped commit description (prefer a maximum 75 chars per line)
#24: 
> If not, move, __rte_ring_do_dequeue() and __rte_ring_do_enqueue() instead of

ERROR:TRAILING_WHITESPACE: trailing whitespace
#145: FILE: lib/librte_ring/rte_ring_c11_mem.h:37:
+update_tail(struct rte_ring_headtail *ht, uint32_t old_val, uint32_t $

ERROR:CORRUPTED_PATCH: patch seems to be corrupt (line wrapped?)
#146: FILE: lib/librte_ring/rte_ring_c11_mem.h:37:
new_val,

WARNING:BLOCK_COMMENT_STYLE: Block comments use * on subsequent lines
#150: FILE: lib/librte_ring/rte_ring_c11_mem.h:41:
+Â Â Â  /* Don't need wmb/rmb when we prefer to use load_acquire/
+Â Â Â  Â * store_release barrier */

WARNING:BLOCK_COMMENT_STYLE: Block comments use a trailing */ on a separate line
#150: FILE: lib/librte_ring/rte_ring_c11_mem.h:41:
+Â Â Â  Â * store_release barrier */

WARNING:SUSPECT_CODE_INDENT: suspect code indent for conditional statements (0, 0)
#152: FILE: lib/librte_ring/rte_ring_c11_mem.h:43:
+Â Â Â  if (enqueue)
+Â Â Â  Â Â Â  rte_smp_wmb();

WARNING:SUSPECT_CODE_INDENT: suspect code indent for conditional statements (0, 0)
#154: FILE: lib/librte_ring/rte_ring_c11_mem.h:45:
+Â Â Â  else
+Â Â Â  Â Â Â  rte_smp_rmb();

WARNING:BLOCK_COMMENT_STYLE: Block comments use * on subsequent lines
#159: FILE: lib/librte_ring/rte_ring_c11_mem.h:50:
+Â Â Â  /*
+Â Â Â  Â * If there are other enqueues/dequeues in progress that preceded us,

WARNING:BLOCK_COMMENT_STYLE: Block comments use a trailing */ on a separate line
#161: FILE: lib/librte_ring/rte_ring_c11_mem.h:52:
+Â Â Â  Â */

WARNING:SUSPECT_CODE_INDENT: suspect code indent for conditional statements (0, 0)
#162: FILE: lib/librte_ring/rte_ring_c11_mem.h:53:
+Â Â Â  if (!single)
+Â Â Â  Â Â Â  while (unlikely(ht->tail != old_val))

WARNING:SUSPECT_CODE_INDENT: suspect code indent for conditional statements (0, 0)
#163: FILE: lib/librte_ring/rte_ring_c11_mem.h:54:
+Â Â Â  Â Â Â  while (unlikely(ht->tail != old_val))
+Â Â Â  Â Â Â  Â Â Â  rte_pause();

ERROR:TRAILING_WHITESPACE: trailing whitespace
#181: FILE: lib/librte_ring/rte_ring_c11_mem.h:72:
+ *Â Â  The number of elements we will want to enqueue, i.e. how far $

ERROR:TRAILING_WHITESPACE: trailing whitespace
#188: FILE: lib/librte_ring/rte_ring_c11_mem.h:78:
+ *Â Â  Returns head value as it was before the move, i.e. where enqueue $

WARNING:SUSPECT_CODE_INDENT: suspect code indent for conditional statements (0, 0)
#208: FILE: lib/librte_ring/rte_ring_c11_mem.h:97:
+Â Â Â  do {
+Â Â Â  Â Â Â  /* Reset n to the initial burst count */

WARNING:BLOCK_COMMENT_STYLE: Block comments use * on subsequent lines
#222: FILE: lib/librte_ring/rte_ring_c11_mem.h:111:
+Â Â Â  Â Â Â  /*
+Â Â Â  Â Â Â  Â *Â  The subtraction is done between two unsigned 32bits value

WARNING:BLOCK_COMMENT_STYLE: Block comments use a trailing */ on a separate line
#226: FILE: lib/librte_ring/rte_ring_c11_mem.h:115:
+Â Â Â  Â Â Â  Â */

WARNING:SUSPECT_CODE_INDENT: suspect code indent for conditional statements (0, 0)
#230: FILE: lib/librte_ring/rte_ring_c11_mem.h:119:
+Â Â Â  Â Â Â  if (unlikely(n > *free_entries))
+Â Â Â  Â Â Â  Â Â Â  n = (behavior == RTE_RING_QUEUE_FIXED) ?

WARNING:SUSPECT_CODE_INDENT: suspect code indent for conditional statements (0, 0)
#234: FILE: lib/librte_ring/rte_ring_c11_mem.h:123:
+Â Â Â  Â Â Â  if (n == 0)
+Â Â Â  Â Â Â  Â Â Â  return 0;

WARNING:SUSPECT_CODE_INDENT: suspect code indent for conditional statements (0, 0)
#238: FILE: lib/librte_ring/rte_ring_c11_mem.h:127:
+Â Â Â  Â Â Â  if (is_sp)
+Â Â Â  Â Â Â  Â Â Â  r->prod.head = *new_head, success = 1;

WARNING:SUSPECT_CODE_INDENT: suspect code indent for conditional statements (0, 0)
#240: FILE: lib/librte_ring/rte_ring_c11_mem.h:129:
+Â Â Â  Â Â Â  else
[...]
+Â Â Â  Â Â Â  Â Â Â  success = arch_rte_atomic32_cmpset(&r->prod.head,

WARNING:SUSPECT_CODE_INDENT: suspect code indent for conditional statements (0, 0)
#284: FILE: lib/librte_ring/rte_ring_c11_mem.h:173:
+Â Â Â  if (n == 0)
+Â Â Â  Â Â Â  goto end;

WARNING:SUSPECT_CODE_INDENT: suspect code indent for conditional statements (0, 0)
#291: FILE: lib/librte_ring/rte_ring_c11_mem.h:180:
+Â Â Â  if (free_space != NULL)
+Â Â Â  Â Â Â  *free_space = free_entries - n;

ERROR:TRAILING_WHITESPACE: trailing whitespace
#304: FILE: lib/librte_ring/rte_ring_c11_mem.h:193:
+ *Â Â  The number of elements we will want to enqueue, i.e. how far $

ERROR:TRAILING_WHITESPACE: trailing whitespace
#311: FILE: lib/librte_ring/rte_ring_c11_mem.h:199:
+ *Â Â  Returns head value as it was before the move, i.e. where dequeue $

WARNING:SUSPECT_CODE_INDENT: suspect code indent for conditional statements (0, 0)
#331: FILE: lib/librte_ring/rte_ring_c11_mem.h:218:
+Â Â Â  do {
+Â Â Â  Â Â Â  /* Restore n as it may change every loop */

WARNING:BLOCK_COMMENT_STYLE: Block comments use * on subsequent lines
#345: FILE: lib/librte_ring/rte_ring_c11_mem.h:232:
+Â Â Â  Â Â Â  /* The subtraction is done between two unsigned 32bits value
+Â Â Â  Â Â Â  Â * (the result is always modulo 32 bits even if we have

WARNING:BLOCK_COMMENT_STYLE: Block comments use a trailing */ on a separate line
#347: FILE: lib/librte_ring/rte_ring_c11_mem.h:234:
+Â Â Â  Â Â Â  Â * and size(ring)-1. */

WARNING:SUSPECT_CODE_INDENT: suspect code indent for conditional statements (0, 0)
#351: FILE: lib/librte_ring/rte_ring_c11_mem.h:238:
+Â Â Â  Â Â Â  if (n > *entries)
+Â Â Â  Â Â Â  Â Â Â  n = (behavior == RTE_RING_QUEUE_FIXED) ? 0 : *entries;

WARNING:SUSPECT_CODE_INDENT: suspect code indent for conditional statements (0, 0)
#354: FILE: lib/librte_ring/rte_ring_c11_mem.h:241:
+Â Â Â  Â Â Â  if (unlikely(n == 0))
+Â Â Â  Â Â Â  Â Â Â  return 0;

WARNING:SUSPECT_CODE_INDENT: suspect code indent for conditional statements (0, 0)
#358: FILE: lib/librte_ring/rte_ring_c11_mem.h:245:
+Â Â Â  Â Â Â  if (is_sc)
+Â Â Â  Â Â Â  Â Â Â  r->cons.head = *new_head, success = 1;

WARNING:SUSPECT_CODE_INDENT: suspect code indent for conditional statements (0, 0)
#360: FILE: lib/librte_ring/rte_ring_c11_mem.h:247:
+Â Â Â  Â Â Â  else
[...]
+Â Â Â  Â Â Â  Â Â Â  success = arch_rte_atomic32_cmpset(&r->cons.head,

ERROR:TRAILING_WHITESPACE: trailing whitespace
#389: FILE: lib/librte_ring/rte_ring_c11_mem.h:276:
+ *Â Â  returns the number of remaining ring entries after the dequeue has $

WARNING:SUSPECT_CODE_INDENT: suspect code indent for conditional statements (0, 0)
#405: FILE: lib/librte_ring/rte_ring_c11_mem.h:291:
+Â Â Â  if (n == 0)
+Â Â Â  Â Â Â  goto end;

WARNING:SUSPECT_CODE_INDENT: suspect code indent for conditional statements (0, 0)
#413: FILE: lib/librte_ring/rte_ring_c11_mem.h:299:
+Â Â Â  if (available != NULL)
+Â Â Â  Â Â Â  *available = entries - n;

ERROR:TRAILING_WHITESPACE: trailing whitespace
#463: FILE: lib/librte_ring/rte_ring_generic.h:37:
+update_tail(struct rte_ring_headtail *ht, uint32_t old_val, uint32_t $

WARNING:SUSPECT_CODE_INDENT: suspect code indent for conditional statements (0, 0)
#467: FILE: lib/librte_ring/rte_ring_generic.h:40:
+Â Â Â  if (enqueue)
+Â Â Â  Â Â Â  rte_smp_wmb();

WARNING:SUSPECT_CODE_INDENT: suspect code indent for conditional statements (0, 0)
#469: FILE: lib/librte_ring/rte_ring_generic.h:42:
+Â Â Â  else
+Â Â Â  Â Â Â  rte_smp_rmb();

WARNING:BLOCK_COMMENT_STYLE: Block comments use * on subsequent lines
#472: FILE: lib/librte_ring/rte_ring_generic.h:45:
+Â Â Â  /*
+Â Â Â  Â * If there are other enqueues/dequeues in progress that preceded us,

WARNING:BLOCK_COMMENT_STYLE: Block comments use a trailing */ on a separate line
#474: FILE: lib/librte_ring/rte_ring_generic.h:47:
+Â Â Â  Â */

WARNING:SUSPECT_CODE_INDENT: suspect code indent for conditional statements (0, 0)
#475: FILE: lib/librte_ring/rte_ring_generic.h:48:
+Â Â Â  if (!single)
+Â Â Â  Â Â Â  while (unlikely(ht->tail != old_val))

WARNING:SUSPECT_CODE_INDENT: suspect code indent for conditional statements (0, 0)
#476: FILE: lib/librte_ring/rte_ring_generic.h:49:
+Â Â Â  Â Â Â  while (unlikely(ht->tail != old_val))
+Â Â Â  Â Â Â  Â Â Â  rte_pause();

ERROR:TRAILING_WHITESPACE: trailing whitespace
#490: FILE: lib/librte_ring/rte_ring_generic.h:63:
+ *Â Â  The number of elements we will want to enqueue, i.e. how far $

ERROR:TRAILING_WHITESPACE: trailing whitespace
#497: FILE: lib/librte_ring/rte_ring_generic.h:69:
+ *Â Â  Returns head value as it was before the move, i.e. where enqueue $

WARNING:SUSPECT_CODE_INDENT: suspect code indent for conditional statements (0, 0)
#517: FILE: lib/librte_ring/rte_ring_generic.h:88:
+Â Â Â  do {
+Â Â Â  Â Â Â  /* Reset n to the initial burst count */

WARNING:BLOCK_COMMENT_STYLE: Block comments use * on subsequent lines
#524: FILE: lib/librte_ring/rte_ring_generic.h:95:
+Â Â Â  Â Â Â  /*
+Â Â Â  Â Â Â  Â *Â  The subtraction is done between two unsigned 32bits value

WARNING:BLOCK_COMMENT_STYLE: Block comments use a trailing */ on a separate line
#528: FILE: lib/librte_ring/rte_ring_generic.h:99:
+Â Â Â  Â Â Â  Â */

WARNING:SUSPECT_CODE_INDENT: suspect code indent for conditional statements (0, 0)
#532: FILE: lib/librte_ring/rte_ring_generic.h:103:
+Â Â Â  Â Â Â  if (unlikely(n > *free_entries))
+Â Â Â  Â Â Â  Â Â Â  n = (behavior == RTE_RING_QUEUE_FIXED) ?

WARNING:SUSPECT_CODE_INDENT: suspect code indent for conditional statements (0, 0)
#536: FILE: lib/librte_ring/rte_ring_generic.h:107:
+Â Â Â  Â Â Â  if (n == 0)
+Â Â Â  Â Â Â  Â Â Â  return 0;

WARNING:SUSPECT_CODE_INDENT: suspect code indent for conditional statements (0, 0)
#540: FILE: lib/librte_ring/rte_ring_generic.h:111:
+Â Â Â  Â Â Â  if (is_sp)
+Â Â Â  Â Â Â  Â Â Â  r->prod.head = *new_head, success = 1;

WARNING:SUSPECT_CODE_INDENT: suspect code indent for conditional statements (0, 0)
#542: FILE: lib/librte_ring/rte_ring_generic.h:113:
+Â Â Â  Â Â Â  else
+Â Â Â  Â Â Â  Â Â Â  success = rte_atomic32_cmpset(&r->prod.head,

WARNING:SUSPECT_CODE_INDENT: suspect code indent for conditional statements (0, 0)
#579: FILE: lib/librte_ring/rte_ring_generic.h:150:
+Â Â Â  if (n == 0)
+Â Â Â  Â Â Â  goto end;

WARNING:SUSPECT_CODE_INDENT: suspect code indent for conditional statements (0, 0)
#586: FILE: lib/librte_ring/rte_ring_generic.h:157:
+Â Â Â  if (free_space != NULL)
+Â Â Â  Â Â Â  *free_space = free_entries - n;

ERROR:TRAILING_WHITESPACE: trailing whitespace
#599: FILE: lib/librte_ring/rte_ring_generic.h:170:
+ *Â Â  The number of elements we will want to enqueue, i.e. how far $

ERROR:TRAILING_WHITESPACE: trailing whitespace
#606: FILE: lib/librte_ring/rte_ring_generic.h:176:
+ *Â Â  Returns head value as it was before the move, i.e. where dequeue $

WARNING:SUSPECT_CODE_INDENT: suspect code indent for conditional statements (0, 0)
#626: FILE: lib/librte_ring/rte_ring_generic.h:195:
+Â Â Â  do {
+Â Â Â  Â Â Â  /* Restore n as it may change every loop */

WARNING:BLOCK_COMMENT_STYLE: Block comments use * on subsequent lines
#633: FILE: lib/librte_ring/rte_ring_generic.h:202:
+Â Â Â  Â Â Â  /* The subtraction is done between two unsigned 32bits value
+Â Â Â  Â Â Â  Â * (the result is always modulo 32 bits even if we have

WARNING:BLOCK_COMMENT_STYLE: Block comments use a trailing */ on a separate line
#635: FILE: lib/librte_ring/rte_ring_generic.h:204:
+Â Â Â  Â Â Â  Â * and size(ring)-1. */

WARNING:SUSPECT_CODE_INDENT: suspect code indent for conditional statements (0, 0)
#639: FILE: lib/librte_ring/rte_ring_generic.h:208:
+Â Â Â  Â Â Â  if (n > *entries)
+Â Â Â  Â Â Â  Â Â Â  n = (behavior == RTE_RING_QUEUE_FIXED) ? 0 : *entries;

WARNING:SUSPECT_CODE_INDENT: suspect code indent for conditional statements (0, 0)
#642: FILE: lib/librte_ring/rte_ring_generic.h:211:
+Â Â Â  Â Â Â  if (unlikely(n == 0))
+Â Â Â  Â Â Â  Â Â Â  return 0;

WARNING:SUSPECT_CODE_INDENT: suspect code indent for conditional statements (0, 0)
#646: FILE: lib/librte_ring/rte_ring_generic.h:215:
+Â Â Â  Â Â Â  if (is_sc)
+Â Â Â  Â Â Â  Â Â Â  r->cons.head = *new_head, success = 1;

WARNING:SUSPECT_CODE_INDENT: suspect code indent for conditional statements (0, 0)
#648: FILE: lib/librte_ring/rte_ring_generic.h:217:
+Â Â Â  Â Â Â  else
+Â Â Â  Â Â Â  Â Â Â  success = rte_atomic32_cmpset(&r->cons.head, *old_head,

ERROR:TRAILING_WHITESPACE: trailing whitespace
#670: FILE: lib/librte_ring/rte_ring_generic.h:239:
+ *Â Â  returns the number of remaining ring entries after the dequeue has $

WARNING:SUSPECT_CODE_INDENT: suspect code indent for conditional statements (0, 0)
#686: FILE: lib/librte_ring/rte_ring_generic.h:254:
+Â Â Â  if (n == 0)
+Â Â Â  Â Â Â  goto end;

ERROR:MISSING_SIGN_OFF: Missing Signed-off-by: line(s)

total: 14 errors, 50 warnings, 579 lines checked