[dpdk-test-report] |WARNING| pw31422 [PATCH 41/53] net/sfc/base: fix diagnostics support build without Siena

checkpatch at dpdk.org checkpatch at dpdk.org
Thu Nov 16 09:12:27 CET 2017


Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/31422

_coding style issues_


WARNING:SPACING: space prohibited between function name and open parenthesis '('
#303: FILE: drivers/net/sfc/base/siena_nic.c:553:
+			if (memcmp(&reg, &buf, sizeof (reg))) {

WARNING:SPACING: space prohibited between function name and open parenthesis '('
#318: FILE: drivers/net/sfc/base/siena_nic.c:568:
+			if (memcmp(&reg, &buf, sizeof (reg))) {

ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#342: FILE: drivers/net/sfc/base/siena_nic.c:592:
+	return (rc);

CHECK:CAMELCASE: Avoid CamelCase: <__checkReturn>
#345: FILE: drivers/net/sfc/base/siena_nic.c:595:
+	__checkReturn	efx_rc_t

WARNING:SPACING: space prohibited between function name and open parenthesis '('
#381: FILE: drivers/net/sfc/base/siena_nic.c:631:
+			if (memcmp(&reg, &buf, sizeof (reg))) {

ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#398: FILE: drivers/net/sfc/base/siena_nic.c:648:
+	return (rc);

ERROR:ASSIGN_IN_IF: do not use assignment in if condition
#416: FILE: drivers/net/sfc/base/siena_nic.c:690:
+	if ((rc = siena_nic_test_registers(enp, __siena_registers,

ERROR:ASSIGN_IN_IF: do not use assignment in if condition
#421: FILE: drivers/net/sfc/base/siena_nic.c:694:
+	if ((rc = siena_nic_test_tables(enp, __siena_tables,

ERROR:ASSIGN_IN_IF: do not use assignment in if condition
#427: FILE: drivers/net/sfc/base/siena_nic.c:699:
+	if ((rc = siena_nic_test_tables(enp, __siena_tables,

ERROR:ASSIGN_IN_IF: do not use assignment in if condition
#433: FILE: drivers/net/sfc/base/siena_nic.c:704:
+	if ((rc = siena_nic_test_tables(enp, __siena_tables,

total: 6 errors, 3 warnings, 1 checks, 372 lines checked


More information about the test-report mailing list