[dpdk-test-report] |WARNING| pw31617 [PATCH v2 03/14] net/avf: enable queue and device

checkpatch at dpdk.org checkpatch at dpdk.org
Mon Nov 27 12:24:37 CET 2017


Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/31617

_coding style issues_


CHECK:BRACES: Unbalanced braces around else statement
#177: FILE: drivers/net/avf/avf_ethdev.c:146:
+	} else

CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'nb_desc > AVF_MAX_RING_DESC'
#758: FILE: drivers/net/avf/avf_rxtx.c:281:
+	if (nb_desc % AVF_ALIGN_RING_DESC != 0 ||
+	    (nb_desc > AVF_MAX_RING_DESC) ||
+	    (nb_desc < AVF_MIN_RING_DESC)) {

CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'nb_desc < AVF_MIN_RING_DESC'
#758: FILE: drivers/net/avf/avf_rxtx.c:281:
+	if (nb_desc % AVF_ALIGN_RING_DESC != 0 ||
+	    (nb_desc > AVF_MAX_RING_DESC) ||
+	    (nb_desc < AVF_MIN_RING_DESC)) {

CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'nb_desc > AVF_MAX_RING_DESC'
#859: FILE: drivers/net/avf/avf_rxtx.c:382:
+	if (nb_desc % AVF_ALIGN_RING_DESC != 0 ||
+	    (nb_desc > AVF_MAX_RING_DESC) ||
+	    (nb_desc < AVF_MIN_RING_DESC)) {

CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'nb_desc < AVF_MIN_RING_DESC'
#859: FILE: drivers/net/avf/avf_rxtx.c:382:
+	if (nb_desc % AVF_ALIGN_RING_DESC != 0 ||
+	    (nb_desc > AVF_MAX_RING_DESC) ||
+	    (nb_desc < AVF_MIN_RING_DESC)) {

CHECK:CAMELCASE: Avoid CamelCase: <PRIx64>
#1272: FILE: drivers/net/avf/avf_rxtx.h:145:
+	printf("Queue %d Rx_desc %d: QW0: 0x%016"PRIx64" QW1: 0x%016"PRIx64"
",

CHECK:CONCATENATED_STRING: Concatenated strings should use spaces between elements
#1272: FILE: drivers/net/avf/avf_rxtx.h:145:
+	printf("Queue %d Rx_desc %d: QW0: 0x%016"PRIx64" QW1: 0x%016"PRIx64"
",

CHECK:CONCATENATED_STRING: Concatenated strings should use spaces between elements
#1278: FILE: drivers/net/avf/avf_rxtx.h:151:
+	printf("Queue %d Rx_desc %d: QW0: 0x%016"PRIx64" QW1: 0x%016"PRIx64

CHECK:CONCATENATED_STRING: Concatenated strings should use spaces between elements
#1279: FILE: drivers/net/avf/avf_rxtx.h:152:
+	       " QW2: 0x%016"PRIx64" QW3: 0x%016"PRIx64"
", rxq->queue_id,

WARNING:BLOCK_COMMENT_STYLE: Block comments use a trailing */ on a separate line
#1286: FILE: drivers/net/avf/avf_rxtx.h:159:
+ * to print the qwords */

CHECK:CONCATENATED_STRING: Concatenated strings should use spaces between elements
#1310: FILE: drivers/net/avf/avf_rxtx.h:183:
+	printf("Queue %d %s %d: QW0: 0x%016"PRIx64" QW1: 0x%016"PRIx64"
",

WARNING:TRAILING_SEMICOLON: macros should not use a trailing semicolon
#1316: FILE: drivers/net/avf/avf_rxtx.h:189:
+#define AVF_DUMP_RX_DESC(rxq, desc, rx_id) \
+	avf_dump_rx_descriptor(rxq, desc, rx_id);

WARNING:TRAILING_SEMICOLON: macros should not use a trailing semicolon
#1323: FILE: drivers/net/avf/avf_rxtx.h:196:
+#define AVF_DUMP_TX_DESC(txq, desc, tx_id) \
+	avf_dump_tx_descriptor(txq, desc, tx_id);

WARNING:SUSPECT_CODE_INDENT: suspect code indent for conditional statements (8, 17)
#1360: FILE: drivers/net/avf/avf_vchnl.c:241:
+	if (ret)
+		 PMD_DRV_LOG(ERR, "Failed to execute command of "

WARNING:SUSPECT_CODE_INDENT: suspect code indent for conditional statements (8, 17)
#1381: FILE: drivers/net/avf/avf_vchnl.c:262:
+	if (ret)
+		 PMD_DRV_LOG(ERR, "Failed to execute command of "

WARNING:TABSTOP: Statements should start on a tabstop
#1385: FILE: drivers/net/avf/avf_vchnl.c:266:
+	 return ret;

WARNING:ENOSYS: ENOSYS means 'invalid syscall nr' and nothing else
#1419: FILE: drivers/net/avf/avf_vchnl.c:404:
+		return -ENOSYS;

WARNING:ENOSYS: ENOSYS means 'invalid syscall nr' and nothing else
#1447: FILE: drivers/net/avf/avf_vchnl.c:432:
+		return -ENOSYS;

WARNING:ENOSYS: ENOSYS means 'invalid syscall nr' and nothing else
#1509: FILE: drivers/net/avf/avf_vchnl.c:494:
+		err = -ENOSYS;

WARNING:ENOSYS: ENOSYS means 'invalid syscall nr' and nothing else
#1541: FILE: drivers/net/avf/avf_vchnl.c:526:
+		err = -ENOSYS;

WARNING:ENOSYS: ENOSYS means 'invalid syscall nr' and nothing else
#1601: FILE: drivers/net/avf/avf_vchnl.c:586:
+		err = -ENOSYS;

total: 0 errors, 11 warnings, 10 checks, 1627 lines checked


More information about the test-report mailing list