[dpdk-test-report] |WARNING| pw29968 [PATCH v3 13/30] net/mlx5: add reference counter on DPDK Rx queues

checkpatch at dpdk.org checkpatch at dpdk.org
Mon Oct 9 16:47:05 CEST 2017


Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/29968

_coding style issues_


WARNING:USE_NEGATIVE_ERRNO: return of an errno should typically be negative (ie: return -EBUSY)
#610: FILE: drivers/net/mlx5/mlx5_rxq.c:1579:
+	return EBUSY;

WARNING:FUNCTION_ARGUMENTS: function definition argument 'struct priv *' should also have an identifier name
#673: FILE: drivers/net/mlx5/mlx5_rxtx.h:340:
+struct mlx5_rxq_ctrl *mlx5_priv_rxq_new(struct priv *, uint16_t,

WARNING:FUNCTION_ARGUMENTS: function definition argument 'uint16_t' should also have an identifier name
#673: FILE: drivers/net/mlx5/mlx5_rxtx.h:340:
+struct mlx5_rxq_ctrl *mlx5_priv_rxq_new(struct priv *, uint16_t,

WARNING:FUNCTION_ARGUMENTS: function definition argument 'uint16_t' should also have an identifier name
#673: FILE: drivers/net/mlx5/mlx5_rxtx.h:340:
+struct mlx5_rxq_ctrl *mlx5_priv_rxq_new(struct priv *, uint16_t,

WARNING:FUNCTION_ARGUMENTS: function definition argument 'unsigned int' should also have an identifier name
#673: FILE: drivers/net/mlx5/mlx5_rxtx.h:340:
+struct mlx5_rxq_ctrl *mlx5_priv_rxq_new(struct priv *, uint16_t,

WARNING:FUNCTION_ARGUMENTS: function definition argument 'struct rte_mempool *' should also have an identifier name
#673: FILE: drivers/net/mlx5/mlx5_rxtx.h:340:
+struct mlx5_rxq_ctrl *mlx5_priv_rxq_new(struct priv *, uint16_t,

WARNING:FUNCTION_ARGUMENTS: function definition argument 'struct priv *' should also have an identifier name
#676: FILE: drivers/net/mlx5/mlx5_rxtx.h:343:
+struct mlx5_rxq_ctrl *mlx5_priv_rxq_get(struct priv *, uint16_t);

WARNING:FUNCTION_ARGUMENTS: function definition argument 'uint16_t' should also have an identifier name
#676: FILE: drivers/net/mlx5/mlx5_rxtx.h:343:
+struct mlx5_rxq_ctrl *mlx5_priv_rxq_get(struct priv *, uint16_t);

WARNING:FUNCTION_ARGUMENTS: function definition argument 'struct priv *' should also have an identifier name
#677: FILE: drivers/net/mlx5/mlx5_rxtx.h:344:
+int mlx5_priv_rxq_release(struct priv *, uint16_t);

WARNING:FUNCTION_ARGUMENTS: function definition argument 'uint16_t' should also have an identifier name
#677: FILE: drivers/net/mlx5/mlx5_rxtx.h:344:
+int mlx5_priv_rxq_release(struct priv *, uint16_t);

WARNING:FUNCTION_ARGUMENTS: function definition argument 'struct priv *' should also have an identifier name
#678: FILE: drivers/net/mlx5/mlx5_rxtx.h:345:
+int mlx5_priv_rxq_releasable(struct priv *, uint16_t);

WARNING:FUNCTION_ARGUMENTS: function definition argument 'uint16_t' should also have an identifier name
#678: FILE: drivers/net/mlx5/mlx5_rxtx.h:345:
+int mlx5_priv_rxq_releasable(struct priv *, uint16_t);

WARNING:FUNCTION_ARGUMENTS: function definition argument 'struct priv *' should also have an identifier name
#679: FILE: drivers/net/mlx5/mlx5_rxtx.h:346:
+int mlx5_priv_rxq_verify(struct priv *);

WARNING:FUNCTION_ARGUMENTS: function definition argument 'struct mlx5_rxq_ctrl *' should also have an identifier name
#680: FILE: drivers/net/mlx5/mlx5_rxtx.h:347:
+int rxq_alloc_elts(struct mlx5_rxq_ctrl *);

total: 0 errors, 14 warnings, 0 checks, 700 lines checked


More information about the test-report mailing list