[dpdk-test-report] |WARNING| pw37365 [PATCH v5 05/18] net/axgbe: add phy initialization and related apis

checkpatch at dpdk.org checkpatch at dpdk.org
Fri Apr 6 14:37:46 CEST 2018


Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/37365

_coding style issues_


CHECK:CAMELCASE: Avoid CamelCase: <ADVERTISED_10000baseKR_Full>
#858: FILE: drivers/net/axgbe/axgbe_mdio.c:12:
+	if (pdata->phy.advertising & ADVERTISED_10000baseKR_Full)

CHECK:CAMELCASE: Avoid CamelCase: <ADVERTISED_10000baseT_Full>
#860: FILE: drivers/net/axgbe/axgbe_mdio.c:14:
+	else if (pdata->phy.advertising & ADVERTISED_10000baseT_Full)

CHECK:CAMELCASE: Avoid CamelCase: <ADVERTISED_2500baseX_Full>
#862: FILE: drivers/net/axgbe/axgbe_mdio.c:16:
+	else if (pdata->phy.advertising & ADVERTISED_2500baseX_Full)

CHECK:CAMELCASE: Avoid CamelCase: <ADVERTISED_1000baseKX_Full>
#864: FILE: drivers/net/axgbe/axgbe_mdio.c:18:
+	else if (pdata->phy.advertising & ADVERTISED_1000baseKX_Full)

CHECK:CAMELCASE: Avoid CamelCase: <ADVERTISED_1000baseT_Full>
#866: FILE: drivers/net/axgbe/axgbe_mdio.c:20:
+	else if (pdata->phy.advertising & ADVERTISED_1000baseT_Full)

CHECK:CAMELCASE: Avoid CamelCase: <ADVERTISED_100baseT_Full>
#868: FILE: drivers/net/axgbe/axgbe_mdio.c:22:
+	else if (pdata->phy.advertising & ADVERTISED_100baseT_Full)

CHECK:CAMELCASE: Avoid CamelCase: <ADVERTISED_Autoneg>
#894: FILE: drivers/net/axgbe/axgbe_mdio.c:48:
+	if (pdata->phy.advertising & ADVERTISED_Autoneg) {

CHECK:CAMELCASE: Avoid CamelCase: <ADVERTISED_Pause>
#911: FILE: drivers/net/axgbe/axgbe_mdio.c:65:
+	pdata->phy.advertising &= ~ADVERTISED_Pause;

CHECK:CAMELCASE: Avoid CamelCase: <ADVERTISED_Asym_Pause>
#912: FILE: drivers/net/axgbe/axgbe_mdio.c:66:
+	pdata->phy.advertising &= ~ADVERTISED_Asym_Pause;

CHECK:CAMELCASE: Avoid CamelCase: <SUPPORTED_Autoneg>
#1444: FILE: drivers/net/axgbe/axgbe_phy_impl.c:511:
+		pdata->phy.supported |= SUPPORTED_Autoneg;

CHECK:CAMELCASE: Avoid CamelCase: <SUPPORTED_Pause>
#1445: FILE: drivers/net/axgbe/axgbe_phy_impl.c:512:
+		pdata->phy.supported |= SUPPORTED_Pause | SUPPORTED_Asym_Pause;

CHECK:CAMELCASE: Avoid CamelCase: <SUPPORTED_Asym_Pause>
#1445: FILE: drivers/net/axgbe/axgbe_phy_impl.c:512:
+		pdata->phy.supported |= SUPPORTED_Pause | SUPPORTED_Asym_Pause;

CHECK:CAMELCASE: Avoid CamelCase: <SUPPORTED_Backplane>
#1446: FILE: drivers/net/axgbe/axgbe_phy_impl.c:513:
+		pdata->phy.supported |= SUPPORTED_Backplane;

CHECK:CAMELCASE: Avoid CamelCase: <SUPPORTED_1000baseKX_Full>
#1448: FILE: drivers/net/axgbe/axgbe_phy_impl.c:515:
+			pdata->phy.supported |= SUPPORTED_1000baseKX_Full;

CHECK:CAMELCASE: Avoid CamelCase: <SUPPORTED_10000baseKR_Full>
#1452: FILE: drivers/net/axgbe/axgbe_phy_impl.c:519:
+			pdata->phy.supported |= SUPPORTED_10000baseKR_Full;

CHECK:CAMELCASE: Avoid CamelCase: <SUPPORTED_10000baseR_FEC>
#1455: FILE: drivers/net/axgbe/axgbe_phy_impl.c:522:
+					SUPPORTED_10000baseR_FEC;

CHECK:CAMELCASE: Avoid CamelCase: <SUPPORTED_2500baseX_Full>
#1464: FILE: drivers/net/axgbe/axgbe_phy_impl.c:531:
+		pdata->phy.supported |= SUPPORTED_2500baseX_Full;

CHECK:CAMELCASE: Avoid CamelCase: <SUPPORTED_100baseT_Full>
#1476: FILE: drivers/net/axgbe/axgbe_phy_impl.c:543:
+			pdata->phy.supported |= SUPPORTED_100baseT_Full;

CHECK:CAMELCASE: Avoid CamelCase: <SUPPORTED_1000baseT_Full>
#1480: FILE: drivers/net/axgbe/axgbe_phy_impl.c:547:
+			pdata->phy.supported |= SUPPORTED_1000baseT_Full;

CHECK:CAMELCASE: Avoid CamelCase: <SUPPORTED_10000baseT_Full>
#1533: FILE: drivers/net/axgbe/axgbe_phy_impl.c:600:
+			pdata->phy.supported |= SUPPORTED_10000baseT_Full;

CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'phy_data->phydev_mode != AXGBE_MDIO_MODE_NONE'
#1583: FILE: drivers/net/axgbe/axgbe_phy_impl.c:650:
+	if ((phy_data->conn_type & AXGBE_CONN_TYPE_MDIO) &&
+	    (phy_data->phydev_mode != AXGBE_MDIO_MODE_NONE)) {

total: 0 errors, 0 warnings, 21 checks, 1533 lines checked


More information about the test-report mailing list