[dpdk-test-report] |WARNING| pw48415 eal_interrupts: add option for pending callback unregister

checkpatch at dpdk.org checkpatch at dpdk.org
Thu Dec 6 18:39:56 CET 2018


Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/48415

_coding style issues_


WARNING:LONG_LINE: line over 90 characters
#43: FILE: lib/librte_eal/common/include/rte_interrupts.h:31:
+typedef void (*rte_intr_unregister_callback_fn)(struct rte_intr_handle *intr_handle, void *cb_arg);

WARNING:LONG_LINE_COMMENT: line over 90 characters
#87: FILE: lib/librte_eal/linuxapp/eal/eal_interrupts.c:80:
+	rte_intr_unregister_callback_fn ucb_fn; /**< function to call before callback is deleted */

WARNING:SUSPECT_CODE_INDENT: suspect code indent for conditional statements (16, 32)
#139: FILE: lib/librte_eal/linuxapp/eal/eal_interrupts.c:560:
+		for (cb = TAILQ_FIRST(&src->callbacks); cb != NULL; cb = next) {
+				next = TAILQ_NEXT(cb, next);

WARNING:SUSPECT_CODE_INDENT: suspect code indent for conditional statements (32, 32)
#141: FILE: lib/librte_eal/linuxapp/eal/eal_interrupts.c:562:
+				if (cb->cb_fn == cb_fn && (cb_arg == (void *)-1 ||
[...]
+				cb->pending_delete = 1;

WARNING:BRACES: braces {} are not necessary for single statement blocks
#196: FILE: lib/librte_eal/linuxapp/eal/eal_interrupts.c:905:
+		if (rv >= 0 && write(intr_pipe.writefd, "1", 1) < 0) {
+			return -EPIPE;
+		}

total: 0 errors, 5 warnings, 157 lines checked


More information about the test-report mailing list