[dpdk-test-report] |WARNING| pw48471 [v2, 02/20] net/ice: support device initialization
checkpatch at dpdk.org
checkpatch at dpdk.org
Thu Dec 6 18:40:51 CET 2018
Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/48471
_coding style issues_
WARNING:COMMIT_MESSAGE: Missing commit description - Add an appropriate one
CHECK:BOOL_MEMBER: Avoid using bool structure members because of possible alignment issues - see: https://lkml.org/lkml/2017/11/21/384
#1032: FILE: drivers/net/ice/ice_ethdev.h:225:
+ bool offset_loaded;
CHECK:BOOL_MEMBER: Avoid using bool structure members because of possible alignment issues - see: https://lkml.org/lkml/2017/11/21/384
#1058: FILE: drivers/net/ice/ice_ethdev.h:251:
+ bool offset_loaded;
CHECK:BOOL_MEMBER: Avoid using bool structure members because of possible alignment issues - see: https://lkml.org/lkml/2017/11/21/384
#1059: FILE: drivers/net/ice/ice_ethdev.h:252:
+ bool adapter_stopped;
CHECK:BOOL_MEMBER: Avoid using bool structure members because of possible alignment issues - see: https://lkml.org/lkml/2017/11/21/384
#1070: FILE: drivers/net/ice/ice_ethdev.h:263:
+ bool rx_bulk_alloc_allowed;
CHECK:BOOL_MEMBER: Avoid using bool structure members because of possible alignment issues - see: https://lkml.org/lkml/2017/11/21/384
#1071: FILE: drivers/net/ice/ice_ethdev.h:264:
+ bool tx_simple_allowed;
WARNING:MACRO_WITH_FLOW_CONTROL: Macros with flow control statements should be avoided
#1118: FILE: drivers/net/ice/ice_ethdev.h:311:
+#define ICE_PROC_SECONDARY_CHECK \
+ do { \
+ if (rte_eal_process_type() == RTE_PROC_SECONDARY) { \
+ PMD_DRV_LOG(ERR, \
+ "Control plane functions not " \
+ "supported by secondary process."); \
+ return -E_RTE_SECONDARY; \
+ } \
+ } while (0)
WARNING:MACRO_WITH_FLOW_CONTROL: Macros with flow control statements should be avoided
#1128: FILE: drivers/net/ice/ice_ethdev.h:321:
+#define ICE_PROC_SECONDARY_CHECK_RET_0 \
+ do { \
+ if (rte_eal_process_type() == RTE_PROC_SECONDARY) { \
+ PMD_DRV_LOG(ERR, \
+ "Control plane functions not " \
+ "supported by secondary process."); \
+ return 0; \
+ } \
+ } while (0)
WARNING:MACRO_WITH_FLOW_CONTROL: Macros with flow control statements should be avoided
#1138: FILE: drivers/net/ice/ice_ethdev.h:331:
+#define ICE_PROC_SECONDARY_CHECK_NO_ERR \
+ do { \
+ if (rte_eal_process_type() == RTE_PROC_SECONDARY) { \
+ PMD_DRV_LOG(ERR, \
+ "Control plane functions not " \
+ "supported by secondary process."); \
+ return; \
+ } \
+ } while (0)
CHECK:BOOL_MEMBER: Avoid using bool structure members because of possible alignment issues - see: https://lkml.org/lkml/2017/11/21/384
#1274: FILE: drivers/net/ice/ice_rxtx.h:62:
+ bool q_set; /* indicate if rx queue has been configured */
CHECK:BOOL_MEMBER: Avoid using bool structure members because of possible alignment issues - see: https://lkml.org/lkml/2017/11/21/384
#1275: FILE: drivers/net/ice/ice_rxtx.h:63:
+ bool rx_deferred_start; /* don't start this queue in dev start */
CHECK:BOOL_MEMBER: Avoid using bool structure members because of possible alignment issues - see: https://lkml.org/lkml/2017/11/21/384
#1313: FILE: drivers/net/ice/ice_rxtx.h:101:
+ bool tx_deferred_start; /* don't start this queue in dev start */
CHECK:BOOL_MEMBER: Avoid using bool structure members because of possible alignment issues - see: https://lkml.org/lkml/2017/11/21/384
#1314: FILE: drivers/net/ice/ice_rxtx.h:102:
+ bool q_set; /* indicate if tx queue has been configured */
total: 0 errors, 4 warnings, 1261 lines checked
More information about the test-report
mailing list