[dpdk-test-report] |WARNING| pw49245 kni: fix build on RHEL8 and RHEL7.6-ALT

checkpatch at dpdk.org checkpatch at dpdk.org
Fri Dec 21 17:16:28 CET 2018


Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/49245

_coding style issues_


WARNING:COMMIT_MESSAGE: Missing commit description - Add an appropriate one

WARNING:CONSTANT_COMPARISON: Comparisons should place the constant on the right side of the test
#37: FILE: kernel/linux/kni/compat.h:111:
+	(RHEL_RELEASE_CODE >= RHEL_RELEASE_VERSION(7, 5)) && \

WARNING:CONSTANT_COMPARISON: Comparisons should place the constant on the right side of the test
#38: FILE: kernel/linux/kni/compat.h:112:
+	(RHEL_RELEASE_CODE < RHEL_RELEASE_VERSION(8, 0)) && \

WARNING:CONSTANT_COMPARISON: Comparisons should place the constant on the right side of the test
#39: FILE: kernel/linux/kni/compat.h:113:
+	(LINUX_VERSION_CODE < KERNEL_VERSION(4, 14, 0)))

WARNING:CONSTANT_COMPARISON: Comparisons should place the constant on the right side of the test
#52: FILE: kernel/linux/kni/ethtool/igb/kcompat.h:3933:
+	(RHEL_RELEASE_CODE >= RHEL_RELEASE_VERSION(7, 5)) && \

ERROR:CODE_INDENT: code indent should use tabs where possible
#53: FILE: kernel/linux/kni/ethtool/igb/kcompat.h:3934:
+        (RHEL_RELEASE_CODE < RHEL_RELEASE_VERSION(8, 0)) && \$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#53: FILE: kernel/linux/kni/ethtool/igb/kcompat.h:3934:
+        (RHEL_RELEASE_CODE < RHEL_RELEASE_VERSION(8, 0)) && \$

WARNING:CONSTANT_COMPARISON: Comparisons should place the constant on the right side of the test
#53: FILE: kernel/linux/kni/ethtool/igb/kcompat.h:3934:
+        (RHEL_RELEASE_CODE < RHEL_RELEASE_VERSION(8, 0)) && \

ERROR:CODE_INDENT: code indent should use tabs where possible
#54: FILE: kernel/linux/kni/ethtool/igb/kcompat.h:3935:
+        (LINUX_VERSION_CODE < KERNEL_VERSION(4, 14, 0)))$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#54: FILE: kernel/linux/kni/ethtool/igb/kcompat.h:3935:
+        (LINUX_VERSION_CODE < KERNEL_VERSION(4, 14, 0)))$

WARNING:CONSTANT_COMPARISON: Comparisons should place the constant on the right side of the test
#54: FILE: kernel/linux/kni/ethtool/igb/kcompat.h:3935:
+        (LINUX_VERSION_CODE < KERNEL_VERSION(4, 14, 0)))

WARNING:NO_AUTHOR_SIGN_OFF: Missing Signed-off-by: line by nominal patch author 'David Zeng <zengxiaoh81 at gmail.com>'

total: 2 errors, 10 warnings, 26 lines checked


More information about the test-report mailing list