[dpdk-test-report] |WARNING| pw35240 [PATCH 47/80] net/sfc/base: add ef10 NIC board config method

checkpatch at dpdk.org checkpatch at dpdk.org
Tue Feb 20 08:39:27 CET 2018


Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/35240

_coding style issues_


CHECK:CAMELCASE: Avoid CamelCase: <__checkReturn>
#30: FILE: drivers/net/sfc/base/ef10_nic.c:1544:
+static	__checkReturn	efx_rc_t

ERROR:ASSIGN_IN_IF: do not use assignment in if condition
#37: FILE: drivers/net/sfc/base/ef10_nic.c:1551:
+	if ((rc = enop->eno_board_cfg(enp)) != 0)

ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#41: FILE: drivers/net/sfc/base/ef10_nic.c:1555:
+	return (0);

ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#46: FILE: drivers/net/sfc/base/ef10_nic.c:1560:
+	return (rc);

ERROR:ASSIGN_IN_IF: do not use assignment in if condition
#64: FILE: drivers/net/sfc/base/ef10_nic.c:1587:
+	if ((rc = ef10_nic_board_cfg(enp)) != 0)

total: 4 errors, 0 warnings, 1 checks, 41 lines checked


More information about the test-report mailing list